From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 76E2A40AB0 for ; Sun, 5 Jun 2022 07:55:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 969C568B66E; Sun, 5 Jun 2022 10:55:00 +0300 (EEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10olkn2013.outbound.protection.outlook.com [40.92.40.13]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7381068B29A for ; Sun, 5 Jun 2022 10:54:54 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d+k/wRh7vedJNfRi/7Od6fAZMJtC+zZFSZhdF1PyDAMZ7wruy22lUxnQVrIwwDW2a2RdBK3EJZEzbUgTHHApntobVmCWxT+b1F9fsUIbtbHagwNdUn+vIsFjCcj1ZIRnuq6nJFZq6WR7+vgBfujKVruBrQB3vFVs1gPQ9wmUyjnICrbaBth5NQeev9Ajnnl6dgAujsxhENmqFVbvPuy2gWTkEAIEA10EcCNZ0SLsjZp6Iz/o1ofCdxCx2Ydz4aHweHgmV+OfEnuf2eX3RkUI5gGpYHHqAmcaLPIalfkBOiUJMDlHQtzt53HBln3orv2B4e65vF+RcJZBoKB7csyJ0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qRnkLJAFIRy2fLNYVyyLQRgG3wISF+L50+tIodL1Md4=; b=ONUJXr/1eTxy/lDqgEdh2JUr6jPDpQJLYE9zf3OFiwjnjE5ejzaLs0h3k2wfPN4hg0rn9DLnBqkFE8OQjpJPVc1bceBhsM2ufJVZ24M0AEdpJRWAmcf0yfJSQv5I8y+gDmk8Bi6DZtdGFlej3RTn4ICCCNmC6Pj7gOLA7KeMj2re+GruIMKP3YcRnsyXgpwwOmV9EJNth0ojhVnSTC4EVYZYJCw5We0gKLX/ngDIcfdzqVctKLEPHzErhkavGvMSazBCH81szrK5IJ6T6rxOB47EZ8ANJ040RpfmZ+aFeyMMgcfuMENk8dQo4BvmcXwtoxm3lbHFLSzYMtTApSZImA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qRnkLJAFIRy2fLNYVyyLQRgG3wISF+L50+tIodL1Md4=; b=LdE/vSEgLmNX/8xG9mUnv7v6jYGlwuKcDRyzaS7u53IXTi1RXB1wP5zK+GUcyqk7rPBHLQK9whT/GKWB/i8lBRH1uVu/woFKce2NE2jpyoHdD5ZjgYNLKRzAZsCfsqw76FbZLWSA8tJDeYmmlv/rHB5hhWnP0ZT5WbamJrd9Cyf/SO03wELD15uUNo+W3SH8bcul2BtPhlx3aETIYJw7rGw5s1UEvWh5RFnCy1O9IdsBMDKeIncarpdzBRbsZ6Oqr0R1tMqDyh27WfAQ1lnWkrerTlFDSmmBemAe9iVcsJzfrobY3vrhz9CBFShRQyV8XOLCsRj2Kf3hm/OsQ/K50A== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by BL3P223MB0274.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:34c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.13; Sun, 5 Jun 2022 07:54:51 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::f144:21f9:cdb1:5c8a]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::f144:21f9:cdb1:5c8a%7]) with mapi id 15.20.5314.018; Sun, 5 Jun 2022 07:54:51 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 1/8] lavc/avcodec: simplify codec id/type validity checking Thread-Index: AQHYPs69Q/NxwRSzxUypnCXsEU54I61A1pQ8gAAAjmA= Date: Sun, 5 Jun 2022 07:54:51 +0000 Message-ID: References: <20220323155720.20017-1-anton@khirnov.net> =?utf-8?q?=3CDM8P223M?= =?utf-8?q?B0365783CC5AF48817C137226BAA39=40DM8P223MB0365=2ENAMP223=2EPROD?= =?utf-8?q?=2EOUTLOOK=2ECOM=3E?= <165441247425.5088.1095760194724448724@lain.red.khirnov.net> In-Reply-To: <165441247425.5088.1095760194724448724@lain.red.khirnov.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [/OPFnTe9nVGuj0FC0xdBk1tAh2euEV8Q] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 130942ad-06ab-41f2-c985-08da46c8abaa x-ms-traffictypediagnostic: BL3P223MB0274:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oI/OkWEfJgolJGiatMGmuF943HvSKBwrnhkLLe7oUcmkNgSjLmBEBL9TlmM+hRdyvt0nCqWa2dXYAbqAS0UYhBICV0CtZf+wbRKIkGMcR69w1hzFXWc7m6tOL3bWfara2xQgmyTdeBb01txhXqG0qeG0U/nsprHYvtIBoNMqgW3Xyc1uwb/Ei05nyjrJX8bhrTVhwsetny4n9vtNZaTymH+qgKn/MaNj+ow312YHjmewBqPWEToEF83ZBbr8/q10Z21Nq/FJHudNTBQxOptUqgtJfxzpBGWius7H7Bf1k2eojK4fTzSneh+M2qW7yrCeRNHrxrgcG2By3VNqhpQ+8sgtE7rI57CHlHT3FTp/WVZBWs1xLowUc28Eb2rTrT49xfOI/rns94y1WqKLKRFlaCNyQ1dI7tUpc9UFZnsA3/E7Lbigb7jKyFgX/G9VaKP9yhoZL5xTcb366eYP+pScbZjxPEIY7Iq2D6TCRJi8Z+sNokHyvarD6Uz9V8kGT7OcReIo5qyMC5DdeUktdHT7EpvedWBIg78eNDBEAot+TAhRwnlB8FfcfsN0/3ItRYlK2M93mVObGPToNKvMr7qiEA== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?YzFOM0ZLRDhOOG9oVFNOY2Y2NStiTC9wWjNYY0hWWFZQYm16N2JQdTBwQ29C?= =?utf-8?B?MWxUMnNzZThFTmFLOUNFbVJNem9BdDRhNGxCVFhsVzd1ZDFub0xsMkR5dHVx?= =?utf-8?B?eWQ2amRiTEgzZDJFWnBMVG4zVGo5S1Y1bTVWY0RSSEZJNmo1dFJ4VVJLU0lm?= =?utf-8?B?RzJxdjBQYXlESkR4dElQUm1qUEs5cStxZTJWeGt1TC92L051OWJlMjI4c1Ew?= =?utf-8?B?NDNhSS9PeGc1UGh6cVBDSTloZ2w4dzZRYXV5OUkxdnVLM2srcEJoMjduUHF4?= =?utf-8?B?OFkvVElNeU9hRHR1Q0p2RVlrMEV6VnBQdjZ0Q0tXTUpDQ0t5aTQyTndTRHJx?= =?utf-8?B?UWhtSkRIN1RZbDF3Z0N5QTBBNFdxZnArd0Z6UlZFMEFiMEJKRFZDdHJDMGND?= =?utf-8?B?VnBnbUdnTnZZTHBZdFpTUjd1enlmVW5SVWxydk45Y2l1TXJ6TzdVdEVvVUJX?= =?utf-8?B?SVRCQm51V29yZEpHaUljbUhPM2VLUmEveDg1Z0JqZnJ3SVJKWWxFRjZHYmo1?= =?utf-8?B?Z28wbUpHTE5nZGUyN3VkZHppYWJKaDhla3NtbXFQekQ2cVhPb0REc3ZIWFRu?= =?utf-8?B?Y1ZJMFk3ZEdHZFRlbnRyWHpERjJ4SW1PT2NhUEN3MlArSTFUanFHZis4NU1r?= =?utf-8?B?V1ZCQlJ1N1ZhMmQzWUhjSjk4ZFFsTjJWYXVoUEtkNDhrcUVicitpVWlidk5F?= =?utf-8?B?YlR4VE5BTTFkcVhQek5YR2w1cUd5UjVvWUthLy80MGZXSFFNZ1B5TTY1YXJM?= =?utf-8?B?VkFmRzR6OC9BQU0wQ3pyeVlyWm9OV3dMZ20vRXdINkhPM3AzRS9ydThUTmdR?= =?utf-8?B?Z1BMYTVQMnlraFhTU1orbkJpVm5CMFZmSXRSNWFuZE1FWFNHUzl4MHRsL3JK?= =?utf-8?B?emdDUUJtRG1MSWhSTVE1S2p6Vnlzc01vS2x2cjMrVDhremoyT0ZZbUkrVlJE?= =?utf-8?B?YmExMHlHRldXV05jdWZxZVl3ckZ4UkJtbHdpL05xSExRVklpWWtCQ2t0Q3Qr?= =?utf-8?B?RUI5SjhQakU4MGVKL0lwOFVGbkxsSmVjWXQrdGlwVHJLNjBwNVZrMnN1VGdU?= =?utf-8?B?ZExmN3c0TDBpZlBnaUw2VzlPVzhIaERaS2xNcnFZdjVza21VMlpLenFUVW1i?= =?utf-8?B?dVV5Z2dTdElMV0xzOUtyQ2g2SDFHMGJkUHRXV0c1R2NVVkRtSllDMVcrYlpt?= =?utf-8?B?S1RJZXRnamhWK0FFSDRpVDBNMkZadWpGQ3d6U0JGU3RMKy9RbHREWTZZZGQy?= =?utf-8?B?aHBZZ3VKaktQR0tFMjlrSkdmbnNpRXhrSjlkUnJiNk5NZUY2WTQrWFp6NWtD?= =?utf-8?B?bk1Xd2pWdi9WYnVJR2JwTjJPT0QweGJiRkdkbDVKTFhWVGpaVlU5VEhiZkVL?= =?utf-8?B?cWNrTGJjMHVJNFVNSkF3UE52dFNwa3dXbE5EbXgwWXlIZVplZm5UOTEvejNw?= =?utf-8?B?KzNkem9jeTZuR0pTMENLYmlab1lXNkU5ZC9rbHZVQ3FnbFVkRjFPSTljNzlk?= =?utf-8?B?dnd0NXNwVXB6OXRvVmx0REJsdkJDR0VmMGJmSjNCRGxxejhvcWZCbTYwYS9H?= =?utf-8?B?d2pDcFR3NHlEV29Cd1FZYWVObmRZWjJZa2RrWXM1NDQwaE82NjlOV1lXR2pa?= =?utf-8?B?dE1uSnB0MHVreGJnMmpOdzNueFhCQ2NMTjVwd2hsUk9DU2w3blNqSGRLTlJn?= =?utf-8?B?emJ6YThHM3MyWmZSZ1o3NzZMWTVCd1ZCQXE1TnBmVEFwR3lob05qRXNRSzVT?= =?utf-8?B?QVJieVJ1OWJuSlduVWd2dlJJTjhFa05ONE02VUZ3RWxKNDQrQlc3V3JwajY0?= =?utf-8?B?QzJ5cStSbm1JT0kyMTJ0UG4yNzNJcXl3V09KU3ZEWDlZOG9FdHFRMWxucEVv?= =?utf-8?B?eWdqZGZHamRYYWRsUXhmSlhvOGJrcTlEMW1mTkR2Qmx1MXlBN3lPTTkzd2E3?= =?utf-8?Q?fFho+cZ+FJc=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 130942ad-06ab-41f2-c985-08da46c8abaa X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jun 2022 07:54:51.3377 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3P223MB0274 Subject: Re: [FFmpeg-devel] [PATCH 1/8] lavc/avcodec: simplify codec id/type validity checking X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Anton > Khirnov > Sent: Sunday, June 5, 2022 9:01 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 1/8] lavc/avcodec: simplify codec id/type > validity checking > > Quoting Soft Works (2022-06-05 07:23:18) > > This is causing a regression in ffprobe. > > > > The commit removes the special-case check for AVMEDIA_TYPE_ATTACHMENT which > > was required for ffprobe and had been added with > e83c716e16c52fa56a78274408f7628e5dc719da. > > > > The demand from the commit message is not yet guaranteed to be fulfilled: > > > > > On entry to avcodec_open2(), the type and id either have to be > > > UNKNOWN/NONE or have to match the codec to be used. > > > > I have one verified example (maybe a second will follow), which is an MKV > with > > an attachment "stream" of type "text". > > The found codec will be textdec of type 'subtitle' even though the stream > type > > is attachment. Without the special condition for attachment streams, this > > is now causing ffprobe to error out with non-zero exit code and incomplete > > output. > > > > > > ------------------------------------------------------------------------ > > Example: > > > > [...] > > Stream #0:9: Attachment: text > > Metadata: > > filename : textfile.text > > mimetype : text/plain > > [text @ 000001AC32310340] Codec type or id mismatches > > Could not open codec for input stream 9 > > ------------------------------------------------------------------------ > > This sounds very much like a bug in ffprobe. It makes no sense to call > avcodec_open2() with the AVMEDIA_TYPE_ATTACHMENT type. You make a behavioral change to an API function that had this behavior established and constant over more than 10 years, and when that change breaks functionality, it's the callers' fault? How does this go together with all that peanut counting of major, minor and micro version numbers per library? What is this versioning good for, when you can make breaking changes and declare the breakage as bugs? Though, I don't want to say that your change is wrong or shouldn't be made. Yet, the change requires ffprobe to be adjusted (I just wouldn't call it a "bug fix"..) Thanks, softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".