From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id B4F804DA57 for ; Fri, 28 Feb 2025 01:47:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0414B68DB99; Fri, 28 Feb 2025 03:47:15 +0200 (EET) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04olkn2101.outbound.protection.outlook.com [40.92.47.101]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DD5CB68D99F for ; Fri, 28 Feb 2025 03:47:07 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jTPSBIR5bbRVTmUzAryTtERr7sog0Ys+BzqVxx+OQnyCddEddYvXh+/tyL2PGZfehum2NMnZIe6q8nGyo4EudZ3j7b7S8W3zRNB/dzeT2Gsmsh5GQ8I1284c+yI8pCCcBQSunKOjunPT9sikPvIbI/NHfTeFE/44LtIGVkI3/2PyyyHXmtpskL8FpUFrsrhbu0D8gXtQOPTQaWAX+SfEYcuT+MVLDIWGORRskt0v10cFE6iywYEFiAoSqRMO5ZSfXa9OrugdaKLYF4XSRII0H2SfgKgaFEHSVeCLe0bMo7FxwsTBiXTOYJ0IKVoI+V2Jatox+KIUddf7BDEeHCjGhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lT6ostRw19zIvUPk8/hvF5oFKosjzQfQwGOou8STRQ4=; b=uTIiUtYzQlYhDQfUlB4Gadqh24JP3OZAdtSTD7GRDNIr4KSJybur3swf3KIPZBex5JGCvOU6xc3/v2kSYeifi++fxh2l3/FbDyKkxEbYtknlIiQDOhV3+TOBbfIeB1E976k0CLjrvtkxxfNjZBqUwdCcNgjj4R6mYKuwAwjurJgE21Lv2BHJnV9cYIeFERk+uA24udXU+BIlDOvY891xiTFzdRDYeR4+Fl0vLbsV88fjYmK0fjAbZR3ckxWgxOzQTZgQDywRJ2wsjEPz6S9l4CTx0r3I1i1f8W6IBd4BGl1evZXhQy9BpI7CVmr/HKRPKeCAWOPe7q68fQ8b4M0IjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lT6ostRw19zIvUPk8/hvF5oFKosjzQfQwGOou8STRQ4=; b=Js7q4Z6i3jjNOlxWsqdK61+FxhsPJkHUuCloUWM4uesGOdTy59wM6/jB4j43xFsttPMSZ9OEsWOfpHEOEs6TNEYdoV2sD942Og+m43ZxwaufPuYRmB+TzJ+8uvKZbpQkD8sUhONp3UxxENYC87bR5xUyox/UziX9SM4sI5jpztOuLclZBUe1PEJo3nbRff+M4xuv2UvDHicH8Cbel1nefI8l2+vba7oO96RnFWp9/7n88f7ifOEWmlxVv/bb1PZG5d415tDCvMM9xMae39IoJE+0qDQbqxsOqKrEoWROX+YNMyaMWupE4urGPsXiKEvKXSLzYetVp956mivap8fpDw== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by CH2P223MB1323.NAMP223.PROD.OUTLOOK.COM (2603:10b6:610:281::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.18; Fri, 28 Feb 2025 01:47:05 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%7]) with mapi id 15.20.8489.021; Fri, 28 Feb 2025 01:47:05 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 2/8] ffprobe/avtextformat: Rename and move writer functions and options Thread-Index: AQHbiSAsTL1DYjnhHEKR31MvWbpZXrNb7HSAgAABH5CAAARvcA== Date: Fri, 28 Feb 2025 01:47:05 +0000 Message-ID: References: <89d538cab47c517b35ecaccb563e14334c9f9927.1740664900.git.ffmpegagent@gmail.com> <20250228012321.GP4991@pb2> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|CH2P223MB1323:EE_ x-ms-office365-filtering-correlation-id: c70d624a-d224-4c6e-6ef6-08dd5799cdc6 x-microsoft-antispam: BCL:0; ARA:14566002|461199028|8062599003|8060799006|19110799003|7092599003|15080799006|440099028|3412199025|41001999003|12091999003|102099032; x-microsoft-antispam-message-info: =?us-ascii?Q?dI75vwLbu1pPX3U73rn74H9BTAofUzuHi2IhkMkdiEnNqrAYMTRGxdwdEY5S?= =?us-ascii?Q?Af4AKWLUs9gFBqTlp/7LBwN2gJWfegjEDJveEGUNJ4LBbyXfFj+dgVmLiiQp?= =?us-ascii?Q?iH0MST+eHslZctvtNhvtuG+KOtRdrNCLl05QjJEfbTJ4SNpncEmz9aJzHf1n?= =?us-ascii?Q?VVkAqlhPvI2SvRUwFO8HPbulz8PJ1mlb0LQpOil/mzsdhsB/TbrR3c4JwPnV?= =?us-ascii?Q?kxswQhODHaUczatMphNsmWSC3HcZhBE2BC4B6n+z9kg39eHPDtGof8lX9hoJ?= =?us-ascii?Q?u1jvIyaNePcy0WkgWQ1NFo+oXhqLvc3vH8xJAg+lQTFTY2Hmo8fQu9A0y8pS?= =?us-ascii?Q?pRZs/LZttKtY677UCB59nt1ppKHj4Ao1pV9lHr3LxQzEywwCeeL4pnlFQH9W?= =?us-ascii?Q?pZhd9frf5+Yr9aZT1zhs09pn0mtgtENass/pKstnBQjlHnU9O0t5laG/ZP7v?= =?us-ascii?Q?ghCIz52jjiC1FJb+C5IXd0FQtmbaHlMv+Zmz+wL6bp+ureYgczEaBJGsTixk?= =?us-ascii?Q?FbE0Sok/S7Z0WH9bUy+73jYeKvCEuZLAEuEQ2Ll4MvPNR60Z5qqNNqKpRsWB?= =?us-ascii?Q?amwB0RRN/E9Qbxiqx5XHcQUXSRNpU2u6gG8vK/8ALdf1cW9/YtJ7m7aCXCZZ?= =?us-ascii?Q?AqFpbPSkuv7glOtQhCTPmSErXQCMntLWsu6Coupuk0e3OwJMc3ryNwUSGoDO?= =?us-ascii?Q?Y5++nCC7AIzRdWMKyFJ+Mh8im9WMei7BdhhBjTn+k5E1ugTTO+HQgpWhX+gx?= =?us-ascii?Q?SXfj2aR2+0WOvU/N33aQOxDKitI9DrIDFUri4yln5aCoGhG10Ohb47lSmSJN?= =?us-ascii?Q?GgNVHmZq3ozlJfwP+7AMhalqsv4QyOQHlVLcCc1hLc6I6TLk3bxOWzVgJ87k?= =?us-ascii?Q?w5p9QJ00AqdKKyKAt2jE9746+sDmUBFS5xyfL67F0cz3N+2aXpEVT0AjrUvf?= =?us-ascii?Q?8WC/8EjRkOxFn+rezAkAnn6mdoJ7eYMqPzMC5SjoLXFniIIsWkEUhFPaeN3n?= =?us-ascii?Q?WJunm0S2Sg+clxCAAirBEicJhGrb3FTgb5zzX9MQwPdF+iUUS6OcsGCkSI6V?= =?us-ascii?Q?SWGgs8PST5iRwdfhrgdvTnnzmK0VwB3V3Mq/LZsrRocS41bogWaBP1LqmQQU?= =?us-ascii?Q?I51ptcCg3yo4OeRVezXETz/z93xTzVBpRA=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8Sj5Fki11eFY9Y8FKePZzJSMWJYaIs16mDEiJBijctTZxDH1qeTQcbAQ2c8R?= =?us-ascii?Q?FjgGSwRTd3T0msH4i4xzYBhLnkG8VJxFfkYJuBzju4KVwy5DV4C6Qfe2CxrG?= =?us-ascii?Q?r05q+2TzwNhar9LeeQXix4kL0CnAyAtir65HZcpi5oot5WLOIS+n2x2n9HrT?= =?us-ascii?Q?PCplh0AVDg4rQS751j8+vYQi4zcxbmHA8/mb1D49elgnPtlqQO2v/57GJ+js?= =?us-ascii?Q?zx4797LK9vsIMnv3gD8/BzFcsJ0K/Awlqnjh5+Rvg1pmTxnduyyS9jY9C0Fv?= =?us-ascii?Q?i5rbaKwcQEEBmdyXKAni1Zq3u+j7KoQ52CeRv9IK6NQ1ukOzcP2CrETkDAKi?= =?us-ascii?Q?/B9OSiP1scl4tzqxlT0SHuqdnnpWc3kbpug1L/oBEN/nEcSnTcrtW/y1NeiU?= =?us-ascii?Q?FLDQZY6Fy9hXU+7AjCvaW2Cusnvm9kjaqrAhgukfqq7jfm/XkpDUUHqQ44F/?= =?us-ascii?Q?m02sWTSmKzYehUMprHM1nujyl8OhlNIW6I3jCcZRnlN5x1I0IIAflYFxXu8a?= =?us-ascii?Q?gCMn68ufW0cvwpx8tXmqh3WcWI8YJb85ghBctzRXIjcp/8LDnMNBC5TiSXEQ?= =?us-ascii?Q?Rukpr9pZQFOjCx/m4rrLmOOlD1Gk+t1HdhCcvgqNfcvEa1/Ut3hWBG+5DWuF?= =?us-ascii?Q?ORf62CYyX5cxGIgtQ23Db4CHJLGIDDv6AIieVMQ28uhCN3LO0SbBgPfwluQK?= =?us-ascii?Q?3prkHfqlB6Y8iAwkOzRLIqKqqooGTgs1zwyCv5L/zJvtgSC9+tQ93t1/E4gA?= =?us-ascii?Q?63W3l0yKz2uzqUgFqCOS/XKvuWnpSaa7YXLzcaZRz2bpqfaNeaMXgtzRRUEa?= =?us-ascii?Q?yhew0s07AIWlEbL+cz2wNis2QKBmAgGz5LuekmqkqSl+j9H29uqIZO/XCAAp?= =?us-ascii?Q?g8myBDLcF04kj061Gc4fj1nEQmvtwAtwYrGvvCZs1IutIa6+3QUKkdS68sCm?= =?us-ascii?Q?Sw3vnpKlj1nsXfa2nnLhYWPZhftLWuD2/E4+KoVzA+P0RKpZQKhcnpNccXys?= =?us-ascii?Q?xm6qk9yYZZPqogBA3caRK0OANXDrOObELUroRpMCUEZBVl13NtDsO01to9k/?= =?us-ascii?Q?oDignn8nj31JU+7Xnw3retz0wSBDCMAedJCO+5iXRc+oRIhWLqZog0hnJUwq?= =?us-ascii?Q?bzBHbeJBb1WrXepVbQfp1s3KO9++6PUhoR1zkuL502piRJ1pQq+0pnOVPefw?= =?us-ascii?Q?nhR1dlxhvHRkmQHJZGbOVw96vhwxEDrP2qPT2SMFLDuphLko8OijS762Nms?= =?us-ascii?Q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-92255.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: c70d624a-d224-4c6e-6ef6-08dd5799cdc6 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2025 01:47:05.0190 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2P223MB1323 Subject: Re: [FFmpeg-devel] [PATCH 2/8] ffprobe/avtextformat: Rename and move writer functions and options X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Soft > Works > Sent: Freitag, 28. Februar 2025 02:31 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 2/8] ffprobe/avtextformat: Rename and > move writer functions and options > > > > > -----Original Message----- > > From: ffmpeg-devel On Behalf Of > > Michael Niedermayer > > Sent: Freitag, 28. Februar 2025 02:23 > > To: FFmpeg development discussions and patches devel@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [PATCH 2/8] ffprobe/avtextformat: Rename > and > > move writer functions and options > > > > On Thu, Feb 27, 2025 at 02:01:34PM +0000, softworkz wrote: > > > From: softworkz > > > > > > Signed-off-by: softworkz > > > --- > > > fftools/ffprobe.c | 910 ++++++------------------- > -- > > - > > > libavutil/Makefile | 1 + > > > libavutil/avtextformat.h | 50 ++ > > > libavutil/textformat/avtextformat.c | 620 +++++++++++++++++++ > > > 4 files changed, 848 insertions(+), 733 deletions(-) > > > create mode 100644 libavutil/textformat/avtextformat.c > > > > this and patch 1 crash > > > > ==1574970== Invalid read of size 1 > > ==1574970== at 0x483EF46: strlen (in /usr/lib/x86_64-linux- > > gnu/valgrind/vgpreload_memcheck-amd64-linux.so) > > ==1574970== by 0x7683D14: __vfprintf_internal (vfprintf- > > internal.c:1688) > > ==1574970== by 0x7696F99: __vsnprintf_internal (vsnprintf.c:114) > > ==1574970== by 0x1239AA1: av_vbprintf (in ffmpeg/ffprobe_g) > > ==1574970== by 0x1256473: av_log_default_callback (in > > ffmpeg/ffprobe_g) > > ==1574970== by 0x1256162: av_log (in ffmpeg/ffprobe_g) > > ==1574970== by 0x125CB4B: av_opt_set_defaults2 (in > ffmpeg/ffprobe_g) > > ==1574970== by 0x127611C: avtext_context_open (in ffmpeg/ffprobe_g) > > ==1574970== by 0x2F9672: main (in ffmpeg/ffprobe_g) > > ==1574970== Address 0xffffffff is not stack'd, malloc'd or (recently) > > free'd > > ==1574970== > > ==1574970== > > ==1574970== Process terminating with default action of signal 11 > > (SIGSEGV) > > ==1574970== Access not within mapped region at address 0xFFFFFFFF > > ==1574970== at 0x483EF46: strlen (in /usr/lib/x86_64-linux- > > gnu/valgrind/vgpreload_memcheck-amd64-linux.so) > > ==1574970== by 0x7683D14: __vfprintf_internal (vfprintf- > > internal.c:1688) > > ==1574970== by 0x7696F99: __vsnprintf_internal (vsnprintf.c:114) > > ==1574970== by 0x1239AA1: av_vbprintf (in ffmpeg/ffprobe_g) > > ==1574970== by 0x1256473: av_log_default_callback (in > > ffmpeg/ffprobe_g) > > ==1574970== by 0x1256162: av_log (in ffmpeg/ffprobe_g) > > ==1574970== by 0x125CB4B: av_opt_set_defaults2 (in > ffmpeg/ffprobe_g) > > ==1574970== by 0x127611C: avtext_context_open (in ffmpeg/ffprobe_g) > > ==1574970== by 0x2F9672: main (in ffmpeg/ffprobe_g) > > ==1574970== If you believe this happened as a result of a stack > > ==1574970== overflow in your program's main thread (unlikely but > > ==1574970== possible), you can try to increase the size of the > > ==1574970== main thread stack using the --main-stacksize= flag. > > ==1574970== The main thread stack size used in this run was 8388608. > > > > testcase: ./ffprobe_g -v 99 ~/tickets/3679/wgetmjpegdump > > > > tell me if this file is not in the ticket and ill send it to you > > Hi Michael, > > only patch 8/8 is expected to work. Since this is a RFC for the moment, > I spared the time for making sure that every single commit builds. > (please see cover letter notes in 0/8) > > Once the direction is clear, I'll prepare a patchset with all commits > working of course. > > Thanks Did you try 8/8 - does it pass for you? It's fine locally on x64 Linux, on AzDevops Linux x64 and on Patchwork andriy/make_fate_x86. But what bothers me a bit is that it failed on the Chinese CPU system. sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".