From: Soft Works <softworkz-at-hotmail.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Marth64 <marth64@proxyid.net>, Kieran Kunhya <kieran618@googlemail.com>
Subject: Re: [FFmpeg-devel] [PATCH v2 00/11] fix broken CC detection and ffprobe fields (cover letter)
Date: Mon, 27 Jan 2025 10:00:03 +0000
Message-ID: <DM8P223MB03650F4CCE29E373D8F7318EBAEC2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <CABGuwEm1CeeV12QUvXvOfAsosO0Yx0s8qqK5pyH5W9O=x7Hs3Q@mail.gmail.com>
> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> Kieran Kunhya via ffmpeg-devel
> Sent: Monday, January 27, 2025 10:40 AM
> To: FFmpeg development discussions and patches <ffmpeg-
> devel@ffmpeg.org>
> Cc: Kieran Kunhya <kieran618@googlemail.com>; Marth64
> <marth64@proxyid.net>
> Subject: Re: [FFmpeg-devel] [PATCH v2 00/11] fix broken CC detection
> and ffprobe fields (cover letter)
>
> >
> > While this is a very valid concern for some kinds of frame side
> data, it
> > does not apply to CC data. It's either in every frame or none. If a
> > provider generally broadcasts CC, then it's always present in every
> frame,
> > even during programs for which no CC is available - it's always
> there. Like
> > I mentioned at the top, we're using the properties field from the
> codec
> > (via codec_par) and there hasn’t been a single case reported where
> the CC
> > detection this way would have been incorrect.
> >
>
> This isn't true, CC data is sparse.
> I have no opinions about the rest of the text.
>
> Kieran
Hi Kieran,
Thanks for your reply.
In expectation of doubt, I had yesterday slightly modified ffprobe to count frames with and without CC side data like this:
if (par->codec_type == AVMEDIA_TYPE_VIDEO) {
if (!is_sub && do_analyze_frames) {
int has_cc = 0;
for (int i = 0; i < frame->nb_side_data; i++) {
if (frame->side_data[i]->type == AV_FRAME_DATA_A53_CC) {
streams_with_closed_captions[pkt->stream_index]++;
has_cc = 1;
}
else if (frame->side_data[i]->type == AV_FRAME_DATA_FILM_GRAIN_PARAMS)
streams_with_film_grain[pkt->stream_index] = 1;
}
if (!has_cc) {
streams_without_closed_captions[pkt->stream_index]++;
}
}
}
Then I ran it on all kinds of mpegts recordings I had at hand, and that's the result:
All video streams only, some were from the same file, others recorded in the same way, hence the duplications.
+--------+----------------+-------------------+
| | Frames with CC | Frames without CC |
+--------+----------------+-------------------+
| stream | 786 | 0 |
+--------+----------------+-------------------+
| stream | 786 | 0 |
+--------+----------------+-------------------+
| stream | 786 | 0 |
+--------+----------------+-------------------+
| stream | 0 | 232 |
+--------+----------------+-------------------+
| stream | 0 | 238 |
+--------+----------------+-------------------+
| stream | 0 | 239 |
+--------+----------------+-------------------+
| stream | 0 | 237 |
+--------+----------------+-------------------+
| stream | 0 | 235 |
+--------+----------------+-------------------+
| stream | 118 | 0 |
+--------+----------------+-------------------+
| stream | 58 | 0 |
+--------+----------------+-------------------+
| stream | 58 | 0 |
+--------+----------------+-------------------+
| stream | 118 | 0 |
+--------+----------------+-------------------+
| stream | 58 | 0 |
+--------+----------------+-------------------+
| stream | 118 | 0 |
+--------+----------------+-------------------+
| stream | 58 | 0 |
+--------+----------------+-------------------+
| stream | 118 | 0 |
+--------+----------------+-------------------+
| stream | 58 | 0 |
+--------+----------------+-------------------+
| stream | 118 | 0 |
+--------+----------------+-------------------+
| stream | 58 | 0 |
+--------+----------------+-------------------+
| stream | 118 | 0 |
+--------+----------------+-------------------+
| stream | 58 | 0 |
+--------+----------------+-------------------+
| stream | 118 | 0 |
+--------+----------------+-------------------+
| stream | 58 | 0 |
+--------+----------------+-------------------+
| stream | 112 | 0 |
+--------+----------------+-------------------+
| stream | 58 | 0 |
+--------+----------------+-------------------+
| stream | 118 | 0 |
+--------+----------------+-------------------+
| stream | 58 | 0 |
+--------+----------------+-------------------+
| stream | 118 | 0 |
+--------+----------------+-------------------+
| stream | 58 | 0 |
+--------+----------------+-------------------+
| stream | 118 | 0 |
+--------+----------------+-------------------+
| stream | 58 | 0 |
+--------+----------------+-------------------+
| stream | 118 | 0 |
+--------+----------------+-------------------+
| stream | 58 | 0 |
+--------+----------------+-------------------+
| stream | 118 | 0 |
+--------+----------------+-------------------+
| stream | 58 | 0 |
+--------+----------------+-------------------+
| stream | 118 | 0 |
+--------+----------------+-------------------+
| stream | 58 | 0 |
+--------+----------------+-------------------+
| stream | 118 | 0 |
+--------+----------------+-------------------+
| stream | 58 | 0 |
+--------+----------------+-------------------+
| stream | 118 | 0 |
+--------+----------------+-------------------+
| stream | 58 | 0 |
+--------+----------------+-------------------+
| stream | 118 | 0 |
+--------+----------------+-------------------+
| stream | 58 | 0 |
+--------+----------------+-------------------+
| stream | 118 | 0 |
+--------+----------------+-------------------+
| stream | 58 | 0 |
+--------+----------------+-------------------+
| stream | 118 | 0 |
+--------+----------------+-------------------+
| stream | 58 | 0 |
+--------+----------------+-------------------+
| stream | 51 | 0 |
+--------+----------------+-------------------+
| stream | 42 | 0 |
+--------+----------------+-------------------+
| stream | 45 | 0 |
+--------+----------------+-------------------+
| stream | 42 | 0 |
+--------+----------------+-------------------+
| stream | 102 | 0 |
+--------+----------------+-------------------+
| stream | 45 | 0 |
+--------+----------------+-------------------+
| stream | 104 | 0 |
+--------+----------------+-------------------+
| stream | 42 | 0 |
+--------+----------------+-------------------+
| stream | 102 | 0 |
+--------+----------------+-------------------+
| stream | 44 | 0 |
+--------+----------------+-------------------+
| stream | 104 | 0 |
+--------+----------------+-------------------+
| stream | 42 | 0 |
+--------+----------------+-------------------+
| stream | 106 | 0 |
+--------+----------------+-------------------+
| stream | 44 | 0 |
+--------+----------------+-------------------+
| stream | 99 | 0 |
+--------+----------------+-------------------+
| stream | 41 | 0 |
+--------+----------------+-------------------+
| stream | 101 | 0 |
+--------+----------------+-------------------+
| stream | 45 | 0 |
+--------+----------------+-------------------+
| stream | 99 | 0 |
+--------+----------------+-------------------+
| stream | 32 | 0 |
+--------+----------------+-------------------+
| stream | 92 | 0 |
+--------+----------------+-------------------+
| stream | 40 | 0 |
+--------+----------------+-------------------+
| stream | 95 | 0 |
+--------+----------------+-------------------+
| stream | 37 | 0 |
+--------+----------------+-------------------+
| stream | 97 | 0 |
+--------+----------------+-------------------+
| stream | 34 | 0 |
+--------+----------------+-------------------+
| stream | 94 | 0 |
+--------+----------------+-------------------+
| stream | 37 | 0 |
+--------+----------------+-------------------+
| stream | 96 | 0 |
+--------+----------------+-------------------+
| stream | 34 | 0 |
+--------+----------------+-------------------+
| stream | 94 | 0 |
+--------+----------------+-------------------+
| stream | 35 | 0 |
+--------+----------------+-------------------+
| stream | 91 | 0 |
+--------+----------------+-------------------+
| stream | 43 | 0 |
+--------+----------------+-------------------+
| stream | 103 | 0 |
+--------+----------------+-------------------+
| stream | 40 | 0 |
+--------+----------------+-------------------+
| stream | 101 | 0 |
+--------+----------------+-------------------+
| stream | 43 | 0 |
+--------+----------------+-------------------+
| stream | 59 | 0 |
+--------+----------------+-------------------+
| stream | 0 | 5002 |
+--------+----------------+-------------------+
| stream | 0 | 725 |
+--------+----------------+-------------------+
| stream | 0 | 528 |
+--------+----------------+-------------------+
| stream | 0 | 7423 |
+--------+----------------+-------------------+
| stream | 0 | 3532 |
+--------+----------------+-------------------+
| stream | 0 | 9088 |
+--------+----------------+-------------------+
| stream | 0 | 105006 |
+--------+----------------+-------------------+
| stream | 0 | 104868 |
+--------+----------------+-------------------+
| stream | 0 | 50770 |
+--------+----------------+-------------------+
| stream | 74595 | 0 |
+--------+----------------+-------------------+
| stream | 0 | 90 |
+--------+----------------+-------------------+
| stream | 0 | 90 |
+--------+----------------+-------------------+
| stream | 0 | 95652 |
+--------+----------------+-------------------+
| stream | 0 | 8745 |
+--------+----------------+-------------------+
| stream | 0 | 2832 |
+--------+----------------+-------------------+
| stream | 0 | 7204 |
+--------+----------------+-------------------+
| stream | 0 | 7204 |
+--------+----------------+-------------------+
| stream | 0 | 7204 |
+--------+----------------+-------------------+
| stream | 0 | 7197 |
+--------+----------------+-------------------+
| stream | 0 | 7197 |
+--------+----------------+-------------------+
I can provide all (most) files privately. Happy to look into any examples if you have.
Best
sw
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-01-27 10:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241128011514.836463-1-marth64@proxyid.net>
[not found] ` <2f43d1e7-303c-4ff8-bd95-37a60f7d537b@passwd.hu>
[not found] ` <61f11f5d-22d0-4223-9b21-56e5282d1b9d@gmail.com>
[not found] ` <bd3bfe4c-b916-d563-625f-e7f2f623fd5e@passwd.hu>
[not found] ` <CA+28BfDkBa8RwGco0uVfmQC=s=umD7uycOq-1bsr0eJpce2byA@mail.gmail.com>
[not found] ` <daef6726-1881-890e-0e28-4e0f3ffe1f9a@passwd.hu>
[not found] ` <CA+28BfC3Ct=aV-fNPktM+39v5Fp9bpQOc-r-FobWuzUSe89CgQ@mail.gmail.com>
[not found] ` <CA+28BfD+2Z75h-EOjriaACrdxAf790L6e0FubBP1qzfUuipVxA@mail.gmail.com>
[not found] ` <CA+28BfAJ7Juo1csX1Nojb2=S=tfKoQByFqHwyJM5oyRytvQHxA@mail.gmail.com>
2025-01-27 9:04 ` Soft Works
2025-01-27 9:40 ` Kieran Kunhya via ffmpeg-devel
2025-01-27 10:00 ` Soft Works [this message]
2025-01-27 10:07 ` Soft Works
2025-01-27 19:02 ` Soft Works
2025-01-27 19:25 ` Kieran Kunhya via ffmpeg-devel
2025-01-27 19:36 ` Soft Works
2025-01-27 20:15 ` Devin Heitmueller
2025-01-27 20:39 ` Soft Works
2025-01-30 4:43 ` Marth64
2025-01-30 4:58 ` Soft Works
2025-01-30 5:07 ` Marth64
2025-01-30 5:20 ` Soft Works
2025-01-30 5:24 ` Marth64
2025-01-30 5:36 ` Soft Works
2025-01-30 5:41 ` Marth64
2025-01-30 5:46 ` Marth64
2025-01-30 5:54 ` Soft Works
2025-01-30 6:07 ` Marth64
2025-01-30 6:40 ` Soft Works
2025-01-30 6:55 ` Marth64
2025-01-30 7:41 ` Soft Works
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8P223MB03650F4CCE29E373D8F7318EBAEC2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM \
--to=softworkz-at-hotmail.com@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=kieran618@googlemail.com \
--cc=marth64@proxyid.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git