From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8C5984245B for ; Sat, 18 Dec 2021 14:29:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2B45568AF6B; Sat, 18 Dec 2021 16:28:28 +0200 (EET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10olkn2076.outbound.protection.outlook.com [40.92.41.76]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C099F68AEBA for ; Sat, 18 Dec 2021 16:28:26 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fGm+FfJ4tE1PI7m4d36EcFUt93g4H8kIm76hOlU5E4EEoU8BHEZTIHxOH7uWM7LBNdeCObDcG+GIjxmec3H0kwQDVYEMU3bO+hv+LHOiM8XrUX7Uj7RWirvTE3sDx+ETosGK3Dq8RzHGBAf4OYGRMz29lW/2D0EInVEjkgfOe6djQx1LiEewoOu+YS9uyRWw8epTUvx788fTarOGuJoFTf1UcK3/g2/L2eFenw6LQsd7B+eLILMg2IZrUcZpG4tzUSl/H7Sw38uwoW5UPJ6hQ4yaqi5IC07W2+bMbplaV5N05hFJBj8NC1KKBk7HI85YpgDw82uFBxUAeUP7t9ISoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rzoiHO4Tl8lA4wHF/fi6JdTd53qGkHT8fENar8gbEwk=; b=TEskHi+eIM2XqudYfZY/j491sgmfYahINNflN8uBhHB3SoJhLkPr8ZVb9k9jJO3CD3eHDklbeoi/+i6V0HlNvRmuxfmJILkZQQ5Fq7ztwCgkKL6B8d98L1gj64+uAIcQMua3nV4zAuPoh2OoD8rNE58ql5+dIPcB+sc3EUlXIqWf6oEQ3QNjju0ed8gBBtPnmI5s/9oRMXt9qzshpwRR2xCraziSU3lq7lJRwlVTGCODw5vWhwhJHEq6blY2jD5nBUaltlgn5FO2DRmHs0oedGSjgGNGis3Hh6gjxoIgKn4mLZ4jnaI0J60+93EIiJTLifQ8Tub809UT+adbvrW5JA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rzoiHO4Tl8lA4wHF/fi6JdTd53qGkHT8fENar8gbEwk=; b=q7QzjADuq/84CvqZrwmibjToM42dY4f00CTC/MzRAN9rAyc7QHp24Mj8oc8RoQpeM1aVgPE63k69VUledGJhlgdiZj/0/2gwBqtYNmT0pcCajj5HDbBpi7a3Wd3v1C08wOulJjFBu9U3HC+t6iOdLposMdk3J+WdTe5ieFrIdmKLSsRAuE5HqhKkOzOGR4rsyrrlZ1Ck9vLRL/ojbzaEokY39dQ9E8caE6rpIoXaPxTkRRlAgJkXAEVhuRnWqsLbttFUGXgtq53hYiWg86p95jQaKMsM7Y8EsFjHik57up2eT6S+tuwPpe+7Q9kupJgqHsWDKORQ7h9R8mWNZ2LC3w== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by DM8P223MB0127.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Sat, 18 Dec 2021 14:28:24 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::9c8d:fc63:9488:9775]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::9c8d:fc63:9488:9775%7]) with mapi id 15.20.4801.017; Sat, 18 Dec 2021 14:28:24 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] Politics Thread-Index: AdfvHU2CBKI4bcoLRhSl52fM3Tar9QBLh/sAAAAs7YAAA5K2AAAAX9TAAA7bNQAAALs1kAA/KcwAAAg1U6AAkH5iAAAAs7+gAAXLhgAAATjkwA== Date: Sat, 18 Dec 2021 14:28:23 +0000 Message-ID: References: <8dbfd345-c661-459e-b242-94830107eae3@www.fastmail.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [fkG6ertCwQLU1K0i7TSIy0gyVCHFQUc0neM8BVNgzEcw75lI3rzufo+nC0w4xYvp] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 14a40aae-e8a3-4aab-32b9-08d9c232a619 x-ms-traffictypediagnostic: DM8P223MB0127:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4aZazch/QmMAFb2qRMUzmmmwesOwXrQRP3SWOkH3Wa+qL8hxbFMGhR5OIRM4/O9asVqIBoJuv7960iLcYfVFOczi5VWsG8X+fHHTouUGtOSCckaor3yM5Ac1TM4S2xGoBPIpUC69ESCo6KTe+Ad6xvMs4C6fbrXUOWb73R3hqyn8nTAuRfeUGtAtu50pcYXG6xzigdRKPtM1lGAf++1ydO3FIgljlHY2U1cAtb57lVscW13ab4/b6b7wYdViO329yWfBvmermZoqqRJlaNN/vXKj3JL7iDZ7yYKkjn8NNO+xURAF82opKbIdRVJYK0eTGWo/FaDG1n9ch+uPiY9CF3f2URkHZo3diXxYA1DeqO+QPTrFyUtUddG3JT2v/DqKuOxoTcVjs/17r1ElvZ7D5ojMXahHRDQ8Jwzkwq6Te2NBMll9WHBxjCt7Tnbsgm1IS1cRN2DHUIOdkHy4cXMJJ0k7m1Whg/13gj2hoYba3STHNhNgAEYykARQGxo8QuGZIlR1KOcoqki4/RZufZNch6L7+RNQ93j7Ln8ftIuLMaXQ4/UMdEqkcd0kuN54Xo+LM+b4HhTuTzc7HWb3NoZ2Yg== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?QlJCKzdyaDZrclgvdHVsak5WeGtIaEJFaWFZcy9mMXhURXgxU2FWNmNUUFRR?= =?utf-8?B?MEE5Q3FMcWVDQ1pJWTVRUXUzdjhMWkJNWTArd2g2MlNkVWhVa1dVNlFsUnJ4?= =?utf-8?B?NmhqTHhjWnZSMUZrbHJ0VytpMUMzSERKQ1I2cld3cnUyL2grMFdCaDJmY0ls?= =?utf-8?B?TWZoamovN2x1eWpPYmpCeEZ2MENiRWVYTHRCOE1RWENJR1hzRkdhVk5uL1Ix?= =?utf-8?B?MytoVE1NQ0VuZjQvR1dFTnNDZExobkNTME5pMmVoZTd6N2dFS1hNMDNGd2VD?= =?utf-8?B?SzAwckZQYmszWFF6R3FZWXNycWo1aExUWHNDRjdwZkZrcnFpMEN6NStiVU84?= =?utf-8?B?a0lqS2tRZnp1UHQyL0F4RU5yT2FKbFZpMmpybjNkbDRLdHk5eENISjJYVkxw?= =?utf-8?B?ZFBsaTFVOUhwTW9SVCt1ZDNYZDFRNzFZZ2FQVDRlS3REU0M1YjZzY3VEMGN2?= =?utf-8?B?bVFMcjhLUzBYZHhrZm15NEJOTm55WHJzSkdyUnppOEN2VHpiNW1yNzJ3SEtl?= =?utf-8?B?azJLNVRYQjRwRklYOEZIZzFpTWtVTmVKZ2tsK2ZqVUkxVXcvZmU1OGp2aVJN?= =?utf-8?B?Mk8wV2JNTUNOeW5SQ1MwMjgvVWU3dE5QbjYzRDdXclpOV0F1U1hxaDdQWFZD?= =?utf-8?B?dEFWeGQ2bldwZy9pVFhqeEFObWVpYzVJSlJBTTZPWkhSZUI3UEVuMnNwYis0?= =?utf-8?B?RFdOeVRGeWNSZEt3enFSSHAvUFpTdTYrN3V0WXJlQ0ZITFBXQnlXSWo0bUpB?= =?utf-8?B?bHF6T2RNZURCRSt1Z2IzZWRZaUw0WkVtV3JadlRIY3owUGtpcTVUdDVvK091?= =?utf-8?B?dkNnSC9XYkxsdy8vYkQvZFpnSXplUW9icmNtTHlhUUVzN2lnYlpzckUzb3d3?= =?utf-8?B?bHJnSHF0WkdRcVhKWGtubG01UnJVSGxENGFTUHFHN0NBaE1MTjNscndHVG5O?= =?utf-8?B?cHI0bDBPTlVNZUhOa3JJZVp6aGMxRHdkcm9SaEowNzFWSDJlaUE5Uk9WeWlu?= =?utf-8?B?dkc4WkpaeS9hNG9TSGh4YzdlMWMySUFsL0NvaHFVYWJEWndRRmxNNG1YaklS?= =?utf-8?B?QnRUM0xBSTQ4d0hWNVN3WkI0QUNFUWlKcHlGdGY5QnBnMWcraG0xRXVGOFlL?= =?utf-8?B?UC9qUS9jTWNJOVY5Y3AydnluTzEyV0ptc05rRG91bWN6cGhDT05CWTBsRytq?= =?utf-8?B?RVUrZlVMM0hkWUtieVM4dUJjUnB3OG0yb2NtUXZKOFBuU3JSblRqb3h4L1pY?= =?utf-8?B?K2ZpYitZMjB6K2pLNmlMYW5rKzR2VjV3cnFDQStVWWF4emJtK3NIYlNtZ2c1?= =?utf-8?Q?0bIJ4L2hIyCHQJ+w3o9htMipWbtTjTtOf7?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 14a40aae-e8a3-4aab-32b9-08d9c232a619 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Dec 2021 14:28:24.0169 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8P223MB0127 Subject: Re: [FFmpeg-devel] Politics X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Lynne > Sent: Saturday, December 18, 2021 2:33 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] Politics > > Dec 18, 2021, 12:34 by softworkz@hotmail.com: > > > > > > >> -----Original Message----- > >> From: ffmpeg-devel On Behalf Of Paul B > >> Mahol > >> Sent: Saturday, December 18, 2021 11:27 AM > >> To: FFmpeg development discussions and patches > >> Subject: Re: [FFmpeg-devel] Politics > >> > >> On Wed, Dec 15, 2021 at 2:34 PM Soft Works wrote: > >> > > > > [..] > > > >> > > > Once for the facts: the subtitle_pts field in AVFrame exists since > >> > > > V5 of my patchset, which I have submitted on 2021-09-12. > >> > > > This has been 3 months ago. Nobody had objected its existence > >> > > > until only 2 or 3 weeks ago. > >> > > > >> > > > >> > > This is really irrelevant, please stop insisting on hacks like > >> > subtitle_pts. > >> > > >> > New idea: > >> > > >> > I could remove the three fields (subtitle_pts, subtitle_start_time, > >> > subtitle_end_time) from AVFrame and add it to AVSubtitleArea. > >> > > >> > How about that? It would allow the frame to be "clean" at least. > >> > > >> > >> > >> Yea, much better, But still original issue is not solved. > >> > > > > Yes, correct, this changes the location but not the logic. > > But this is something I could surely do. It's a bit of work, > > but it would be safe to do without breaking everything into > > dysfunctional pieces ;-) > > > > It wouldn't be my first choice since there can be multiple > > AVSubtitleAreas while only those values from the first one > > would be relevant. But when this would help to increase the > > acceptance, then it will be fine for me. > > > > Another possibility I had thought about, might be to leave > > them at the side of AVFrame, but put them in a struct field > > of AVFrame named 'subtitle_timing', which itself would have > > the fields pts, start_time, end_time. > > > > > > I did some research regarding the use of the start_time > > field. While it is used and cannot be dropped, I found > > that the following changes would be possible with moderate > > effort: > > > > - change the time base of start_time and end_time > > to the same like subtitle_pts (AV_TIMEBASE_Q) > > - rename subtitle_start_time to subtitle_start_offset > > - rename subtitle_end_time to subtitle_duration > > and adapt the logic everywhere where it's used > > > > In combination with the subtitle_timing struct idea it > > could then look like: > > > > frame->subtitle_timing.pts > > frame->subtitle_timing.start_offset > > frame->subtitle_timing.duration > > > > or even eliminate the pts naming and do like: > > > > frame->subtitle_timing.start > > frame->subtitle_timing.start_offset > > frame->subtitle_timing.duration > > > > or still move them to AVSubtitleArea, which wouldn't > > be that nice to access and require to check the > > subtitle_area_nb value wherever it needs to be > > accessed: > > > > frame->subtitle_areas[0].start > > frame->subtitle_areas[0].start_offset > > frame->subtitle_areas[0].duration > > > > > > Please let me (all) know whether one of those suggestions would > > be an acceptable compromise. > > > > Renaming the fields doesn't get around the issue that they're > still overriding fields with a different meaning from the > AVFrame structure. That's not really a compromise since they're > still there. I'm suggesting those things that are doable. > I also am not accepting a hardcoded timebase of microseconds. > Rounding really matters for subtitles, since presenting them > a frame early or late is unacceptable, so I'd like a time_base > field for the timestamps. I can't follow. With 120fps, the frame duration is 8300 microseconds. And you say that's not enough to hit the right frame? None of the subtitle storage formats has a precision higher than milliseconds, often it's less. Finally, a fixed time base avoids frequent re-scaling and that in turn means less rounding errors. Kind regards, softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".