From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0B82A40AD5 for ; Sun, 5 Jun 2022 07:59:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0231168B6A2; Sun, 5 Jun 2022 10:59:42 +0300 (EEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11olkn2105.outbound.protection.outlook.com [40.92.19.105]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C8DEF68B4B5 for ; Sun, 5 Jun 2022 10:59:35 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mK0BHCPSjYBb5b4dS1kg2A2lH97Z1IYEI2HZWbR2wRiNn32aP8+CUSiI/Bjw9aDSsD+MXGodAkUP8cfMDHlDrr3FdQOJABHtBJjTlcB3ZKGSh3gebAyfdi2l/gswOc5N9I69LW1Q+IuAEGoFz+m0fr9mbP6OwTyRRq18KSCRFAeUPnBM4lYkfo7UYmKDkrB3+Z80BfbLgssaYsMZ0vjE2WunK9ds7uBb3v/BlvaP4PB+OkOJUCdKEUAsseHznGSvfs8dz72p0sSxtKnQGBO8MLSaeXG7IvhAxJI5L/Q5OkxjyiiaSxzAf4ctXjHO4Kdkgukc6glhmkPuXfPrwMh9BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v9ecHsqs/cyYvO+y55tMvgUol9aG23e8NdwAfohgszQ=; b=HrtB2XEkJtigk76aUvPrd/njYxJ52Ueq7Msoz9+JqbsUOxrNkch/ZnzW8/yxFeSjBtvG0l7MoCR7Ly+ra/5GvGbJWaIf3867DF3JyMT+GvuDiLTMKx1rPGgIC4slBN+rsGJr+GZtBkXALrSFWY/+ojAeR6lT2ohFD3bxGXLuja+ssEILdC7QrB7kGYAz+LX90dW+7n40zTA/weDFYEo6by/MYaeZAz60eWJp82vfdDWAr675ZoYA8F6Ih+F/w58KN28nKGO1y2GDslU+jgwH1DxBJz91x7svAt9vc+fTJpj3TqRDHlEh2fdQ2RhPuFQml2N4WpX7uU/BiFypG4Pprg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v9ecHsqs/cyYvO+y55tMvgUol9aG23e8NdwAfohgszQ=; b=ciXlCKSXxX6VG+TsSS89jxadJ4BnB5o75BGefwXB+WFt/yZgEpTOR24p3iLtuCMsjMKL+gEDVtF6eDDTISQnDDCvBBv7rZiJrkjBIvNp4MMe7Jf/GomE/ksGCYm3pl+1TqHx/ENkqA+CozBMQQbVlp0UfvCw24HR5rZd2MH10i5zWZuCb9rZ+L3/fBNR3poBK+OX5/OOiU6A+7QfyngG72o96ISjLTgJUvnp3IJJh7yoqP4FAnPDl6QXVFqTTkOXgWP4BZw1Lb/Oml06/Iwloba3l1hw27Dr3O9zYRL9Is8nmrpM9ekQaRitTAujOyw1SWwcuyqn+l1jI6Q6LSoGiA== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by BL3P223MB0274.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:34c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.13; Sun, 5 Jun 2022 07:59:33 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::f144:21f9:cdb1:5c8a]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::f144:21f9:cdb1:5c8a%7]) with mapi id 15.20.5314.018; Sun, 5 Jun 2022 07:59:33 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 1/8] lavc/avcodec: simplify codec id/type validity checking Thread-Index: AQHYPs69Q/NxwRSzxUypnCXsEU54I61A1pQ8gAAAjmCAAA83gA== Date: Sun, 5 Jun 2022 07:59:32 +0000 Message-ID: References: <20220323155720.20017-1-anton@khirnov.net> =?utf-8?q?=3CDM8P223M?= =?utf-8?q?B0365783CC5AF48817C137226BAA39=40DM8P223MB0365=2ENAMP223=2EPROD?= =?utf-8?q?=2EOUTLOOK=2ECOM=3E?= <165441247425.5088.1095760194724448724@lain.red.khirnov.net> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [44cu/P6xlCCmmiJwYLJSpFEZmo7p7Fj3] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9300274b-e09b-4b13-b295-08da46c9537e x-ms-traffictypediagnostic: BL3P223MB0274:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZrxxvDyBXyI8gr9kGBPj0tR5HTB0xhTwFkl54u8uIAAY/I9Y+P1BDmuiALockAV7G/75RVuV9h6fk1nmKcBkrBUzxgm2rm408otJNyzlhqj+yrCcs3VYuRE9h0A1vzO8Rvesl2IMS2FhrdpzoERYiLQjBC8zfMtzNFurnMo5n8XLs9JbMhTpXKtFKvrKnuAWiX9u+SZcqAmjyZUb0L4U3QbtDl8+8AxiR//qBsOSROjeyK4v1SXaVG5qcyI3PTA29WoNnME4Nr+g+OVS0vGrig2SZ059oE3ApflYzIh3xuCBS1MF8p9MsUPyrBGkEtXzTALGFLu6G3+a2i3VsFVkwAqagoCnYCjk9Ond3uV1mwyvK90r1gkCol8bieM/yb6mm6iVHEm9k5szBtCLETZKcu7+hwg9MXW71I00xplMY9BvIU8w59FNB7NnFiYibRbp3Xy5gqagp5i2a/51MKL6IPolzF1nspOnzdn0np+YgIYhGrfBVH/s072zB/BrDiAOwhYR5wtw0MDpdmLU4pHmcycqcSb5zx0/f8XZF1db+PGIFyZoN13NbdJHL03/zEIwbaOTFA3ZqzOW4bVDO1zbZQ== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Z3RnTE1OMURCVGNxdDVjZmVxb0gyaGdKcGw1SHNNZUdQZThmVDBPdTg1N2Zh?= =?utf-8?B?YUs2UEFxdGhieDBVUzB1eTVSQzdLWEZXcGt1N1gyaHg5eG9qUGtFRDg0ZTFL?= =?utf-8?B?Q3FtUnMzRG94NGx1aWF6WDQ2MUo1dWZNdnpNRGtTRVoxRk9ta29ZcFNrSHN1?= =?utf-8?B?VlV0eU9iZHdiTmhFWUdybm9BVzJFYndUWFIyM3prZzZZcnFWRjgzbSsxeDYr?= =?utf-8?B?Y3U5K09LYkNMS1dNMnUwSFF5Y05GNDdqREc0UURmTnBhOHlkRWdMejloZHRz?= =?utf-8?B?MDVmNzJxWkxPL09IZE1nTzI3cEdoUjYvUE1Hb0VuUHlWYUZhSm9xYStFZi9U?= =?utf-8?B?VUp2ckk5YmRLcVZTaWsxVDN5NFRtQTlvL1pNOGU3UlhKaTh3cHgrN29UZ3J4?= =?utf-8?B?ZmZwQklTc2poak82aURnSk9qR0IrcHQwY0hycVRDc1IrSnZPaUV6Q2RabmtK?= =?utf-8?B?SzViRGEzQm1XbGpIdnpHcndvbG1icEplelhaQnpHamthSjdNRUNteVorbCtN?= =?utf-8?B?bGlRWkxRQm9UK2RUSElNZC9GQ3MwNExpbm1QUytLWjZDcCtYNmk3NXpqMHM3?= =?utf-8?B?ZHVvUmk3RU1IMHdDR2NmblZBWHZsSjFsZnJrTkNnMHdDZ0l5eDZtLzE0OEhv?= =?utf-8?B?dEtZRTFMZFdsUDFyYU42OU5LcDg5NGU1VGVqZUN0QklIWkpFUkcrbGpWUi9G?= =?utf-8?B?Y3VsN3lFMXc4bGxqeFZqY3pvcDJXaDdYanp4ZFNYMDdxWXNXNUVRRjlxcTF3?= =?utf-8?B?UVZ0RHhhTU1McG1naVcvZktXWnBUOHdpNHhMV0IzL3FwSFE4Q1o5RERQbVNB?= =?utf-8?B?OVBFVlJoNktxT2drRVJQc0VtaWpWRzJIYXgxRVBXNXBPNmFhaG5rTVBSRUZz?= =?utf-8?B?WU1obGVUVjlabkZseHpvK0p4R1dUUVYxSVFOUDE2dk13RVVZSzhWblNVOVls?= =?utf-8?B?dFZ2TS9FQWRJUk9SL2kzY3poYnNVaXJDZkpNWjVza2Ura0FSRVZDR3AzL2xO?= =?utf-8?B?MGQ5aGdpQmpjbTRBaVNWa0VMcmJ3cmxCa2RkVm9hZ1h5WlNicjQ5eUZFUVdv?= =?utf-8?B?ZjNYTmVCSkpkWU02dERzN3RVbnUzYmUyRysyOXB0QXRwclJEY0xBQUhhUkFM?= =?utf-8?B?aXJwaW16eDVOZ0pNMHc4bGM4UHV4ZFVjMzVwaWFEdDJxVkxlYlZPSEJyb1J3?= =?utf-8?B?aDVTbTRPM1VGNWJEd1lVcHBONkRwMU1mN2FhbCtVeUJCbmhlN3V6elNMclJM?= =?utf-8?B?NTdXM3NGbmdQWEdSRFhKbzRzZXMza3Y1RVZnLzl5aW9yc0MwQjd3N3VWcFkr?= =?utf-8?B?R0psUGtkdjVBbWpRd3hTT0pEZFRNVVpCZ2dtUi9IM0E0Y1RpdHpXWGhiOXpY?= =?utf-8?B?cGVTQWt2RmNFR3hvZTQ5enRVOU5JV0tid3ZIeWU5amYyRFBvY21vYzF3Z0Fz?= =?utf-8?B?S1FQRUIyWW5pZjd6TUU1M1U0T0o2cDdvRFV2SW5yS1p4VFBkK1BiY0VDQnBs?= =?utf-8?B?a0JOMmxpTitCNnBEbkJkNElGTUpqcmlYNHBmaENrbGY1M29uOFpIQzdITUVw?= =?utf-8?B?S2xtV081bnd4Q2o5WmdralFISVQyb0JDY2x1WlhXU1VVUWhNWUIyQkZuVUVB?= =?utf-8?B?L3VpNXVLVGxmKzFna2hBNG1VeEk2THQ5VkJhcXdwNk04cERlT0FtNVViZHpI?= =?utf-8?B?VjQrRkwybGQ5TE5pS09FY1FtUHRFNG9wL05wNWhpQzJ4RVhhZkxxWFQ4eWhI?= =?utf-8?B?RkZMVEV2MkxNaGp1ZzdGR2tpc2kxNEV2MzhteXl5U3VjOFNUM2FhSmUvSWx0?= =?utf-8?B?VE5MQ3crcUJxaDVIMkdSVGR4TEFOYlJMU1F5RVJwSG1HRW5ZQ1NlTmJBUk9w?= =?utf-8?B?dXZqaWlaQTF5UWp6RGc2TGhXQlhIRkdaL0dWVG1wcjVReXJhRnJvYWJSUXMx?= =?utf-8?Q?XeZvz7vgkZM=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 9300274b-e09b-4b13-b295-08da46c9537e X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jun 2022 07:59:32.9216 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3P223MB0274 Subject: Re: [FFmpeg-devel] [PATCH 1/8] lavc/avcodec: simplify codec id/type validity checking X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Soft Works > Sent: Sunday, June 5, 2022 9:55 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 1/8] lavc/avcodec: simplify codec id/type > validity checking > > > > > -----Original Message----- > > From: ffmpeg-devel On Behalf Of Anton > > Khirnov > > Sent: Sunday, June 5, 2022 9:01 AM > > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH 1/8] lavc/avcodec: simplify codec > id/type > > validity checking > > > > Quoting Soft Works (2022-06-05 07:23:18) > > > This is causing a regression in ffprobe. > > > > > > The commit removes the special-case check for AVMEDIA_TYPE_ATTACHMENT > which > > > was required for ffprobe and had been added with > > e83c716e16c52fa56a78274408f7628e5dc719da. > > > > > > The demand from the commit message is not yet guaranteed to be fulfilled: > > > > > > > On entry to avcodec_open2(), the type and id either have to be > > > > UNKNOWN/NONE or have to match the codec to be used. > > > > > > I have one verified example (maybe a second will follow), which is an MKV > > with > > > an attachment "stream" of type "text". > > > The found codec will be textdec of type 'subtitle' even though the stream > > type > > > is attachment. Without the special condition for attachment streams, this > > > is now causing ffprobe to error out with non-zero exit code and > incomplete > > > output. > > > > > > > > > ------------------------------------------------------------------------ > > > Example: > > > > > > [...] > > > Stream #0:9: Attachment: text > > > Metadata: > > > filename : textfile.text > > > mimetype : text/plain > > > [text @ 000001AC32310340] Codec type or id mismatches > > > Could not open codec for input stream 9 > > > ------------------------------------------------------------------------ > > > > This sounds very much like a bug in ffprobe. It makes no sense to call > > avcodec_open2() with the AVMEDIA_TYPE_ATTACHMENT type. > > You make a behavioral change to an API function that had this behavior > established and constant over more than 10 years, and when that change > breaks functionality, it's the callers' fault? > How does this go together with all that peanut counting of major, minor > and micro version numbers per library? What is this versioning good for, > when you can make breaking changes and declare the breakage as bugs? As per your logic - wouldn't this change require a major version bump? Or even an avcodec_open3() to ensure backward-compatibility? _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".