Re: [FFmpeg-devel] [PATCH 1/3] avformat/hlsenc: Log information about segments written

["softworkz ." <softworkz-at-hotmail.com@ffmpeg.org>]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> Marton Balint
> Sent: Freitag, 13. Juni 2025 23:03
> To: FFmpeg development discussions and patches <ffmpeg-
> devel@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH 1/3] avformat/hlsenc: Log
> information about segments written
> 
> 
> 
> On Fri, 13 Jun 2025, softworkz wrote:
> 
> > From: softworkz <softworkz@hotmail.com>
> >
> > Signed-off-by: softworkz <softworkz@hotmail.com>
> > ---
> > libavformat/hlsenc.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
> > index a93d35ab75..a3e523a5df 100644
> > --- a/libavformat/hlsenc.c
> > +++ b/libavformat/hlsenc.c
> > @@ -2703,6 +2703,12 @@ static int
> hls_write_packet(AVFormatContext *s, AVPacket *pkt)
> >         if (ret < 0)
> >             return ret;
> >
> > +        if (oc->url[0]) {
> > +            av_log(s, AV_LOG_VERBOSE, "SegmentComplete=%s:%d
> Index=%d StartPts=%"PRId64" EndPts=%"PRId64" Duration=%f
> filename=%s\n",
> > +                   av_get_media_type_string(vs-
> >streams[stream_index]->codecpar->codec_type),
> > +                   stream_index, vs->number, vs->start_pts, vs-
> >end_pts, vs->duration, av_basename(oc->url));
> 
> snake_case consistently please here and in the following patches.
> 
> Thanks,
> Marton


Oh, ouch, hadn't thought about it. I'll withdraw the logging patches, 
there's no mutual benefit.
(my fault - it's right for FFmpeg to require consistency in output)


Best regards
sw

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".