Re: [FFmpeg-devel] Graphprint Patches Overview

["softworkz ." <softworkz-at-hotmail.com@ffmpeg.org>]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Kieran
> Kunhya via ffmpeg-devel
> Sent: Mittwoch, 21. Mai 2025 13:00
> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> Cc: Kieran Kunhya <kieran618@googlemail.com>
> Subject: Re: [FFmpeg-devel] Graphprint Patches Overview
> 
> On Wed, 21 May 2025, 01:45 softworkz ., <softworkz-at-hotmail.com@ffmpeg.org>
> wrote:
> 
> > Hello,
> >
> > thanks again to all for the patches. I figured it might be a bit difficult
> > to
> > keep track of what has already been submitted and fixed and is still
> > pending, and I'm sorry that there has been some duplicate effort to fix the
> > same things - so here's an overview. The ones with X are the ones I would
> > like to apply eventually:
> >
> >
> > Timo Rothenpieler
> > https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=14528
> > (I would favor "ffbuild/commonmak" over for 1/3)
> >
> >   [1/3] fftools/resources: fix preservation of intermediary resman build
> > artifacts
> > X [2/3] ffbuild: correctly silence and tag new css/html steps
> > X [3/3] fftools/resources: add missing extensions to .gitignore
> >
> >
> >
> > Mark Thompson (already merged)
> > https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=14537
> >
> > X [1/3] ffmpeg: Don't print graphs if there are no graphs to print
> > X [2/3] fftools/graphprint: Fix leak of graphprint object
> > X [3/3] fftools/graphprint: Fix leak of graph section header string
> >
> >
> > softworkz
> > https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=14563
> >
> > X [1/5] fftools/makefile: Remove resources from ffprobe
> > X [2/5] fftools/resources: Use .SECONDARY in Makefile comment
> > X [3/5] fftools/ffmpeg: Free print_graph option variables
> > X [4/5] fftools/graphprint: Fix memory leaks
> > X [5/5] fftools/tf_mermaid: Add missing uninit and fix leaks
> >
> > https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=14570
> > X [v3] ffbuild/commonmak: Fix rebuild check with implicit rule chains
> >
> >
> > Derek Buitenhuis
> > https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=14569
> > (1/3 and 2/3 correspond to 2/3 from Timo, and 3/3 doesn't fix
> > the rebuild check like "commonmak" above does)
> >
> > [1/3] ffbuild/common: Remove what appears to be a temporary debugging
> > comment
> > [2/3] ffbuild/common: Properly tag/suppress sed command
> > [3/3] fftools/resoirces: Mark .css.min and .css.min.gz as NOTINTERMEDIATE
> >
> >
> > Thanks again,
> > sw
> >
> 
> Can we just revert the whole set until it's cleaned up properly?

So that it can be ignored for another 15 revisions?
I'm glad and thankful that others have looked at it now and I don't expect
so many more things to come.

> There are more patches to fix issues than the set itself. This is
> understandable if it's a bit architectural change like threading but it's
> not.

Please note that many of those patches are just single-line changes and
the "more fixes than patches" is not that unusual. It's only less visible
because nobody normally sends an overview like I did. Even though it's
not an architectural change, it's still an entirely new feature with 2k
lines of new code (counting the last 4 commits only).

I really would have preferred this to have happened while the patches 
were submitted for review and I don't know why nobody had responded to 
my messages asking whether somebody would still like to review it and 
would need more time. I would have happily waited longer - even weeks,
if someone had said anything.

Finally, for a "better picture", I could have excluded the patches from
Mark (already merged) and Derek (duplicate), but I still listed them
to acknowledge their efforts.

Best,
sw

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".