Re: [FFmpeg-devel] [PATCH 01/21] avutil/avassert: Add av_unreachable and av_assume() macros

["softworkz ." <softworkz-at-hotmail.com@ffmpeg.org>]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of softworkz .
> Sent: Mittwoch, 7. Mai 2025 20:54
> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH 01/21] avutil/avassert: Add av_unreachable
> and av_assume() macros
> 
> 
> 
> > -----Original Message-----
> > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of James
> Almer
> > Sent: Mittwoch, 7. Mai 2025 20:30
> > To: ffmpeg-devel@ffmpeg.org
> > Subject: Re: [FFmpeg-devel] [PATCH 01/21] avutil/avassert: Add
> av_unreachable
> > and av_assume() macros
> >
> > On 5/7/2025 2:57 PM, softworkz . wrote:
> > >
> > >
> > >> -----Original Message-----
> > >> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Andreas
> > >> Rheinhardt
> > >> Sent: Mittwoch, 7. Mai 2025 13:59
> > >> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> > >> Subject: [FFmpeg-devel] [PATCH 01/21] avutil/avassert: Add av_unreachable
> > and
> > >> av_assume() macros
> > >>
> > >> Patches attached.
> > >>
> > >> - Andreas
> > >
> > > Hi Andreas,
> > >
> > > from https://ffmpeg.org/developer.html#Submitting-patches-1
> > >
> > > "..ensure the correct mime type is used (text/x-diff or text/x-patch or at
> > least text/plain) and that only one patch is inline or attached per mail."
> > >
> > > I'm saying that because the way you are submitting, Patchwork only ever
> > recognizes the first attached patch, so - in this case - the remaining 20
> > patches are not checked by the CI runs.
> > > It's also difficult to review patches that are submitted in this way, even
> > more difficult to respond, as that requires to copy the patch into a text
> > editor first, in order to add some synthetic quote marks ("> ") and when
> > replying, it isn't clear to which of the patches the reply is corresponding
> > to.
> > >
> > > As long as there's no migration to a better way, why not try out making
> PRs
> > to https://github.com/ffstaging/FFmpeg?
> >
> > I doubt "ffstaging" is affiliated with the project in any capacity.
> 
> Hi James,
> 
> it works like this:
> 
> - You make a PR to https://github.com/ffstaging/FFmpeg
> - You make a comment with "/submit"
> - The PR will be submitted to the ML as regular patches

More specifics:

- The PR message is sent as the cover-letter text [Patch 0/n]
  Markdown is converted to ASCII

- Commit messages are checked for compliance

- CI builds are run on the last commit (yet you can submit 
  without waiting)

- To submit new versions of a patchset, simply force-push to
  your PR branch and comment "/submit" again.
  The patchset will automatically be submitted as a new version
  (v2, v3, etc.)

- Comments made on the ML are automatically mirrored back as PR
  comments on GH

- Cover-letters sent to the ML include a range-diff, showing
  the changes from the previous version
  They also include Git links to directly check out the patchset

Best,
sw
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".