Re: [FFmpeg-devel] Enhanced waves filter

["softworkz ." <softworkz-at-hotmail.com@ffmpeg.org>]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of CLUSTERF***
> Sent: Montag, 12. Mai 2025 17:01
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] Enhanced waves filter
> 
> Hello, FFmpeg developers.
> 
> I am making my first steps in developing FFmpeg filters. I don't know if
> this filter was invented by copilot based on my prompts or if it
> exists/used to exist in other versions/forks. There is one reference to
> a ffmpeg wavefilt.c on search engines. I am really sorry I am not
> proficient with git and not sending this piece of code using the
> recommended procedure.
> 
> Is an enhanced waves video filter of any interest ? Used FFmpeg 6.0.
> 
> Best regards,
> 
> Jim


Hi Jim,

Welcome, and thanks for offering to share new filter work. To keep things short and on‑point, here’s what you’ll want to do next:


1. Send the patch the FFmpeg way

- Work in a clean branch based on current master.

- Split the work into one logical change per commit (e.g. one commit that adds the new filter).

- Make sure it compiles (./configure && make -j) and make fate still passes.

- Run git commit --signoff (Developer Certificate of Origin) and give a concise, descriptive commit message (lavfi: add waves filter).

- Generate the patch with git format-patch -1 (or -N for N commits).

- Mail it with git send-email *.patch to this list (you need send‑email configured; developer.html explains how).

- Stick to plain text, no top‑posting.

- Full instructions are under “Submitting patches” and “Coding rules” at https://ffmpeg.org/developer.html.


2. Authorship & licensing must be crystal‑clear

You (not Copilot) need to be the author of every line you submit. If an LLM suggested code, you must have rewritten, understood, and be able to explain every piece; otherwise we can’t accept it. Anything merged becomes LGPL/GPL, so only code you can personally vouch for, backed by your Signed‑off‑by line, is eligible. If unsure, rewrite from scratch.


3. Documentation & tests

- Add a short entry to doc/filters.texi showing usage and options.

- If the filter’s output is deterministic, include a FATE test so regressions are caught automatically. There’s a minimal template in tests/fate/filter-video.mak.


4. Check for prior art

wavefilt.c doesn’t exist in current FFmpeg, but you may find similar ideas in old forks. It’s fine to re‑implement, but please mention any inspiration in the commit message.

Send the patch when you’re ready and it will be reviewed on‑list.



DISCLAIMER: Like your code, this message was generated by AI.


_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".