From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6320942BF0 for ; Mon, 2 May 2022 06:40:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C16A968B284; Mon, 2 May 2022 09:40:37 +0300 (EEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12olkn2108.outbound.protection.outlook.com [40.92.22.108]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A7BE368B158 for ; Mon, 2 May 2022 09:40:31 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XcRjENfQOf0SSkhw4vefafPm8882omk0PKOQJSKss/aA4jc05QI7iUrnFtqBGp0jwJp9rESHSpxg+bZeYHVrVaE6HZbUVyP6FI5/qkRmuG4GxAVCQbEKDji6bw9xEgoouixgSy/yQ1xOtv//RQ2sUX1RljpR15hZB8wzDK8SjfCJnz+L7gvByiAeVRzRanxq/nRlNIrXWW6IuFQhfwNN7hs2Sj/QRmz/iHroCsfjHSAR0SWyZo/45OiIN3w7IGExYd8HLOMBfgKU0yDDTZx+dezt3wdviQ1idRxiQJbn/iuLm+4xJRvsMCXZnSY5AmM+2Zgz496gkEftnTKVsfG5iA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BjXprxHxp4RGzRBi4GMNWeOc4whiQGsHDorF23L8U5M=; b=AmhHxdQ03jNRBHDvKWD24HDI4uDkRE0bz8IiJi7hNmoJ0o0x4xY5EgGZzAXmabIIij2cSbIKGXo45fuUjVzIa9okFApBhUOv55Teef+tiNF0iRwHaCrh8uruSMN03BqWAxZm7TeUAmBYLqhr/kq4oERdrcoC+BkrvPZSI3RyiUwyMx2bOH/N89ST6PTTj7CdtrFWgFOUKt70v1xh6wfGRYz0y4bKgps/xtBNQSGdgzyky+Cz5as13586JkYUMQd9uM6E//FNoZEPbrxlvy7hoVBVjT2fpPO9Tl7ycn8w1baGydhzvqZpsUSD269dGeec9fD5lD4vjn+7LGfDuBr++w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BjXprxHxp4RGzRBi4GMNWeOc4whiQGsHDorF23L8U5M=; b=EDU4Tv8nCGI1JAJVluLiqChq0voD+7EM6d8IDzskeybEPW9ZByG5/eOksY243jzKFw/+Cau1jvnvswZRdtoLOwOfZwxtd8tu9A7tjfxSVw8m3JZzRu9KV4HAWIrRHUSDnVcrcO3Qplt2GIgMveqgaxGUzQKNE+VablJQ9k3WU9S0I+FqZ5FD7nsZfFvM4rlmJ/Z577tao+OmGMAqUJKJvqANrBmMI5IFrQjxKf6gLVZyFa2AejbGhnE38rm85FktVNXnS4mIRIHeKbU2Ae39gvELbJHv7sVeWkFOBEBLDZulGKt/4p/y4FMZwYesph8QsEKlPxPwkAZetNim/kDcTw== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by BN0P223MB0070.NAMP223.PROD.OUTLOOK.COM (2603:10b6:408:145::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Mon, 2 May 2022 06:40:28 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::7472:6f83:eeb:45e3]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::7472:6f83:eeb:45e3%9]) with mapi id 15.20.5206.013; Mon, 2 May 2022 06:40:28 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v2 1/5] avutil/hwcontext_d3d11va: fix the uninitialized texture bindflag Thread-Index: AQHYW7ZG7PhAR+3Ey0KAzg+WBYVY360HcgaAgAEHemCAAPMjgIAAAdfQgAC/84CAAAFkAIAA6O6g Date: Mon, 2 May 2022 06:40:28 +0000 Message-ID: References: <20220429104505.1747-1-tong1.wu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [Q4E0LUjEVl9dEfoLA47ZaTw8ZUDfKNff] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fbb38e29-6588-4049-9aaf-08da2c06a562 x-ms-traffictypediagnostic: BN0P223MB0070:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LxmPgUYHT40nN3ugzPxFGnvPsizcnqOx8q2mtuF6o054hfC0T6TOQCqwIVQ9tZ+JSKhjUE7OtI2pAFAyxlzW3xmd4foQ5EYxehezY/JVK5Hc8+Af8aZ+VHB7H+YgbDr47JeOHkPLMVxOgmfYXCTTFJ8DQXhIVlIDhNP3TCHuqjyoQvLgdNbKYzK35TwhHAlr8yxsytAiSmJ+0TbHI9apMl3ZpjxM/HmhJGHkT1S6pS06df8nhkYa/nBmXJhOazn36M9aDpRWoWF1JyIU5CLh9Fb0BsGE1376F00IwsaJpXCZQHuBrMxFgyaSMq5Oi2DYI7l5v6voGqFkxIozmQGhB8AV46OhuJqA6sImxQXQNkN0FbTLl2mUV04c/pJlQqBMxvbPHYs361Yhk5vCex366becc3G6u+7xKnPoyWTYYSAUwGUW6vTFvT416bgJ8/hW786YxJjmedvOB3P7AJ+ZuKtDO12LxBTMkQPxuckOezlPDzDCksVRK9jG+KN7jkKAGR0cYuTU4Rubw06Cc0Q4biJp40wJLhkWqsLYQv7M3e5Mlz6FJvhIFHjEDGJAt2ttO37QJH8ThNCb6eV95uG5eA== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZjB6ZjlWcWNKZGF4dTM1ZEkrVFF0V3RwVVNYbkJLWmFnYWEvVGMrcHFPYkxQ?= =?utf-8?B?Q1hnQmxVNG0rSTFCbnVlMlZiU3ZlaXdIT0w2c2h2bEZpS0ZNNzhxd09KZFdP?= =?utf-8?B?SXVlam42VnlnOFJEekcvRWN6ZW5CcmhVakpNaGtobDhoNUFnNmJMTk94VlN6?= =?utf-8?B?dWZ1a1huSWYvbDJjakk5WEEzV0hhcTBGNWl4SDBWa1Y0OHVQMjh5TXVtYmFs?= =?utf-8?B?T3k2MjVOQSsrQkI0U3RKbktuN2VIY0NSY3Nxdy9UdWRTakVzZ2hXOWo4aUVU?= =?utf-8?B?ODUyY2E1aW5NR1JVTm9rVWFNU2p4QnFUNGNRR0xFSVpnREFIbS9LaFBDREhK?= =?utf-8?B?VmtSTjZIcGhEVlZubWd1VFh5dk1qVFcvOFlzTHk4RVlHc3R6RnF5VFJnQ2VT?= =?utf-8?B?NFVmcDBnNHNpL2g3cjdSNDBDN2NYZHNnUGEyc2NyTy9Sd255aUxrRjltRWl5?= =?utf-8?B?WXRDdFoxVFR5K3lDVFQ0N3hwUW95T0xSbDIxNnVoYlVZZ2E4cENhTkJ5djUy?= =?utf-8?B?NjJldUt1VjJBSW1nOVY3L0hhUmhva0dRbXRrM01yYk1HL2t0M0JrMjVYcVhR?= =?utf-8?B?aXo1WUMzRTJrTzJxSm5aL2pNVkszY1R5TlRWcGhRNFl0dm11RGk2bE5oMzEx?= =?utf-8?B?ZnNmWU5qK1JUL0FTNTkrUlV5WHNKb3FRaVNxUFpUTHRwQmlpVlJsRGFQSnMw?= =?utf-8?B?QTBqRUJyR0s3dkIwTTU4R1JnZkJySUdHNEpxRHdnMHBNcUxMVldIRDd4QjhY?= =?utf-8?B?d3Q0SERhbmpUQitrOVlhOTY5cldHSG5velJSbUtpSGpJRHR3c043WkRzRGtC?= =?utf-8?B?a0ZsY08zUHNZa2hBeEZhVlRGRlc5eDZDTStTc2ZkalVHM2ROeXI1WS9CS1BJ?= =?utf-8?B?UDFkcTlUWWM5b0t5bWFCNVJla1ZoZXcxUVhHNmN4d2U5dy82Qnl6M3c5VGFK?= =?utf-8?B?SStZbjBBVHdtM21EVHJzSW1vWFdSRmdRdDdZWEtNSU9kTFpwR3Bsb0lmSFMw?= =?utf-8?B?bWNmNGlVR09IcjQ1RW0wNDlxVDl3cEMyLzBGYzM2MXZVQXB5ZFFWL1VMQ1ZC?= =?utf-8?B?RHlOcVA5YUhyTTgvcEUwNFBGRHFWMi9rVmpteVZ0TmlvZ2JJOVR0cXFmMDMw?= =?utf-8?B?a1o5WjNRZkx5NDdWZVVGZTVUY3M3UnZ0L1EvK0NPZkY5VUJqZU54UXlXbEhH?= =?utf-8?B?R3lmRmltZjBvak9QYnoxOHU0SFBjLzhNTHV1empBQTVXZWJETjVyekN2bDdB?= =?utf-8?B?a2hJdEZLL1NINElad2xEc2lNajRjQS9nUnB2blgwalJ6SjZQVGE3YVQwcm1S?= =?utf-8?B?VTNOcldVb21OenJNNzcxVmc5UGsyRFRSK3kxaFJXWFU0c0o5SzZvbXdSeUxh?= =?utf-8?B?N3UxVnZWYXBLUE8yamZXLzRYKzJONTFVS3BTU2JaR24wdmRORXZZVlpCaHZS?= =?utf-8?B?UWpyRWdQWHd5ZEh0M2poZU9oRkkrU0dsSFVGZCtydkFqY0pwcmJyUUdCK0NJ?= =?utf-8?B?ZzFqRzkrRVhBY0d1OG9oM242amQzSXhlUzhKbFZhWWJ0djMrNmtQMXJsTXhV?= =?utf-8?B?cnlFdlVsNWZmZHgyOUlnbisydlVNeVJxc3VjMEJtVCtJZzJsUXVGdEJXUU5I?= =?utf-8?B?MDNTWmR1MktsZXcxYWUvUGx2cVNvRUdCRjRtUXhlQTdMUEc3VW9pcjV5bkxa?= =?utf-8?B?bGpteDFGczc0TVoxTzBvTk4ycUd0RkJkZzRYUjNXRGFyem52Rms0d1JyU0R2?= =?utf-8?B?L1FXdzg5TlVCaEQwTjR4R1NsZEgrSGRxbmNUcGVPK1MzalFwMWVBdzhLeTB3?= =?utf-8?B?K2lNWUdPdjdmemFRRW9qVlFBMzBUeWZDanZZQ1poZm9LcmFzVXpBNHViY3Fl?= =?utf-8?B?UHUyRFNmWjlBL1l6bWxVTS9VR2xENlk5SmZNMVFwdDZWQkdKQzFkOFVFUi9o?= =?utf-8?Q?zZyF2/UiGTY=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: fbb38e29-6588-4049-9aaf-08da2c06a562 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 May 2022 06:40:28.2162 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0P223MB0070 Subject: Re: [FFmpeg-devel] [PATCH v2 1/5] avutil/hwcontext_d3d11va: fix the uninitialized texture bindflag X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Hendrik Leppkes > Sent: Sunday, May 1, 2022 5:54 PM > To: FFmpeg development discussions and patches devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v2 1/5] avutil/hwcontext_d3d11va: > fix the uninitialized texture bindflag > > On Sun, May 1, 2022 at 5:48 PM Hendrik Leppkes > wrote: > > > > On Sun, May 1, 2022 at 7:09 AM Soft Works > wrote: > > > I think that's what Hendrik wanted to point out as far as I > understood. > > > > > > > Basically, I want explicit behavior, not implicit defaults. Anytime > a > > hwcontext is created, something should tell it what its going to be > > used for, so we can determine which flags make sense (or ideally, it > > should just specify the flags). > > > > This patch creates an implicit default for one use-case, is this > going > > to work with all others? No, of course not, because it has to know > > what flags to set. Thats why explicitly setting those flags is > > important, instead of just fixing one implicit case. I said I agree with you - basically, just that we need to differentiate between the use case: 1. Use via API => No defaults should be applied, caller is responsible for specifying the flags 2. Use via ffmpeg cli => Applying the render target flag would be safe here. We could require this to set via parameter, but there won't ever be a case to specify something different than the render target flag Why? Let's look at the possible flags: D3D11_BIND_DECODER In all decoding cases, this flag is set explicitly, so it overrides any default we would set D3D11_BIND_VIDEO_ENCODER Set explicitly when required, so it overrides any default we would set D3D11_BIND_RENDER_TARGET All other cases require this flag (e.g. video processing) No Flag Dead end, texture would be unusable for any kind of video processing > On that note, the example commandline it fixes just does hwupload and > nothing else - does that even require render target to be flagged? > From what I can tell it uses a simple > ID3D11DeviceContext::CopySubresourceRegion to copy from the staging > texture, which should not require any particular bind flags. Bind > Flags in turn would then depend on what you are actually trying to do > with the texture (shader input, etc), in this example... nothing? We are still in the context of ffmpeg cli - you know that there are no shaders or 3d operations and no etc. But at this point, you can derive to another context or you can hwmap. For all of those things, you need D3D11_BIND_RENDER_TARGET. Summary As mentioned I see two possibilities: 1. Use D3D11_BIND_RENDER_TARGET as a default when used in context of ffmpeg cli, otherwise no default flags 2. Require a device initialization parameter in the command line (but it would always be about setting the render target flag and there's no case where you would NOT want to set it) Let me know what you think. Best regards softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".