Re: [FFmpeg-devel] [PATCH 1/3] fftools/resources: fix preservation of intermediary resman build artifacts

From: "softworkz ." <softworkz-at-hotmail.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Timo Rothenpieler <timo@rothenpieler.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/3] fftools/resources: fix preservation of intermediary resman build artifacts
Date: Sat, 17 May 2025 17:28:19 +0000
Message-ID: <DM8P223MB0365042FB73924C90ACECF41BA92A@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20250516230202.355445-1-timo@rothenpieler.org>

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Timo
> Rothenpieler
> Sent: Samstag, 17. Mai 2025 01:02
> To: ffmpeg-devel@ffmpeg.org
> Cc: Timo Rothenpieler <timo@rothenpieler.org>
> Subject: [FFmpeg-devel] [PATCH 1/3] fftools/resources: fix preservation of
> intermediary resman build artifacts
> 
> Without this, make install triggers a full re-generation of the graph
> stuff, which results in re-linking during install.
> ---
>  ffbuild/common.mak         | 3 +--
>  fftools/resources/Makefile | 5 ++---
>  2 files changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/ffbuild/common.mak b/ffbuild/common.mak
> index 0e1eb1f62b..4a3cc0c748 100644
> --- a/ffbuild/common.mak
> +++ b/ffbuild/common.mak
> @@ -229,10 +229,9 @@ SKIPHEADERS += $(ARCH_HEADERS:%=$(ARCH)/%) $(SKIPHEADERS-
> )
>  SKIPHEADERS := $(SKIPHEADERS:%=$(SUBDIR)%)
>  HOBJS        = $(filter-out $(SKIPHEADERS:.h=.h.o),$(ALLHEADERS:.h=.h.o))
>  PTXOBJS      = $(filter %.ptx.o,$(OBJS))
> -RESOURCEOBJS = $(filter %.css.o %.html.o,$(OBJS))
>  $(HOBJS):     CCFLAGS += $(CFLAGS_HEADERS)
>  checkheaders: $(HOBJS)
> -.SECONDARY:   $(HOBJS:.o=.c) $(PTXOBJS:.o=.c) $(PTXOBJS:.o=.gz)
> $(PTXOBJS:.o=) $(RESOURCEOBJS:.o=.c) $(RESOURCEOBJS:%.css.o=%.css.min)
> $(RESOURCEOBJS:%.css.o=%.css.min.gz) $(RESOURCEOBJS:%.html.o=%.html.gz)
> $(RESOURCEOBJS:.o=)
> +.SECONDARY:   $(HOBJS:.o=.c) $(PTXOBJS:.o=.c) $(PTXOBJS:.o=.gz)
> $(PTXOBJS:.o=)
> 
>  alltools: $(TOOLS)
> 
> diff --git a/fftools/resources/Makefile b/fftools/resources/Makefile
> index 8579a52678..3a307bef12 100644
> --- a/fftools/resources/Makefile
> +++ b/fftools/resources/Makefile
> @@ -4,10 +4,9 @@ clean::
>  vpath %.html $(SRC_PATH)
>  vpath %.css  $(SRC_PATH)
> 
> -# Uncomment to prevent deletion during build
> -#.PRECIOUS: %.css.c %.css.min %.css.gz %.css.min.gz %.html.gz %.html.c
> -
>  OBJS-resman +=                     \
>      fftools/resources/resman.o     \
>      fftools/resources/graph.html.o \
>      fftools/resources/graph.css.o  \
> +
> +.SECONDARY: $(OBJS-resman:.o=.c) $(OBJS-resman:.css.o=.css.min) $(OBJS-
> resman:.css.o=.css.min.gz) $(OBJS-resman:.html.o=.html.gz)
> --
> 2.49.0
> 
> _______________________________________________

Hi Timo,

thanks for the patchset!

Most of it LGTM, but for the main issue, that's not the optimal way yet,
because with that patch, the intermediates do not get deleted when doing
make clean (I've been there already).

I wasn't aware of the relinking issue, have started to investigate futher.

Thanks
sw

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".