From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 99C3E43090 for ; Fri, 20 May 2022 10:40:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 977C668B482; Fri, 20 May 2022 13:40:02 +0300 (EEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11olkn2044.outbound.protection.outlook.com [40.92.19.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3200968B3D8 for ; Fri, 20 May 2022 13:39:56 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QiGQJc5D0oGut+URpDhUl/uhSzdFhS0f9d3DoR4uOAYiFmdk0fAfUq2SEAbmYyNDkUa11Lj5sKVktq+nBbwclCs2zAvYCITak7dw6GiKf53u/71ZTxARwjOHacXNGdy2ZvIH9UiQu1Nuf8VJXjuYXTAOiDnbK5hEkJaXWqA/rkaO1VjHp8oEUDqkZF4HAHZVtiUpwfWmsSQFtRuFen131u1yVQEXJKi1kZgywumG+efE8atHoZ19BOU5XHS9qR+7tmMcI8NrIUus4bFTaTYbMrf+wKYeISvS1w4PHvVff1vDmhiZWV1RybtweHSTywkec/mRbz+ZY4purjVoxV48lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=drlk0OuSBbLGxJMlSMZa8y1+TTS118og/rbhc7AtT7Y=; b=f/P6xWC1GCB+wtfiiW1EdY2fi+LLL5TCL5WX2uZ/63RsaQXxnIi7ZmxbQYsuYh4e6lOjs4nJY+y1YA1uAVuoyORKLlqbp5chhQmwuQFxrLov8JHAGhsVxaEkeRuWbbZUoyfpu4kZCwy6JOeynone+8uMe5OAViGdk8J163/omGF2rZSesjqnWCJU6dGpm+phbgVzPDUfLdooAIi2p37ab21tJr4ZCPw4peW9xAa6Fz2hqDo5iO6k15CuqFfq1tr8juyDnOZb4QyO/IlcIF9paXFKwluP1P0Cpb7XeI9bmeFuf8HhIkao+o00Ft1J7/jO5fUA2r1PC18rG1iVSuGBNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=drlk0OuSBbLGxJMlSMZa8y1+TTS118og/rbhc7AtT7Y=; b=KzflP41WwleluGhg6WVOVTOAmyiH2qgVjTL8Dtt1AY6WDEMR3rZDRsrCtUFuZfLGdrU3hzG2yedcocbCskW4BhbmK4MsiK6ftZ3RZG0cIg2fU3BMTA+FmVEZK5SelSdh/D3Y04LlKOq/5ckYmQKR2dG3biLUrMN2bB7N85kNtVOK2wimpLewYJDSRSCWLbuzfoDgpFJrH6N0XM0RHMm/TKCEyBiYQtzjRDS8r2JM+2/lhvYsSzYZRL10BG+lpfJu3XGcCTU4noTaQqYsqM2GDn2+q82uGeENFcJjIJiJbLw+WqSzFon8P/EzIrzqA+w4F2UhBCErhjGeN57zaYGbBw== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by DM4P223MB0517.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:ae::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Fri, 20 May 2022 10:39:53 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::c536:493f:7cda:53dc]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::c536:493f:7cda:53dc%3]) with mapi id 15.20.5273.017; Fri, 20 May 2022 10:39:53 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] avcodec/libx264: don't define X264_API_IMPORTS when compiling static Thread-Index: AQHYa9MhZAmI4J2BGkWRTzy53N4oQq0njh8AgAACJPA= Date: Fri, 20 May 2022 10:39:53 +0000 Message-ID: References: <23cc0bf5-9cef-5b8d-7e4d-440776cd2e5f@rothenpieler.org> In-Reply-To: <23cc0bf5-9cef-5b8d-7e4d-440776cd2e5f@rothenpieler.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [Bxew36V1x8fBDY56UAm8ootHl+HZwEHa] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 50e5f2f4-77a6-4d03-83d9-08da3a4d1339 x-ms-traffictypediagnostic: DM4P223MB0517:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: L0djL2BwG3fSWaKP/MbVPT3z+KPUsIeptz7v3zl62l+nNiwto+sqjhE0plBMnkVZ+DwCaLEk67VRduq9eOLUQROB+47NFfSjpm960krU+KItEg1MlSsxrRYQi1TVR9kIzetGYpjDtYn08CpomPI56C2yoLiqdddyluDh45HBue+99lRT3izeBW5hj/aQXuZjVFyZNr+M3mdQZ/b8HrQ7pHWmGH6AY2n8CLOL15WFv4xLcHxuF1zZNXau1Y2SM2btJ0+tPl2ZXSQUQSaJUmuQMc0pIX6JgvgGgMjgzPiBuiPa6SZpxos1vwkiLtllCG08otLSYpYovGt4c6bofj8C6q6OV7Cx9rdVtLKu/Z9U5B0XHIMVfgUVU52KAIc7y9R5MLVJl9GHTXc60y8c3qzoP0UkzgKbayY13Gq3UpYYqoP4Zv/jF6FD0LNsp/h350/O/P32KdsFE7WbFuGFOro+ggh3pDpokZKu09blP8tbhR0ApnB9TOhODmmTeaPO18w9+qYfqRK1ShDjUL/FNBoRLg/vZmoUAB1MnWwOiq3o7pa9pw52IdZF7DvozrzfMWJrtYRMGctv2LOorRG1+xIzHy9Hif+Qs4xKljLW5/qB5axFUeGsPfpmWARuPpd9+QSx x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?TWI1U2h2dXdhRFNuLytCQWdoNlVVOGxlNFlHbzVPdEswSUpkZkg0RHczRzB5?= =?utf-8?B?ODBINUF6cWcrVnlMa0FCWHl1TmVWcU53QjdXTHJ2cFN5VWtPNFhxZmp5b1Q1?= =?utf-8?B?UkhOeWhkUmpnZ2ZNMEdQNnVQN1dSM3Z6SERHNS93dWhPeGJiK1AyNmVqVG5U?= =?utf-8?B?R1hhVVpPMVByN2dkeDErZitiTzhDcHhRTmhhdlJFQzE4bElYRVR5SjY2SUJT?= =?utf-8?B?aEx0T3FKSVJMbklkdG16d2xmMmlKR2lKd21aUmd2MEtTMzlRSlVBZTFDbTUw?= =?utf-8?B?eVplMnZzcnRnQkltUGxNZnhrdzl6azlTbktKNW5YMU9zamlMMDFaWm9SSHhy?= =?utf-8?B?UEE4dGFxU2JBanBZTzR4S256dFVmV0V0RUJaaDhzWGFSd0szdG1OaGxKbHdP?= =?utf-8?B?Mk9NRGxXTTJoYmpNMnF2aitIcE9XUDJqeXVjcTRWbFFibUdacFVCankrWGE5?= =?utf-8?B?ck1lUitXYnlTR2JMekdUcTdiZHRNLy9vbnBUbEF2WnVTMnNoK21EUFRqeW5U?= =?utf-8?B?MWFOSXNRaDFDeW96WmVGNHVMSTRzR05nWGExMXl4QXZpanRUL0VNYVFYVm9O?= =?utf-8?B?RE80bUptTE1qcmhHeDZqQkdyeWxuMjdEZ3ZCNHRtVkxCUXJ1SVVVN0hDcGNs?= =?utf-8?B?aEVCZXJRZW9TZGplMlVRWE9QWkRDSkZDNFA0aFQ2dGVhamNsa0huSXJLY3pr?= =?utf-8?B?UmFRZlRJQ0w0TE96ZDloSmp6R3BobjNYUURRaE5LcnVkQzdOL2FFQXc0dzNk?= =?utf-8?B?Tk85RWxQRzhuTVNxUWJNUHNwY0ZBdXM5Q2dkTnh2RnJsOElMNSt0TkdFQ0Fq?= =?utf-8?B?cmd1Z1k0NGY2NDE2Wk9WYmNaOFhLS0xScVVHemY2NjdKMm05cEFzb0U1WUpE?= =?utf-8?B?YnNxNUtvTjFERndYTGZlcDRKRTZBN280Y0djaDNBWExkVnFTb293NHd4RWJD?= =?utf-8?B?Z0hCbDg5Vkhsc2kxTFhnUEUybktCaG15MXlNU2lwUVZmUEdHU2ZCWlVwNWU3?= =?utf-8?B?ZTJTQmdKNUU0bU51eFU5L2RMenZwQ0tlbithYzVPYWMzazRxZEJqQndMdEp5?= =?utf-8?B?SmY3QVBUSTE3RmZrZ3c5Q2FGZ1BkRmNwMWM4OWl0dnpWaU9LUlVCdWFQUCtz?= =?utf-8?B?KzJ4bjlZeHFDc0E5UEhTRlN4b2hCT0FoTVpYREhpZW5uSEF5UmNROFpFMTlV?= =?utf-8?B?ZEtnRm5hU25VaWl5YmZmZGUxTXBCblRPcGYzYXVVUXg3dXJoUnZtekxMZ3B6?= =?utf-8?B?VW5vSnFGZGpKNkRWdEhJL290R2trRzgvZmxzdExITC9aTnc5YUtuQ015eE9K?= =?utf-8?B?Vzl1SDRBZFF6ei9uTmZZT1phWjdRMWpmbXE1RXpOZUgyZ1ZzM2xYQXI4MGpx?= =?utf-8?B?RmtNaUg1OFozS2hnWWFDaGlhamlzUHVJRlRPK1pnRkQrWmlSZy9MWThDNS9U?= =?utf-8?B?djNvSVJvMWRBYXZCTjh2RGgwL096Qk5tN3ZZZjloMWhVb1FJRTZGdkoyRXVQ?= =?utf-8?B?UkI1S0tpYmJIcmZLMHUzTTFBb1VNY1BKcGsybklGQTl6ajVFSGRHWTNwbU5i?= =?utf-8?B?NEx2azVIdklZMlJpZ0loQVdaTlRzNThtYjdDencrQkdybmFqOEZqZjFVY3dQ?= =?utf-8?B?OEF2SXBkNUZQdmxkc1dBNWxmNTFSUWpKQlN4OUhiaEozbWZTbEdwUFpUVVQz?= =?utf-8?B?dDVWZXRsWVdsSUV4NGNFMUdQRFFsV0plUFVDVU9LRk04Z3g4bkExWVBrVHFZ?= =?utf-8?B?L0hRMndma1NsZ1l3aWxnb1N3ZU9Ueml2aVRqM09YbGhlN3EzaCtLK0hyZTJJ?= =?utf-8?B?OElGV0FDMG13VFBPTzJSRU5DdXBoS29Yd0w3TUxyd3BwcEpIUEFJeHVaSE1p?= =?utf-8?B?SS95WUlGRkFNSU4wY1NQUEZMZlpBZmpHS2Y2cDFGaXJZMjhPM0o3d1hTakdN?= =?utf-8?Q?tOCIoetGMng=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 50e5f2f4-77a6-4d03-83d9-08da3a4d1339 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2022 10:39:53.5150 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4P223MB0517 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libx264: don't define X264_API_IMPORTS when compiling static X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Timo > Rothenpieler > Sent: Friday, May 20, 2022 12:18 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libx264: don't define > X264_API_IMPORTS when compiling static > > On 20/05/2022 00:52, softworkz wrote: > > From: softworkz > > > > The definition of X264_API_IMPORTS is required for shared linking > > (when MSVC is used) but it must not be defined in case of static > > builds as is stated in x264.h: > > This doesn't seem right. It's about shared or static linking of > libx264 > itself, not ffmpeg. How about some custom macro like DISABLE_X264_API_IMPORTS that one can set when desired? In that case there wouldn't be any logical irritation. > The correct flag should come via pkg-config at configure time. There has been a patch which does that, but it didn't go anywhere: https://ffmpeg.org/pipermail/ffmpeg-devel/2021-October/287426.html That's why I wanted something straight and simple which doesn't hurt anybody. Thanks, softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".