From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 4C32B4E13E for <ffmpegdev@gitmailbox.com>; Sat, 8 Mar 2025 19:49:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BE73E68DD52; Sat, 8 Mar 2025 21:49:34 +0200 (EET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12olkn2067.outbound.protection.outlook.com [40.92.23.67]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3472168DD52 for <ffmpeg-devel@ffmpeg.org>; Sat, 8 Mar 2025 21:49:28 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=c21z1CEGACtEdXRXjaX9PwksYQ40PGr6qGidoHYiVErTGeMOWO9RabRjXC2D2FNvpchLqDH+81xT0PzAFkuzo7tVoapp4W8eLu6FYBzvlufVlpdPpgyDBZHvIBTgmnFcY6pTiNqmqo8AFNLml/jSf7TglvLONVbMmg2JfS8UAp7SsivWufTt8lG12Nk/pX3tgTFO+USwWbII1nR9GOrU5l/kWDzigupZDFZsx503eiCUMtymjSG7MuIqDd5fk7UCgey84yvDygD4IXK2rm6T0eIMhYzbsW0zpOV+iP3BN3Ba6rjOXXC+1DT0tmfInu/QAsE+MTQkAcXrZUIqz0kLVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a1u+ueZWzyeG+hrUw66HvqwIHXH4rnh7zenitDVWLyY=; b=oLSNNdtWMFtRvWmKYrsGa/vhG1rUnDkFDIxgTVTAdxevKI11VSQMDsX8WjM/VPyZ4bBh9XesPz0VIK3kea4cu7qogXNTBNI7hQaTimLdFyW9NvevhmVlTc2bEpLmPchuXhOnbrhDc7hY3ddHbzAMBg8T6hpmePxyP/5gdY5cnMffLIzdxhPxQrfh/KRSMl4bIlh4tzfdGcVSiZrNaX5cBm0vhQ+vNfejo7J7FUwcSmnp26kis+e8RcxKLcD3w3nNTOz3Ymf1avtI1kFS7MHVhMbHo9xOLUxsnWvu7SV0Ad1RP5UqsWwGktFH8ve7vG/D6YZ5rscYAX1AJen+AKjU0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a1u+ueZWzyeG+hrUw66HvqwIHXH4rnh7zenitDVWLyY=; b=Zb/TwNUVLNusvNraPyhSVFhce4m44gxV56h9J+dkjucSovzSj4GBmH8mVB/VnVhdqsV4aCZhC/h5w+UmTySiXswd3QuwAxQ2tyr7KbkugCYHJ20LLy8HcQO920rnfuKY+eLAc2Ebf4/T7dLAnpRFmA2tVi6Ep662naUSFU+RpTrA8RIP9z47PfBii/pB8m+n2IQGi5KcaW1J7QB1p3lCEvyCQl1pBqbIpl6Fju0ifFMpLRypK7pOajhAt2+JEgYpnhZsHrQ9JdkOG2dVv2RV4roOuKaw2EjXnPls+DGrGL3y0G9P1qZYGCGUa7qIzoiiODuJUoVJwHC2SWGy/jQwOQ== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by BL3P223MB0097.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:34d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.24; Sat, 8 Mar 2025 19:49:25 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%7]) with mapi id 15.20.8511.025; Sat, 8 Mar 2025 19:49:25 +0000 From: Soft Works <softworkz-at-hotmail.com@ffmpeg.org> To: Stefano Sabatini <stefasab@gmail.com>, FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Thread-Topic: [FFmpeg-devel] [PATCH v5 1/8] fftools/textformat: Extract and generalize textformat api from ffprobe.c Thread-Index: AQHbkFNUoeKwZReo+EmVecvt/2LUzLNpmlKAgAAIlLA= Date: Sat, 8 Mar 2025 19:49:24 +0000 Message-ID: <DM8P223MB036504096BDC3FAF08D843C8BAD42@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> References: <pull.52.v4.ffstaging.FFmpeg.1740869691.ffmpegagent@gmail.com> <pull.52.v5.ffstaging.FFmpeg.1741456535.ffmpegagent@gmail.com> <b26a45ea0e84c39a75de607789833be79bba2f5a.1741456535.git.ffmpegagent@gmail.com> <Z8yVsYWavdUm230j@mariano> In-Reply-To: <Z8yVsYWavdUm230j@mariano> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|BL3P223MB0097:EE_ x-ms-office365-filtering-correlation-id: c58911a4-38d3-4ea2-6fab-08dd5e7a544a x-microsoft-antispam: BCL:0; ARA:14566002|15080799006|8060799006|8062599003|461199028|7092599003|19110799003|3412199025|102099032|440099028; x-microsoft-antispam-message-info: =?iso-8859-1?Q?nMk9umO1W+l++s4YC3eXk/izDAcjUu32r6NhA8QWdVRb3gU/+YNXC3z5Ag?= =?iso-8859-1?Q?8X0PR+WIbyW286XzPg1xk7mnC3yWKbuoDGWzqbmEDxmuZKd+iyXbzTI69c?= =?iso-8859-1?Q?Gy0lF0FvfkxyNz6IteHyRO3+U8jWSfpUihf+rJUHdfBx3+4yx+13jC9Jaz?= =?iso-8859-1?Q?kIVhXBSw1wDsr0D3pv/OK0eUiNKL/zMbo1qrBzXIbbycxvPVxTChyX5UHq?= =?iso-8859-1?Q?fKffW/a4O1e/1coQW1FuFlxxR/NyvRauEoaqp1qtsBLQBu8PDntk5dxjsI?= =?iso-8859-1?Q?igSHlK6aPCdcOCXgVraxpknNeyKfGc6AFn2C9tNbX62P6AyedmOZXRHMaI?= =?iso-8859-1?Q?EEetCF0aQe9RM6eVN1tLLPi0RD+SNLUO3J+xwVTAsmIMYA3Eqw/lS4ZF7j?= =?iso-8859-1?Q?wznalVoCTssRWOmWodF+jFqe3m6t4tbXaKpLJQ6ojv/22s2CHjVgTRzdS3?= =?iso-8859-1?Q?+tKOYqsYG9q4dxrgh1ps2004aFrccHPcO27o1jFX4p6A+l22rQH7p3WQcL?= =?iso-8859-1?Q?EBSJ3n50G+MircqfqUwfDugYv3KdqUO5oOBaM6Ls2UvA8wisZ109RXfdT/?= =?iso-8859-1?Q?Xmn3hfbB+UzisO9SaA4Q6y1eGa4y3IQ9ZI2Bx1MMxXqIuSRPakmylz1Rm5?= =?iso-8859-1?Q?hVOG+NAFeDY4x6kdfszLatgIbHR2ucrxpjSW01QVj3PCRdp1Rg5JSVy3KQ?= =?iso-8859-1?Q?DRT/jVaeb8zVtUjFFmoHza+lwdDYW1K6kI4tHjwJ4QmMgGVMp8zw41vfJb?= =?iso-8859-1?Q?I6llRMHb9l0Z0cej7/V+BIIZtIqpmu+gEnFVzaY9q/duftXPF8ghZpe5oa?= =?iso-8859-1?Q?2VN+zzvDF5UuCzKSuxpVBecPWGP/qMVrNhL7Yk6yZG+/xDsqbyw9HJcTUF?= =?iso-8859-1?Q?6GmGilTS5S5e4glAlesOGo/8HhUbjvJpPt590W/Pkw5z26CA+fr7uLM/it?= =?iso-8859-1?Q?KvlkAukjCFG3OMqJNSdD0BW2N5rl1td5T98jqahe0SBjXlNYYT3NZv73Np?= =?iso-8859-1?Q?fCirAGYSTaOxHSgFIeV9UG32Gcku/rU07Jc7BHqDNp9ullo4sskXEphhjV?= =?iso-8859-1?Q?hg/+HmK6Vx2X76ugJIXYTPfvkytNutxq/HywkIzWtsmHOSC+2cAZ/u/wxy?= =?iso-8859-1?Q?FCizPCOQ=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?BZpvdGXWF59B1luiRh4zmRwE25K3fk5T9bKAuHo8tCqwdUiUEeA/EYHXsH?= =?iso-8859-1?Q?HU64gHOzUnktLcsvagLtr2fKfn3AfUofkBPM8Qg+HBlIsOid8Vvz6b5krP?= =?iso-8859-1?Q?Dy0uaAtABxfDRmN11SSWIAC3bz5TsrlKzge/z4p3JyJ3dQtKFo5pBqvdIc?= =?iso-8859-1?Q?Ea44M2YXSQNrhlvfSc0u9eB5IS81iX083QxpMhemE+FEwTscwP6aJoPVaO?= =?iso-8859-1?Q?OZQ4XyRYWEP0auAcculhUo6BzZDaG0amxO2apPSDhuKeATX+QNhf2bH3QK?= =?iso-8859-1?Q?dqmVOaWWS6JDU2fMqPzxMJTiDKWDm/ubK1g/e8/+QJ7DCeJMzOCcsCn/P3?= =?iso-8859-1?Q?UWVKM+rleUPWYPFrSxsJjyEXDTHRnhlHY3wlYij37zZkechMYIG2oUmvmq?= =?iso-8859-1?Q?kLi8mHu/Fm5otiCeZKPRBzsN8KraqQrxAHQ54BXSTVEdemHQkZbRoZot6I?= =?iso-8859-1?Q?QBsBOXosBN2Io8EymQPSHNgvANZlnkFfCBP3WjYoY4UY9CQvOiq5tq5go0?= =?iso-8859-1?Q?V1yrhUe7avgMN1+CxoyaQflL4L7NvO+fLMiY0O4EjVZJVwRlBIbqSgDGXm?= =?iso-8859-1?Q?ke9W515vjAzqQNFo/CmAEoAC7NCWsLSBB+61F+beOIaz63y0DrHU/3y04N?= =?iso-8859-1?Q?luOusStUqxEVYaFqbxuw+vXe0Yg2VwWWeTv56fgLOm3MvPfh1+dZ7PRAuQ?= =?iso-8859-1?Q?mpAuBYzB7vv0NxU65w0fpH/vDeLvKTpMoX8GF8zgmgRP0Pzbl1MwdTqAx8?= =?iso-8859-1?Q?MvsTy5rhJYd8bNFCjM5FSzabbJxaQNBZHlOGGFqyIPD2On7EyuLcebVgnU?= =?iso-8859-1?Q?rnqHGT/EwVWDb6vBueDZ+ldlCzC107VXMbeU09J73LaWwepoP2+3uXh0P8?= =?iso-8859-1?Q?u2BZSjgPk4G1u7KDa8lHFmx5z+4t7/OY5XWRJwuN7gkSoAne7L+6A3zoOC?= =?iso-8859-1?Q?Rj5rXmzWzenp66Lf0Gtu1Bt7dHN6sIIJP9vAczrPbufRXyRq2ZCDPuPCSI?= =?iso-8859-1?Q?eqzRIegjBdyJDIZNj3rSltkbIOUvDQ9X6o5iPflLRAh4FDPjegi1jfBCkT?= =?iso-8859-1?Q?F/gGYJAebU55vNuiRi86oyc1s5p6b55RdJ/nWV1hFmAiBDI0PEetAX/gdW?= =?iso-8859-1?Q?1p76x0Ulc09KeDpCp4S8d94p/5Pznz0QdSXuoMFBDJWhO6JJOJIWGGg3Zj?= =?iso-8859-1?Q?i7DQJgORjGYUt15U+riA7Z4ui0HP0mo9t9jiuzkpLzOmJs0jwVOi0swjWZ?= =?iso-8859-1?Q?pHRTzR0mmUhOZ9SFGHSt6hEcnnfHB4oTQVM9GofqE=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-92255.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: c58911a4-38d3-4ea2-6fab-08dd5e7a544a X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2025 19:49:24.9384 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3P223MB0097 Subject: Re: [FFmpeg-devel] [PATCH v5 1/8] fftools/textformat: Extract and generalize textformat api from ffprobe.c X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/DM8P223MB036504096BDC3FAF08D843C8BAD42@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> > -----Original Message----- > From: Stefano Sabatini <stefasab@gmail.com> > Sent: Samstag, 8. M=E4rz 2025 20:09 > To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> > Cc: softworkz <softworkz@hotmail.com> > Subject: Re: [FFmpeg-devel] [PATCH v5 1/8] fftools/textformat: Extract > and generalize textformat api from ffprobe.c > = > On date Saturday 2025-03-08 17:55:28 +0000, softworkz wrote: > > From: softworkz <softworkz@hotmail.com> > > > > Signed-off-by: softworkz <softworkz@hotmail.com> > > --- > > fftools/textformat/avtextformat.c | 672 > +++++++++++++++++++++++++++++ > > fftools/textformat/avtextformat.h | 171 ++++++++ > > fftools/textformat/avtextwriters.h | 68 +++ > > fftools/textformat/tf_compact.c | 282 ++++++++++++ > > fftools/textformat/tf_default.c | 145 +++++++ > > fftools/textformat/tf_flat.c | 174 ++++++++ > > fftools/textformat/tf_ini.c | 160 +++++++ > > fftools/textformat/tf_json.c | 215 +++++++++ > > fftools/textformat/tf_xml.c | 221 ++++++++++ > > fftools/textformat/tw_avio.c | 129 ++++++ > > fftools/textformat/tw_buffer.c | 92 ++++ > > fftools/textformat/tw_stdout.c | 82 ++++ > > 12 files changed, 2411 insertions(+) > > create mode 100644 fftools/textformat/avtextformat.c > > create mode 100644 fftools/textformat/avtextformat.h > > create mode 100644 fftools/textformat/avtextwriters.h > > create mode 100644 fftools/textformat/tf_compact.c > > create mode 100644 fftools/textformat/tf_default.c > > create mode 100644 fftools/textformat/tf_flat.c > > create mode 100644 fftools/textformat/tf_ini.c > > create mode 100644 fftools/textformat/tf_json.c > > create mode 100644 fftools/textformat/tf_xml.c > > create mode 100644 fftools/textformat/tw_avio.c > > create mode 100644 fftools/textformat/tw_buffer.c > > create mode 100644 fftools/textformat/tw_stdout.c > = > Looks good to me. > = > As I said, there are a few API tweaks we might want to apply to > improve overall consistency and usability, = Yea, probably you mean things like the optional field logic where you need = to enable it initially for all sections recursively to even see any output. I left it as is for the moment to keep it more focused, even though it's al= ways tempting to get everything right at once, sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".