Re: [FFmpeg-devel] [PATCH v5 1/8] fftools/textformat: Extract and generalize textformat api from ffprobe.c

[Soft Works <softworkz-at-hotmail.com@ffmpeg.org>]

> -----Original Message-----
> From: Stefano Sabatini <stefasab@gmail.com>
> Sent: Samstag, 8. März 2025 20:09
> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> Cc: softworkz <softworkz@hotmail.com>
> Subject: Re: [FFmpeg-devel] [PATCH v5 1/8] fftools/textformat: Extract
> and generalize textformat api from ffprobe.c
> 
> On date Saturday 2025-03-08 17:55:28 +0000, softworkz wrote:
> > From: softworkz <softworkz@hotmail.com>
> >
> > Signed-off-by: softworkz <softworkz@hotmail.com>
> > ---
> >  fftools/textformat/avtextformat.c  | 672
> +++++++++++++++++++++++++++++
> >  fftools/textformat/avtextformat.h  | 171 ++++++++
> >  fftools/textformat/avtextwriters.h |  68 +++
> >  fftools/textformat/tf_compact.c    | 282 ++++++++++++
> >  fftools/textformat/tf_default.c    | 145 +++++++
> >  fftools/textformat/tf_flat.c       | 174 ++++++++
> >  fftools/textformat/tf_ini.c        | 160 +++++++
> >  fftools/textformat/tf_json.c       | 215 +++++++++
> >  fftools/textformat/tf_xml.c        | 221 ++++++++++
> >  fftools/textformat/tw_avio.c       | 129 ++++++
> >  fftools/textformat/tw_buffer.c     |  92 ++++
> >  fftools/textformat/tw_stdout.c     |  82 ++++
> >  12 files changed, 2411 insertions(+)
> >  create mode 100644 fftools/textformat/avtextformat.c
> >  create mode 100644 fftools/textformat/avtextformat.h
> >  create mode 100644 fftools/textformat/avtextwriters.h
> >  create mode 100644 fftools/textformat/tf_compact.c
> >  create mode 100644 fftools/textformat/tf_default.c
> >  create mode 100644 fftools/textformat/tf_flat.c
> >  create mode 100644 fftools/textformat/tf_ini.c
> >  create mode 100644 fftools/textformat/tf_json.c
> >  create mode 100644 fftools/textformat/tf_xml.c
> >  create mode 100644 fftools/textformat/tw_avio.c
> >  create mode 100644 fftools/textformat/tw_buffer.c
> >  create mode 100644 fftools/textformat/tw_stdout.c
> 
> Looks good to me.
> 
> As I said, there are a few API tweaks we might want to apply to
> improve overall consistency and usability, 

Yea, probably you mean things like the optional field logic where you need to enable it initially for all sections recursively to even see any output.
I left it as is for the moment to keep it more focused, even though it's always tempting to get everything right at once,

sw




_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".