From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 680D942EEA for ; Fri, 13 May 2022 09:35:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 095E468B46E; Fri, 13 May 2022 12:35:04 +0300 (EEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10olkn2072.outbound.protection.outlook.com [40.92.42.72]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0B9BB68B347 for ; Fri, 13 May 2022 12:34:57 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lHlJsum2wBhQR60FYTsPiiGTnBbrSR7SveImP+p4tWcOKXdBhlXm1Q7kBGMFj7e3meOC+K9ruKLBumiW9PrOY/vwid5+pgpUwAQXWVoUU6XhAQBpofHofE31A6Uk4cJZi+AIPVt4o51byN9YDaC0XmlhGjkV94CZMCUnv13P2uYPlzWFkLXJDHBgYYH/DyvrUwm/WtAiHawx9LxXX7ECD37sdYIeYt4XiPWhfgbgnmbt2e0kApWg1OBg0y68vEuePmIFAERu8r7diTZ00u7+EqnjLb7tPf3fUZMPAcLDsGdjEKLuo7+ccSPfldhEOjEhlON7U7DuL9N56EUyxs926Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=toZ8QFsTm/9eimhEra1t04CWvnv49jeZaF/wmrjCHEs=; b=Wx4cnpBjQDfKMCAeKMTIvJR3fjyEoRoBTWgRjVal+d7fJE9RnPHaqWh5vdEcgdRabZa8bZnZ1/BQ2TaNJsZ5KeV93U81yTWV8om4BEYDpf457/AKpnxuig/KP1XZiXc2Ko08BFUVosJdDe/e1W0NU/OlMwlDVp0I5ZRvt6y+UUNWH5wIJWMor3ZFTzpk/DDYdGgc3rEwTnyRfPDx4j2TGfgiOhpSXqA0OdaXtcahQn5F+kDUkNZXSpGWQLRStCBajZ8a7p6KcXuSUqrvYSk65AcIV2B2vK8cns2Tekd/VK6EGaKYHm3oZaAPqoGm0MYdiUCPKfyg93Tbz6dmXPSg+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=toZ8QFsTm/9eimhEra1t04CWvnv49jeZaF/wmrjCHEs=; b=Nh7g2I7zGl0uRSn10uhwpQ6baocz7lPAqux8Vv3sXbREt6hZTM02OYDOYXmQmHoHxkO6HoiURpE/uREBuyffA5Jqun/8MIwUaBaNvZkePCH0vdCwZWP9CfwZZXb5O8DYKz4RyhriIhrNIw5qGJTmEJGr/pMb3fDO/BnKzwmBtoqefG7FHQ7Rhi1qRLHLIRaZcB4CF5XYjodTc9ifmsFuXhKCoVSmhFyWffXc4o78GaJE6dsNi8fAFB1LsHs7zi3LCoXsGZSGVkn/EBBTmuwhOIDJO3HH04Ddy2Kv/lgLVazQw2Ybl2glxZlLJLpaXk4xSD61OVWvy9anSoVkA2b0Ug== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by MN0P223MB0485.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:3c7::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.14; Fri, 13 May 2022 09:34:52 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::7472:6f83:eeb:45e3]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::7472:6f83:eeb:45e3%9]) with mapi id 15.20.5250.016; Fri, 13 May 2022 09:34:52 +0000 From: Soft Works To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH 07/10] avfilter/vf_nlmeans: Move ff_nlmeans_init into a header Thread-Index: AQHYXriq6NmNTzVVck+rOPFLZ4OqTq0cY0RQgAAl1oCAAANQYIAADP4AgAAAcYCAAAFV0A== Date: Fri, 13 May 2022 09:34:52 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-tmn: [h6s1NQMRYDu2afxB4vve5i2r03uAdkPR] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 432afe79-4e07-40c2-3436-08da34c3d52b x-ms-traffictypediagnostic: MN0P223MB0485:EE_ x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BM2SluRilpn+hh45t4zk9XUQCQ+lKekTA8FMg3BQH0lvYscKEGPMUhQmRZzS7xzS61ERY07VhMwJRHRWphOGYkfLYG1wHXy4sNX1erQZ2zsP0RqmWmiO754T5MAuLQfcDyrC0VXyn2sF581HVUj/wok3J11oBfEjyWfUaodMht5lIyM/HDxBCYIQL5RqlruTT6GqkmZh6SAROcNCsHBdlVPdPNg0b3exVn97NDIE+KcdS1g3tl0kwQzLqd4WbwU/RnjWyV0xabsWRgDM/NO1UHYds7W6y3dMrW++zCdNEGCaDsXz7mFBdP7nPnjIwOqgjtjAwZNDsQmfLMkIcyoJxyTWb4lwEJMbAtdFed7yYHb2wELsvGqF2+oh+pYqNd2G6AtvJrPrgbTHWaoiT46K0kYBBsEFWWwJtNnaxW4cEUH857Q71jTgIEnL1c2QV0BzB0e4Yng5U9L4SRvHdVRKQhzM0CCl0nVQrYxRezwcRTcymmmJZfNXrFen68R41YsTNgOuf38pIZxRb/1aFphHGhc35b6xSw5jVS5tCw6yB0eQHWEYNEZsxz0573ZCr/+X1SM3i0tVOo32Jw8yYJSPAyzMIS3frvtkPbeu3HBd+SmiNbr7N8IL5uu/QyRDTFUM x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?aDJiQitBZmUyOGlQSVNBV3l2Vk5YaGIrVlc0dWpaQkZwaC8vTVBlWmlzUVk3?= =?utf-8?B?bDBWazFocndhNk1FeTVmTHNzaTlraU03Q0M4M2lIZ3JOK05FbzIyVSs5a1FY?= =?utf-8?B?bHRSWVlQVnl5cy9kc1hUSi9POHZDdXpzZ0c2blFFVnVLaTF1K3FMdzlhMjAw?= =?utf-8?B?NzNyMmRyOERPZFJGaGZvMXZRdExlMWppRWJjcm1OY3ZCTWdYNko3M3ZJcFlQ?= =?utf-8?B?RXMzU2RXd09KbEtlYnZxQklsanY1K1lLSnRJZVZ1UXZ5bXFXVmYzczJqaHhY?= =?utf-8?B?V213MGZ5TUhTWmhna1RRRURZRnlVT2JCYzUzaWMvNjFsRExhcTNHVEhRc3Fp?= =?utf-8?B?a3RCNE1IT1dRWTRiMVJuc0duTGxaQWxWellBVXY5ZGxabDd1VEF3dXV6dVNs?= =?utf-8?B?UmhkeXp3MjFJVVB1WWVhR1FmeHB1NW5Tb3VNTlJjOTlHTlhYM0lyTzRUSFJa?= =?utf-8?B?QWpsQVBhM0Z1QytYQnI1b0lGZW44Z3hneVBSMUM2aVVFQlN4dndFZXdmQU1u?= =?utf-8?B?aUlyL1N4L2pxWnJhYTBEdTh2OTNDWXV0TnpLTFJ0NGhYc3ZKUkJtV2JQOHhG?= =?utf-8?B?bjRjREVsdVk2V215OG5nYk1oNEFBVzdkWjd6bnIwUFJhYkx6YlZTUFRFdjJB?= =?utf-8?B?K05hZC9mK216Vkp0QWQ3ZFVXdkpsNEJCUTF2T2V6cXdxOWQ0L0VpbE1CS2Rz?= =?utf-8?B?dmo2T3gwckhVNFQrM3g5RE93KzVqbU9WbjluYk5WMno0bHRmWmRkSjZRL1lv?= =?utf-8?B?RFBSR2VVc1NXZUVuMjdsTVV0ZXB3N016YWJ2Tm5rdC9sbit2Ni9aU2Y0WHlV?= =?utf-8?B?VUg1dlcyMVNIV0hoeVZCYXR6anN3Q1I2Y2hzRHk0b0lXZVYvM3JCOXZPc21W?= =?utf-8?B?ZS8rOGo4V3pBK1RFQWxuVEh0QXYvSk52QXZYZ203V1BwMU43Y0Erc3VVcExS?= =?utf-8?B?aUx4WE9GQXFETXBxVmIyc3g2MTBvVW03Y2l3OS95MlFBL3ZQZXRWdDRUbXdS?= =?utf-8?B?WEtibkZ2YVBvK1lTL2YzWDJjbWIvQ0ZjREJKbXBYVlBVVjlWbkMxeHZJNzlj?= =?utf-8?B?K21lbSt6d0Q5bCs2d2VGaXRRNVoxa2M1aEsyU3U4ZUhxWHl5TW1MbzNuUXNi?= =?utf-8?B?ekpndE9rb05OZVV0cklwWm9sTlRlUHBhb043b0FwS1A5ODNzOXVQOFFQMVBP?= =?utf-8?B?ZXFOY1RUZkx0ZVpsOTRGd1RHTXp5NTh0a0E2YmZxWVVoUC95eEY0b1R6WCtN?= =?utf-8?B?a2VPc3FCSnJGaVl3WWxBM25ueGNFempUd3YzL0Y0TWJqSTZ2V1psd2tXbmNQ?= =?utf-8?B?bG8vQ0tNSnJMeGRNUnU1YnkxeEZydE02SkRmUXg2cXNETUVnNTYvWkpvT0Nt?= =?utf-8?B?RTlHM040TVBvS1JHWDNuUjB2QWMyOVJ0QVVUNnMwVVBoR1Z1M05UNHpOSE9s?= =?utf-8?B?VFNRSjh3akhyemlsWUNac29DV3c3d2cxdENtRXNIUlNzcVZxd2tyaGRwZkpE?= =?utf-8?B?U0VGcy9LK2VSUnZYT1VWZGx0Z0tpcG1FOFFPYnlaWUJIcDNRczJtalY3OUo0?= =?utf-8?B?eUNibk1NOU9pNEYzc0JaZVJEVzBJaWcwTVlwVFZVNXdKU2VHZ2tlcS9ZZHJO?= =?utf-8?B?YXhDeklaeTI0TE9KeGxFVFFPeUxwMnFRcFB6eW9ZRGl3eTN0SU5BQ0VlYzZJ?= =?utf-8?B?WWhNeVlELzFqY2xYaUhIVVZqRXRVdUV3RFFEQWU2eFNNVHJCNUk0RzIydXhq?= =?utf-8?B?V2ZjbmZJOElkUmRuTGQxekFwMzJIWjhRVzF6UjdESDFUR0tHYjUxaGVzU0FU?= =?utf-8?B?Mm1yaVZkRk1zUERCdzJOb1VrQ1VJTjZzSkpsTnFVYXM4NGNFL1dxUmNOZzNu?= =?utf-8?B?dE1NZmdUTHV0ZkVDTUxvVzJXbEd5TC9NbzRSSWRLMlBPS0RsYktCYjJNZUVV?= =?utf-8?Q?ZL6yezSKYNI=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-1ff67.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 432afe79-4e07-40c2-3436-08da34c3d52b X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2022 09:34:52.5836 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0P223MB0485 Subject: Re: [FFmpeg-devel] [PATCH 07/10] avfilter/vf_nlmeans: Move ff_nlmeans_init into a header X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Hendrik Leppkes > Sent: Friday, May 13, 2022 11:27 AM > To: FFmpeg development discussions and patches devel@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 07/10] avfilter/vf_nlmeans: Move > ff_nlmeans_init into a header > > On Fri, May 13, 2022 at 11:26 AM Andreas Rheinhardt > wrote: > > > > Soft Works: > > > > > > > > >> -----Original Message----- > > >> From: Andreas Rheinhardt > > >> Sent: Friday, May 13, 2022 10:27 AM > > >> To: Soft Works ; FFmpeg development > discussions > > >> and patches > > >> Subject: Re: [FFmpeg-devel] [PATCH 07/10] avfilter/vf_nlmeans: > Move > > >> ff_nlmeans_init into a header > > >> > > >> Soft Works: > > >>> > > >>> > > >>>> -----Original Message----- > > >>>> From: ffmpeg-devel On Behalf > Of > > >>>> Andreas Rheinhardt > > >>>> Sent: Tuesday, May 3, 2022 8:38 AM > > >>>> To: ffmpeg-devel@ffmpeg.org > > >>>> Cc: Andreas Rheinhardt > > >>>> Subject: [FFmpeg-devel] [PATCH 07/10] avfilter/vf_nlmeans: Move > > >>>> ff_nlmeans_init into a header > > >>>> > > >>>> This removes a dependency of checkasm on lavfi/vf_nlmeans.o > > >>>> and also allows to inline ff_nlmeans_init() irrespectively of > > >>>> interposing. > > >>>> > > >>>> Signed-off-by: Andreas Rheinhardt > > > >>>> --- > > >>> > > >>> [..] > > >>> > > >>>> + > > >>>> +static av_unused void ff_nlmeans_init(NLMeansDSPContext *dsp) > > >>>> +{ > > >>>> + dsp->compute_safe_ssd_integral_image = > > >>>> compute_safe_ssd_integral_image_c; > > >>>> + dsp->compute_weights_line = compute_weights_line_c; > > >>>> + > > >>>> + if (ARCH_AARCH64) > > >>>> + ff_nlmeans_init_aarch64(dsp); > > >>> > > >>> Hi Andreas, > > >>> > > >>> the above breaks compilation for me: > > >>> > > >>> 1>libavfilterd.lib(libavfilter_vf_nlmeans.obj) : error LNK2019: > > >> unresolved external symbol ff_nlmeans_init_aarch64 referenced in > > >> function ff_nlmeans_init > > >>> > > >>> The reason is that I'm (obviously) not compiling stuff from the > > >>> libavfilter\aarch64 subfolder. > > >>> > > >>> It might need an #ifdef ? > > >>> > > >>> I haven't taken a deeper look at it, though. > > >>> > > >>> Thanks, > > >>> softworkz > > >>> > > >>> > > >> > > >> That surprises me: The earlier code did exactly the same; in > fact, > > >> using > > >> if (ARCH_*) is our typical check for arches in dsp-init code. > > > > > > I looked at this a bit further. It seems that the VS project > > > generation tool that I'm using is creating dummy definitions > > > for such cases. In the previous workspace it had generated > > > > > > void ff_nlmeans_init_aarch64(NLMeansDSPContext *dsp) {return;} > > > > > > in a separate code file for being able to work with the ffmpeg > > > code in VS without modifying any of the code. > > > > > > Now that you have moved that code to a header file, this logic > > > doesn't work anymore. > > > > > > > Why does your compiler not just eliminate dead code like all the > others? > > Is this MSVC -O0 behaviour? > > > MSVC does not do DCE when optimizations are disabled, yes. So this is > where this is coming from. > > > I just sent the patch > > https://ffmpeg.org/pipermail/ffmpeg-devel/2022-May/296380.html, but > now > > that I read this I have to agree with Hendrik: Why not update your > tool > > instead? > > > > Actually looking at the tool, it seems like it handles header files. > Did you actually re-run the generation tool after applying this patch? Today I pulled HEAD and ran the tool (after I had pulled the latest version of the tool and compiled it). It didn't detect the header definition. That's why I wrote to Andreas. Thanks a lot for your help! softworkz _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".