From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id AC4104D427
for <ffmpegdev@gitmailbox.com>; Fri, 18 Apr 2025 02:48:34 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5FD4868813C;
Fri, 18 Apr 2025 05:48:30 +0300 (EEST)
Received: from NAM11-CO1-obe.outbound.protection.outlook.com
(mail-co1nam11olkn2015.outbound.protection.outlook.com [40.92.18.15])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 47BBB687CB6
for <ffmpeg-devel@ffmpeg.org>; Fri, 18 Apr 2025 05:48:24 +0300 (EEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=O/PCcnnz437fqUhyLynBCsxZObQ7AhlL93KDf2O+HcPZ6PMQ0uoy/6+NMMV05iua2nFt5GFo48Cdtxpyzg4xeKnn+SUCFSSUFW5JuFxDQeunOTcMBjgDm8JPjAc/1tC3nOKDh4nL/gkJmnClPdua2V5FwXgMCuZ6IBdnTs7DPyGPpGaZzRyQ+kn/8FQsm9VcgKw8QqBG2rtu73oHuhv1IvP7bRYE4NxA8gJdaCX/nNIyfzzfm9qnQlxFL1xxMh7k4zT8FUaVdmWgJuubY/yp3asImkJeG2ykdiEoMtNfS6E/OKWD/Lnr7qOUpsSx0xEHWEa8DAHNqnxCp3RlWae0uw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=ijMLrRM7F16UAG+H7GMR1fSq/Q6bCNA73MbR92oCkJw=;
b=BUYtwuKCLHALpMOkhfRjwqQDIuPNJLcUbol6yVe00wsDuR2EjRCY2DtbytsN5ua1UqKT7z95dm9dcU3kEXbIPjs66lnyzYwSOTZGBQAg51J+6AX8DVTJYITrII9UM7GeojBrWCo4pqaIRzb491mlvz4CwMJZq+D9+Mx29SyV1Ugmw1UkmCQS0woX5WKNhYeVpzanWkOoPoxsWgDHRJ/3fYYga41N1islHjGJbo0OVjRRlvp6M9+Vjb5yQ+xjijtz8H8YNQ5YZgcsOs42Q6+tvtSnW1A2C+yOS/5iOy8ak26OSifZc6YOEF1VnOAaf0xm4khHa+zbZCPaerQZbCta7g==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=ijMLrRM7F16UAG+H7GMR1fSq/Q6bCNA73MbR92oCkJw=;
b=gmPq5L95kMjhbe/vVSo8X07mFthRQtZh0Rq9l+E4F18/1OsuJdnNbb+STQCaPlpJeir/kjhI0KvXzmqZc7K5EmP+iOfDpKkPDak5rnC3At+T9NQKe+fDIZAs1ewSGGuLbf9kQbip3lhzJpRrxPL1z4gdJO1rs5P7uKpqdP0VN2SKtVy4VUTlCjfpGZFH7+BJcw6MHvS5qFXrHIOXDUtFoU0yk3bqNQPLkXLJ9VzwVwMc4CJScBWrjZPR7qY3okdz+AIhqee2l2C1uZWVTzVQ8xly1UlkFUDh4r72Ds4W2jENwuBCQLXJFkH4WFrUixhpk5XMUtyG0WTcdsdxYQZzIg==
Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by
PH7P223MB1139.NAMP223.PROD.OUTLOOK.COM (2603:10b6:510:31a::6) with Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.8655.26; Fri, 18 Apr 2025 02:48:20 +0000
Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM
([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM
([fe80::bf09:8e9:b07f:98a7%4]) with mapi id 15.20.8655.022; Fri, 18 Apr 2025
02:48:20 +0000
From: "softworkz ." <softworkz-at-hotmail.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Thread-Topic: [FFmpeg-devel] [PATCH v2 02/10] fftools/textformat: Quality
improvements
Thread-Index: AQHbrrgW9R6AVB6Btked3yEOin54GrOmHO4AgAAHeCCAApaAkA==
Date: Fri, 18 Apr 2025 02:48:20 +0000
Message-ID: <DM8P223MB03650355D78199373CDA2345BABF2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM>
References: <pull.66.ffstaging.FFmpeg.1744634826.ffmpegagent@gmail.com>
<pull.66.v2.ffstaging.FFmpeg.1744798340.ffmpegagent@gmail.com>
<6568269678c770544d58a9277feaf4953c352d9d.1744798340.git.ffmpegagent@gmail.com>
<GV1P250MB07371D91FE8825EFAB6DA6C08FBD2@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>
<CH0P223MB0363BF1B89B56D5E8AD9E695BABD2@CH0P223MB0363.NAMP223.PROD.OUTLOOK.COM>
In-Reply-To: <CH0P223MB0363BF1B89B56D5E8AD9E695BABD2@CH0P223MB0363.NAMP223.PROD.OUTLOOK.COM>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: DM8P223MB0365:EE_|PH7P223MB1139:EE_
x-ms-office365-filtering-correlation-id: fa4de5fa-6481-4d73-d84d-08dd7e237a82
x-microsoft-antispam: BCL:0;
ARA:14566002|8062599003|19110799003|461199028|8060799006|15080799006|7092599003|41001999003|10035399004|440099028|3412199025|102099032;
x-microsoft-antispam-message-info: =?us-ascii?Q?riKmwEZ+UwSSaJgTAyfpDmV8zFjYBQlDbWQaNXeWr7RPCPWeoEo59Tsoxz/J?=
=?us-ascii?Q?iftG+SZKGkE83jlolaVY00mRQAjvfwIv3KRkqSji/vrsP1o+d7ZE94bsl7Ox?=
=?us-ascii?Q?TDW7py/TlkpfNtBx1Y0UbXrwYHmzyK1QHvxplwobluvuf6SG55m92Y6uh2ze?=
=?us-ascii?Q?xW5dqUcI0V9fAUCo+Ygq+EFdCECEibrKlgITR7iVmX64YBoNjA4utAVCm7ud?=
=?us-ascii?Q?YQDvDuqVLyT6Kv8z7aAdp9IjUSXAcy0SmJU9wrZtpLfMcCLqudAHNwoVorM0?=
=?us-ascii?Q?z7B2zNuIaEcrSoedt1L732Tj7tsmy/bRxSfnEedDx2gpXLxBornv/e6bxvie?=
=?us-ascii?Q?ixCoidTKIi7Ot7yuHhe4/Q0WIDcTNOacUelJK+o6OCrcTw+8UMOFfNIEZZtI?=
=?us-ascii?Q?NyWuGKeaHGRF5ETW+Lbc3M34T+31MVZIxvVZfk+q7o5eEnDcD0kieooI/GdM?=
=?us-ascii?Q?wS6aGWuqBYgqYm25CaFzDneQow+vd9VYYf6Oq/hoPnVgtRsXYNuORkv82hUj?=
=?us-ascii?Q?Dpvfwnl9mCCC284qIOT+ZYoYOt6/gN+2buFn8tvXbkii0xp3bJ2/mBc7n/jS?=
=?us-ascii?Q?iYbDlv0oO82ITxpdqVFohDl/5UqDPr8WOclJC8+1i8A1Lkj6O5L7gfN2bve4?=
=?us-ascii?Q?RvRlPDOYSrU6br5FMFr7tad1sR1W/d3PBxYAW+rPbFtvMRjmisDH1aR3DmzM?=
=?us-ascii?Q?eMvzUKQQ/cl7vINyRNlnG+MeNryu8yMrKXalvLYuWe2q6zC7ZNMaMJ5WiVqB?=
=?us-ascii?Q?8Dfv9MunxJRAtBO2H7vjmwEV80C65SAd2sWnvkY24LOXnruGxZWGKwu0QjKe?=
=?us-ascii?Q?brFrq2BcGyjaarILJwR+k3Q5S9Mau7794zGSh7vWDrDQdAPDE8CpJdQZ/pd3?=
=?us-ascii?Q?/7ikmh5Fa8M+lmtCMivGHOU5WBmBhFL3fpDWI68UnXyzeVNRBvb1TUI1KlwN?=
=?us-ascii?Q?0qkuQlAJGRnFgHvstXPwBqW/J52em/Ic435JvZJ3awcVfHVLOfw3y9SbgfOw?=
=?us-ascii?Q?33UJKAnWvitvCByOExNOnSwZXubXA6ot1TjlYmXMvjPtFKMPye8LpU8udACC?=
=?us-ascii?Q?zFgSlmzouvMidB9yCryDiKZgnWlQQykbkLUg+N/sAd3CvbvNU8x8nJ+lwxCU?=
=?us-ascii?Q?wCnBnIHdu2VZt8qnWEBafft4eswQlzn0NZI7J3fmK3UmJyM/Sd61jdgqJ4wB?=
=?us-ascii?Q?T5JSFdP9f2uvorX4?=
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CdlHQVCY4MTM7RMjnSWCp2jwzJGL0gaXSA75a+jWfoe+8SzVucr8GQQjfo6L?=
=?us-ascii?Q?4131wWIPl5HIKQWJFdZNWdpF1BbnYDeRVbj0lLKzoY0MQStmCg4qMJOWYcUv?=
=?us-ascii?Q?BqlyMn5W2ZMmPqSs66I28IuC0J/xYv37l0SnY+PN382+GAEIqzh5bwYGtVd/?=
=?us-ascii?Q?FtklhfNr6u1Ie/AnDn/eDUBHWrJ+8FMH5YRgHnSpV4ZCrNyQWvxbMvn+A4Iu?=
=?us-ascii?Q?sD+8YnAkaOHHpeudi9/ONQNB9+w+ISgucThUJBw1DYC3QIoTyQB3HcyC4pRh?=
=?us-ascii?Q?DSYVIfBXjVc828bCnuAsl7iGT/iOUZQR/jF5brsRXx4GJZ0iCtfv6I9+K0+g?=
=?us-ascii?Q?e2yhiAHp1303IhNn/eiADmL/zpmrhUaGDm/ayJJB4usCkZGjCxdTChJp/EBV?=
=?us-ascii?Q?I3a7c4sjVqz4a7+EBkQv5yhy8mK1OUautujSbb77pvdwygoKx3Bu9OJO3vf0?=
=?us-ascii?Q?NYDBWeO/8LFrMYGAXEJPbAw2T8+vD+wFvuTbc6NkzDUHTUFiq1MMx+gxln6t?=
=?us-ascii?Q?J3XbsWo17exZF70JZ968QJJFOpOJCSYsoyLWonppyrD6GQe5Af+BxgaJc+Ad?=
=?us-ascii?Q?wDHO4gkkE2yK9Vmt0jOC7VwZp4nFdJDB67t953FEYuCTY+UcUW5I/ilSoNeR?=
=?us-ascii?Q?zSPsPTakSbqxDW8EvWhh15tza5lm3m1ATx45LdwgEUSHczcF+tQprWqLSyXG?=
=?us-ascii?Q?yTqJagrZZnibJZkF1hvNJQbYy1Yvvelilj26lRPXEtFrac+el79DpHuH2NKr?=
=?us-ascii?Q?NdtniRz//5PV8j3fM2ASSBI6JwDURBhKdqgCHPzs/lDbeERWPuh34J883L6X?=
=?us-ascii?Q?lEHypw/m9/4YzgAX4hLkHTId9gUxRjStHWEJDvOUaH/KvEr3/2wHRsGxFoy2?=
=?us-ascii?Q?ItckEuF7XOaQvt6KwlCV5p90qhV8iQ+55N+YhCshCOuCpzoDFlyvXw9BfYu6?=
=?us-ascii?Q?hc6QAfqkYcAkOggPDA1YndYNHFwbfoxQ3eHDY1abiR2rt/EABs9V3gZV2nk4?=
=?us-ascii?Q?L3Ud/13dHo8BwdnJnhLmkeJ1MmF/+YHlffOGM52exQxCqT5sITJGMpaeX5w0?=
=?us-ascii?Q?5EJvUnu9oJG0CCsQW4kALOhtMyFeMIJbaSgWfguLayoXHZxjO6xH48bwaW7o?=
=?us-ascii?Q?JsLt9eYUxWAK4MIWmuS43zMXa6/NKByWKsJvET2kc7n4NB68RM+ajM8jDplh?=
=?us-ascii?Q?Jf0QWs2xOYEz4bAJPZDu3dUt2fY+b2fHb0OoFcLp3WMfzjkMxmjINWIrN4U?=
=?us-ascii?Q?=3D?=
MIME-Version: 1.0
X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-92255.templateTenant
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: fa4de5fa-6481-4d73-d84d-08dd7e237a82
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2025 02:48:20.0777 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7P223MB1139
Subject: Re: [FFmpeg-devel] [PATCH v2 02/10] fftools/textformat: Quality
improvements
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/DM8P223MB03650355D78199373CDA2345BABF2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> softworkz .
> Sent: Mittwoch, 16. April 2025 13:33
> To: FFmpeg development discussions and patches <ffmpeg-
> devel@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v2 02/10] fftools/textformat:
> Quality improvements
>
>
>
> > -----Original Message-----
> > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> > Andreas Rheinhardt
> > Sent: Mittwoch, 16. April 2025 12:49
> > To: ffmpeg-devel@ffmpeg.org
> > Subject: Re: [FFmpeg-devel] [PATCH v2 02/10] fftools/textformat:
> > Quality improvements
> >
> > softworkz:
> > > From: softworkz <softworkz@hotmail.com>
> > >
> > > Signed-off-by: softworkz <softworkz@hotmail.com>
> > > ---
> > > fftools/textformat/avtextformat.c | 111 +++++++++++++++++++------
[..]
> > >
> > > #include "avtextformat.h"
> > > diff --git a/fftools/textformat/tw_avio.c
> > b/fftools/textformat/tw_avio.c
> > > index 6034f74ec9..b1743fb43a 100644
> > > --- a/fftools/textformat/tw_avio.c
> > > +++ b/fftools/textformat/tw_avio.c
> > > @@ -53,7 +53,7 @@ static void io_w8(AVTextWriterContext *wctx, int
> > b)
> > > static void io_put_str(AVTextWriterContext *wctx, const char
> *str)
> > > {
> > > IOWriterContext *ctx = wctx->priv;
> > > - avio_write(ctx->avio_context, str, strlen(str));
> > > + avio_write(ctx->avio_context, (const unsigned char *)str,
> > (int)strlen(str));
> > > }
> > >
> > > static void io_printf(AVTextWriterContext *wctx, const char *fmt,
> > ...)
> > > @@ -78,10 +78,12 @@ const AVTextWriter avtextwriter_avio = {
> > >
> > > int avtextwriter_create_file(AVTextWriterContext **pwctx, const
> > char *output_filename)
> > > {
> > > + if (!pwctx || !output_filename || !output_filename[0])
> > > + return AVERROR(EINVAL);
> >
> > You said in [1] that you removed all these impossible checks, yet
> here
> > they are; they are also above.
> >
> > [1]: https://ffmpeg.org/pipermail/ffmpeg-devel/2025-
> April/342317.html
>
> The next commit removes it.
In V3, I have squashed it into the previous commit.
Thanks,
sw
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".