From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 813D14D0F2 for <ffmpegdev@gitmailbox.com>; Wed, 16 Apr 2025 04:38:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D96B4687CF9; Wed, 16 Apr 2025 07:38:33 +0300 (EEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10olkn2093.outbound.protection.outlook.com [40.92.42.93]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D5AB1687CF9 for <ffmpeg-devel@ffmpeg.org>; Wed, 16 Apr 2025 07:38:26 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=S7An9R+Fq7QIK0bRc40J4pAAkyvkQQss+ZAlQW8iidSUkTM4Zbez59ZuL8cfwAKiEN1yA0STFAQN2mt5gWOABDW+qWhGctRmINm3CNaW+/xyRRE62QzRklnJQ7NRUQEkIwxP+dE2E7NQCemoCwzAx6dDS/dkBD//OX2troncenk8+WmAiB0x+PiTTjncL/7yX0rPjKpC+Gcy49w6mopmKjcuJsIRpR+1kFiQNGM7VvcM8k9Vs39/1s0sOaInCf8B6lxjl8N1+T2eYX/2yyjlw34+ncUuw5cKQF5/QwI2Lt7OanBUbtLKEb9NOXWtzuzxxzUW41S2uMRzK6I9JrBz3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vh3nQX6RWatRpz/DI1ElCSRJ6Q8AmfjWq1cfTVNkAE4=; b=q0sTHUeDWrGj+tZu6+Y6FTCTg9XLtSRo5yDpjx0RrEj8L3pJHJvGnNaZwnilw9uyahecczt6cY3KFkKNf3T8+9SJCbud8N9ELPU34CqFu3VyYRz3hZsgGXCKGeAE0i4odwv7oUXQHN9TcEhIpAwrN9jqI9A+Vk++lcWBwgg+gdRgPs4MdqSQahIUwTBUqOxk7mUp+MaZuev2EfF+XVvb5MCEKVFLO/HCKFQeMLoRNmmKlfcg0FAEtMhid1L1zUXq12a4kFUUGR8yXKnjMkHlzKEQRmHqJs6daOIZR5H4u+V1uUunf32JbNly+i0S50zWP9l8GHbqndw84cH69+8BvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vh3nQX6RWatRpz/DI1ElCSRJ6Q8AmfjWq1cfTVNkAE4=; b=uOF1L7vdq/kULgtk/4Cxv/2RUTsoPInKN2srF4wt/BUNuG4JFgICmsaNLT56LvYoEWla2I46VMCVdbnhCjOKg2T8dGeMg7tm1f3RutmBLqQAXOU2N9iA44hXSgupnq779na3SH1juOKZj8wQ+vM6XWj8Uq4Me+j3GXUvllLPXvmS5HbjsMkTpD9n94ArTa2BTlVWaU4aLBXJPPbffN1kafrpmiJew9rR6Xp5WEZiw5ihF3gxaahn554917f4on9t9C3W2+t7x/UEGr1skPxhlA9JGrEso05hC+LyCWnGkLu6sFN4cjM8KWAgae2WNH4v6ODLYGAch171AE4D3YA1uQ== Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM (2603:10b6:8:b::20) by IA1P223MB1370.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:597::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8655.22; Wed, 16 Apr 2025 04:38:23 +0000 Received: from DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7]) by DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM ([fe80::bf09:8e9:b07f:98a7%4]) with mapi id 15.20.8632.030; Wed, 16 Apr 2025 04:38:22 +0000 From: "softworkz ." <softworkz-at-hotmail.com@ffmpeg.org> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Thread-Topic: [FFmpeg-devel] [PATCH 01/12] fftools/textformat/avtextformat: Simplify avtext_print_rational() Thread-Index: AQHbraHTu3l+JvRExU60UdWjAjGt3LOj7GeQgAB7K4CAAQCBIIAATGsAgAAAanA= Date: Wed, 16 Apr 2025 04:38:22 +0000 Message-ID: <DM8P223MB036503000DE840BECEFCDFFFBABD2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> References: <GV1P250MB0737FC8C3B89F1100A6324E38FB22@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> <DM8P223MB0365FA00332594FD619AA750BAB22@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> <GV1P250MB07376B6342E54BFF4FC853378FB22@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> <DM8P223MB0365A746840DC346FCBA543CBABD2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> <GV1P250MB073782E37FF068C4070974E08FBD2@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> In-Reply-To: <GV1P250MB073782E37FF068C4070974E08FBD2@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8P223MB0365:EE_|IA1P223MB1370:EE_ x-ms-office365-filtering-correlation-id: a8f7f97d-74f9-4764-a497-08dd7ca08536 x-microsoft-antispam: BCL:0; ARA:14566002|8060799006|461199028|19110799003|8062599003|15080799006|7092599003|3412199025|440099028|102099032; x-microsoft-antispam-message-info: =?us-ascii?Q?5CUJnvFwuorHyLYRX24/+8un7KlfyRm0Ti/ra60YU4WlntLzIFGM5IolVCK8?= =?us-ascii?Q?0z4JTJCDrNQ8ibii4mdTNlFfVxfxktx47HKRa7NO/mMMUavzeOn/y2M9xGo2?= =?us-ascii?Q?Ll66XP5EgETe0BUEw8UzuiyB9cet7G1Gay7xRZQWI3KvMcqLKZg+o2W0dgQ/?= =?us-ascii?Q?s+stjNC68WdCOxbigw2T20Hh/Y6gWf8NcIShAcgRwoEJ+2tbp4dOcY2kWPuq?= =?us-ascii?Q?AnO6GqY0yi115DqKy1dTuyV9wYW1R7AQMlH+/KRNOSlhVKrs4GASAMdrZ8vu?= =?us-ascii?Q?RL0FfSBR60tdLfwWJlmzD7tjCO/aku6Qkyl+vP1WgFBxayPFUfm2WbKpK3oG?= =?us-ascii?Q?hF5C5bhiuh89loUp5BA2ojfWA+1NWG6V+LOtaRstHKIrKUamWx0Zj5BjqYdk?= =?us-ascii?Q?5nWGKopiKzB2dtdlKzczhCoQ7EGGsCFa5n7iGe2YZQ/zL7L5+o3PqFCHE3Xq?= =?us-ascii?Q?0B8v5gbdPuKKPmP7dK47zUApgUURo0g/+dpS3BsQcR4CJCZz0/rAFWil+Nqo?= =?us-ascii?Q?JGB7EXpSb8SDq0g2ETn+o1E5incXatmE8zJqOeEtODmoAIT4wo6LbcctrZ2r?= =?us-ascii?Q?sn/i1DWkCjW21ERaxNTI0Gf3lEbZZ0xe1YSUH/IQCPnRmYrw3LJzXHh9iMxv?= =?us-ascii?Q?9D6TbSJPt3WUXEtQ5dTsmwsipvq3mCUjIhfSuOXnxd/z05OYQUxYwBp+Iz2f?= =?us-ascii?Q?o2QtXttN6Kmo+VQStc7fkC7qtJyiyo9jDfeBi19tAfBMstsJcsEVTDhB3OxQ?= =?us-ascii?Q?4a98kzJqzsyKs3zfQY8R/pJd15cPy+qu2IFZ47Q/or1Tv4/Yi/jitTHSZv0A?= =?us-ascii?Q?ce6GQqqhXNHECCLWQItAD0k+hFsVyTHiZLduo9Vv4KeEiObnb3k83OK3uyJ5?= =?us-ascii?Q?yi+cu4g5xqp48zem9onQiDf7P3U1TWIz52+xhfqf1mTozsOWVX49QpufZoOv?= =?us-ascii?Q?GjqR/4htQuR0t2Qfom83OaZJt+SO0HH5Fn6EIIGH0BKdZpNyez2/R04kJflC?= =?us-ascii?Q?614wmmZP/VDFfw2tCorGhVwujlaRYg1/9JjQvaxbIAaYUBT+HNq47Hkl8bYv?= =?us-ascii?Q?XSgrRbWE8ZgRRp4syIBUEk1HmslODdPjQM/QkOnilidYrlNSBWE=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MuuORrmJ5hq5/u1cuiXZ8FlNXba4qWeX0w2TGIBay1LvfvvVqh/szrziWOEh?= =?us-ascii?Q?ADVtaGpLuVrK8GcyF9HZi/93Yi6qQQVnJ/tLIdi18JD41uIkGwofWsSstzU2?= =?us-ascii?Q?lPIhzIlObcn5Z9TD4EokPWt5I8kKu317keH6vMMvQ4ogpYyKJEmAaxY4OLg8?= =?us-ascii?Q?XAp+2rBM7AJVgoiSroL628fo7AXLClX9Gmy/j4uN2jZywpLoSdUV3iEjk/3P?= =?us-ascii?Q?TZ1BGAzMRWBoKG99Rn2NOyHQUQFZRPh96+4OXNBp9ibjcrfbLVk6uXzp8IB9?= =?us-ascii?Q?yzzMUVSW6gr6Gy2OIL+vSdaXZ2PwHi5wR8VWdRqtI3+KIy4meHxndY15Coo0?= =?us-ascii?Q?202ah1q7EFSC2/n+43i/jf57382XcDWGTh3fkLKyeB06sCCudDqR2jXINLXl?= =?us-ascii?Q?8b4P1bNY14pE46IHhpSnVnpQO2wic9driqZotWdEIpVNKHWIBDGm63VtZMxz?= =?us-ascii?Q?wUUbC1RONQC4mcGcyoCVtAdzKQwxREN/JlzlDB7d1WxtqvIdr9vMkw04aTTe?= =?us-ascii?Q?EQZJTvkgnDKk7CGyVUqeZ7tSf2fS/D6KuorcZb8UNw531A4kOdv3A9W9ZWLF?= =?us-ascii?Q?SWJEHC6f1V0CqRLMnJZqw9Ai//qJBW8dhqL9GRCBIa8t10OnoKswTPBwf4TD?= =?us-ascii?Q?EbuNzDQPx6gH5prqdZ8kAsrTWobh9M2Z/1hnMG2enSThxAoiJF2B/al2R6z/?= =?us-ascii?Q?hZPXbueSa65zhP/KjNRz5Rd20yeIUMWPutGcyyymZFVEsuKRL/41f1gqM8mf?= =?us-ascii?Q?xlBUgr81weJWyzs6e0V0m9xVtzEtHvp/oB5am8Pw/cMGuutDQcYjihDDX3ig?= =?us-ascii?Q?c2Ggj6KzjmDLr5hnYB7DeNg9VbE6oubuS3nw6HsGxfn1EhNQEso5WOmgQ3lH?= =?us-ascii?Q?sj+sE6h2pfTNItknbjUrvCXsRP0V05h36u0kysd5USR1d6J79kKJxnBthBza?= =?us-ascii?Q?RgO/gkrN0lsSTQ/z92Z22a54C/cggDwKV+3iBJxU/KB5IM5JaKJ4hWmnYuKy?= =?us-ascii?Q?5NnMHumHeoYfHtrBiaj2I/35JgRPsMp69PPBuWjbv9DAr85rlwT/lVkgEON0?= =?us-ascii?Q?eAbYHv8JuVVb6VbLYrUET+UQRQ4sx170b4slQyKqHvxAyHc3EUXQlzhd1Dxs?= =?us-ascii?Q?OmAxamhIBSYN6jJhY99Tz5C+SzxpmNvu+X8XW5j5ijFSbVtBjclESAdFNqph?= =?us-ascii?Q?1S3sNxzcKr/Nh3tBUVuco8KfNU+158xisYlWAbTWSOYxPzwzPbG02pKhKxs?= =?us-ascii?Q?=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-92255.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: a8f7f97d-74f9-4764-a497-08dd7ca08536 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2025 04:38:22.7683 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1P223MB1370 Subject: Re: [FFmpeg-devel] [PATCH 01/12] fftools/textformat/avtextformat: Simplify avtext_print_rational() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/DM8P223MB036503000DE840BECEFCDFFFBABD2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> > -----Original Message----- > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of > Andreas Rheinhardt > Sent: Mittwoch, 16. April 2025 06:28 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 01/12] > fftools/textformat/avtextformat: Simplify avtext_print_rational() > > softworkz .: > > > > > >> -----Original Message----- > >> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of > >> Andreas Rheinhardt > >> Sent: Dienstag, 15. April 2025 10:36 > >> To: ffmpeg-devel@ffmpeg.org > >> Subject: Re: [FFmpeg-devel] [PATCH 01/12] > >> fftools/textformat/avtextformat: Simplify avtext_print_rational() > >> > >> softworkz .: > >>> > >>> > >>>> -----Original Message----- > >>>> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of > >>>> Andreas Rheinhardt > >>>> Sent: Dienstag, 15. April 2025 03:00 > >>>> To: FFmpeg development discussions and patches <ffmpeg- > >>>> devel@ffmpeg.org> > >>>> Subject: [FFmpeg-devel] [PATCH 01/12] > >> fftools/textformat/avtextformat: > >>>> Simplify avtext_print_rational() > >>>> > >>>> Patches attached. > >>>> > >>>> - Andreas > >>> > >>> > >>> Hi Andreas, > >>> > >>> thanks a lot for working through this. I'll go over it tomorrow. > >>> > >>> As to not waste your time, it's probably best when we get those > >>> changes applied in a timely manner so that I can rebase the new > >>> patchset on top of it. > >>> > >>> Since you're sending the patches as attachments: > >>> How do you want me to reply with code context? Whole files or > >>> just snippets? And quoted? > >>> > >> > >> Snippets is better. So is quoted. > >> > >> - Andreas > >> > > > > Hi Andreas, > > > > thanks again for the well-spotted improvements. Just two notes: > > > > > > 0007-fftools-textformat-Use-av_default_item_name.patch > > > > In the new patchset, those macros are removed from the individual > > files. There's now a single macro in tf_internal.h and I've applied > > this change there. > > So you use a move/deduplicate commit to change something? Not good. No. The patchset has a deduplication commit. That's what I've submitted to the ML already. Now I made another commit locally (on top of that) which makes this change. > > 0008-fftools-textformat-avtextformat-Fix-segfault-upon-al.patch > > 0009-fftools-textformat-avtextformat-Fix-segfault-upon-al.patch > > > > Can this happen? > > Of course it can. All allocations can fail. That's why we check them. > Have you been coding with the assumption that allocations never fail? > (You can use av_max_alloc(1); to simulate allocation failures.) Allocations can fail, but statically initialized global const values? > > > > From my side, it would be great when we can get this merged asap, > > then I'll post a rebased version of the patchset, also accounting > > for your other review comment. > > Done (with the exception of the av_default_item_name commit). > > - Andreas Awesome, thanks! sw _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".