From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5143F40E1F for ; Tue, 8 Feb 2022 17:48:48 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D329768B161; Tue, 8 Feb 2022 19:48:45 +0200 (EET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 00D5768B09C for ; Tue, 8 Feb 2022 19:48:38 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644342524; x=1675878524; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=pJ8jI7TXn4xjlmKnRzwKlwXWe/UNL/BuNZVxU3GPHXg=; b=JZc2pWTN8s4pzWO0Ngwn73bLpot0sGSjnhqfHsqvm6nqesm6ATn6pDie A/dXyXXXLoDIAZlVEifeErxf06/4EJp2bWgvJtOQZvxFZmmst6V+RokWm FMYUrzKLmzq3oqPlwCotwf/GrK1WVQh5zO3vIkbqJgvwVG3cIg2ZKCY0i zirtk8qMl5rhJ95XSaX54+X3oUajMuQ3b3pu+vU2eTpQ/BTZSrgJLOcLg g4ol6UPhpFAXT7q6hQ2Q84MTWqPbzu8B8lui8HtBKGCwJAJMnjFsdzrLf LkKHfAxSkUt8Tt8Yw6lU9qmMSk1/naXgDmxgmh2V/+uHDoNbHiKkQgcJu w==; X-IronPort-AV: E=McAfee;i="6200,9189,10252"; a="246595436" X-IronPort-AV: E=Sophos;i="5.88,353,1635231600"; d="scan'208";a="246595436" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2022 09:48:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,353,1635231600"; d="scan'208";a="632924599" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga004.jf.intel.com with ESMTP; 08 Feb 2022 09:48:36 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 8 Feb 2022 09:48:36 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 8 Feb 2022 09:48:36 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.170) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 8 Feb 2022 09:48:36 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZV/O+H2+4GknH9S/5Y/CAI9oyj5tmizB3T8w+nyjoOQijh4++BufSIQt5SPz420zp7/vemgIZQTk2ISYPvmT55yLd7QYaDJHIpIrvKdmyohuEqtXSKKr9mRRlQfdDJMkQCQhUptX/dy63xbqScQ0zELFZqIkiYuFStw7NtW6bQ8oVowfDwRotIY1EpJ0qEfdrs2RXdV5xjWVBU/jowqW9l8TFBR4DABgV+mH0pkZYaySSKVlbUHID6H30pzL6GpzLs1pb3kvB45j+la2zHCbkfAygkVDeEdrvtuUwGh3yb+clRDMthzXhOgh/ArjoyqglpLpyG4tNcmTzlpy1V4AzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wh2RGAndtssQ0rEEdNTWPe/aWpdO55bXztHaXmnMOao=; b=L1n/zQhxojZNQHCM7C5vfdh/1fHZg3+XOHEUA6JX9w7KkzxIbFghJGKhjGiUaAyG2DSTWMIjGvhlWxbkKm/7rECOi/zZX23FhXlrmd4eMiHQztGmbthk+EKE4zy6Jwn4hruyYGfSEUSRZKBLRfvkZ1CAEpQwrr4Nl/X94YBd5ppR0/4q1dUzAEas+Aiuwhoi8UGVuQZEiTV28Xp4/+x4wxnUWklipar/xNijS7WEpzHHX4dcrKHkpX6Jtaa+JyzPJpN2aL4djdV3XH3Hmk1TJxt2O3847t4MjfEkl1ZCp+nVSRErzy5vDICIV/hzKViyZo7zcQ/80Zd7MkdweLUnsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DM6PR11MB2746.namprd11.prod.outlook.com (2603:10b6:5:c9::10) by MN2PR11MB4064.namprd11.prod.outlook.com (2603:10b6:208:137::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Tue, 8 Feb 2022 17:48:34 +0000 Received: from DM6PR11MB2746.namprd11.prod.outlook.com ([fe80::94b6:229e:5590:c102]) by DM6PR11MB2746.namprd11.prod.outlook.com ([fe80::94b6:229e:5590:c102%5]) with mapi id 15.20.4951.018; Tue, 8 Feb 2022 17:48:33 +0000 From: "Eoff, Ullysses A" To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] lavu/fifo: fix regression Thread-Index: AQHYHK+CddHUmOx3cUCGCOJ3JB9KwayJ7q0w Date: Tue, 8 Feb 2022 17:48:33 +0000 Message-ID: References: <20220208054734.14166-1-haihao.xiang@intel.com> In-Reply-To: <20220208054734.14166-1-haihao.xiang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1d990626-4345-49d4-6b59-08d9eb2b3a04 x-ms-traffictypediagnostic: MN2PR11MB4064:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:191; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DuefJ+2Z5oyUVyBqIW3p6DzeS8I0qNZGIr5Niq7YTa56lYQBuXYQPabRUQFVIkwiA9P3v3mMVhYnCtBMu+m39ORFpIj7r7Hbl6R+Ib03HZUmYjAByNEy/dzpdTBLP9fAFBM43nQk9eqFmr/CdE18B1OHRS9fByfVFghkg9TfT+FRv66INEYoy7dFYz+mmLeHIrArB125tKDID1RQndqcKl4YyUnKy4ZSAnxPdy5CmNHtfDN0NZWUEUqoGy0cQ0Kzbcv8B2KfxWT7LvJjxCrO6wuCrYLvN7k5yZxTYDNy6QkLgOPiUrksix1ZqG9ZBj1mxbwDY3xkP/AyWCET9ISXF0o/deFAm5w6pGZdaK6Vqf38k3EHS0MkOW3azx/swdYB6e08kSSXKJbJqDdmTFTbnuAEcj9/KBuLhFu7x7fPK1UupYSs1uOghFLKwoAbgu6LbJiHL/XY9G1a7KIuu9GJGE1sj4zCOjeORaNxiw0KfFGAEQsJZ4O4dBj1x95EXqrqLPHDswDJqlmQ5egA9F8s9wwEEEcr8rQ6hg6p4+ZdrW1GZAwdvoVcbtl18ddXOkqtORVyYWxFOenqkDtEMM+S0a1k5K042SQXtwYr7EeYPNhtbuiU9VhbvVNdNIgjIlzOT7gsRNLoBTp9a0Izf4+DPitALmo2tHTCd4fajjO9rwhwtuv0WH+IDrGHJF4K6zBfMMXOhRW4EESb5nhNkUDVRug5oQt32l8cIWLppvqIlnAL7zMUYyFmBau4Sv7WQ9pA5ILv+rSQWc9LqBnQsuZL1jsnLpd6SzpwQDpSPBxU4Eg= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB2746.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(8936002)(38100700002)(107886003)(4326008)(2906002)(8676002)(71200400001)(38070700005)(508600001)(52536014)(66476007)(66556008)(66446008)(33656002)(64756008)(26005)(186003)(82960400001)(7696005)(86362001)(76116006)(966005)(55016003)(9686003)(66946007)(6506007)(53546011)(5660300002)(122000001)(6916009)(316002)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lDHf9zrLdYzJNhN9NHkUdQWa7NW2U5BDOtkgIF3Cj3Tthci3mG2VqttOafyU?= =?us-ascii?Q?ohaywgWGzFj2s5OmNiu7VAkGOReCd2RdtufyQV6/eWczyw3FUmmGd8IY3DmR?= =?us-ascii?Q?61wPuM9/0tiVs5uuNnKyti5vePZd/lK6oe2CwT04l4CbUjEo2PBo7QZGh6n6?= =?us-ascii?Q?NtqOiIOLNKEYNRaLF8e23/dBOd/eaFfqzo0LE6hSVf8raQ7egJfEvHvHQGuW?= =?us-ascii?Q?P++b9abdXP8oPGbgkEiFIRQiGLMbCQ+F+e0M/+uGrPdt8MPBbPWLGmu8NFvZ?= =?us-ascii?Q?uioanlwcp50aPdU1KwOIsd6oxCCnasPYiJEyi6v85OjlRWfBmuZXlMCY1gIQ?= =?us-ascii?Q?W3rGvF4YixOSZ2chig4b9s63SsOBb/ltSDMClV69ud8ycggzGVRlvM2+FCfo?= =?us-ascii?Q?Gxrzb64ZipLGCIDqQCDJ4bWPtZd/7kZel1xhvt5X79nNu0Pj/3saX1LJEuvM?= =?us-ascii?Q?7LGK/9hPYOjoz2PSPQ4hNh9CNYwU77SCaVDgda+YvtTwFgwPrF7sw1FCVOqt?= =?us-ascii?Q?gUhq+wHsHCCcrUliuszBy73Ab4XqzlxGGBQF5ZHRSqbW4zGfEeSF6wPN3ys/?= =?us-ascii?Q?1KQ7pvjlDtl4VFsrsqdHdKx36u/OmRvaAP/Anu1Bdgyx+z2n4PkIl/Bs/IGK?= =?us-ascii?Q?zgZyvH37VM+2X+d00s9dFz706m2PFlQnsvsYl0PWnDB3BwxWMC9zr1Uy6gTP?= =?us-ascii?Q?nrZjhUDyrpgsjd5FntDtr6Ul4ob9rtIb3XuKNPowLypFewfXRbXpL4Z6+g46?= =?us-ascii?Q?W2mRZ0Gnv7G/Y96wKrmEWh7S4pRQtztZ9AzB4RViXlztij7SmR+eeXySFQY0?= =?us-ascii?Q?zlcaj5CL0wgFfbYgBRzSwwihFiFmTLLTYKxqubMFuEIzCWtS+uIbNpm2KU7N?= =?us-ascii?Q?wfPoj5Jx0llsTbAaJ7mhFAT6+fQnTrO0BO9T+vpuJE+RmLJJ5RKwPq+FRD9W?= =?us-ascii?Q?rVuGhI2mBlMMVEaucVISayZeijHF6kjE1b9HU2odE80D+RSy6tnjq6WomWPj?= =?us-ascii?Q?ip3IaCM1blm4CprSSA/ml5nDY/jEev8mn4Fw3MDBbbNW8IQ//h6le5VlP0EW?= =?us-ascii?Q?HR/UG3a5tJGClUBjw7WJN+xqvVW0RL8Sa4L8NDseHeqewtiaWTYNIzPyidIe?= =?us-ascii?Q?XmE3iLLRyoOLr9BBKt3MdxuB9XS+7Y/IoyOvHWIH/NeUPbIZ3hvgEFbAKYWx?= =?us-ascii?Q?G6k1Izar0hCDXCSWlIp+HKdKSt4vZpqtKYXFaE6ERwT9IcqTUjmGVjYS6i28?= =?us-ascii?Q?jS+yoyltWJdpgSVNXHbBOeZpVQUJn3PlZCJhT3RLdi+UGvfg5EUdu9PYfE/9?= =?us-ascii?Q?JkSWDp8HKUeoOhJitGFzG0oC4q35vna7A2nQvL7Qp4Bq3b6F0f36AO9j0Eu7?= =?us-ascii?Q?q5jGUt2vtCJMpz2McZ63OYU/DgC8++X41IQhllhu3oOfn62SOwXsbM9FoVp6?= =?us-ascii?Q?TpZYqgejSlI9wYyN5Z5K3Ckk3XznBRm5QPeChn9er9V+nty/uUxOXZZ7fY9i?= =?us-ascii?Q?E9dqpE5BLqIeHIsAxsCH0r/DCfPy3f07pzyyCRI5TD2JrLF98E3Xqj9DLy+K?= =?us-ascii?Q?eGbwF6EEpqN/M7L0GRDklY3VUu9b4JbZXmiNdUl24yAFhZ+C67Ld/s8nenF7?= =?us-ascii?Q?Erypid/INri81izbzlJ5Rx2PnI3N0qhRtp80Psz+0QCqciOSscNhAUTr3AhS?= =?us-ascii?Q?LOFcGw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2746.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1d990626-4345-49d4-6b59-08d9eb2b3a04 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 17:48:33.8500 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SO8cvNWoiY6nWuYKhE8XzXQNMK1IafOFtCnmvgQt69V7WSsq8NhogtYD0VvXHYUbBqXrZQidEDAgdOD6jgH6yjb+ATw3UjULpAjjGtcLMbs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4064 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH] lavu/fifo: fix regression X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "Xiang, Haihao" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Xiang, Haihao > Sent: Monday, February 7, 2022 9:48 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Xiang, Haihao > Subject: [FFmpeg-devel] [PATCH] lavu/fifo: fix regression > > From: Haihao Xiang > > offset_w might be updated after growing the FIFO > > Fix ticket #9630 > > Tested-by: U. Artie Eoff > Reviewed-by: mkver > Reviewed-by: U. Artie Eoff > Signed-off-by: Haihao Xiang > --- > libavutil/fifo.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavutil/fifo.c b/libavutil/fifo.c > index 0af0154945..02e0ec3f0d 100644 > --- a/libavutil/fifo.c > +++ b/libavutil/fifo.c > @@ -147,13 +147,15 @@ static int fifo_write_common(AVFifo *f, const uint8_t *buf, size_t *nb_elems, > AVFifoCB read_cb, void *opaque) > { > size_t to_write = *nb_elems; > - size_t offset_w = f->offset_w; > + size_t offset_w; > int ret = 0; > > ret = fifo_check_space(f, to_write); > if (ret < 0) > return ret; > > + offset_w = f->offset_w; > + > while (to_write > 0) { > size_t len = FFMIN(f->nb_elems - offset_w, to_write); > uint8_t *wptr = f->buffer + offset_w * f->elem_size; > -- > 2.17.1 > LGTM > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".