From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BAFC340884 for ; Thu, 29 Jun 2023 06:03:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9F97768C289; Thu, 29 Jun 2023 09:03:31 +0300 (EEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6324A6801F2 for ; Thu, 29 Jun 2023 09:03:24 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688018609; x=1719554609; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=hVrSPgMdJ4N1Pq5teW6yAqi+1IoTJEUl5bUF5XI1b3k=; b=Je36kOhcKG847kkrsfPsZhIIEYMfdTWKbHDkErbgSqNBLPIgor/8Vt7H wl7GatMtpg6GmR3+OtMHWoy78FBsRZdwluxsIJ6+11P2NLfwdatXdO9lz TK6lc4cftS4UyCiGXJUfiCwhiHMnucOsMY8zSwCCN2qgvgrz/F+LxdcBG M3IsnENO1g0ZfRCjg9tvtqKWwPGuOE9ASpVjy1PCL3xFUs+mGvbk2thFV 5mFPEIJtBrWVXvk34QBn5MH0TwLrnQSL4AWdu8tBIzJVTqhk3yJ82EGDe AYjFKZ0mLXEX+9YTIRyeg1P21TRFGRuIaJVx/FUUV7NXRawitA9NEbHSg Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10755"; a="425701671" X-IronPort-AV: E=Sophos;i="6.01,167,1684825200"; d="scan'208";a="425701671" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2023 23:03:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10755"; a="717239832" X-IronPort-AV: E=Sophos;i="6.01,167,1684825200"; d="scan'208";a="717239832" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga002.jf.intel.com with ESMTP; 28 Jun 2023 23:03:21 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 28 Jun 2023 23:03:20 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 28 Jun 2023 23:03:20 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Wed, 28 Jun 2023 23:03:20 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.106) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Wed, 28 Jun 2023 23:03:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H7czFpWoUploSIcsS8aY5ndu9DGCARouUqZ6+NmIPgNpbIafhyLwwYDEQE4AJdWW1J4LEb2Fnik1Coir/oWqg+5jjmANTk1OTcsO9uzZwMkttU7X7PnELipcjD0pwIWalMh7zgRSO24nhXr5wjWNuL5xqUfjz3Z71tA1sA1DftquHFBjOHdIGlONL31w/R/uJ7nkrHmUT6URajS4I5XE5LyFcQadkiEjLmWszbtz4izSZWpOId7OYpplw8isR4OPdXXhJAIstcCqW+BVma5emWpT1LgYIXjaXt3CXL5y1E5X/WANf2mu5iy86APPu4A4atTuVcKvKY2Rj8s8Ias4UQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dxddV0ZryLch1qBovQtViYsU2MW+oh/Bh+ppbW9oP+Y=; b=AdrsQ0XBppSkNUH+9dB03mpzVskgOcUQB/a6hO4dqlx9pw5g4KDEF79YavrcTxmI8ZlUifV5RdszWuawGxW21PTa0bDT1y/NUWj34rbE+vFDumTTmuqRmjHOKPPL35yQWPAEfgkO8wyw7PKGZiLiejmKnMIKzn8inY+O8rX7jvpAFixMy5jYJi/wwW67MwgPiQ5aYGbzJnisHS/WXkagMDBCbK8Pab8BjJ9JbAZ08GYlpu4LegFIsIz/y7PGlnW5FHrWW3egvtDZNVGqPinNQE6nHvk/zYG1GUw3U9EcfjI/maN4pmHjqdxKlzIo0Cic8DCB5oZafrpb4mHaIJge8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB2681.namprd11.prod.outlook.com (2603:10b6:5:bd::33) by IA1PR11MB8149.namprd11.prod.outlook.com (2603:10b6:208:447::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Thu, 29 Jun 2023 06:03:18 +0000 Received: from DM6PR11MB2681.namprd11.prod.outlook.com ([fe80::534e:f5e7:4c88:ba3b]) by DM6PR11MB2681.namprd11.prod.outlook.com ([fe80::534e:f5e7:4c88:ba3b%7]) with mapi id 15.20.6521.020; Thu, 29 Jun 2023 06:03:18 +0000 From: "Dai, Jianhui J" To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v2] avformat/ivfenc: Set the "number of frames" in IVF header Thread-Index: AQHZqdTcOxh2R/hSNke0O+LDwdAtvq+hSLpw Date: Thu, 29 Jun 2023 06:03:18 +0000 Message-ID: References: =?utf-8?q?=3CDM6PR11MB26814011FF82B8637DF846B7B14DA=40DM6PR11MB2?= =?utf-8?q?681=2Enamprd11=2Eprod=2Eoutlook=2Ecom=3E?= <168796589909.21886.12641050031611059268@lain.khirnov.net> In-Reply-To: <168796589909.21886.12641050031611059268@lain.khirnov.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB2681:EE_|IA1PR11MB8149:EE_ x-ms-office365-filtering-correlation-id: 2e87c191-50a8-41d4-ceb2-08db78668914 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gf4jlDfUGjjYC8gDvZwl6CEnRBbgf7aS0fC4UpfdqorK554UIHjJVxTN3nheg2gK1prkqOfN2nBGrE0mJ8ouFa2qb+fQl61fzxzaw+7LsEIagAupzbkcuyBt4/YMAtF0yeHp/jvBqiOHeBq2oRAAgL70+78VzgRwK7YCy+typm2Q4xgATi3ghD9st/7jVbI8dqFuMtN09zlNTTzkdOCMZmazTtRPZ486mIDLF/7JJ/nQc9w+8xKvUG+XuZOYke271pad3jpvui4DE7Biv9CIWeiQ4yvM7hy8vkT9pnJDA3uHuOAbyxlmShGA3V7JdRRF7NLlRhIY8EWde2aKQMWVIJ37HD+LMLFeIqLc1obHTC2B/qeL5Nt3+mvz/OWMktNclsgId+i2UXk2OpJMYFYewBXr/qLmNUQHKIMv7HkgFJZBIC9lWK60bAzml+ENCz8kom8QMRM80TuyzM5ik+3c3hmzXuu7QSOpFaG8DoHrf2m8uw2za5r2vDQvwRPW6nJR0IuFshGHmDB4/Zb73Dlcc+mos+jIx+h+opxd17PKxCSvnw2XU4XH8+CwMWr0b/+lSlS5M+sGD18AwUxhqQcMT1tYa0MVi4WyoWbxSxxwbao= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB2681.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(346002)(136003)(39860400002)(376002)(366004)(396003)(451199021)(66446008)(66899021)(38070700005)(9686003)(26005)(66556008)(66476007)(66946007)(122000001)(86362001)(33656002)(6916009)(8936002)(41300700001)(316002)(8676002)(55016003)(82960400001)(5660300002)(52536014)(64756008)(38100700002)(76116006)(966005)(6506007)(53546011)(186003)(2906002)(83380400001)(71200400001)(7696005)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lGZ4SWnLdv8OHydoIpd2pYe/zwl5DOLDTSi9AvECBXhfxeqJJg0tXRacSDgR?= =?us-ascii?Q?QyxsIeIEKriXHbx9VuuOnGewc7QMqHQUnlxtUMSg/uvEnFrtUWaOWDtXTIIn?= =?us-ascii?Q?JJOIMA0xIyrQe5IaezjKqXgI5zChpiJj3Zs4wSnbQRLeJRg5I3gmiPuhEQWV?= =?us-ascii?Q?irR1vaVQ05YZulDq9SIOhxOCrsXGUvQOpw0hgwR3YsIUNgD/HclXXDXHP02D?= =?us-ascii?Q?8+Cks0V3jFOfZorBwExqoyx2/F+92tz+o+4EGMndMvPMeWJ/ihdJPIi7NgnN?= =?us-ascii?Q?GkT4MGAlszeHe5Ugr3CDvPQaxEgD8lGtAE6gQIYK3hHJfziEEkSUUJ+zdK89?= =?us-ascii?Q?UfV7Ju+uMPbvl+aywqqciqiE+i497Mmig21akSl93i+kAI5zTH8TV71BMchg?= =?us-ascii?Q?oK3aOwPo/5lktGfScm8LHGPm3VyfpYudszZp/C4Jo8NhtDS0XFQWIdfCzJ3e?= =?us-ascii?Q?QX+MeymGWfMx0FOWT/bIIVm9r7RxzhzXE7F6wXkRdAGtY9LWeulmEdOiA0dk?= =?us-ascii?Q?LNjWDbAiVdunaM3Mue/g4ZdpxvL4HIER9LHbrihD2SIW5cDW+Dsb0tt+FWvL?= =?us-ascii?Q?IWllOY1S+RBH8+61CJ4+RoO0VyVnjzO3ylkG/+gV10zL6cgvQi24uKCgfrZW?= =?us-ascii?Q?AUh8WBLxUtrvXp2BnKqsfHW8DxezoonjVzGPKjefAU7TcDl80Ki6JDc2UOI9?= =?us-ascii?Q?NSak4a0G03QR21XgYuf0LYiHb8DUtDh4phEml8Bmnwe434w25k5IKrkNaMdU?= =?us-ascii?Q?NB9wIMhudVpJAjpP8vuHKKHFcdbyRFp2PgqSHWXQAMUvhrsTVej98rWijR2d?= =?us-ascii?Q?9iuAw8a2BGX/N28L0lG+4iPjJI3h4L3gGkUMUqfDSLnElj9YhnFZEJAiTf49?= =?us-ascii?Q?MAOXuJ6te722OMvM3MBQO5AN+NwPUwXNUHRhEVmcrgSzIwpxOgfMYOFRfINy?= =?us-ascii?Q?unawkeKeB5nMI0gprBgyap/Bffmtl7Rb8+gy5KebH7VFDXb6H5qagP0tpjBF?= =?us-ascii?Q?LcbGsYKQ3veiZKTdiVHyPDHpJTZ7SiQCoAP6CgOR4zSpIJvPcQ7X/wL9TRlD?= =?us-ascii?Q?pVjjrYzgdEUG/MtZ2qunzTwovPgZckPgoXrhF24n3pzh5DJkXBy8K9oHNuFq?= =?us-ascii?Q?bSskkTgJgk30wormSWXiqL+XtGVjNhmpbLHXWpUFvADoFPLmZn7h/3/4BPEk?= =?us-ascii?Q?6yArSp3KTg8MpAgB6H5Z0pZysNcZMCeCl//yIC6M1I7n8ygXGfZJHy1JX4pM?= =?us-ascii?Q?EOJjshcbIQK81mWDWVJPnqkjoXz1ZMttqj0o8aF/deJWCQE1eNDMlBTLiWRg?= =?us-ascii?Q?yBvG4cOtIy4TjGSrzoAdwN2FexWXKxjIoE5m8J6ZQfrKnYJPBHrXxz3Wk3nA?= =?us-ascii?Q?9a9Vi4ZNnbULkfFYMmBLQVBFvxKrxlwPnz3mCgQQsXze9KUIJBU54JR0vyjD?= =?us-ascii?Q?g8eWlpbSYI5vTc+IhBCzvipIzjF/5U+YltShtTBTYgsjKHLSN0zIWXJCYv62?= =?us-ascii?Q?yauJyDO8ZKcz7LTYl3zgHO+WpClY/EOJtMXN/Jpx5O9BC4BgJ+SzlS+FXyHB?= =?us-ascii?Q?Zpk6HETA6GZ+5ixxyR1qxDItWWkcNXst/iTKz2Js?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2681.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e87c191-50a8-41d4-ceb2-08db78668914 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jun 2023 06:03:18.4781 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QxU/HBLgl9c1Brtc3HncqoOewuzKyvj7/kEVHkTuAVhlwWc44Bjb+aN35J90s2iKpNeByOn1V50ny98DLpj04A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB8149 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v2] avformat/ivfenc: Set the "number of frames" in IVF header X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of > Anton Khirnov > Sent: Wednesday, June 28, 2023 11:25 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v2] avformat/ivfenc: Set the "number of > frames" in IVF header > > Quoting Dai, Jianhui J (2023-06-05 02:53:35) > > diff --git a/libavformat/ivfdec.c b/libavformat/ivfdec.c index > > 511f2387ed..01012db948 100644 > > --- a/libavformat/ivfdec.c > > +++ b/libavformat/ivfdec.c > > @@ -53,6 +53,7 @@ static int read_header(AVFormatContext *s) > > st->codecpar->height = avio_rl16(s->pb); > > time_base.den = avio_rl32(s->pb); > > time_base.num = avio_rl32(s->pb); > > + // Infer duration from "number of frames". > > st->duration = avio_rl32(s->pb); > > This should be setting st->nb_frames then rather than duration. > And the muxer should be using that field as well instead of its custom version. ACK. Do you suggest letting `duration` unset? It is interesting that the 'duration' is often right in this way, if the time_base.den/time_base.num == fps which is the popular configuration. > > > -- > Anton Khirnov > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org > with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".