From: "Dai, Jianhui J" <jianhui.j.dai-at-intel.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/cbs_vp8: Add support for VP8 codec bitstream READ methods
Date: Tue, 30 May 2023 08:01:10 +0000
Message-ID: <DM6PR11MB26811C79CD393DE7789DDBF7B14B9@DM6PR11MB2681.namprd11.prod.outlook.com> (raw)
In-Reply-To: <2c3840b1-0964-8c5f-c2af-0ae367734817@gmail.com>
> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of James
> Almer
> Sent: Monday, May 29, 2023 2:05 AM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/cbs_vp8: Add support for VP8
> codec bitstream READ methods
>
> On 5/23/2023 4:19 AM, Dai, Jianhui J wrote:
> > +typedef struct VP8RawFrameHeader {
> > + // frame tag
> > + uint8_t frame_type;
> > + uint8_t profile;
> > + uint8_t show_frame;
> > + uint32_t first_partition_length_in_bytes;
> > +
> > + uint32_t start_code_0;
> > + uint32_t start_code_1;
> > + uint32_t start_code_2;
>
> These are unused since you read the values with fixed().
Thank for review. Done in PATCH v3.
>
> > + uint16_t horizontal_scale;
>
> uint8_t for this one.
>
> > + uint16_t vertical_scale;
>
> Same.
Done in PATCH v3.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org
> with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-05-30 8:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 7:19 Dai, Jianhui J
2023-05-28 18:04 ` James Almer
2023-05-30 8:01 ` Dai, Jianhui J [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB26811C79CD393DE7789DDBF7B14B9@DM6PR11MB2681.namprd11.prod.outlook.com \
--to=jianhui.j.dai-at-intel.com@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git