Re: [FFmpeg-devel] [PATCH v5] avcodec/cbs_vp8: Add support for VP8 codec bitstream

["Dai, Jianhui J" <jianhui.j.dai-at-intel.com@ffmpeg.org>]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Ronald S.
> Bultje
> Sent: Thursday, November 9, 2023 12:38 AM
> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v5] avcodec/cbs_vp8: Add support for VP8
> codec bitstream
> 
> Hi,
> 
> On Wed, Nov 8, 2023 at 10:55 AM Ronald S. Bultje <rsbultje@gmail.com> wrote:
> 
> > Hi Jianhui,
> >
> > On Tue, Nov 7, 2023 at 8:52 PM Dai, Jianhui J <
> > jianhui.j.dai-at-intel.com@ffmpeg.org> wrote:
> >
> >> The smaller delta patch to export the variable:
> >>
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/DM6PR11MB268186349E
> >> 600824E1577DFDB1A8A@DM6PR11MB2681.namprd11.prod.outlook.com/
> >> Personally, I prefer to limit the static data only in vp8.c.
> >>
> >
> > Understood. It's going to be a dice-roll either way, and since I'm the
> > maintainer, I get to pick :-). I prefer continuing with what we have
> > in this version, but I'll leave it open for the majority opinion to
> > overrule me for a few days before we merge this.
> >
> 
> Actually, I realize that sounds quite rude, so let me elaborate: I prefer external
> data tables (in a separate source file from the rest of the code) because they tend
> to be big and clunky and you can't really change them anyway. They are
> essentially binary blob in numerical form. We use external data tables in quite a
> few parts of ffmpeg and I've grown accustomed to that design. For now, for old
> codecs where nothing much changes over time, I prefer to keep it as it is. Small
> diffs means easy to trace back when stuff breaks, as a general rule.
> 
> But I admit that all this is personal preference. There's nothing wrong with a
> different approach, it's just that: different. Let's agree on a color (green!) and
> move on to shiny new objects.

I fully respect all of the feedback provided during the code review. 
Thank you for your patience. : )

I don’t have the commit access. Appreciate to help to submit if everything goes well.

> 
> Ronald
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with
> subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".