From: "Dai, Jianhui J" <jianhui.j.dai-at-intel.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] vcodec/vp8data: Make ff_vp8_dct_cat_prob static
Date: Tue, 9 May 2023 02:18:38 +0000
Message-ID: <DM6PR11MB2681106E02B8E50F2CF37EDFB1769@DM6PR11MB2681.namprd11.prod.outlook.com> (raw)
In-Reply-To: <bfa9a393-b0c9-9a13-e2b3-04b5fcbfd63a@gmail.com>
Thank for the suggestion.
In a WIP patch, I try to reuse ` vp8_token_update_probs` by include vp8data.h; But face the compiling error with ` ff_vp8_dct_cat_prob`.
Let me move ` ff_vp8_dct_cat_prob` to vp8data.c at first.
Jianhui Dai
-----Original Message-----
From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of James Almer
Sent: Tuesday, May 9, 2023 10:04 AM
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] vcodec/vp8data: Make ff_vp8_dct_cat_prob static
On 5/8/2023 10:49 PM, Dai, Jianhui J wrote:
> Avoid compiling error if included by multiple sources.
>
> Signed-off-by: Jianhui Dai <jianhui.j.dai@intel.com>
> ---
> libavcodec/vp8data.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/vp8data.h b/libavcodec/vp8data.h index
> 1fcce134eb..ac4af5f733 100644
> --- a/libavcodec/vp8data.h
> +++ b/libavcodec/vp8data.h
> @@ -353,7 +353,7 @@ static const uint8_t vp8_dct_cat6_prob[] = {
> };
>
> // only used for cat3 and above; cat 1 and 2 are referenced directly
> -const uint8_t *const ff_vp8_dct_cat_prob[] = {
> +static const uint8_t *const ff_vp8_dct_cat_prob[] = {
> vp8_dct_cat3_prob,
> vp8_dct_cat4_prob,
> vp8_dct_cat5_prob,
This is also used by the ARM assembly, so it needs to be moved to a new vp8data.c file, leaving the prototype here using the extern attribute.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-05-09 2:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 1:49 Dai, Jianhui J
2023-05-09 2:04 ` James Almer
2023-05-09 2:18 ` Dai, Jianhui J [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB2681106E02B8E50F2CF37EDFB1769@DM6PR11MB2681.namprd11.prod.outlook.com \
--to=jianhui.j.dai-at-intel.com@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git