From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 394194EE30 for ; Wed, 14 May 2025 03:56:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D590068BE2E; Wed, 14 May 2025 06:56:10 +0300 (EEST) Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11020126.outbound.protection.outlook.com [52.101.193.126]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0A71F68BE03 for ; Wed, 14 May 2025 06:56:04 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=llQB0dbSf69cIR4biBWpH1TviyB9b1RJiWaX0Ewr+wE1NuE4nURvRLfcn7uvqpgAYw3Zf+vtPbms4d7ui8/W5ak5UeFZ/wsfvTVqask6uGFn2wSPe1G26XQVTDN+Zbj2RRanIIMsCGbz3syoXQhk32CIRux1oIfZYCHK/Bf9B9yByRnOjwGur9YvxfpzaAM9ZyM2hcQdO8CgUDH4GWnza6zkhqfoSFr9S0ZiY7jAhMtgFcbIK7erRPonV/TJHVVEQAWPDbllxCpvkgrSrRHxSxCmvmKQ7ZdGW4Zw+4/KNlPjPk08aHIIOj46BBIgBXxtQPLCVZyz0kMuy/DDJkWBRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=btm86nWEXhhPilUYxMxyfGal5ZafG0r+zYd0GakA0ww=; b=iYpexxp0GjVTjcZqga3b0kga0tXr6+mExNEYafuN10uqKT/ZXQA5nODxg4qyvI9ssDB8HPiKvySZuQO6u3dHNs1CyVKKcIYkwIw+AW8N/YUr94aKRhBxNrJu76ky1Os5ojkru/4R5EPdPBzc5kY4mjdDw4G5JmcZvPIo6A12c0wF7igPTDYAIccq13aNhq7/FvisJws+29cQPcElhNayktAJ2nPuiLjBxbyd8BUOTxnJX6joHnAl3pHpglMk0gisfnXQJt1VnTd0b5BQpJw7Iw7RoQNpVcAqd3+7Sg9ex+r/fEE1X8TQFQEIMjKnHM+8fYaY/pd2QGxQSqUI4WKrmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none Received: from DM4PR21MB4619.namprd21.prod.outlook.com (2603:10b6:8:244::8) by DS7PR21MB3598.namprd21.prod.outlook.com (2603:10b6:8:91::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.4; Wed, 14 May 2025 03:56:00 +0000 Received: from DM4PR21MB4619.namprd21.prod.outlook.com ([fe80::7670:fa05:fb39:c4c9]) by DM4PR21MB4619.namprd21.prod.outlook.com ([fe80::7670:fa05:fb39:c4c9%4]) with mapi id 15.20.8746.006; Wed, 14 May 2025 03:56:00 +0000 To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [PATCH] Boost FPS and performance: Optimize vertical loop for cache-friendly access [libavcodec/jpeg2000dwt.c:dwt_decode97_float] Thread-Index: AQHbxIIyH+G0sDRphU2AVo5guQ8OI7PRfy5A Date: Wed, 14 May 2025 03:55:59 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2025-05-14T03:42:19.822Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR21MB4619:EE_|DS7PR21MB3598:EE_ x-ms-office365-filtering-correlation-id: 39285464-11fc-4a62-856d-08dd929b3d1e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|10070799003|1800799024|366016|376014|38070700018|8096899003; x-microsoft-antispam-message-info: =?us-ascii?Q?egZvgNtbzJkGi4CV+h8rEDutunCRqb+GDP0suc6+VQptqmDH8bS1qwzYp+1M?= =?us-ascii?Q?GKO6oEA3YE8rDQbdzrW5WeiLrHb7SjncwIt/PCjJUqWdInZMtdoswV4H31Vk?= =?us-ascii?Q?IohGjOLUJX6D5j1m/nVj7dI8XzlaWUMFd+jiiLvFUsuYv4zhlmV9W15GSla6?= =?us-ascii?Q?57oMTyjehh/VebLKgY2iletkfHORSahDPq0F6dq1jkESVm6w2QKapVW0dd5g?= =?us-ascii?Q?hlx5KLcphG/gmOMpt4L0bpHCmPmMLg+sGSotG22+hRQY+T53K1bD2shsjWG5?= =?us-ascii?Q?Y6YxwBzYqdMrC93a+jPYnN5XirTxMTvW6oISJqEizPJTQdXyX+kef8rY2gxm?= =?us-ascii?Q?H+Pc3VGRPVnZqjaI5mNMWCizG4Ud7l6/Mx7zG8z6O9DVl5PmDbBDehfmlEXK?= =?us-ascii?Q?Net4MmtJU2qPkZdNXaGEiU6pnuRWtRnD6YpD7hZf0kTLsGPOk0rf2Ci7qdXz?= =?us-ascii?Q?rJPaE4p/sWwG+X/5kxWZEqucaYfMeyL+ZVlC3mM3d8QxdpKpzHW926uUn7na?= =?us-ascii?Q?j8uWEMb5C3ILzi7i9gNk+4GHxrZuiCeXVFx4ZThQUPJxkSNSWX5OKTqCaD8x?= =?us-ascii?Q?AGJcnV95AOqx0zBUo/O1MYA0+I8P0WGEg/l420buefoMzqQ0NRZWQpfVRIBS?= =?us-ascii?Q?Yte6xXzr4cEJoxgm4ioN8Cns3Em/l+ChOPeT0APK92j0uC6jQJEGQrsLeNQ9?= =?us-ascii?Q?qhQTGQcFeWWKckVdDIYaPu3yybgzfH/pvdOkkVh2is4DXHV8TueBDjEeb5De?= =?us-ascii?Q?1syIbjWY8VCl9bu73ksYSBWxhvBQ9U7ziH1LNIgMp16h6gTz7pZ5WFOIGnK2?= =?us-ascii?Q?KpPUq5NGoR02vmewbhrQIbV6gbAnwCAOtiBm2XGXy5BKludBP+YlWFjcrRYJ?= =?us-ascii?Q?gelIvQ3zULNLR0N6y6Ben2sQg6y6d7aG2Tyw7kyxpOF6KSh7ITsN9eUmlvMv?= =?us-ascii?Q?zq/AzwN/w9+iEmKQtTb11BK6ZaErf40JmuvBlgVZFtuUZJEHnfG/RP+Bcmgs?= =?us-ascii?Q?uDJT15gTgNbe5x0OjK0oqLzLJMtmBmyzqafd5OifucrpPCa1Va1G0IYKou25?= =?us-ascii?Q?GSDgoGP6bxeD7/BkB0ifOYrvFNJyNYGxJROecxsuvas/O3pgA+MZUHnW0JPe?= =?us-ascii?Q?CDa8BjobVyl9ZTAwZWBb/5bC5FPinjjMy9Qg1LoNJOhQbMP2W+dV0b8CXFbo?= =?us-ascii?Q?wy6WJDaLDmR6ffEXLIg/zB/codSPQfG3SX/HWKPT5YUDZ3ibzuDKrAVzAW9n?= =?us-ascii?Q?zfWdctkhVXTT2JSURgR17lAqTl4a/F4Fu6/zTMwh17FiTFunALZ+FaW6bObN?= =?us-ascii?Q?Mf1y/l3l5VgsCFihB71qk2V6aRx2wgAWV+dcPx++o62slahOmjLwQc9sHLD/?= =?us-ascii?Q?k6Y8EDYq52Nkg+3V/r4JfO4HRCHdoG3Ldj0U/NP9h0Mt810ee1Fo2pwXA9dV?= =?us-ascii?Q?8y/6nrfFbxj2AmW6tFuHnQSv4VfMENiRlVrraoXu7fQbr+u5TTe/9A=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR21MB4619.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(10070799003)(1800799024)(366016)(376014)(38070700018)(8096899003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?80VumYKjeWwCzgCNzcOC855GQdREsdCMDg1oStuyzfDNF04vwnLrJA5ZJ93z?= =?us-ascii?Q?s/UZl7neL4kwi7TdytWUVK3+vWNDd77SR4yRWOAVq68ev4lvk4vYVegSC5Gx?= =?us-ascii?Q?EdX6XcG3APfmbLU4aWkOK5agrEmnT38lsrzgvOdN6P1eJFiE0CHOblF1mGn7?= =?us-ascii?Q?q5k3uMYwjysE3a6w4eZSBqY2bqM8AJ7n5RfPFBmK29OVKN5Jm7gq7wgDYLwT?= =?us-ascii?Q?hFuzr9jxlrVsTHdfC3owt80uOXepfEfeLPVBZL4sb79TdD2rZLKnE8WzfsMk?= =?us-ascii?Q?okZOsk8xlvvZiGEC///kUbW8QHekthzQCZxzAMDQoJ7DHqP37nV9BPZ098TL?= =?us-ascii?Q?dp09PGauJk0xk4Kv5a3dLsJILxklgQRV3zuJFGCsc0CvIDXS45dUnZme+nFZ?= =?us-ascii?Q?7ZE2Nx5hQVIb1WG7DqFtyCTe8/v8pw8lkF3lelmY1f8u4iLFv9LgBtMTdNlN?= =?us-ascii?Q?o6NshkeEcMVrqHQ/2F/Z37VYLdc4mj+TDsHB125n1GEGvgw5XX1mSLB6sxUg?= =?us-ascii?Q?Fb/Vip3JMOcHnwAmDQXHdPK2IOhNTOdNF3oqm6drDDe1ovzE10YfuzGNwOh0?= =?us-ascii?Q?cM3+oK8Nyz/2UCcnqGcHhLZP+L5g2akqs8rn7yZwEknvR3l1ANy9WRaUD7Ao?= =?us-ascii?Q?gXTP0rZUNnv787cIsH+mUMCoQqOreBDwBTmVMXnGFFAtn7WvFDchkYTY92Ic?= =?us-ascii?Q?y24vZhyx4wIfxg4Qm9dkFjXxot1rqT1mLxXAc0dQcHoTqebs+YjMsITLOxuE?= =?us-ascii?Q?t2t85zTmLrIcWQAhkw7OHa4uFHGXQ0sD2BBB5kb14taVL/w59IrZOSG2oRXY?= =?us-ascii?Q?dxzbzPD/oljf753lqCKP7S0jGWGiFvXBsxie6Ftc31zF9pMWy03pt58snwRF?= =?us-ascii?Q?plqhOe94K6+VKcquUFFWsxKVpDGmAjPQIkQW1ZO9uTKwoxXQTa76bZkmmi/z?= =?us-ascii?Q?plKvny8qBdqDrX6ucwfXyXLC2LeMdstptKXYZzqOhxbKyXbuItctIYQOHVay?= =?us-ascii?Q?M/E99+wc97GIDm3N+Lj0NrRLAslFYvQQAI51c+GDrDU+zV6yhkx+Pd2SAr9A?= =?us-ascii?Q?eHXnRLmDGN6N3yEMPyzlYqz74SE9at7Li5Ox6PTL2BQtLN3bpEMnC13efU2Q?= =?us-ascii?Q?r31dnCL7Lg8eoBKxHEn9koCI7Hb07zeZ/dP439hHKvMhon6aL7UDBHZDVQy5?= =?us-ascii?Q?7t7LOOtH1zJckCSvSa6F7mhdUIewW1maH4skEl0zskMirNg5NrPkiDNjTTtX?= =?us-ascii?Q?AhQUVKs45Jy1Sc2jVp6zt5P4SDV12z5GICH647+jnYeBgJhIk7FnyeUpyu06?= =?us-ascii?Q?ZEsF9q/NdfHJWQZqSA5ORWhKmMS4v+zaRsWZbyLZiopS+Dn7/+Zjso4J2yMO?= =?us-ascii?Q?ZXj3D1NGvHLQSW84POLmlG09ygmPPfG91YD3hpXiEa2uQdSRKn69urZIof1M?= =?us-ascii?Q?hclfOotttTA+buDbdCdGW3PgzgZxPz36RlE5gKdvY2ympIOYIMkjN0aamlOm?= =?us-ascii?Q?glWMHGUgWKRqhgbrAgTk2ZqtMYJhvmpxzRzwQQHEhP78bxhPAY0+JwwH78Zb?= =?us-ascii?Q?sdgDgIqF4mwZFr+qT/q/jieeCRTOVnL3hNn5gdf534p2pQNXRW0FRQr8EMM/?= =?us-ascii?Q?j6I8Mcji7DlLvs0JI594GvhoPTNAGqBcHYq5ododEk19?= MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR21MB4619.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 39285464-11fc-4a62-856d-08dd929b3d1e X-MS-Exchange-CrossTenant-originalarrivaltime: 14 May 2025 03:55:59.9298 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uHRwC13IZhXz8f6oPcFjnvHRAusPHTj3oVpyO7oIC1uX8KQmAPU4InjXy5uc8IleEPOR9KCfWJv19h5hV8e4Jw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR21MB3598 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [FFmpeg-devel] [PATCH] Boost FPS and performance: Optimize vertical loop for cache-friendly access [libavcodec/jpeg2000dwt.c:dwt_decode97_float] X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Chitra Dey Sarkar via ffmpeg-devel Reply-To: FFmpeg development discussions and patches Cc: Chitra Dey Sarkar Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Original Implementation: --------------------------------- In the original implementation, the "VER_SD" section processes image data stored in *data using strided memory access in a vertical fashion This leads to inefficient memory access patterns and cache thrashing due to non-sequential data access across multiple inner loops. Proposed Refactor: --------------------------------- The proposed refactor replaces this by allocating a cache-friendly 2D array buffer. This change eliminates strided memory access across the three inner loops, significantly improving cache locality and reducing cache thrashing. Additionally, the data is transposed outside the lp loop, which allows for efficient per-line access and write-back to the l buffer, further optimizing performance. Performance improvements ------------------------------------------------------- This change results in a substantial performance improvement Sharing the FPS data benchmarked on our end for the file 'Tears of Steel' using HandBrake Device / CPU Model Official FPS Optimized FPS % Improvement Surface Laptop 11 (10-core X1P64100, L2: 36MB) 3.18 6.15 +93% Surface Laptop 11(10-core X1P64100, L2: 36MB) 5.16 7.31 +41% Surface Laptop 11 (10-core X1P64100, L2: 36MB) 5.57 9.21 +65% AMD Ryzen + NVIDIA RTX 4060 Laptop (12C/24T) 9.97 11.22 +12% Mac Mini Apple M4 Chip 9.00 12.00 +30% ------------------------------------------------------------------------------------------------------- --- libavcodec/jpeg2000dwt.c | 72 +++++++++++++++++++++++++++++++--------- 1 file changed, 57 insertions(+), 15 deletions(-) diff --git a/libavcodec/jpeg2000dwt.c b/libavcodec/jpeg2000dwt.c index 9ee8122658..45d7897893 100644 --- a/libavcodec/jpeg2000dwt.c +++ b/libavcodec/jpeg2000dwt.c @@ -409,6 +409,15 @@ static void dwt_decode97_float(DWTContext *s, float *t) /* position at index O of line range [0-5,w+5] cf. extend function */ line += 5; + /* Find the largest lv and lv to allocate a 2D Array*/ + int max_dim = 0; + for (lev = 0; lev < s->ndeclevels; lev++) { + if (s->linelen[lev][0] > max_dim) max_dim = s->linelen[lev][0]; + if (s->linelen[lev][1] > max_dim) max_dim = s->linelen[lev][1]; + } + float *array2DBlock = av_malloc(max_dim * max_dim * sizeof(float)); + int useFallback = !array2DBlock; + for (lev = 0; lev < s->ndeclevels; lev++) { int lh = s->linelen[lev][0], lv = s->linelen[lev][1], @@ -431,23 +440,56 @@ static void dwt_decode97_float(DWTContext *s, float *t) for (i = 0; i < lh; i++) data[w * lp + i] = l[i]; } - - // VER_SD - l = line + mv; - for (lp = 0; lp < lh; lp++) { - int i, j = 0; - // copy with interleaving - for (i = mv; i < lv; i += 2, j++) - l[i] = data[w * j + lp]; - for (i = 1 - mv; i < lv; i += 2, j++) - l[i] = data[w * j + lp]; - - sr_1d97_float(line, mv, mv + lv); - - for (i = 0; i < lv; i++) - data[w * i + lp] = l[i]; + + if (useFallback) { + // VER_SD + l = line + mv; + for (lp = 0; lp < lh; lp++) { + int i, j = 0; + // copy with interleaving + for (i = mv; i < lv; i += 2, j++) + l[i] = data[w * j + lp]; + for (i = 1 - mv; i < lv; i += 2, j++) + l[i] = data[w * j + lp]; + + sr_1d97_float(line, mv, mv + lv); + + for (i = 0; i < lv; i++) + data[w * i + lp] = l[i]; + } + } + else { + /* + * This array alleviates cache thrashing caused by vertical strided access across 'data'. + * By transposing the data outside the 'lp' loop, the inner loops gain sequential access, + * leading to substantial performance improvements. + */ + for (int lp = 0; lp < lv; lp++) + for (int j = 0; j < lh; j++) + array2DBlock[j * lv + lp] = data[w * lp + j]; + + l = line + mv; + for (lp = 0; lp < lh; lp++) { + int i, j = 0; + for (i = mv; i < lv; i += 2, j++) + l[i] = array2DBlock[lp * lv + j]; + for (i = 1 - mv; i < lv; i += 2, j++) + l[i] = array2DBlock[lp * lv + j]; + + sr_1d97_float(line, mv, mv + lv); + + for (i = 0; i < lv; i++) + array2DBlock[lp * lv + i] = l[i]; + } + + for (int lp = 0; lp < lv; lp++) + for (int j = 0; j < lh; j++) + data[w * lp + j] = array2DBlock[j * lv + lp]; } } + + if (!useFallback) + av_free(array2DBlock); } static void sr_1d97_int(int32_t *p, int i0, int i1) -- 2.49.0.vfs.0.3 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".