From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 469A643C67 for ; Wed, 27 Jul 2022 18:13:48 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 100E568B90B; Wed, 27 Jul 2022 21:13:46 +0300 (EEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2047.outbound.protection.outlook.com [40.107.94.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 38D3968B646 for ; Wed, 27 Jul 2022 21:13:39 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hOgo4IBowVdKdn3ScGBqNY8nNMRNpdwMEqqd7G8MGJfH4MPFaSQ2S3EpLnH+OqW1D4Jr4zkDd/KE6TMzTz3Boq8KkpSjlC2Y+tIb8RMH3xS6jnjrmz+0PskEQvjiynaHS1Yjcdua6VpVwphJRPI3pzNo5rC47ZQcuCSpZ8CZdEoR4ZfF/jAnsGS9dA4CJKENwdUrt+qnNzT+phVR8BRa094XgIil6PnAguEFsTp0Ucfnie+rNfkN4k5vRPJEgb+YQENKshw4vWI4y6EyqDP2cCkpeoJDhinZl/kjbqF1FOwMv6+NTjkH8PX5zjzpUKZrA1QAlD6ZzkA/lTEVcNvmEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yYpQMQdVlBnWDxKz9xkL5NqsBb5UFBfQ3J8+m2UTjNY=; b=Swa4vYaGamibuRcbyYmT2+goovqBYMskJ1Hx2VGr1U3SHZoZdSFA5bJ0ZY3qwldpGy14/TRmYSvnJcRVf4qRt3dFUmUYaz4d0JrgyPeDVt+b+SEE2JM+8caO1raHVaXAmj6NInrghCjWRXhHdoG2APtw6PTclS/7R6TPzi7eQTMD9u1f2iJrFhTdrhpj+sCWvTG8TKk7gG+ZoxwP0xPA4hnUqn1TGeGH2mcAdB2nbH2cJ+qZ7vuU72lGFhzruVd3TcTUkI7oIR7CENkeKjLuh1jVfNisxZFyW9hLEk6h/Z/0DoWFmw7G/tktfZiqFiBo6d4U74+URLpUlTSczu3oLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=genetec.com; dmarc=pass action=none header.from=genetec.com; dkim=pass header.d=genetec.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=genetec.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yYpQMQdVlBnWDxKz9xkL5NqsBb5UFBfQ3J8+m2UTjNY=; b=cWxnlN7Be8SfCj9ISOaDynR8wKQ6XsMEsKx1ot5jtqvnMDVEvbyKxFKcDQ9SWSNXRkUkKKtc63wTU/YNitmjS0YpKyAq1VFr8SDKtAkWG5zY9U9UfzsWT9lgFjCbDbnaX/lf2sVDn6eFGC9bmTEPvdA2zfvB/SASjbj0FIhGzpU= Received: from DM4PR18MB4128.namprd18.prod.outlook.com (2603:10b6:5:38b::11) by DM6PR18MB2378.namprd18.prod.outlook.com (2603:10b6:5:15d::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.6; Wed, 27 Jul 2022 18:13:35 +0000 Received: from DM4PR18MB4128.namprd18.prod.outlook.com ([fe80::9905:dcb9:da51:4391]) by DM4PR18MB4128.namprd18.prod.outlook.com ([fe80::9905:dcb9:da51:4391%5]) with mapi id 15.20.5458.025; Wed, 27 Jul 2022 18:13:35 +0000 From: Julien Vary To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] Adding av_abort() : adding custom handlers for abort(). Thread-Index: AdihM3vPBGgCa10HQDiOIdb5/ojUOwAnpe2AAANxQYAAAI3qcA== Date: Wed, 27 Jul 2022 18:13:35 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=genetec.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 95f3760f-ea0a-416e-518b-08da6ffbb8e9 x-ms-traffictypediagnostic: DM6PR18MB2378:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: U67cTmu74Kj9RCiXaiyGebnz0j5fHHChoAMXFHxnxTNuqKfNg9XUAEDzMrOy4o+K9ke+JrkRnN7RGQQ2nPI7ALCQ8GJivLFOsZgcQOztWgwrK6EdkaXeE5dp0q6ThiBZdaPfn7/klZNGYum5sPXOnvxG/K55A+NSGH93OyoWsJx2iIGryWnE7UatpVWhur1tJA8HhUgcjTSfMjPg6uZQc7PAnb9bRcB+FmRo2ikWbXA51ENIFxi08lHAnFu959fdBBhmpvmzsIBVCArs3AHp3mJcJvCbAw4r8eDP2NIaBMql+/YDuh8IKFfVY96eKGNNWcsFd7ZxhbuxFAOENYhxHNY0LCmmFHXsTYvgP6oivyBttVY8dq93HNqSR+Tuz2/b0WcFYGShWfPl6Jwknei/Bm4k9WA2J6hH/J95K0dM3dF1FU44FQf1L0HbB00q3ZFJ5mROd3P2xayU5mPaJYtFy70BoMlc18vwz6TKEciA6j+w+eUWyXHsMP5HgR2mFaxPKS9/ZEbnmMs/E8/8447Wo1ksKuCRYk/Q66sg6P6EefeazUNWfLDr3VMI0mggsF/QolyUzN7d2nyMCDUgLJuLyn4QltHDTWqNkEaw9YUGefN6jHiz5dPLX2EOtul6nsH8e3dKZTnduHp2JpJrmghiwYlla3ev5yq/dMfNdnyhjtq3SREx79tJBnhxiZkh+YUXdSofnAzET3fHENcPRWlsKjuKfeLBKYjikPM1FP4InJuPxNa9Bjpwe3Lk8w2seW+gQ4qx2Yxe0t8kjrgceTKq8SLuITu7a4tWAtP1xWozJHc= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR18MB4128.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(136003)(39850400004)(376002)(366004)(346002)(396003)(478600001)(9686003)(6506007)(7696005)(41300700001)(71200400001)(122000001)(186003)(38100700002)(26005)(38070700005)(6916009)(4744005)(8936002)(2906002)(52536014)(55016003)(316002)(64756008)(5660300002)(86362001)(66946007)(33656002)(66476007)(66556008)(8676002)(76116006)(66446008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tLMx0afYtnPiEsohOo6NKefRnhy0w66pJsYIQXx9SqvPaHdAhqq07f2rOlWj?= =?us-ascii?Q?XRnqcG42CwHkOmF7m7UxYI1Vay8UYnftwH9VeejsS2q+94gYv6TFi/rkF5BC?= =?us-ascii?Q?s5B1wvZ4Lt9F+6jWEb89sr60+Q7/5FsZDS0UBkcMAWc+EuxyTGwiPlEZIrer?= =?us-ascii?Q?L8W6y/nzdvGiq/LG7qiP4Fb0cc1cixK+MCVH23FDQUBF7FZUPpABRL8ucQU/?= =?us-ascii?Q?BW6D6KnMWOO3strkzmd4vTmNN7VlFLfsrdRgQ0X8a/8m0yqUk82nRuw0SZI1?= =?us-ascii?Q?bP+yPwNZgl1nfgGnVvrOT2cjtLO01oQHvuF05WDvDaInUsGDq+d354Kt/QLN?= =?us-ascii?Q?IipaXLvy46xV5dIXYf0A2pN70+dPsTOyStDsyvQI/Th3twmnbkTQLuIWkfri?= =?us-ascii?Q?5/wGYMjc179Rh8aMESLxxAtKN14xw+e2Gd43g20Mp4MR7hDYMLDbQ8KvzLqD?= =?us-ascii?Q?J3TKVrGNjO098ZZ+eLyWE1Nh0iRtymlyiTjLcTDhJKcojhFc7MQk2AteuVgn?= =?us-ascii?Q?0+wR3lVgzWh5oiTbMm5rtJvEgYLzynojKMKSJcaLx7NuLUK4eG9L1jMYTRsW?= =?us-ascii?Q?W8U7NP+IscR+5KfexteB26JEG+oS+ZQtMd1MVUqV4spmPsYSnNH2s5a/11mA?= =?us-ascii?Q?6qAjGLSp1Rdr9Ojv1cfPg6g6pDtBDEMROD6AfHvJqt+42yVz0wcUpBAuwLEb?= =?us-ascii?Q?5yibRgHtRWppzV+JhIOMaUFzjgp/vAIedvbUOJBI6N1ImnDTO+q+O8rAxzEk?= =?us-ascii?Q?/0kzz6zzgj/ZrMJcdrtHfpojVMWHbBdFKtmT86KAHCOcSbuhYASUwSKkIAZp?= =?us-ascii?Q?DmeRhr5S7hjQjVJvQVikObZuWAHqRfWj2zj4BvZZDbWnb7ZGH5qDH/1blyCY?= =?us-ascii?Q?p3eh9M41qHR8EYYPOFLm0foJWohLrzzQ2uS89TyEV9Re++iRcDVaou0TeoR3?= =?us-ascii?Q?jJE49xDSC/DLQfjtdaIb6UM8ZzxIEQa78xEj5oX92cvYKwzGmRLLiX7ZhWFH?= =?us-ascii?Q?/gB89X3eui8dKJ1dfVle8MKtQQWLCkDyJQX7eURYWlYacxbDFRRyD7BviHlQ?= =?us-ascii?Q?wp3ZySqEyo7fq+nQowgpPKaQBCS31NrUG5hVGWqBYN0V7iPx6TZWnyP64y0o?= =?us-ascii?Q?yMMr0b5bVTN6pHSQpXl/zPWhF0d50x3Bc5ZMCqmg6YFGBCrrpk4xdxIw1afA?= =?us-ascii?Q?q1oKw7QAZUQ6whduTF9UhGa0RnHJnvv5M6xTNgiTrCCqSG6uqEyywZlh8ixM?= =?us-ascii?Q?xOe3JOt1fk9xwkLgewXORQGmMqxqRdjoK+wHvhdjpxENFbUO88wucvvKUydp?= =?us-ascii?Q?5dmpD6Mmt+U0YRhjfWqH2vtV4b9s2xzhteRFU0BNyr9ZTKPwOCuVI2tmtmzv?= =?us-ascii?Q?/MGsNqMxFZ5aMFSTKSashmbzFWA8UPFVdj2Xc23VFnM9nHfdMaMwdGoFhox/?= =?us-ascii?Q?gEhoub7MBnXN+Q1jnb9a4I9C4UV4z7qyam13wwNbecUmZzf89u23gqdQkcFk?= =?us-ascii?Q?5bRNA1cghBf205qmIVCSOrvfhyJp9CUdD5/DUbbcoq2TjO8gD7tIshXzhGxy?= =?us-ascii?Q?j1ne1uF8c2e1xez7Wcw=3D?= MIME-Version: 1.0 X-OriginatorOrg: genetec.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR18MB4128.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 95f3760f-ea0a-416e-518b-08da6ffbb8e9 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2022 18:13:35.5963 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7ba8d2fb-4660-4a19-802e-4d015a17e167 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ppGFPwi85ewse13U/LSj888TPht9GPun7CqVAV1VpMWlM2tr5EUiVD2NxREaXectujVtyyphovvbi+yO9zCZqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB2378 Subject: Re: [FFmpeg-devel] [PATCH] Adding av_abort() : adding custom handlers for abort(). X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: >> abort() should generally not be in a reachable part of the code - not >> inside any of the libraries anyway, ffmpeg.c is a different topic. >> If it is reachable with any input files, and not just present to shut >> up compilers, this is a bug and should be addressed to return an error >> instead. >> >> Therefore, we should address those cases, and just leave abort as-is >> otherwise. Nevermind that av_abort would need to be a public function, >> which sounds like a really bad idea. > >IMHO abort() calls should all be converted to av_assert0(0). Or is there a use case for using abort() directly? I don't think so. > >Or maybe we could add av_abort() as an alias to av_assert0(0), which eventually just calls abort()... I agree that if the goal is to bail-out on 'should-not-be-reachable' code, something that alias av_assert0(0) seems a great idea. Shall we then give a more descriptive name than plain "av_abort()" for those situations? Nicolas George & Hendrik Leppkes ? Your thoughts ? _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".