From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4EDB04217A for ; Wed, 27 Jul 2022 16:53:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4FD0768B8C5; Wed, 27 Jul 2022 19:53:04 +0300 (EEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2042.outbound.protection.outlook.com [40.107.223.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9FFAA68B72C for ; Wed, 27 Jul 2022 19:52:57 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PiMq5NNWBLqavduQVodB9M93pkvC0HP40zhNJtIecaYdxIgMxfG1H0cvXTSXwb8UFo0B1ov0wcrpJD1MYm6iR567okwyFTets+3QIcHdB9UFp6fffB7uoRqt3kmYvpWe02LCNI0/6GK4IsQwuOwgNRwJU/MgMMblvG82BF/GtLbQCf5k6ZXNGE+enh6BNqVPuS6LUEArlYmdmh6EPOJj2iJ92oRfUDqKJxgem9AWbpPjH/bkEeZRYH+e77bbAO0CA7ygbEUfZZhHnVLtlGp7ZvZujYVXhOS2cWbgo49OCGlFdbZe/F51v1N90th4mAgo2FSx7wn9bOR4wXtmM0ybUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OjreXpHCmR38T+Vxm/odoHIhAW7uC6kOgu8i20loaW4=; b=RUMaQoTVF+Q/YJY4eabglJWGtIUc1hl5cxnbrYVadGQTn4NgO7ChFzN7eQZxBcAyRMwBLkIFa4J5YGgqscFfDzXSzCIRDC4Y0DKwcZHcPF8ME35oEnqQUqILST4j9DvevBmO4/+LTbJjfkRUr881bmSGV6xpzdmI4vTQVxut9lxI14xzKUbM3MfMCEZxAvBtoJ0cOgTRqhIzVntbnrcuLMjawU+/gQ60SNJy/UrngqIFto5XegF2lt1/JUE4jqBhuiOH0v3vCpgb2lHBld2b00R4t0U13TV3OXfSFIAkAHAxGbo5FGwvqy+X9uZ932CfmhyK5evKTPRnSjrDo8ILRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=genetec.com; dmarc=pass action=none header.from=genetec.com; dkim=pass header.d=genetec.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=genetec.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OjreXpHCmR38T+Vxm/odoHIhAW7uC6kOgu8i20loaW4=; b=Xp2/mjRzY2rYlLZ+ANI4Ttw5QBE0G7xbQwcZ2c+DASTiRELoZJl/KeDg9i6Q/53yPbdXRgiF3omDog4Wkgf24s7DTZ/ydI7dtOKQuI3fQwdR3nX5Y0GemHv+Ubv/UDnZpe27awEu79fNYSC+aDW2za7Md6DqxEuAW5w2Y165Y64= Received: from DM4PR18MB4128.namprd18.prod.outlook.com (2603:10b6:5:38b::11) by MN2PR18MB2511.namprd18.prod.outlook.com (2603:10b6:208:108::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.6; Wed, 27 Jul 2022 16:52:51 +0000 Received: from DM4PR18MB4128.namprd18.prod.outlook.com ([fe80::9905:dcb9:da51:4391]) by DM4PR18MB4128.namprd18.prod.outlook.com ([fe80::9905:dcb9:da51:4391%5]) with mapi id 15.20.5458.025; Wed, 27 Jul 2022 16:52:51 +0000 From: Julien Vary To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] Adding av_abort() : adding custom handlers for abort(). Thread-Index: AdihM3vPBGgCa10HQDiOIdb5/ojUOwAnpe2AAAEjEYA= Date: Wed, 27 Jul 2022 16:52:51 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=genetec.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: de8451a9-705b-4a3a-1090-08da6ff0719d x-ms-traffictypediagnostic: MN2PR18MB2511:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NFHXY7/s26pDqWI56HMJVzbeHBTQo4QGtmXNfvMGu9d/MqEmLxhIq93uX85nfofN6F8J9pQf1/JFJzPr9vJga2oZsHP2e9Vy/VXDTYCrnjbklpfttXF+LzUwEb1ilqhw6uu4XHVXKg6cV7toGfCHcNVo/A2+tRrDUcQHy6BbWrDi/wT4LTL2t6w7P0ni9qFeny8rpt5Phd25o7SB6oWXumDm+9ezI3B6ikqybH1SqYrTw2qyRs4Ny+b2BRwRcVJ7hPXGv523nSuFysRcWCWr84qtIr8yl+cgu3rrs3s0nypstGvlvfV2KFXwUqGvUNYY90XN575DxdJKTjllPQ+Q8O+MnPczhb5oYx6KqUbuvE9TfgDj6gsaD0J0NCaWuFuO4uMiEs113xRE7zS8Gg12K0YMnSjsC3gbMlUx75qzdsmjgNqY7/VR82JZdclLFD9DvLEmgcnEXx0qSzgKlHdCbYR7SHrgInr1ccClBLKwiUHjRlsMl2BJ1IyzbvY2JaaJDjFt/jPf1afn0G+Ygw86iZfcpi/62sSfUwwsrEM4+Viu2qywBAVHRby2VI/ApI7ACC6AB2J3/BGo10v3zlAXAM6owCbPT4FAmz/NowpcQq+1sQSamBGT/S+NCv11bEz4gr6d86I52pTGJFd7M6hXjKagia0PVTrRiYt584m/mssH7JJO840BUiswwX1RDHlA9cI7VSYlV7NITmgpSGWElwm2Y4lP8byRRUjWn8NDPgSOMiup+k6ZHdx+YLsyLDUsM4DFsGxT9BdcNbwrgMp/H8lJdCm439v67ISK8vujgmxIBP8p7/s0ULyM+yI1oVIq x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR18MB4128.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(376002)(136003)(39850400004)(366004)(396003)(346002)(38100700002)(71200400001)(316002)(86362001)(122000001)(33656002)(478600001)(41300700001)(7696005)(6506007)(6916009)(9686003)(26005)(55016003)(8676002)(2906002)(64756008)(186003)(5660300002)(8936002)(52536014)(66446008)(66556008)(66476007)(76116006)(66946007)(38070700005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VOKY68Osu9rSqNYcv9pPPXMMmovHZ3O+v8LR2WCySL6cePHwOVIbetUgm93W?= =?us-ascii?Q?WZSkgUwAE1GIvxzz+s2oZSR2DObjc7ucS6/nJzaWE0t57/q2pFnl7qjnV/A+?= =?us-ascii?Q?aKBndIrtIw6BY8c+vsUBJKX1R9Ewbqoias9aZdaTLiV2rJtkfyuIusUZ6uJA?= =?us-ascii?Q?2LlOTFh4xdROT/+gc1BGdZ8HWlX7Jlg9APWjq+SmaeQjXlU76QV7XxebgJq6?= =?us-ascii?Q?e9bJAiVtOt8OjCah+gWHmtmnrlfJleN6Lf66K1C4qrI9G2DlFACRRWgqP76x?= =?us-ascii?Q?3LiTjocgByiZNHzhszhU0hJ0GSg4Vy3ZtTtBZK/kjzv8bwNvFUQdF2ePMrzo?= =?us-ascii?Q?3YKIdkDY6WqXBTi3OTsOgCpwpw6dSclb3nsiGdEJZduknI3TuDsUPxhc40Ju?= =?us-ascii?Q?JWhHiKp/+lNTQOSWnsT2vEsLETrWiJG09+zy/m9Bt9icoNfYt87eG+El+6mr?= =?us-ascii?Q?YXBFzO2kIjqFvDNyj1/E6lnbz+bZl+BoZtC+3Ye1YZi8cx+J8YcP0Qix3NoK?= =?us-ascii?Q?s2Z4YjgRaZO5PGr2CLda42G1DkRvx2zE46d0fQGzO+WA+K5Fdj3ObsNg2eLZ?= =?us-ascii?Q?9tm0jwXxVK30bO36DoENPf+L06N8EZKmyG4GUNwqyfHTdtWBbFQurgtGyn70?= =?us-ascii?Q?Y7iRnbQBDjL4SRxXoXVVT04BTAONcTowUKY/gKkqB+BZd5IQtn7qgV+pYEvd?= =?us-ascii?Q?N9WVSPtkLlqm2vWTp5xCDlCoQV49xvsFLSy8jwz3G8TABacywK2YUUqM90cc?= =?us-ascii?Q?UC1DlswVscTHL2QuNZjCik3LaSlTTgF50NaXCXU8c0ZJ6ZqyUFODNa2gKkXO?= =?us-ascii?Q?rHSvurVSxrHXqU7evXFZBFJ7ebaqlmwSh+BI85+mBO6c4fhgBIY2F7AFLxnp?= =?us-ascii?Q?iMA9D2UxD4bSMbH6od4KXzPWZdHwWAwHgMFWE/dB8WsNExE8pniHzdS0Psm7?= =?us-ascii?Q?Qu69HHr9j0eSMpYsJsf/9mUYLJzZS1dd5dhj/N9J/TwfLeeObI0AVpH6hbLO?= =?us-ascii?Q?O9Oz2F8qiSXEDiQWEskInRthxaM9ObCvhujI1Vz8CMP1lPjVfbf6O9RugcT7?= =?us-ascii?Q?CEmcTqB/Qk/dkezy5VMn2z7qEO6oBhMLicj6qCkgq5r+NsQ4obLJ5nvaDToo?= =?us-ascii?Q?PJSTvib8jpRd9h5Ue3wgC0F49Qn6vQhQ0LSHEXt6DJD+IcNA/W7+oxPtRJvP?= =?us-ascii?Q?nWPedOIaoTyr6QrtvQc7xq/1E2YGYmjhQneBvhDDHK5lONhfv66ioQz9cv22?= =?us-ascii?Q?5aJ/tB5rGuh10g6Wi1MYNkWBaZk+ZexRqrQldjkJO36jAgY8LPDUDUZnCxwc?= =?us-ascii?Q?k6rJ1Ste6iFu6ZYF3f7fsZJnAbM+Te9mEhuoRYGqa5snL0VCQmRcLixv2sHG?= =?us-ascii?Q?XFXVOLrV7dIiShuiloD8lOsUrvBlS9u4E5mpeZq2U6bhPUWYXbG76ejpyw/p?= =?us-ascii?Q?ac24qbOnHMf7RrATHEOOMawysWqlkeIVx05HMoMzJ2lLRtfWaSVH+V6+Q+NG?= =?us-ascii?Q?bah3Z+lHbpAwFHVbF17vYnOcGn2sJ0oYdvAjm3zYOHMxfgy2QXe6+IbXF71Q?= =?us-ascii?Q?twp3+khYllqmWSemddE=3D?= MIME-Version: 1.0 X-OriginatorOrg: genetec.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR18MB4128.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: de8451a9-705b-4a3a-1090-08da6ff0719d X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2022 16:52:51.5143 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7ba8d2fb-4660-4a19-802e-4d015a17e167 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cKEKJVhpavKPv6STyIzYUSwVchUJaqgMHIbdJV+Ij8oXnlVkRYOJhMaA6BM+weKZU3HabqpBOEmj2XS2Cakieg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2511 Subject: Re: [FFmpeg-devel] [PATCH] Adding av_abort() : adding custom handlers for abort(). X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > abort() should generally not be in a reachable part of the code - not inside any of the libraries anyway, ffmpeg.c is a different topic. > If it is reachable with any input files, and not just present to shut up compilers, this is a bug and should be addressed to return an error instead. > > Therefore, we should address those cases, and just leave abort as-is otherwise. Nevermind that av_abort would need to be a public function, which sounds like a really bad idea. > > - Hendrik Historically, we had issues with the abort() within libavcodec/vlc.c alloc_table(), but possibly those are now fixed. > A program that terminates on abort() does leave a core dump, I just checked. > > Nicolas George We had a different behavior on Windows back then. Now that we can compile ffmpeg with VisualStudio (instead of cross-compiling with gcc on Linux), we will try to re-go the route of SIGABRT signal handler, and see if we got more success now that we have the same C runtime. (We had a custom handler to create a "full mini-dump" with dbghelp.dll) Thanks to make me realize our problem (and solution) is now potentially obsolete. Julien _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".