From: Julien Vary <jvary@genetec.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] Adding av_abort() : adding custom handlers for abort().
Date: Wed, 27 Jul 2022 16:52:51 +0000
Message-ID: <DM4PR18MB412809D43E70042A5ED78C2BB8979@DM4PR18MB4128.namprd18.prod.outlook.com> (raw)
In-Reply-To: <CA+anqdxt56psVfApDHLf2yKz3NZ4VedJ2s5RiO+a8+htWcB+NA@mail.gmail.com>
> abort() should generally not be in a reachable part of the code - not inside any of the libraries anyway, ffmpeg.c is a different topic.
> If it is reachable with any input files, and not just present to shut up compilers, this is a bug and should be addressed to return an error instead.
>
> Therefore, we should address those cases, and just leave abort as-is otherwise. Nevermind that av_abort would need to be a public function, which sounds like a really bad idea.
>
> - Hendrik
Historically, we had issues with the abort() within libavcodec/vlc.c alloc_table(), but possibly those are now fixed.
> A program that terminates on abort() does leave a core dump, I just checked.
>
> Nicolas George
We had a different behavior on Windows back then.
Now that we can compile ffmpeg with VisualStudio (instead of cross-compiling with gcc on Linux), we will try to re-go the route of SIGABRT signal handler, and see if we got more success now that we have the same C runtime.
(We had a custom handler to create a "full mini-dump" with dbghelp.dll)
Thanks to make me realize our problem (and solution) is now potentially obsolete.
Julien
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-07-27 16:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 14:02 Julien Vary
2022-07-27 15:28 ` Nicolas George
2022-07-27 16:01 ` Hendrik Leppkes
2022-07-27 16:52 ` Julien Vary [this message]
2022-07-27 16:57 ` Andreas Rheinhardt
2022-07-27 17:39 ` Marton Balint
2022-07-27 18:13 ` Julien Vary
2022-07-27 18:40 ` Nicolas George
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR18MB412809D43E70042A5ED78C2BB8979@DM4PR18MB4128.namprd18.prod.outlook.com \
--to=jvary@genetec.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git