From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C2A14495EA for ; Wed, 15 May 2024 09:43:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A281068D3A8; Wed, 15 May 2024 12:43:57 +0300 (EEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1C4E668D3A8 for ; Wed, 15 May 2024 12:43:49 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1715766235; x=1747302235; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=Kc9Y4dS7ES2BUF8TednAJAJ3XSexJlXh7jdmP8t6Iis=; b=LQ57HW6YLApeZS/QOTbw0dhJnemZFxT9zKlEBk9g3EUYXb3AglRpSdlW W7WxCuAX21xPtOfjnVFZxKRW8a0y/po2QxM/JD8M5Fjc56mpBWRlc+7bC 8MFWcUwIoeJB7OBDbVEpeQnASehaHGceO9hhGuo4dRJkgSHBc1d/yK6An w766wZF1Wu2UChYJD3/f+/t4MqhoYzp886dXMksFF5eyLqYUWhz9aA94k jWoPSmFx52kdFpRIunVN6TqdIoknO0uT10ai+SI+7/2eMrHU7cHlnVvBe 6jxpRkIQ508wqoIV9D2sNbyMfFKrtGEkbrjG1XB6JvYxWMWEtO+WT9wN/ w==; X-CSE-ConnectionGUID: ByNrnfFrSRGVqfA2zTutZw== X-CSE-MsgGUID: sGcuNu5cTceqZnkCoZ7Akw== X-IronPort-AV: E=McAfee;i="6600,9927,11073"; a="11635327" X-IronPort-AV: E=Sophos;i="6.08,161,1712646000"; d="scan'208";a="11635327" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2024 02:43:48 -0700 X-CSE-ConnectionGUID: /6lQZ6+eQpCWGemBqiPgjg== X-CSE-MsgGUID: WHkE7OTNRymFCLwcGIXjRA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,161,1712646000"; d="scan'208";a="35784408" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 15 May 2024 02:43:49 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 15 May 2024 02:43:47 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 15 May 2024 02:43:47 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 15 May 2024 02:43:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PapIN5/A8jF5B5sIIpD0HU9yFGB6xzWSaKII9izatJKjRLN6C7OGuBpHgf6zsxsc+oalV1ptUQliSOhcVNop5mMMX51MudkfL0G2aYLszxjGxb7ORY9keSl1bFoYzxzFv5UJ4qC/gB3elt6xhlNoD9Cc6oeUSaDIlUUpErhRPS0TJthURApAuzjq51lAHk87A1lDp7Cpuw2tNuz69Mcw5zQCmKL7uVsGg+HYL8+2iN6fldKAxoKPBbohQPV5AxQmjrTvKnt67MFQl4irenPOca9WhiE0aLpjDW8fDbf+q2tX1VF5Iiv+I+YtUmURsyV6YfJl6aiyb0dfWEdt2MAa9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=obBrqx7pSGi2TQO3WQHTZ/OkvNtbWBQxJuvnwSjUujQ=; b=L8NHfrMxkA5SakYlyOOx1qla0okQB/LEwsZA6l6cY1WA7jgLlnpATYFn/r/XUq8sZJzSCZ+6p9JBCzl/szamIXZIFQ46HABisdKlgPwdFTSFZETvXoLKRzODQI27YnHgB7Rc0BaFziDHaPOL8wOklRLOAMUceExvmICoGhhhASKoMYHdDbZ53z3qnsAwC+zAq+n1hAaYKE3WVxeZno0ui+sFSd/QdClDHd1FeDEvv1Yb53yIZcT++5tBcUYdgdY8R0ppmqyEwnZgl6DBOl5MFzuVaQo8mQBOGblWlkEIJUS7y/eQWGQIoVrDbuOwn5M+6FL4VUex5ecztz/TOMK+fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM3PR11MB8672.namprd11.prod.outlook.com (2603:10b6:0:44::11) by CH3PR11MB7938.namprd11.prod.outlook.com (2603:10b6:610:12f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.55; Wed, 15 May 2024 09:43:45 +0000 Received: from DM3PR11MB8672.namprd11.prod.outlook.com ([fe80::99bd:8f3a:2952:b834]) by DM3PR11MB8672.namprd11.prod.outlook.com ([fe80::99bd:8f3a:2952:b834%6]) with mapi id 15.20.7544.052; Wed, 15 May 2024 09:43:45 +0000 From: "Wu, Tong1" To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v8 01/15] avcodec/vaapi_encode: introduce a base layer for vaapi encode Thread-Index: AQHapjiySEcD1S+RCEqyPOVCoj680rGYC7Vg Date: Wed, 15 May 2024 09:43:45 +0000 Message-ID: References: <20240418085910.547-1-tong1.wu@intel.com> <4fe8403f-b8da-4a1f-905a-a9f0eef4654c@jkqxz.net> In-Reply-To: <4fe8403f-b8da-4a1f-905a-a9f0eef4654c@jkqxz.net> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM3PR11MB8672:EE_|CH3PR11MB7938:EE_ x-ms-office365-filtering-correlation-id: 57345d46-9009-4a9d-12cb-08dc74c383a9 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|376005|1800799015|366007|38070700009; x-microsoft-antispam-message-info: =?us-ascii?Q?FKlhJOgfSf/FvKLHzy5jshYzmjtvgLQ7kZLJZR7Jmuk2vjtAehuYjXlBJVUg?= =?us-ascii?Q?34mvFYR6EjjKBqb8mWYHxo/k2G+IiHq5nkWl9P125a7iUqt81ovpGjaCdp35?= =?us-ascii?Q?VLi9I0cKsyEkb2hpTPjTFZk09iOXaCOwhjmaeU56pE71Q/WBKKcPyH8J4j8U?= =?us-ascii?Q?CUmbQsuSADEYreEyPdWohlAY+Yjm3UKhSdei8caZcfP/Y+4m/R51NF9m6N9F?= =?us-ascii?Q?PVXXLVdMctdnw5z3wDLbv/AIUTC/6BkbrNVuBecbwQBNVIrFdPNMDOzCV201?= =?us-ascii?Q?UnEfXZGImr0ramqGJqy5HWM3M2d7ffsjSCqTQoXJy/3Q4cozRreRoYYXG7vx?= =?us-ascii?Q?MwfZxyYPxgCpEaDqmfbal/KHsCUyympvtmJ1wCBNBklZRjyZytOMCUbIAhJY?= =?us-ascii?Q?7vq1XHYLf9DTUVUEDAw0DKZ2qBdgQ0WkQ2hOXOzJEjs+2zedtN4S20QoRx4j?= =?us-ascii?Q?staZ1Xjg57XmH67hJVJDxnnp2w5xAerZsJ0pWthgBRp89j7jCQizLVM1X1e1?= =?us-ascii?Q?1vdFs4DRO3rNufjMr4iYkCyfT5dRq9zUZy0iZaGO5Rrf/OP6qI1fOA1NYij9?= =?us-ascii?Q?Umol7dbT/L9UAy91XZNVuiJr2GCu6IyeUfwPFNVtxr7jkI3C56cW1KL+Lz/M?= =?us-ascii?Q?nWFEXi7kAYQuoXP/+U0w8aneufuWVm4V8044RtMcsuGcn+NTrZPrlHkn6odj?= =?us-ascii?Q?yDDPNGGXpiPRJ85MpxMeXw612xTmli9KwqdKT5jvqdurK4gioCG5pyJnUcIr?= =?us-ascii?Q?HC32GuxUPIriGPvPuPmirLZjd5rI8qOAC7wpQywlnby/XS6bnVwRJ5YSVlzc?= =?us-ascii?Q?hoPtOr96K15lIb0xunhUKIwwKw/TpPbo9oJ+pLNnR9iGmh32OJhucJ0mOCDo?= =?us-ascii?Q?gCLpAsMPSF04izgJ+qayCzm1gSLwCeYDfz8KmKY9b6EsxTjs1U//z2JGkWuF?= =?us-ascii?Q?Y02MvwXtee/jrq9Bi6nH14/T1h1yzhD8mHESsaBTj8V5jZjSVZqRCR2Uo6ov?= =?us-ascii?Q?X62FScu0LLiVmQVl2A8nyJpEobya5EVBmjM4totGwmQucZ2mm3Zn0450h9//?= =?us-ascii?Q?4JQk6PDE75n5TyeX4v3WJRx7N2pU8r2QLtlee8WV/s10nxDRgMSJ7c0HsUy1?= =?us-ascii?Q?xB1JQTKtmWyZ2q/TqnuhchCrRbin0roC6oZ8PU9/nlRRpym/GKtdWBMWzULx?= =?us-ascii?Q?x/hNeDLtMA0x6Cx/WbbV7xP/0n0f8FysKxE1Yd3dqDZ2vVuMy7Ts6N6VwyeQ?= =?us-ascii?Q?QKakdO/RsMNK21IoFJSvqGFGLgjfMRUNKWW6HhAKfcAuf0fEp/gNEjBLv4zh?= =?us-ascii?Q?DoMTV65po/z6qdmKR3/I10EmLtnQNu0bwuM+dFz+aR1Icw=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM3PR11MB8672.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015)(366007)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uZAeweAt1ifZNFRaot6UhT0g3et03a5XiIxjmIlTpS0WfDAWeI5IJpnJGcTr?= =?us-ascii?Q?IFHKQmqelBs7qR03fwDiEC6z2rLQjJ17OymTryQFRGFSMC7nLcC3ScnEH8AQ?= =?us-ascii?Q?cQ1ZKQ+xcMqj1PMrGx3IsJOpCSCAmFFhPLkbV4tmfHB9bUJXOZjPP4NoEHNC?= =?us-ascii?Q?9cA4t94gMmxis7QwKJdYZAJogeSxYbsH2WgvYgDhJf3cUXDTyogLhj/FqtVe?= =?us-ascii?Q?hA9XkYnZcqC25AWh0C1xpGQFfAKJja2cMmDnU2yKnRLAQeC1ovF6I6HtJSlY?= =?us-ascii?Q?cClUrFniL9Oj76EDCR3o6+4Xp6Keq/S/3+xYyEk4DkU5kloSgzXMRjlSyaB0?= =?us-ascii?Q?23kwNzemctg0bskxZr3p/7xHwP8MjhSxTW4QDdf/SOPyCA/FT7KyGh4S60Oc?= =?us-ascii?Q?t9uWYrtOUJJ6KobIY7ic/fZdYCvh8+r0QziwzytbCEptP3KjYZraHMsRANtH?= =?us-ascii?Q?DiVVSkLo/1BfAbYTXhFUfiRkpAKl2zqao3NOMcwJEcTnm2hllvg0fyfvp19d?= =?us-ascii?Q?zrao1+RJeGW5Pth2pMkN3Cxaxmp8f0LzQeSPNYiMbFPpXoSJRxEZyq5p6JA7?= =?us-ascii?Q?Od1umOZRvRH7VRbV6TbuZpNlfvmWV6e/IJeGh+aljjZCxIZqoHdrxJ0C2+wk?= =?us-ascii?Q?ge7lWhb8o2+/VwWdpJCNsTuZqSM8R5I5/Z9V5nlxdS0zqYyjwyhuDsCbmw6C?= =?us-ascii?Q?mMLoTf/J89iig8BlO2/cP6oxA248jaEbxuv45VWwDUmCWIcVCoW4JDg62hoU?= =?us-ascii?Q?qszYJiGI1qkPDj7GeN+4FQo1K9LjsQJKrQVHwdqs5x+PDGI49XTdFgoLufY/?= =?us-ascii?Q?HncRMO12SBiXFgaPRpAGSl62Hz9lO1IBB57HS9czSQjHViq4z2+xEuZwmVu9?= =?us-ascii?Q?2SYP04Uabn03LFtHNzGPvK5zo1Xwr/qJ+aLQsHa026v7LLdz0yAQwE4xjo+3?= =?us-ascii?Q?gO74gxdGZEFOalFOs07UmUEF7CdTfNXodGQ2Xz7XO6pUKRxvv1gKX5xL2EVd?= =?us-ascii?Q?xIRJmngqkpxtMC/71lkKvKkSPTpmA8B2MHp45SFeUA2FQl+kltIoGca6+pSr?= =?us-ascii?Q?wQzdyBOK7SeXWaxsms6fqrbQbiCqWMtRxuBjS0A7UwHDWFstOXf/zL1fVNXA?= =?us-ascii?Q?PnEbHPxvLpelPDkN0yN5RYjvkHQ3+adt2bKzTwXEsSxfJmunfx9M2Eu06vgf?= =?us-ascii?Q?iKRY9aw6OR4BNrLLlciS6v4Fu2YEnHqZpM3geN6v2TTEN9fyr+HlnvB4n6or?= =?us-ascii?Q?LD57XF0jXk+2kYrWLu2FQKYgDb1MJ31POlrXsQB1jlNutYPLbPhS7z3pmGeE?= =?us-ascii?Q?y46/91BZkzr3gaW4BQ7nN0SrPmkPF47j7vdcdH5HxrwZWxN3gHXwuQF+8lO8?= =?us-ascii?Q?cJrm73IkqX8l/mTceVSfjfjCFHKdVraQO6zUNhHNK6Goe5BXNxqfy5pft1Z1?= =?us-ascii?Q?cQK4A55NzIe+LudauE8hdT9xXaKz8/9WcBW1DkNEEorS81LTI50obs7PvWGE?= =?us-ascii?Q?bfbThYPI3XT/I0AUVfSo1ua3jkRDTXNUUzx0dY3A/hPg6jdtPwFiMHhU49eF?= =?us-ascii?Q?lkZUzlA0UGN1BC6n/StIKyDc7ykEzqVOw1WWx9Mu?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM3PR11MB8672.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 57345d46-9009-4a9d-12cb-08dc74c383a9 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2024 09:43:45.5792 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: y7XnoPN64+ItcV4q0ATVHbEkCj3QI64Rm+BymXc1Aqk7/0w6dhhp7EuvbzueQc4tdE+uUFfu+ouZAUE9PlSXCg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7938 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v8 01/15] avcodec/vaapi_encode: introduce a base layer for vaapi encode X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: >-----Original Message----- >From: ffmpeg-devel On Behalf Of Mark >Thompson >Sent: Wednesday, May 15, 2024 3:56 AM >To: ffmpeg-devel@ffmpeg.org >Subject: Re: [FFmpeg-devel] [PATCH v8 01/15] avcodec/vaapi_encode: >introduce a base layer for vaapi encode > >On 18/04/2024 09:58, tong1.wu-at-intel.com@ffmpeg.org wrote: >> From: Tong Wu >> >> Since VAAPI and future D3D12VA implementation may share some common >parameters, >> a base layer encode context is introduced as vaapi context's base. >> >> Signed-off-by: Tong Wu >> --- >> libavcodec/hw_base_encode.h | 52 >+++++++++++++++++++++++++++++++++++++ >> libavcodec/vaapi_encode.h | 36 ++++--------------------- >> 2 files changed, 57 insertions(+), 31 deletions(-) >> create mode 100644 libavcodec/hw_base_encode.h >> >> diff --git a/libavcodec/hw_base_encode.h b/libavcodec/hw_base_encode.h >> new file mode 100644 >> index 0000000000..3d1974bba3 >> --- /dev/null >> +++ b/libavcodec/hw_base_encode.h >> @@ -0,0 +1,52 @@ >> +/* >> + * This file is part of FFmpeg. >> + * >> + * FFmpeg is free software; you can redistribute it and/or >> + * modify it under the terms of the GNU Lesser General Public >> + * License as published by the Free Software Foundation; either >> + * version 2.1 of the License, or (at your option) any later version. >> + * >> + * FFmpeg is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >GNU >> + * Lesser General Public License for more details. >> + * >> + * You should have received a copy of the GNU Lesser General Public >> + * License along with FFmpeg; if not, write to the Free Software >> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 >USA >> + */ >> + >> +#ifndef AVCODEC_HW_BASE_ENCODE_H >> +#define AVCODEC_HW_BASE_ENCODE_H >> + >> +#define MAX_DPB_SIZE 16 >> +#define MAX_PICTURE_REFERENCES 2 >> +#define MAX_REORDER_DELAY 16 >> +#define MAX_ASYNC_DEPTH 64 >> +#define MAX_REFERENCE_LIST_NUM 2 > >Is there a reason to change these from enum to defines? I'm not seeing >anywhere they should be visible to the preprocessor, and this means they are >normally invisible to a debugger. It was a enum structure before V7 until Lynne suggested "Define these, don't enum unnecessarily". > >> + >> +enum { >> + PICTURE_TYPE_IDR = 0, >> + PICTURE_TYPE_I = 1, >> + PICTURE_TYPE_P = 2, >> + PICTURE_TYPE_B = 3, >> +}; >> + >> +enum { >> + // Codec supports controlling the subdivision of pictures into slices. >> + FLAG_SLICE_CONTROL = 1 << 0, >> + // Codec only supports constant quality (no rate control). >> + FLAG_CONSTANT_QUALITY_ONLY = 1 << 1, >> + // Codec is intra-only. >> + FLAG_INTRA_ONLY = 1 << 2, >> + // Codec supports B-pictures. >> + FLAG_B_PICTURES = 1 << 3, >> + // Codec supports referencing B-pictures. >> + FLAG_B_PICTURE_REFERENCES = 1 << 4, >> + // Codec supports non-IDR key pictures (that is, key pictures do >> + // not necessarily empty the DPB). >> + FLAG_NON_IDR_KEY_PICTURES = 1 << 5, >> +}; >> + >> +#endif /* AVCODEC_HW_BASE_ENCODE_H */ >> ... > >Would it make more sense to put the HWBaseEncodeContext in this patch as >well? (With just the AVClass member.) > Yes and will do it. Thanks, Tong _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".