From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 0F7F64F509 for ; Fri, 27 Feb 2026 01:17:15 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'QUEX9pc2glvTNH74cWErl31ao+/AiM/pWaJItLetflA=', expected b'uHCGn5zmplk/Hi1wXAxnx82rku46Y3+X+9k/LN91IDk=')) header.d=gmail.com header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1772155029; h=mime-version : date : references : to : in-reply-to : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=NjTJweyz4a/H3u0vvx5SH1delCG1hyIbL+N/vQKnPrI=; b=1eKdQDHGiqpwE8MnNJ3ueq/qgPGjwIux/4B/mr29DH70rpG+axSCelbX2Kzio0YFwpuAD U661lGnFNlfm8WBrVq3jzJiR1vnfDptc5Vhp1NXOgK9F3viiw5qz75mJ/M3qhpjgFl+deWK 41TfZJd3OK385BSb2on9vypIzSoDHm0Qjs3Tup6v3JgprCLV7kHTGTWqFldYPXOA5IyNrRG GJg+EOpg6UBxN7AAond2UX4LWI7CQTmGi6oxy2O9gHrgVeqxggP5uRZCj+s8AIjTDyct2kp TvSjSnzSUU5K/+gORbrgP39Bu6C7HKtOF4FtUfv+NHi7q94hiFzfMH3Jq8KA== Received: from [172.18.0.3] (unknown [172.18.0.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id A3D13691357; Fri, 27 Feb 2026 03:17:09 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1772155019; b=hTinPVerUzUGEUQ9HUCi8RlRMqarb87fUvrXK5V/ThYxN8uPaBuEt+iRBf9EGLyTBkHkX KjTPkys4jo5647sWgEozBRxfFAdBEJZ7oXL4t6CJFYN7VAl+V3BxrXwl17ZGcuskOknTVea XE++tGdHzoqwpMZ+7FsvEqE3wqxKynQy9YTau8WH8G7mVvSnSGHj/f5Q6GTeZ27z627waSQ P0TPL1qCoQJUUU7MmeSm79VnnZZz/imaJ750ErdBnnaN6gubyK47ZrkwvwA9AkVke/yXnJW 1OYwQ2iNK9d2C+fupGK9tMsXaAZT+YNLvfsG/ruhifwmTa0Z9mS+X8ZTHj2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1772155019; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=QUEX9pc2glvTNH74cWErl31ao+/AiM/pWaJItLetflA=; b=DbLyIO2PwNDmjLVSlc3Ks8UD70rZGIDUmhYHC+KGkX7JuyvKUber9wLSm03A+v4OSYf8g D3C+mwcHE3+0c2nOcR7SdUBo80j0ZzibQIvR1v36H5X48ODs9bQKtiKxRV4vUz255NUUTXx t42FSrY1Hf7XKuYX1sfcn/7jfsEFtZIEiNFu3/ZYjPa0EnWyQvZ9r6xhxIWolwgIaTDlyr1 F+tOThntPQ3s9ZBwAwHrIFcheIlyaaRVhfa+qYMZKfAP0AatpTMakvmnfRth6Yai9+Pxaew MxOM+nr3I8pTnBY0boVUV4HWgUIutXe12maEU5oT4cnATm9mEHvMxIYCYChg== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=gmail.com; arc=none; dmarc=pass header.from=gmail.com policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=gmail.com; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=gmail.com policy.dmarc=quarantine Received: from mail-dl1-f46.google.com (mail-dl1-f46.google.com [74.125.82.46]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 3F45269126B for ; Fri, 27 Feb 2026 03:16:45 +0200 (EET) Received: by mail-dl1-f46.google.com with SMTP id a92af1059eb24-1271257ae53so1865998c88.1 for ; Thu, 26 Feb 2026 17:16:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772155003; x=1772759803; darn=ffmpeg.org; h=message-id:in-reply-to:to:references:date:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=uHCGn5zmplk/Hi1wXAxnx82rku46Y3+X+9k/LN91IDk=; b=j/jXxuYXDRuAt8MONL6jpVDPQmFwOMB20LogXMFEOmPWrtAnazRSfBhk2FXvb9rcLT SnJeU8XQHGEwoqMNBoYiVRsWUgbQq4/dPC/BF9uAQHLZyhG9PdN/aw2VTpow+5mcX9jU NyAvi1VlbJGM5y0nwrWnvP8rXQYqQ8xPW0X+iWav4zie/JAZ6HCx0deD3EVzJ2DQ1YEk hEblZQJI/XCtWp8GUCkqXrDoPrx8+2t4c+NaZjsyxyHIjElYY2iaSMGb8IS9nQcp9pNs hUhLA9BBaupKGLi7eEn+sBBoNGrnngFO9T9oZi24xYB2IQUky/g9hxLJyA5PYTWS0iM0 q3YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772155003; x=1772759803; h=message-id:in-reply-to:to:references:date:subject:mime-version :content-transfer-encoding:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=uHCGn5zmplk/Hi1wXAxnx82rku46Y3+X+9k/LN91IDk=; b=eo+yHLCm1P1UART77wbXNv9StJuedV2dBlQW5d/5s/NAEGAmCdKlw/Ryhf1C+jR0LF x0dX9IAdKZWn9n6EFluxPRJcUM0QOWu//24k1jKCcedzIu2FSzfp5Mnps1WeI0TWbKF6 99i5JrpO3BuCpuQ8kTZwwEwX4BuB/HppQyRgGaLPwyAgohWad8R+XaaZ+l5/WD4tucFI a2bXeInjCrOjMHCaZgLODiw7cBZsQEHGsOcB6UPVxz3OzuwvFWDOYfqF+wCQk+/wZwDI e5WOTjGEKWMhGjYX4EPMj453Cu4wu4k59gdPAp2+WTUhCEXhKwHAam2VswB6Td5Zb1hG NZpA== X-Gm-Message-State: AOJu0Ywg7n/tM/JXucZnEczbAhQ/vmhEL07FPH0FWwxxdTsTrMe+J9nI rxfMalax6UnaMwTScCd+Li1laQ7TNcDwiZbS3SmKbvsUj141JbWiq5twkAJekQ== X-Gm-Gg: ATEYQzwZ5CWs7NQT+CkGBttT2SuRFzkpbde1ESP9Vflm6PCobnXybJbX5Kq+J5PWEl4 nzR2aT/jSvegir3um8U0pbG+VWtKw+YiWEfKp+GuzfdW8hTG+pieqxKX2egUEOhPgN8gIKL1vqW RWSprOFb3GvvTQ56fn2HOTSdae3PHs41W083M1heYkYc0cuxohUBPuWwbvetL91/qRwdxC2e7hc Cj7646AmysLQd1EvPVpVD2IXn3VSaSfbzG8CAfke0c9msVl+QQi1GdgsJ7VHYa1rJS5RTxSbJg0 R/hLYR5VkIfMeWD+6cTSS+RIW6BlOzFkxgmMXahlxzNBuLfwM3qWShVb8xgMOyW4OrDM8p7ERix UnuxiwcemcYCUYA9e46lf8INEjcsQ3TdkjVhYlxckz9vhuXOFBmnon0jNia0Fus1BwW5x8jiako 2BUgGnUA2mWn6gXAt+uGd4VmQkLHNF19Nrx28= X-Received: by 2002:a05:7022:320:b0:119:e55a:9c04 with SMTP id a92af1059eb24-1278fc3c1efmr445591c88.32.1772155002654; Thu, 26 Feb 2026 17:16:42 -0800 (PST) Received: from smtpclient.apple ([23.247.137.216]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-127899d499fsm5115885c88.2.2026.02.26.17.16.41 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Feb 2026 17:16:42 -0800 (PST) Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81.1.3\)) Date: Fri, 27 Feb 2026 09:16:28 +0800 References: To: FFmpeg development discussions and patches In-Reply-To: Message-Id: X-Mailer: Apple Mail (2.3826.700.81.1.3) Message-ID-Hash: IOIUEDPKLTF2AXSDOLYXXO3MYRVHQOGZ X-Message-ID-Hash: IOIUEDPKLTF2AXSDOLYXXO3MYRVHQOGZ X-MailFrom: SRS0=i91n=A7=gmail.com=jacklau1222gm@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] Re: [PATCH] avformat/rtpenc: use unsigned type for ssrc option List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Jack Lau via ffmpeg-devel Cc: Jack Lau Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: > On Feb 27, 2026, at 08:15, Michael Niedermayer via ffmpeg-devel wrote: > > On Fri, Feb 20, 2026 at 08:24:08PM +0000, NEKO ASAKURA via ffmpeg-devel wrote: >> The ssrc option used AV_OPT_TYPE_INT with range [INT_MIN, INT_MAX], >> but the underlying struct field is uint32_t and RFC 3550 defines SSRC >> as a 32-bit identifier covering the full [0, UINT32_MAX] range. This >> caused ffmpeg to reject any SSRC value above INT_MAX (~2.1 billion), >> which is roughly half of all valid values. >> >> The auto-generated fallback path (av_get_random_seed()) already >> returns uint32_t and can produce values above INT_MAX, creating an >> inconsistency where the automatic path succeeds but the explicit >> -ssrc option rejects the same value. >> >> Change the option to AV_OPT_TYPE_UINT with range [0, UINT32_MAX] >> to match the field type and allow the full identifier space. >> >> Fixes ticket #9080. >> >> Signed-off-by: Neko Asakura >> --- >> libavformat/rtpenc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > will be applied as soon as someone approves: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/22302/commits If no one else approves it after a day, I can give it my approval. I ensure this fixes an issue. In WHIP, I previously added a workaround where I converted the 32 bit SSRC to an int and passed it as a string to match the SSRC option in rtpenc. ``` snprintf(buf, sizeof(buf), "%d", is_video? whip->video_ssrc : whip->audio_ssrc); av_dict_set(&opts, "ssrc", buf, 0); ``` And it finally was converterd back to uint32_t because ssrc is declared as uint32_t in RTPMuxContext After applying this rtpenc patch, I will directly correctly pass SSRC as a uint32_t in whip.c: > > [...] > > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > The educated differ from the uneducated as much as the living from the > dead. -- Aristotle > _______________________________________________ > ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org > To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org