[FFmpeg-devel] Re: [PATCH] avformat/rtpenc: use unsigned type for ssrc option

[Jack Lau via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>]

> On Feb 27, 2026, at 08:15, Michael Niedermayer via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote:
> 
> On Fri, Feb 20, 2026 at 08:24:08PM +0000, NEKO ASAKURA via ffmpeg-devel wrote:
>> The ssrc option used AV_OPT_TYPE_INT with range [INT_MIN, INT_MAX],
>> but the underlying struct field is uint32_t and RFC 3550 defines SSRC
>> as a 32-bit identifier covering the full [0, UINT32_MAX] range. This
>> caused ffmpeg to reject any SSRC value above INT_MAX (~2.1 billion),
>> which is roughly half of all valid values.
>> 
>> The auto-generated fallback path (av_get_random_seed()) already
>> returns uint32_t and can produce values above INT_MAX, creating an
>> inconsistency where the automatic path succeeds but the explicit
>> -ssrc option rejects the same value.
>> 
>> Change the option to AV_OPT_TYPE_UINT with range [0, UINT32_MAX]
>> to match the field type and allow the full identifier space.
>> 
>> Fixes ticket #9080.
>> 
>> Signed-off-by: Neko Asakura <neko.asakura@outlook.com>
>> ---
>> libavformat/rtpenc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> will be applied as soon as someone approves: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/22302/commits

If no one else approves it after a day, I can give it my approval. I ensure this fixes an issue.

In WHIP, I previously added a workaround where I converted the 32 bit SSRC to an int and passed it as a string to match the SSRC option in rtpenc. 

```
snprintf(buf, sizeof(buf), "%d", is_video? whip->video_ssrc : whip->audio_ssrc);
av_dict_set(&opts, "ssrc", buf, 0);
```

And it finally was converterd back to uint32_t because ssrc is declared as uint32_t in RTPMuxContext

After applying this rtpenc patch, I will directly correctly pass SSRC as a uint32_t in whip.c:

> 
> [...]
> 
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> The educated differ from the uneducated as much as the living from the
> dead. -- Aristotle 
> _______________________________________________
> ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
> To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org