[FFmpeg-devel] [PATCH] arm64: Fix wrong BTI landing pad

[FFmpeg-devel] [PATCH] arm64: Fix wrong BTI landing pad

[Andre Kempe]

This patch fixes a wrong type of BTI landing pad when branching to
functions instantiated via the fft*_neon macro.

Although the previously employed paciasp instruction serves as a landing
pad, for the ways that this function is invoked it is the wrong type, resulting
in an unexpected termination of the running process.

Signed-off-by: André Kempe <andre.kempe@arm.com>
---
 libavcodec/aarch64/fft_neon.S | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libavcodec/aarch64/fft_neon.S b/libavcodec/aarch64/fft_neon.S
index dd5f55eb87..9ff3f9c526 100644
--- a/libavcodec/aarch64/fft_neon.S
+++ b/libavcodec/aarch64/fft_neon.S
@@ -340,6 +340,7 @@ endfunc

 .macro  def_fft n, n2, n4
 function fft\n\()_neon, align=6
+        AARCH64_VALID_JUMP_TARGET
         AARCH64_SIGN_LINK_REGISTER
         sub             sp,  sp,  #16
         stp             x28, x30, [sp]
--
2.25.1

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] arm64: Fix wrong BTI landing pad

[Martin Storsjö]

On Mon, 25 Apr 2022, Andre Kempe wrote:

> This patch fixes a wrong type of BTI landing pad when branching to
> functions instantiated via the fft*_neon macro.
>
> Although the previously employed paciasp instruction serves as a landing
> pad, for the ways that this function is invoked it is the wrong type, resulting
> in an unexpected termination of the running process.
>
> Signed-off-by: André Kempe <andre.kempe@arm.com>
> ---
> libavcodec/aarch64/fft_neon.S | 1 +
> 1 file changed, 1 insertion(+)

Thanks! I pushed this now.

// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".