From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D03CB463BD for ; Tue, 16 May 2023 16:16:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4E13A68BF41; Tue, 16 May 2023 19:16:32 +0300 (EEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2110.outbound.protection.outlook.com [40.107.13.110]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 053CB68AF9E for ; Tue, 16 May 2023 19:16:25 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PmhsIA+IgRK6G0UM1YW1BuY1blQfbjHibG3HRgJ8vb82GqYM9Kf381ZVroslAWe/Hiycvki4TjFzq2BVnFiMOwD1wIYh5GOOzd7PzBJFp5o030EltWhdt3bcC3t8gi0vR4v+KM/DSFau5urARPOpulfk5DsAZZZIHVtcve19KHggrjIKYFkcUtCz1Oc7H7JghZ+UPEL6sk7SJwFkcjWbCZBQ8TNER3Z/djgOh3C+ObLqi9HglZO/t7KE2tia33oyz3U2UaU7Xjae2bfhTL18RUMbnuGnYIat4jIn1f1sRrLZpUhTIQ+1gdcgn0strSjnkL6COiytBtIsHTqvDrPR8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kT2b+Pq61nsdZp48lDhwQj9+14Wpliu22cdfhsZqKdg=; b=FNLABisnEr1dQC/Q/CRqy/SEWsSZpjXH3gQ0U5wSQbnGcX/HKVQWAe+QK++lY3msMQql74aGTMBDfoPMKxP8BTV/wjBaeNKhOS0Ti0xdr4V/FjcW6Ou1zjWQNNYU6T00Xd4VrSY2paapWtzWZq7A/3ngf7IoD901bP4Ky1RV/O5W8AZMrzi74JxQm2kFah6QRzfEe11w1gXRY2A57xR5nD+P6t3w/Fec/3hjSPHz3I8aFiTFLMeQvQfCI3p02xcYbTChdxAZuQEVC9YeDl+3Ypkw7MDftnG6tDGFLVMPVwpoKNp8tfWRzS3drklbySFV5H4wTd+wGpB8bCf0To2SLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=qt.io; dmarc=pass action=none header.from=qt.io; dkim=pass header.d=qt.io; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qt.io; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kT2b+Pq61nsdZp48lDhwQj9+14Wpliu22cdfhsZqKdg=; b=tYmtg3ObDTkE69bPU9qnCSYnt85oGwDAPGtYgc3w+GwcrMHnfwKdyPBs/EjREC5sCiwkdZtddBX4kv9UyEhIrLG3JrA/Gr2ItndQEkJdIe3qQfufA0fu6t0QureZm4YwvcP2fBZu2YzoE58Ow4WdMCg5Q25dhSuQ5fknaFQm0Sw= Received: from DBAPR02MB6165.eurprd02.prod.outlook.com (2603:10a6:10:18e::8) by PAXPR02MB10342.eurprd02.prod.outlook.com (2603:10a6:102:248::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.32; Tue, 16 May 2023 16:16:22 +0000 Received: from DBAPR02MB6165.eurprd02.prod.outlook.com ([fe80::fcdd:550f:463b:bd2d]) by DBAPR02MB6165.eurprd02.prod.outlook.com ([fe80::fcdd:550f:463b:bd2d%7]) with mapi id 15.20.6387.032; Tue, 16 May 2023 16:16:22 +0000 From: Samuel Raposo Vieira Mira To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] avcodec/mediacodec: Add VP8 encoder Thread-Index: AQHZecC7mtn72az3sUCDICIeYANlhq9Oh6MAgA6nFo8= Date: Tue, 16 May 2023 16:16:22 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=qt.io; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DBAPR02MB6165:EE_|PAXPR02MB10342:EE_ x-ms-office365-filtering-correlation-id: cc881748-3894-4bc7-88c5-08db5628e3ba x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nfjrxewrqmv9zhCye8uej+y0gSqqa6YYmJ1K88iEY1cPiWvnT18wsBBM+VUG+tL1aSJszmptTROzwIo+AScLS3IDiiRFahnVs7EGsvhAPeaVN7q5z35PrJsYjKDAPCxJzn7OfG0Sl4N0qzQsjCzrq+KDsgEoiXJHl2ywKX9SpQoqA6hGL0A17H6hXaWaefm6Fis3HpDkWGU+92gAJI6DvfiA1i9151I29YXaYYyuttviTF7rT/wCr/x7DCttzv8K4INPDvjgYNikWh0K5VvG7YDj6xwr6aanpUjhu4cwYlRw32wmDlULzxbyyBpWaqqaoxXimcBvrbPc0XvnxtwxzU/5kkSmAv+PVRvjrtiNJiKxP+GSZX2r3DKd4HwsmFCULvEmx3pHcd3U/AJkPWbKUq5L4Ws2uQK4xb0bfN+1llaVLlCGWrJkZhglWOs2Xf4NvBb4bsEeH+RK9l8CbOizSW5TZ9eUK8Vg+3o1RSQkCurKmdrd5htCmWiv13WL5aJ/xPGzzTmr7QMNEUQq8idI5iT/g72ctIePzD4YIbduudW6EkGL2etU2GSL7qfUU1kLbgq2rn555E9bGDrNrqWiKT/wPZ8iGrmoQ6iUfqrno57A3kBYjgoYG7QXvQ99Cj+0oMKhmCph1r5wlsA38LXEwA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR02MB6165.eurprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(136003)(346002)(39850400004)(376002)(366004)(451199021)(6506007)(9686003)(26005)(966005)(55016003)(122000001)(166002)(38100700002)(33656002)(83380400001)(38070700005)(86362001)(186003)(8676002)(66476007)(64756008)(66556008)(66446008)(76116006)(2906002)(66946007)(478600001)(6916009)(8936002)(5660300002)(7696005)(41300700001)(52536014)(91956017)(66899021)(71200400001)(316002)(48020200002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KfycRyZ33gwkGwdERaFvUG6ORHpdpSooUNcfEvCFR2geGTCA3rI4Lrwp079b?= =?us-ascii?Q?qBZL5Al/f+pmXDBequW0zJXzmxcUAi32C2cd6RFO8Xgir543pkpOezcULrA1?= =?us-ascii?Q?D1N973Q4yvY8Ts2ettihx9QG+zkrNbTQwyhMymDt8MZ97hxZGdR7peTeJfO6?= =?us-ascii?Q?qa9e9dqfu8MjV5TKHb72fHwVv8uoNnfnxahyuCdkMHBjrTmb1864jiJns+On?= =?us-ascii?Q?oENVflzifQCgpWTe1ikkt6eIYTEHQb7rjBNxZ+sC9zzwYlk7ea9HWaIveqll?= =?us-ascii?Q?Yb2vOT/o1zAA8cnegLZV4SjuHlmsdt2bFt9kdm5anWP/v5ffniuthzdyXoOf?= =?us-ascii?Q?Y2lZDRILm5sOP9raO+6v70x10XbbACh1CQtCt4/Eimqkff3yEikwQ6wGMgtJ?= =?us-ascii?Q?6kEqqJGXWkfJH2uhh7jOTaxSVe1yvU9oEfNfER41fbDqQyYywpHEvxOvPDo/?= =?us-ascii?Q?9LhgNtAdgPtpDJNpSi0XT3sSdZ6qH04gQECB9L11o6KLPuZ7PpKHoPWAU3Qx?= =?us-ascii?Q?rpAk84gt9aZ6WFcptfIMIa/LF9QAg7E/tklJEeBHCOVFsSIAmi3DDpondhcz?= =?us-ascii?Q?XIM9QXFmQ4AFLlltb8T1Em3zfGjFbS0cfJvf3nTK1HRcgeepF2dnLM+Eifqk?= =?us-ascii?Q?BJHiyx4AsntWH1+Zx6a/WZTKf2BdoXUqAJKUQtyd4v8kRfZmvI9VJp+Nas/0?= =?us-ascii?Q?/A24OYr3TBIXwVra0prPRrzdb/e1RDzuzA9fv0vvaFbpS4F0v8/zu0E+dXb1?= =?us-ascii?Q?BFMudwmpuHxx9UEylHeN1WTdAdGEOpnGGDv8FAQeNs+f152XRuWCM2gEu3Dw?= =?us-ascii?Q?D8IDJrY7Fm+G0foJfMl34ZoHL4SbKO0pi/jrl9Tf0g7oyhWdOPNXoHLn0PpF?= =?us-ascii?Q?deqyRDsEsBq9uF49grled5bHhDgnFvkGNjKrBe2GrOUsE9U+uVDBGTL7eEXS?= =?us-ascii?Q?6O4c0nBbevap6MTp1QUTCK0a+RpiikPZR4WIj0/5VSIAntzJuCWmG7R3CTZq?= =?us-ascii?Q?rYUs9UtigPnxL3cz8rCfUZz6RJgruLhaRvzCwW30h+O6NQ52TRtsZSnVzp3f?= =?us-ascii?Q?Dp2UEKr+fDWhjricomIdrCzrSWMCRi6pWxHqZH502Y47kvNNZfNSBXLiYMyO?= =?us-ascii?Q?FWeb3kFC3Dy3Jd5J4CJcP8iOl7yeXD1CvCtI0NjfoNkwSImlwUZ6onCYmyhO?= =?us-ascii?Q?pzfHGzxiGnbHb8bumX/wUJX0Bxkge5rfhQRHWb0/+toAZ/aNaZkfDgR3brTA?= =?us-ascii?Q?6Rf2n4JL77mu8N8OboixPPAxUY7TPbKkUVbCQ5SNPIpWxkmcH2thg/VUm5Gn?= =?us-ascii?Q?ejMuXrYl9mCXg0sV18VkADA1tBfsd0KM01SSoKdCEss5MZanVfNHPvNYf6ML?= =?us-ascii?Q?k4rpH6MB/WPz46OK2RchNebm3DrWRAdxqVppICANxYsP4InZpUH49Ig9uohA?= =?us-ascii?Q?zD/mOo/Hg8rR1QHvQBbI+yS4ly+yCyY61ZmW1FyvXjg+XeDZF3IJgya+C7vx?= =?us-ascii?Q?asRfRKJhMVjcuaPhjpZD7BmVOJdz9Lh3kajgC9AattxmsIJZywHV92bsGafL?= =?us-ascii?Q?CU8EmFyd0quE7mYIBEACi76TwjHNpz6Ti9dyzSzGVEqmNkuqmiVgJkEmYoLQ?= =?us-ascii?Q?jQ=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: qt.io X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DBAPR02MB6165.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc881748-3894-4bc7-88c5-08db5628e3ba X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2023 16:16:22.1970 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 20d0b167-794d-448a-9d01-aaeccc1124ac X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: A7FvfoTz1/r35qlJ1LRzPUsLJGSWclyD6FbowN0q9H2vufO7TRBR69Y3ZLcVPEe/4hJIATAWn437xUvfdvCz1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR02MB10342 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/mediacodec: Add VP8 encoder X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > > Connected FFmpeg to Mediacodec VP8 encoder. > > Minor Version bump. > --- > > configure | 1 + > > libavcodec/Makefile | 1 + > > libavcodec/allcodecs.c | 1 + > > libavcodec/mediacodec_wrapper.c | 4 ++++ > > libavcodec/mediacodecenc.c | 29 +++++++++++++++++++++++++++++ > > libavcodec/version.h | 2 +- > > 6 files changed, 37 insertions(+), 1 deletion(-) > > The patch file format is broken (missing a space before unchanged lines). > Please send it via git send-email or add the patch as attachment. Thanks for noticing the issue! will send as patch next time. > > > > @@ -387,6 +389,8 @@ int ff_AMediaCodecProfile_getProfileFromAVCodecContext(AVCodecContext *avctx) > > case FF_PROFILE_HEVC_MAIN_10: > > return HEVCProfileMain10; > > } > > + } else if (avctx->codec_id == AV_CODEC_ID_VP8) { > > + return VP8ProfileMain; > > } else if (avctx->codec_id == AV_CODEC_ID_VP9) { > > switch (avctx->profile) { > > case FF_PROFILE_VP9_0: > > The function is a map from avctx->profile to MediaCodec profile. > It's not supposed to select a default profile. But there is no avctx->profile for VP8. Should I create an FF_PROFILE_VP8? From: ffmpeg-devel on behalf of Zhao Zhili Date: Sunday, 7. May 2023 at 11.26 To: Samuel Raposo Vieira Mira , FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avcodec/mediacodec: Add VP8 encoder On Fri, 2023-04-28 at 11:07 +0000, Samuel Raposo Vieira Mira wrote: > Connected FFmpeg to Mediacodec VP8 encoder. > Minor Version bump. > --- > configure | 1 + > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/mediacodec_wrapper.c | 4 ++++ > libavcodec/mediacodecenc.c | 29 +++++++++++++++++++++++++++++ > libavcodec/version.h | 2 +- > 6 files changed, 37 insertions(+), 1 deletion(-) The patch file format is broken (missing a space before unchanged lines). Please send it via git send-email or add the patch as attachment. > > @@ -387,6 +389,8 @@ int ff_AMediaCodecProfile_getProfileFromAVCodecContext(AVCodecContext *avctx) > case FF_PROFILE_HEVC_MAIN_10: > return HEVCProfileMain10; > } > + } else if (avctx->codec_id == AV_CODEC_ID_VP8) { > + return VP8ProfileMain; > } else if (avctx->codec_id == AV_CODEC_ID_VP9) { > switch (avctx->profile) { > case FF_PROFILE_VP9_0: The function is a map from avctx->profile to MediaCodec profile. It's not supposed to select a default profile. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".