From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6C84B4494D for ; Mon, 5 Dec 2022 12:33:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3C70968BC72; Mon, 5 Dec 2022 14:33:52 +0200 (EET) Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03olkn2041.outbound.protection.outlook.com [40.92.57.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7F4C768BC72 for ; Mon, 5 Dec 2022 14:33:45 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=frkj7GSQKgTTr0DlIQYQyueyjWy6yEeAP+8gSdzvRrkwxpKpgcV4saoCoXu8GaY+TATOU//Gb5O55LGmKDC4sfJjN57MwJKEjIi0KZBceCRWD8yL/hhDonfm7DvbIoRUC/r6JtMlN/COT9fspeZ25H1zLEXalNKYlG1sBp+BTOty2PVBea58QnIHy8Z8q2exEeGnGNtQFQMoc+e/7LWnrz85qh33lFtjSBnqglyIIVaqQlVBygaXyPORfL0lDunH3h3yr2aVYuuYy57mc8L5gzugUJsaYOWC0kpDkWXbqtyvBWOU+ngZc0CFEbdl2OXHSWMU5gRN2StCZRUbp+ak6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EbVyfyFHagZMkBb6k7BAX7TTwGbDG46b2pPE8U9iE90=; b=WLIpeNIzLYa5VtJ9dxxqGddLu8HSrsA9dwUit1lJMfgnfiRFh2RjnOVH7EcyGHAJgsXLyEg2V5DiMTrNa9IuZZpvbeLV3lF9EykSkYDYsosJCyEEapynaZkKhKvmCiQYW8vp29a4869cp+Et6hi+jDYmSeAVFXHk5PClwkQOf/5+HBKfCavTfQdjP1RBnUal906ERPbr5Y6yZtF7RMoKZmphuqI+5JJQirrmO30RM0O9i7Uf9N9rPzPhH2KXiH871YhZjY066/jqairsIwhei0lt4dk16Ioz7yNI/gDxDPRHHQQSZtuC7nFuKqPW7/8Kdxgr5R8lwh1VpFWk+0nCEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EbVyfyFHagZMkBb6k7BAX7TTwGbDG46b2pPE8U9iE90=; b=TLnXEMu85H9JSi1QuFP6AK5nFxZSxl1CQ+Af6GCXgQtfz5gcQ491rPigLm6rycr4tzrhrfZeGKOmFIupkPVAGvat16Q/zVkuwOgc9laBkPCZu6oDwVD0SdUojfxJON0IECIdsxjM9+dhuWjVdShlHFv+tD2slWoNQJQ9f29W6yOQ60/LA6Z6B/sbHAFALkxLYpY31Em5yUB0McLtagz5uEtWzaPe1A+CSMAJdrs0A9a5e213RN9brHJ7eN1al6wxTzTHMIGAa7RCbT74fBQ0MoYQ3sxqtDELE0jauRXMrYMRIGrp/aXFpFYY7Gvzk2+R+SfV5kFdfmB9HCIWTX5RAg== Received: from DB9P191MB1482.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:224::19) by AM7P191MB0712.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:134::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Mon, 5 Dec 2022 12:33:44 +0000 Received: from DB9P191MB1482.EURP191.PROD.OUTLOOK.COM ([fe80::bada:6a73:3b1:7977]) by DB9P191MB1482.EURP191.PROD.OUTLOOK.COM ([fe80::bada:6a73:3b1:7977%9]) with mapi id 15.20.5880.014; Mon, 5 Dec 2022 12:33:44 +0000 From: Basel Sayeh To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [PATCH v2 2/2] libavformat/dashenc: Enable HTTP persistent connections for dashenc_delete_file Thread-Index: AQHZCKU0GnmaqIOQHEWshS8aAc+GPq5fOlKb Date: Mon, 5 Dec 2022 12:33:44 +0000 Message-ID: References: <20221205122211.10781-1-basel.sayeh@hotmail.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [VGpia2QnVBE3vrx6b3wP34MwxzGb1reD7KmuCdWATVZfXUbHeHozYCAGzMduxPqm] x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DB9P191MB1482:EE_|AM7P191MB0712:EE_ x-ms-office365-filtering-correlation-id: 660473fc-ae5a-43b9-6bb5-08dad6bcf2df x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: M19O3btGFwSNPOeo7VXR/8u1kwZFOuZDewh4v653wDxm5i6p0yTAWDIsca4n5XVSN0lCtSPLMEgFoAxxZ599myQnHOiF4y7TNAThSm9Ztzq1u4e65JlpppyXwvujCeDTU3mUJvKCTEUWIi48PX12OjFokPjgD/2WZRMmt67g2mZ8yxxLp8Y10lF0uepp1us/KvPrj42RvtYjZxiOVoDh/Wj3CLB8wRHF7efy+TaY6CkhwJuV7luvlSDkNAmuqq7jvMF0dXYt9rU/GWCUrCDVyTVSCSbSPKVkT0XFFiZeyttrYWwo+JYK51BP4Iqm/OcLQAPIbHLtn3jNv1gBpmCluiu6FNvUD2H85YvWWJV5A7AZmFy4pFq6tjfPlqYibpTCg7P8lUB7fzwMyAfNr+VmPtw8rv44JqzCTfmZtk1gdqvruOBh6BdyPs72bQcW4u5orgtE05GgRW4XZMWtey+fEMmklXHFZJcQXY7GashQYWv05/L9sR1tmlen1uRGFGH/bm1EZYBkdUgBAPWX5q0vqXZ9UteTdgOMTfRqvV+ckg2wf+OdrQxizfv4ab0KYs5v9jybbvy0ArnMoGE8z5ReKIMErkuFBGmWst9NLyqoknuh575YnUdjkkNOAV1PLt5QWZ/1xdSCy8yeEPBzv+8wbuNyyvGYmUflbKQZiVcCDPc= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?W7O0jeVG/50fOHNGV5M0FMV5Y5Qw5T5SRliNAEluBCFGkG5mp2wqkevJtv36?= =?us-ascii?Q?T24+Q2wH74Yhv0fZu6UtLrM3XKtOiwzVbkAkfzeipEpm1kPvJp1g580zcupO?= =?us-ascii?Q?71WdNm+SCcG3+yoLUBTjaBgn/nyy4swIJiPPgb//JlX3y2VVUNyPqIbeBeJc?= =?us-ascii?Q?o+C7ED9hGwqfGSboxFi2J9cpR3RUR9lT06LSHbewNJIqRFoERR1YYpMwUkLp?= =?us-ascii?Q?PtDE2Zx2jFhv3KH3g8hlkRsEI2u6TLG+MO0H40qZMt+9Np+nzn0WBJutJbqH?= =?us-ascii?Q?FCnsY8HKpXSPjXeU2xTogeZ5PFtgplHT2Ht1txrC4N1/tKP/A1MAqN0M/95q?= =?us-ascii?Q?ER+ibfDaTb/h+q87+Khc0ECjxNzeuIP0Bla/JyH1JhINHS24UC6BG8R12W0G?= =?us-ascii?Q?BayOfQ5H+TwfAWxStkL1w37nvxFVcuTjxfEOTSl/jXi+x9tshSKhqDJ+VGVR?= =?us-ascii?Q?kL9h+cbM5fp42+pzIGwFQxJbDNAaiBO+PbVceN0S0a0KDolj8BCwNsrPK9yY?= =?us-ascii?Q?NR/m/3Gqt5oK8WYVGz1Kz56CQJi4qSab2tYVtGU/cjMcothkBpSE+19Ou0Ac?= =?us-ascii?Q?7WksAlaOfxe9EKv50LN5NzXzz0hbBKVSk1PMxsemiYe4m+al0o8UwZGguT0N?= =?us-ascii?Q?jEfde61qSwJxWKbMUHPUARD+xOFv+Kr1M9w9TOnsL+RIaDwPN3tOaXqv9yI4?= =?us-ascii?Q?oajb8MjWX6q1eJ9Gjv7ai/oBd92UWTB9TLn4NKeahqvzAsV+UGxA+JP6LQWq?= =?us-ascii?Q?Hs3o4CRCKsOrcDmP1j8sIhX4cVcpLqZwwbygnmu3qN8tD/qXf1S7ZsnBTg5+?= =?us-ascii?Q?DlYBHktieRGmE9cLJtqqd244QKv92VLgIqSVYHrn8oMa21dkiRkE6rkBIeim?= =?us-ascii?Q?r45N6fEg9ouiL0rKQC2ZWktcxdY5SI2hYHl+mJWmbTUsBkpPpZ7O+F2i22Tr?= =?us-ascii?Q?XQnwNtkZ5Nnn5U35PycFLFNfRMk5CsC3WaFmO9ODfr/tADlUwAOBp2Eggkf/?= =?us-ascii?Q?4up3Xxvr071jZvrZFBICczGI9rlr6KYUr3WXM9+OQ6FhkmF3tncsQ8i4sP/s?= =?us-ascii?Q?PydzUVQokejssTthv8vI1uCH2pDaSOoKfNPJLwLcSgGGGKaGUxKaOT/G96zr?= =?us-ascii?Q?1RGKHw+Tv0NLLutRZ9ohvkr3gRBYUqKgeg94PUDjtes+rtjesnjUjEAe2Sj/?= =?us-ascii?Q?jBeySSarRuhcRyphJjiqqE4uSW/+wPUDVtWbfxTi6f0QbT6aBwEmeBoUXE8g?= =?us-ascii?Q?dlF72u7/pzGmJ4X0yAHcAm90HxT1uIvd2hnohoyGUTWI56pBxhs2OgZG2ySz?= =?us-ascii?Q?f9nAIHg2UCyfYZjr56KdH5bTNvwTe7o1KucvocJw5xKbdA=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-50200.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB9P191MB1482.EURP191.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 660473fc-ae5a-43b9-6bb5-08dad6bcf2df X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Dec 2022 12:33:44.2958 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7P191MB0712 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH v2 2/2] libavformat/dashenc: Enable HTTP persistent connections for dashenc_delete_file X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: oops, another small mistake, please see v3 ________________________________ From: Basel Sayeh Sent: Monday, December 5, 2022 2:22 PM To: ffmpeg-devel@ffmpeg.org Cc: Basel Sayeh Subject: [PATCH v2 2/2] libavformat/dashenc: Enable HTTP persistent connections for dashenc_delete_file Signed-off-by: Basel Sayeh --- libavformat/dashenc.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 9c1bcad9e3..2521568ea5 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -179,6 +179,7 @@ typedef struct DASHContext { int master_playlist_created; AVIOContext *mpd_out; AVIOContext *m3u8_out; + AVIOContext *http_delete; int streaming; int64_t timeout; int index_correction; @@ -642,6 +643,7 @@ static void dash_free(AVFormatContext *s) ff_format_io_close(s, &c->mpd_out); ff_format_io_close(s, &c->m3u8_out); + ff_format_io_close(s, &c->http_delete); } static void output_segment_list(OutputStream *os, AVIOContext *out, AVFormatContext *s, @@ -1855,18 +1857,22 @@ static void dashenc_delete_file(AVFormatContext *s, char *filename) { int http_base_proto = ff_is_http_proto(filename); if (http_base_proto) { - AVIOContext *out = NULL; AVDictionary *http_opts = NULL; set_http_options(&http_opts, c); av_dict_set(&http_opts, "method", "DELETE", 0); - if (dashenc_io_open(s, &out, filename, &http_opts) < 0) { + if (dashenc_io_open(s, &c->http_delete, filename, &http_opts) < 0) { av_log(s, AV_LOG_ERROR, "failed to delete %s\n", filename); + } else { + //Nothing to write + avio_flush(c->http_delete); + dashenc_io_close(s, &c->http_delete, filename); } - av_dict_free(&http_opts); - ff_format_io_close(s, &out); + + if (!c->http_persistent) + ff_format_io_close(s, &out); } else { int res = ffurl_delete(filename); if (res < 0) { -- 2.30.2 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".