From: Mario Hros <k3x-devel@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Mario Hros <k3x-devel@outlook.com>
Subject: [FFmpeg-devel] [PATCH v2] libswscale/x86/yuv2rgb: Add missing EMMS
Date: Wed, 26 Jun 2024 19:54:45 +0200
Message-ID: <DB8P193MB06968DB8968EA73A417B29BCAFD62@DB8P193MB0696.EURP193.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <AM9P193MB194004554ECF79F43679CFB2AFF92@AM9P193MB1940.EURP193.PROD.OUTLOOK.COM>
Previous rewrite from inline assembly into nasm (commit e934194) missed the required EMMS instruction to bring the x87 FPU back into usable state.
This needs to be done for 8-byte MMX or Extended MMX only.
Signed-off-by: Mario Hros <k3x-devel@outlook.com>
---
libswscale/x86/yuv_2_rgb.asm | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/libswscale/x86/yuv_2_rgb.asm b/libswscale/x86/yuv_2_rgb.asm
index e3470fd9ad..5926133af8 100644
--- a/libswscale/x86/yuv_2_rgb.asm
+++ b/libswscale/x86/yuv_2_rgb.asm
@@ -354,6 +354,10 @@ add imageq, 8 * depth * time_num
add indexq, 4 * time_num
js .loop0
+%if mmsize == 8
+emms
+%endif
+
RET
%endmacro
--
2.39.3 (Apple Git-146)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-06-26 17:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 17:35 [FFmpeg-devel] [PATCH] " Mario Hros
2024-06-11 17:19 ` Mario Hros
2024-06-25 20:09 ` Michael Niedermayer
2024-06-26 17:54 ` Mario Hros [this message]
2024-06-26 18:55 ` [FFmpeg-devel] [PATCH v2] " Ramiro Polla
2024-07-01 11:46 ` Ramiro Polla
2024-07-04 17:52 ` Mario Hros
2024-07-05 8:46 ` Ramiro Polla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB8P193MB06968DB8968EA73A417B29BCAFD62@DB8P193MB0696.EURP193.PROD.OUTLOOK.COM \
--to=k3x-devel@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git