Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Sebastian Koerner <seb_koerner-at-hotmail.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [Patch] Linker error for __ff_aom_uninit_film_grain_params
Date: Mon, 12 May 2025 11:49:09 +0000
Message-ID: <DB7PR03MB3627BDB6197F1D8D4B60CA858E97A@DB7PR03MB3627.eurprd03.prod.outlook.com> (raw)
In-Reply-To: <DB7PR03MB3627FADAABDFBBBA9D47809F8E97A@DB7PR03MB3627.eurprd03.prod.outlook.com>

Correction: Sorry, the log is from arm64, but the text says x86. It happens to many non-linux platforms.

Also note that Hunk #1 of the patch is obviously junk.
Should be just the one dependency to aom_film_grain.o

--- ffmpeg-7.1.1/libavcodec/Makefile.org        2025-05-12 11:48:13.000000000 +0200
+++ ffmpeg-7.1.1/libavcodec/Makefile    2025-05-12 11:48:58.000000000 +0200
@@ -108,7 +108,7 @@
                                           h2645data.o h2645_parse.o h2645_vui.o
 OBJS-$(CONFIG_H264PRED)                += h264pred.o
 OBJS-$(CONFIG_H264QPEL)                += h264qpel.o
-OBJS-$(CONFIG_H264_SEI)                += h264_sei.o h2645_sei.o
+OBJS-$(CONFIG_H264_SEI)                += h264_sei.o h2645_sei.o aom_film_grain.o
 OBJS-$(CONFIG_HEVCPARSE)               += h2645data.o h2645_parse.o h2645_vui.o
 OBJS-$(CONFIG_HEVC_SEI)                += h2645_sei.o aom_film_grain.o \
                                           dynamic_hdr_vivid.o


________________________________
From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> on behalf of Sebastian Koerner <seb_koerner-at-hotmail.com@ffmpeg.org>
Sent: Monday, May 12, 2025 1:41 PM
To: ffmpeg-devel@ffmpeg.org <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [Patch] Linker error for __ff_aom_uninit_film_grain_params

Summary of the bug:

When building ffmpeg 7.1.1 from source on macosx x86-64 and selecting only h264 one can observe a linker error around __ff_aop_uninit_film_grain_params


Undefined symbols for architecture arm64:
  "_ff_aom_uninit_film_grain_params", referenced from:
      _ff_h2645_sei_reset in h2645_sei.o
ld: symbol(s) not found for architecture arm64

How to reproduce:

configure ffmpeg 7.1.1 for H.264 only, like

--enable-shared --disable-static   --disable-programs --disable-doc --disable-everything --enable-decoder=h264 --enable-parser=h264 --disable-bzlib --disable-iconv --disable-lzma --disable-xlib --disable-zlib --disable-libxcb --disable-vaapi


Patch

--- ffmpeg-7.1.1/libavcodec/Makefile.org        2025-05-12 11:48:13.000000000 +0200
+++ ffmpeg-7.1.1/libavcodec/Makefile    2025-05-12 11:48:58.000000000 +0200
@@ -1,5 +1,5 @@
 NAME = avcodec
-DESC = FFmpeg codec library
+DESC = FFmpeg codec libriary

 HEADERS = ac3_parser.h                                                  \
           adts_parser.h                                                 \
@@ -108,7 +108,7 @@
                                           h2645data.o h2645_parse.o h2645_vui.o
 OBJS-$(CONFIG_H264PRED)                += h264pred.o
 OBJS-$(CONFIG_H264QPEL)                += h264qpel.o
-OBJS-$(CONFIG_H264_SEI)                += h264_sei.o h2645_sei.o
+OBJS-$(CONFIG_H264_SEI)                += h264_sei.o h2645_sei.o aom_film_grain.o
 OBJS-$(CONFIG_HEVCPARSE)               += h2645data.o h2645_parse.o h2645_vui.o
 OBJS-$(CONFIG_HEVC_SEI)                += h2645_sei.o aom_film_grain.o \
                                           dynamic_hdr_vivid.o
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2025-05-12 11:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-12 11:41 Sebastian Koerner
2025-05-12 11:49 ` Sebastian Koerner [this message]
2025-05-12 12:14   ` dev
2025-05-12 12:42 ` Zhao Zhili

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB7PR03MB3627BDB6197F1D8D4B60CA858E97A@DB7PR03MB3627.eurprd03.prod.outlook.com \
    --to=seb_koerner-at-hotmail.com@ffmpeg.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git