From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 46EDD446B3 for ; Tue, 20 Sep 2022 23:56:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1852368BAEC; Wed, 21 Sep 2022 02:56:02 +0300 (EEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-oln040092072017.outbound.protection.outlook.com [40.92.72.17]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4079168BA40 for ; Wed, 21 Sep 2022 02:55:55 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U9n0nva5z9zWPaaH+jGTAQKHuSWr4W3DUJWJ2Z0QxuXPBbuHLorUcgVkY1lfjkTOq/k/uyLfhZca1HJV7ob3HRhmPEZDsXzrQ9Pyu8OGCea5RNT6DRrH6y41mOwi8unF+TThXB6+0HmV5AAzUz0gfhbBwBSHKp95MMKpp9ebcW5qKIHo2dU32njaLZbM3E15RZE9yE5K+HQZnOu0qUMwqYETz3KoqGVYdhR+YxA3j5MTIKyPltWMopZcQQXubdQ5z+WsQJxWAO2V7QT/hmvGKRMmNMEtVQ0ETufl4wGchVs9FQqgZLsZ0Xs2v+jIKgh/kSlUlqqYXF3JnF/SNXCaOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XonIC+MtGERxJfB46jjW2bSKBxM9ElHayK7OG2LZLDA=; b=lEXDiWmnpXNwFuqCXt8MmgDXif/11TS5yzQAynv+NWuiS+JbAe97XPDUxmYAjXArWqzsOccn6+zRyC9Fod63aQJqhMv51QB7Al9iF7+oX7f3deuFcDgZfhLBaVpQ/BsrzX9pOXS6E2iWt37R7DjwPKPQs1vVQMiAJweoIwQD6mF4UgERT/Wy+UMQRXuLLuqyOR9xZIHKOFo6p0+oNYvkPlAQ+wZfW5vFfDVN2EDogTATh8IjicyewSueKrsWE7oq170E2N4eiwppVK1JUyDaYZDdDtaBTxBsh2y0FGlurgWTOyGrsuE7nBLsJKmdQOvgMEciUsHDMwj97ZKRacbI9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XonIC+MtGERxJfB46jjW2bSKBxM9ElHayK7OG2LZLDA=; b=UEzAzEvpzXtJJZnZQn0bReNcf6sRVwNnE93zaJC/cbxTNXWgHuFaNV2vz3CHEBJ8u+l7gbBsAq5w8KDy7F0x2qs8nEPOdFIukg4cc1pxI2vpWerVOMDq/Rg5HVXy/jQ63Rfp9T1Y5xhuz4EGhLfhHQv27CgR7cIpdCh2LowYOIcPGzYVYyJ3rsPATvtxpQNTfkxZF3MtF4k4m0MvgtjE6AcmZM31Z/AKrF4FqiElDGJhAWCVoRv7iGC9RyLQnMg0+6Iplmqrnt/7iBoaTxGHTIw5DcBLHJAylYoJQWX1v+oUc9A5J4FyDy/D+s8Yaj5TYgkKltRe5CPr0QGLihKj0A== Received: from DB6PR07MB3175.eurprd07.prod.outlook.com (2603:10a6:6:1d::12) by DB9PR07MB8725.eurprd07.prod.outlook.com (2603:10a6:10:30c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14; Tue, 20 Sep 2022 23:55:53 +0000 Received: from DB6PR07MB3175.eurprd07.prod.outlook.com ([fe80::3417:be7b:af2d:c2ca]) by DB6PR07MB3175.eurprd07.prod.outlook.com ([fe80::3417:be7b:af2d:c2ca%7]) with mapi id 15.20.5654.014; Tue, 20 Sep 2022 23:55:53 +0000 Content-Type: multipart/mixed; boundary="------------LeJo5PFcZ5dAySFerFB0RvU0" Message-ID: Date: Wed, 21 Sep 2022 01:55:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Johannes Kauffmann In-Reply-To: X-TMN: [+p2C5aO0ex9b9IK3La+DMe0isblx7Yz7] X-ClientProxiedBy: AM0PR02CA0137.eurprd02.prod.outlook.com (2603:10a6:20b:28c::34) To DB6PR07MB3175.eurprd07.prod.outlook.com (2603:10a6:6:1d::12) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB6PR07MB3175:EE_|DB9PR07MB8725:EE_ X-MS-Office365-Filtering-Correlation-Id: 1bb4de69-a911-403f-74fd-08da9b63a6ae X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CGUzpBh3X4aigL/4OhJxGpSjn1ScgAC81V9alH0CPlZDEaWjhhbjm/nNsZc9KimdW/oz2BEsGprYoIZTocQ0g6SG9ZEQbh5wKxhUCOIIMdIGQ2cqrXZQLIvXCf9FM1T1kNkkUdEyrKgsV+qTpvhhu9/KHBNw6C5DXbxPHBejWlDkq9hEBZjmO6PhwOI0bDi/jDVjz/jReiDCuyFOtnG4JTmftcgX3Vu0mL8kplBVo21Thz4z8H29p0KL3TmLcKD6TunA0ygL2rPb7Q2zZbnXd65xnUmhcLQ/lR+BVtFWt/VSG4tW6BuABbDtB6bKtU2mFgY6J3PsxrOCxhg4lZNwpZwgCEXv9bEChvXjJSqE1i93tYhvqIdlYbJXeVD8QAORZ87ts6Iqi/J982uKqElinmKlLfHild/CtXdLJeMjYRLevzSasvqtryRCIsmqlLGO++6I2zD871gBb5o/Ecq2d/uJAjPpBXDE43s2ryMnpzVFeWOeuNYvuJ6Y/cszVoV3+YA2rULUdxH37h2wfDWJKPvkMQx5d7Gsuy6vjk7cEI0/wCTEHeFxFP5yK3wb68U3vI8yJHPHbfVSFY8NdB4X34FpXAK8kbnbD0091MCoqzTgyqLBWqGr3nMdVeRIf3gghTdewMZKdJHuj14iuX9Eh1dO6g1h+bl+SsgTTAuz7k/l8nr3oHjNoRlQUaG5paHhcGxhrgfXloObx5oE+LrzUg== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TFdraE1VVXJDSTMweWJuNExtNksrTmNJcnhhUHp1UHJDN2lMSWs3cmt4Y2pt?= =?utf-8?B?UW93WWVmbnJLUmZwR0s0SWRicWRSVUlZZGI5eENXU0xSK0dQWUhaSVJLQTg4?= =?utf-8?B?ZVRVUitYb2VLN3hyZENwR0syZ1c0a3FZTzM2Ri83WmJqVENreGtUZVgxSDhm?= =?utf-8?B?Rm1SVWtUTDQ3R2hkK1dnYnhFeCtQR2p4SWd6a1VmbUx1OFNKSEEyK2FOZTZM?= =?utf-8?B?UmQvdnpwSmp4cW5SbCtJa2RwOERsaFBTbEVta04rZ2ppRUxQaS81L1BSWkli?= =?utf-8?B?RmgrV3R0c2pYQ1JUZDh2amVhVGlrVzlmTXdRbSszdmx6MHhMclB0UlcvVEpi?= =?utf-8?B?NlllODJoY0Y2TG5kNDEvK1J5bEE3KzBGQW5JN3ZGQUtHRzAvYkwxWFlhbVVC?= =?utf-8?B?NTBrM0hLYnBDeDk2aVVLNVlmWmxycUY0RngzSnhKZmdINVV0a3Y3eEw3MC9k?= =?utf-8?B?cmNhbEx5bmZTWjBuOVhOY0dPUTM5Q0g2NFA0NGcvK2FQWlhsbTlBeW5CR0w3?= =?utf-8?B?SUJ1WlRocklsZ0dJLzNhaTYyOVlEMVdDWjN6bVJveVRyeGRpaFQyV1ZJbDdO?= =?utf-8?B?aUlTbzVyaGNkc0w3eUs0c2Jic2d1UHpTOEl1UzFyT25waGFDWi9qNlAzbGpC?= =?utf-8?B?ODE5TmI4Q2wyakVzanBVRlNaaEJkM01CWGgyVVViTit0SXUzSi85aEttM3Uv?= =?utf-8?B?WU5ySVJkSmZWcVRWTzVZS0lUWVhqZFM3cE9DblhJMGUwWU9FUlR3WFVhWGdn?= =?utf-8?B?MlBQWWFOeitqQ1JBNm9rR0VYWWRmUjZJTmdPb0xGVTVkMDRoTkZ5d0VqRlJT?= =?utf-8?B?TlFKRDVGRmVkUDlqMmpVTnE5NUJZUHQrbzRKeU1RdzdZWTV3R3BKMXA5SDZE?= =?utf-8?B?RmpteURWSGhGRlVNSEtwb24zL3NWMGord1RURHJ0ZXRoZHJFa1BvMDFKSFBO?= =?utf-8?B?WnozcEJNUnA3NThSQzhFMlhKN0I2Q2pLeEcrQUdBb2ZhV25IS3pzN21tOGxz?= =?utf-8?B?K3ZoZzg4SHBaakxDTjdZaHRCNStYTGFodWR2YnUweG92eWJkTVUrdGZwdUtU?= =?utf-8?B?MTBTQmpENzNHR25NWFltRXllRUxkZHJSd0dTM1ZxOEY5VXRYclR5cVF1aVNX?= =?utf-8?B?V1NmdGY0bzZjc3YraUc4Qld1eUp3aC91clJGUm0xdnhOTTZXYkNFcC9oZmty?= =?utf-8?B?V2hxZjgwVTF6dHg3VS82bUxEYmdiaFFzVVZMSWVnTUFXamtSbFU4M0haMW5t?= =?utf-8?B?bG5Dd3o1TTEwNkdZTDNxUTVYV0VHY25TNTcvTTgwSDVSdXlLYUx1SDBWVXQ5?= =?utf-8?B?UmY0MzdzNDR2NWJhczBabVIrSDU1QWpxdG8xVkZCTVhEL1NvMUtIV01NWWJp?= =?utf-8?B?cEY2NmFOTXo4U09qRFlKQjJxOGFpaWg3emJEdVBJNE50VDA4V2VHVEtUYjZU?= =?utf-8?B?a20wN0F4WGRoNXFUb0xPQ1hrY1NPY0MyYUltMmQ1amZSMmE3eGtrcDZXYkJo?= =?utf-8?B?cUh2SkNKUnhuNlZiSnRIYU81eGQ4SzVZUkFJMHlPc0M3QTUwQi94OUFBbjZm?= =?utf-8?B?b3RTNXA4U05MaHk0dmdaRVBqZzJDV3gyblFNdFpERU5GK3BUV2V4UEpjY0pv?= =?utf-8?B?Nk8veXhhbjZaaWQ2YkFvTnJDeWdqcmN3bUpzT2p1MDRlcXZ1T2l4WmhwSzEw?= =?utf-8?B?VkprbEd5b0gwaWp6RXhEbXMwQllhWDRzamtYZjZFcFNvRFJBcis5Sjd5cUVt?= =?utf-8?Q?UzejWih53Hd9vGRjcA=3D?= X-OriginatorOrg: sct-15-20-4778-2-msonline-outlook-1105a.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 1bb4de69-a911-403f-74fd-08da9b63a6ae X-MS-Exchange-CrossTenant-AuthSource: DB6PR07MB3175.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2022 23:55:52.9989 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR07MB8725 Subject: Re: [FFmpeg-devel] [PATCH] libavformat/fitsdec: use correct type for assert X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --------------LeJo5PFcZ5dAySFerFB0RvU0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Now with correct formatting. Patch attached. On 21/09/2022 01:22, Johannes Kauffmann wrote: > Since avbuf.len is of type unsigned and not int64_t, compare to UINT_MAX > instead of INT64_MAX. > > This fixes the following warning on clang: > > src/libavformat/fitsdec.c:177:26: warning: result of comparison of > constant 9223372036854775807 with expression of type 'unsigned int' is > always true [-Wtautological-constant-out-of-range-compare] > >     av_assert0(avbuf.len <= INT64_MAX && size <= INT64_MAX); >     ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > --- >  libavformat/fitsdec.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/fitsdec.c b/libavformat/fitsdec.c > index 54412c60ff..b2ef826f52 100644 > --- a/libavformat/fitsdec.c > +++ b/libavformat/fitsdec.c > @@ -174,7 +174,7 @@ static int fits_read_packet(AVFormatContext *s, > AVPacket *pkt) >          goto fail; >      } >  -    av_assert0(avbuf.len <= INT64_MAX && size <= INT64_MAX); > +    av_assert0(avbuf.len <= UINT_MAX && size <= INT64_MAX); >      if (avbuf.len + size > INT_MAX - 80)  { >          ret = AVERROR_INVALIDDATA; >          goto fail; --------------LeJo5PFcZ5dAySFerFB0RvU0 Content-Type: text/plain; charset=UTF-8; name="0001-libavformat-fitsdec-use-correct-type-for-assert.patch" Content-Disposition: attachment; filename*0="0001-libavformat-fitsdec-use-correct-type-for-assert.patch" Content-Transfer-Encoding: base64 RnJvbSBhNjE1ZDMyMjA0YzUwYWI4YTM0MWNhYWZiYTc2YjAyZmZlYmQyODc3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2hhbm5lcyBLYXVmZm1hbm4gPGpvaGFubmVza2F1ZmZtYW5u QGhvdG1haWwuY29tPgpEYXRlOiBXZWQsIDIxIFNlcCAyMDIyIDAxOjAwOjIzICswMjAwClN1Ympl Y3Q6IFtQQVRDSF0gbGliYXZmb3JtYXQvZml0c2RlYzogdXNlIGNvcnJlY3QgdHlwZSBmb3IgYXNz ZXJ0CgpTaW5jZSBhdmJ1Zi5sZW4gaXMgb2YgdHlwZSB1bnNpZ25lZCBhbmQgbm90IGludDY0X3Qs IGNvbXBhcmUgdG8gVUlOVF9NQVgKaW5zdGVhZCBvZiBJTlQ2NF9NQVguCgpUaGlzIGZpeGVzIHRo ZSBmb2xsb3dpbmcgd2FybmluZyBvbiBjbGFuZzoKCnNyYy9saWJhdmZvcm1hdC9maXRzZGVjLmM6 MTc3OjI2OiB3YXJuaW5nOiByZXN1bHQgb2YgY29tcGFyaXNvbiBvZgpjb25zdGFudCA5MjIzMzcy MDM2ODU0Nzc1ODA3IHdpdGggZXhwcmVzc2lvbiBvZiB0eXBlICd1bnNpZ25lZCBpbnQnIGlzCmFs d2F5cyB0cnVlIFstV3RhdXRvbG9naWNhbC1jb25zdGFudC1vdXQtb2YtcmFuZ2UtY29tcGFyZV0K CiAgICBhdl9hc3NlcnQwKGF2YnVmLmxlbiA8PSBJTlQ2NF9NQVggJiYgc2l6ZSA8PSBJTlQ2NF9N QVgpOwogICAgfn5+fn5+fn5+fn5+fn5+fn5+fn5+Xn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+ fn5+fn5+fgotLS0KIGxpYmF2Zm9ybWF0L2ZpdHNkZWMuYyB8IDIgKy0KIDEgZmlsZSBjaGFuZ2Vk LCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2xpYmF2Zm9ybWF0 L2ZpdHNkZWMuYyBiL2xpYmF2Zm9ybWF0L2ZpdHNkZWMuYwppbmRleCA1NDQxMmM2MGZmLi5iMmVm ODI2ZjUyIDEwMDY0NAotLS0gYS9saWJhdmZvcm1hdC9maXRzZGVjLmMKKysrIGIvbGliYXZmb3Jt YXQvZml0c2RlYy5jCkBAIC0xNzQsNyArMTc0LDcgQEAgc3RhdGljIGludCBmaXRzX3JlYWRfcGFj a2V0KEFWRm9ybWF0Q29udGV4dCAqcywgQVZQYWNrZXQgKnBrdCkKICAgICAgICAgZ290byBmYWls OwogICAgIH0KIAotICAgIGF2X2Fzc2VydDAoYXZidWYubGVuIDw9IElOVDY0X01BWCAmJiBzaXpl IDw9IElOVDY0X01BWCk7CisgICAgYXZfYXNzZXJ0MChhdmJ1Zi5sZW4gPD0gVUlOVF9NQVggJiYg c2l6ZSA8PSBJTlQ2NF9NQVgpOwogICAgIGlmIChhdmJ1Zi5sZW4gKyBzaXplID4gSU5UX01BWCAt IDgwKSAgewogICAgICAgICByZXQgPSBBVkVSUk9SX0lOVkFMSUREQVRBOwogICAgICAgICBnb3Rv IGZhaWw7Ci0tIAoyLjM0LjEKCg== --------------LeJo5PFcZ5dAySFerFB0RvU0 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --------------LeJo5PFcZ5dAySFerFB0RvU0--