From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CAF10437A5 for ; Tue, 28 Jun 2022 11:52:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5BEC868B931; Tue, 28 Jun 2022 14:52:49 +0300 (EEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-oln040092069086.outbound.protection.outlook.com [40.92.69.86]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 964FE68B58F for ; Tue, 28 Jun 2022 14:52:42 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jJlvk6MUfA5wlnhpvp6EcaypWi5JqMg6BlhghgwaHjY9a4B6UWZTzD6bEsWhkn6lG8+/mu/L3QwFxwpkS/4OPx8qjk9aP+t7mxJqmBV2h+pvAkSnLLxNOgM1PDyJuMnI0e95Efkjhr2beNoxltxzC1v/nx4793TumG4b0p/JYu89i1bda3GGAZuSiTG10kSZkH3PndfisY2lIMu9SYTGwKBvtpXE4T5ICMtBjecpVhFuymCLa+IKjxzyeUiL2m90OY2qhDU0AAUOxWWl9YZrAPf7ZksDcGSXo/iBjYRQEC07/fFg2uFCnDh59HUeWlrNl6OGypfcaVRWQk7kOQj1Ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sp2TXDI+5oGPsSz8uwQ9//Oi8QJu/GYQbWY8NiVvkXM=; b=cPvqyqNmmchnaPFMgJnE2d9H/UxAIUmArmejIU1C+lBnxONJ5h266+WuccBZqlmDsIEotNuM9nF6at+Y+ABAR5jwe/nfvue+28brtBarppR3it3w/a/TAlqb0XyHnOQF01OnM2foDFO+fp2wusvPVIvT62owWpgw6WrO1sQe5fCL2Py2ZzM2QmP+FI2ud6iR1jb7OsupIexjwhxpaDwifJ4l0R75IBjgnxwEWNYVQNw3y6fl7ZEBXjuE3/L08fr4QgDnVrzQ1L0siUxwIb20a0H5K4mHIF0HxSu4YfKzvvISLQ6aS4ezXpiJvelokKmve1vvJeJuJEMQN2jpt6Te2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sp2TXDI+5oGPsSz8uwQ9//Oi8QJu/GYQbWY8NiVvkXM=; b=RZ5OSbEHGMqyrF1hP6EFJpuFAH7UfAgvv6jX6dt8jMYRKTpPRuBYw8jJ7grpLfv0v+lfY8XGEgjIAotVH6e6TOt7ngaiLA3e3c9CF9h0eMVJXU8IJD7kIDb7c9M1ztqmHqpgQmZnot3KrVTAKPissb+IJBD8IHOpXxZyqMOMC80Ctaz5fWGol3ktyiXSmKergcUQs2eqhsBBZc+W0mLIe8a34SoruyQTMZND3vPrRL3d1TifWCbVbrkAb9ZLDPmmT3IZg/YIhu1K0c3mfUO00bTYmO8MVYeWdfRwegyLuZrM0D5j8Vw3QGr+CacK+mPcZXp4hnJG4Xcbt9Fr7x3Xyw== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by AM6PR0102MB3541.eurprd01.prod.exchangelabs.com (2603:10a6:209:19::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15; Tue, 28 Jun 2022 11:52:41 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c%10]) with mapi id 15.20.5373.018; Tue, 28 Jun 2022 11:52:41 +0000 Message-ID: Date: Tue, 28 Jun 2022 13:52:39 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220628115023.54166-1-lq@chinaffmpeg.org> From: Andreas Rheinhardt In-Reply-To: <20220628115023.54166-1-lq@chinaffmpeg.org> X-TMN: [S1Nljy9zz4w3Kix3pdU+K+gie8YRBbGn] X-ClientProxiedBy: AS9PR06CA0402.eurprd06.prod.outlook.com (2603:10a6:20b:461::20) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2b2fa30b-8f8a-4285-28fa-08da58fcb46e X-MS-TrafficTypeDiagnostic: AM6PR0102MB3541:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6dvRSqlKM1T2e5SETYIRUhXdk0wNyQcpiSJ94ZEKyDv9bG4DApCvW2HD7m4Zi8p0Z37dPgHKh/aaKjVKn7Km61MxZm5SNd8uRMHy5IgAhscWk4uv43KoPKWIfR/78vknGETv6S75+9MttWkwDlIkJAr3YLRcG3/lDGqEdq2W4WwwkdjmIV2noP/1PKOWEJFyBdLfHK1oBInzwDM9EDF4nPkuF7mP6sswj1/55kl06wj00TK8Kk0B2e+rkGVEuxh0haJxLYysE1ubhFh270AlfVJlJMhJRjx/S724xIkKNTQBywygdJyUXvrICwyCpEj+MKm8J2vEUOKdIull6xXAeXeqG41oKal+KqAdVPsj5rV+Y/u6etFDXY/HKzAZ3oAqJuwhHXBwcnla+GYuMByykuqWrRveEAeo093bO9pkFnjIeWMSZmMsNbXXHuY/o+lqQvlIfA9cdVBQ4bXMjdo4nspxhhuHPY0nNi5syy65oOmCtQ2bdrRPuHZpSE++l82qQM9M1vCnlaqlLKj54yqiAG7T4fDvgzq4bx7XlwOulfO6iKRZ/bGhTYIJdGqL3VMFqYF0S2zCeWqjpqmmI8ZOi9CkR6OZ9oBQxavQdQXtqT8ilb13y+583XCuxbv9ZjffcCioGtvkwC3dLCCsRqG+Iw== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VnphdVJBSFcrd2xTaEE5VllkMzMvVzRDT3FwQkZXa2ZpM3FjU0JOM08wVUtv?= =?utf-8?B?SmRueXpZWGdiMGNuWno3RGRGNVlJaTVsMGsrc2NlMW9SaW02NDVUZVNJYmdp?= =?utf-8?B?RS82TjZlZjhBelNoN2dOVW1sYWxXUXR0aittWVVqQjkzWUsvT0ZBVDBvVnNo?= =?utf-8?B?M3lhSTRYOWNWZ2plcHk3dzlMMGdpNXhGZG1ORUhDTXRwUWdYaEdWcllPdS9s?= =?utf-8?B?RUdLM2FiM0NkZzZPM1VyMGtHMHZQTVdwYjIrTlY1ZVN2YVZVVnlab3lIRGxP?= =?utf-8?B?dnpEUnpsTzBrRnQrUGdPK3VHNGM4cDBxSU1jclRBVHJ2SWhRVHo1a1Z4R1Uy?= =?utf-8?B?ZkVPNzhZMEt4Y1NWMkxNRkNkNzhvTCtOTW85NDBqL2NvYkZsQzBBWm1JaHR0?= =?utf-8?B?TE5QbithNGRGVzNRNloyR0ZLenovWUtndnljUysyUjNQcWxuSUhZOVRrTUU1?= =?utf-8?B?d0VCMWlVNFMxSW9uWmJ4NWNMVEl2bVZzdUswN0ZiVW5yVllya2EwYzZCSVk2?= =?utf-8?B?bTBQbk1vV0MxVlExNm5ldXkyb3Vpd0VHd3krSnh0YTZDeVJ6RWRiWGgzbUox?= =?utf-8?B?ZDUrTklNUzhiZ1pPbjdVcXJvYWhxNHRDcmRZelcxLzdBZTJROGR2SU4yVlgv?= =?utf-8?B?ODFrb0JGRjhYbkhqTmp3YXkxVXFtRDY1RFlqVE01MlkzMFZscmE2aTJBOTBI?= =?utf-8?B?ODRVSUtyZCtHTmZocVN2d2tHeEJoN2d4b3JzZmt6eHJjMlE5OCsybHlJbXJC?= =?utf-8?B?Y2RrWHdibEZZYzJxSEEwVGw4SDNnczNoanhYZG0vekNBeHpvRDNSRHdkWnFs?= =?utf-8?B?dU9GQVYyMjBERyszazI5U3RkNlNkRVZ4OW1Fa0RQYUtYWkRYVExYN00yYytu?= =?utf-8?B?VTFFdEZCR3k2SDdqaWs1VGRXOXFZMk1PakFCWUc2eHUyd01kU05FU21QV1A0?= =?utf-8?B?YkVMbTdBb05RZzcvZ3l0TklmWCtCcndRLzlWZzhsSHM4SHdCS0EwamlKWTJB?= =?utf-8?B?REZSWDhTTDRseUJoMHc1Z0ExQWlHc3l0WDBQL0VqczcxN1BFUitwd0dMb29T?= =?utf-8?B?TzZ6TlFDOWFHVnlpaWtHd0pONFc0aFNvN0RrZjFGOUswRVVsVVJSNHZnSWxO?= =?utf-8?B?VlVhUTBhcS9reW1ManhCWDZhck11RG5rTStEbW1pRDRvWWtxSUlCMmd1eXRy?= =?utf-8?B?aUxxOHkzRGlhY3dyZFNuaHh4VkpKVjRDWWNqNXFEM29XU2FpNWNpQ0swTHRB?= =?utf-8?B?SlpEZFR5NnVOajFOaXFNQ09zdyt5MHNPL0oxVlA1MjlYb05qUStjSnBuNUxX?= =?utf-8?B?ckNWSHFUNTNORjNLNVE0YUlqVjZOM3BIV2M4Mk9jejM4S0p0YzRINWFyMXYr?= =?utf-8?B?WktGeElnREdGeG1LNEhVSUpKYkZZVGhuWitONi9ab09EZ1U1cHNxR052SEE1?= =?utf-8?B?NUlZOXVIY2d3QUorSUp2RzVEckVDckJGdkNrTFJnaGppaThMSTlCZ2JIOXp0?= =?utf-8?B?MUdScTVIb0IvSk1uRjFZRUlVcVFjUGZtbWZQUmtGOTFzQ2NGUGtFZlNHZ2xp?= =?utf-8?B?VlR5dzlhallLdmRIZEd4N3FJZnpubjh5Sk52VFQvb2tUcjUxK3pBc2dIVVVm?= =?utf-8?B?bXRtYWhxRjVvckd3RG40WVI2VUNYdzJ3Z0xxWmFKWlkxQk1pL3VZenQ5VVJX?= =?utf-8?B?RFBpNW9KeXJ0YXlvSy9SYVE5WEltYXloMUFuYWthelRCN2tpdllRb1hOZits?= =?utf-8?Q?LkBMesFyzssPTJF27M=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b2fa30b-8f8a-4285-28fa-08da58fcb46e X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2022 11:52:41.1436 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0102MB3541 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/encode: change the assert0 from (ret <= 0) to (ret >= 0) X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Steven Liu: > Because the codec->cb.encode return 0 is successed, > and the negative error code should failed. > > Signed-off-by: Steven Liu > --- > libavcodec/encode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/encode.c b/libavcodec/encode.c > index b68bf1e184..b43a16f708 100644 > --- a/libavcodec/encode.c > +++ b/libavcodec/encode.c > @@ -217,7 +217,7 @@ static int encode_simple_internal(AVCodecContext *avctx, AVPacket *avpkt) > avpkt->pts = avpkt->dts = frame->pts; > } > > - av_assert0(ret <= 0); > + av_assert0(ret >= 0); > > emms_c(); > You are asserting that encoding succeeds (and you allow encoders to return values > 0, which this check is meant to preclude). This is just wrong. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".