From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 74D2D43E49 for ; Tue, 16 Aug 2022 07:09:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5750068B88B; Tue, 16 Aug 2022 10:09:05 +0300 (EEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-oln040092075109.outbound.protection.outlook.com [40.92.75.109]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3586A68B702 for ; Tue, 16 Aug 2022 10:08:58 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RRWI1yD4mstEP4kCFILzlWhBrZL5zSGTj/Jn9T5s60bPsBqKDdlQar460atgAkeweIwK4bO65c2e4Bk7AAf502XgfC53haMywjRcza6N/CtmN1Iqk3ZNOwTl3F+yiuwfgyNeDdaFb38hWc4Rlitb+qZA8IyQ4o/NUlh69AnDu5NLstldxvUGFPWBywYYngECVqrssIafjhINnYTPLq2PvGWHoE/q8pBDJ+D0PBZ9Z1XXXOiVx3XeUP111SvX7Pne0NMzfgBBaJnq99U4Opi+fqsA9P9jOX+z/z/vz867t+ZzpMysGl+ltly63ZaMjS471ZZwtpPLzsu07hOGJiCD1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HzYb8Cned/VlxP4XG/zv0WxfVf1G73znZKpW726S+Ag=; b=XUifcJim677XIisz/JmWjXz3NwcZfKgue9Oto2oLUhA4G12ONdiyWQp/Tb1CSZlUyIUFuVzEAhTaC3d7Iznvc7bGcbszRiY6QhGNLbfih0coka5gTz0cc6Q8ChfTtBQTr5ZYfoCcuWZMHaB4+4SRpdTwKQ4LdgKVn94TBTh1BAISvStn0M2m003xrXZqmrBGX4FlfUn9N/llrRwQC+dU9vbrs3BZdT+ugnGzl9pYIBMs2YfiY5Qw2fjhrJDrzf6xFATzipRZYnO+31tWk5TjqMxSH8E1/k9G/s7yLRkzhoQyRDAVNCpR9p/gcjBbRf+CkhJ1TfpkEnclA+TOYXz9kA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HzYb8Cned/VlxP4XG/zv0WxfVf1G73znZKpW726S+Ag=; b=THkZprDaFCuQR1BdfsaFrGYfuhPLVV0ZVMa2hdi7UnR8IcRkO/rm7+KSNXq3Uv+YBCh6wtA2P71gLEDc8GSxXFWEOveZVRI7K4ZQGATC83J8IvpdC8zG/kknfdyeNlC8psrwWi3j17ALgyHDK5RZpJc1OXLd+gBlIpPdxcG18AiviygBJ++morTAV7mpECf0x6nDEhkq73Zz/5o/jBNn8xjVU39CQ8AmDxJwMTUjhmYQAhtExjQv8/2xjCld+dFjjMfiO70Mc1+2DGXlHbqXTOMDVBLH/hTZvnkwcKLaZOgukMCO5EKtaWRPDRChi2JY/Nwd+amQy9oBDi1ODndfaA== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by AS8PR01MB7941.eurprd01.prod.exchangelabs.com (2603:10a6:20b:370::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.16; Tue, 16 Aug 2022 07:08:56 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::210e:b627:bcc9:8c46]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::210e:b627:bcc9:8c46%11]) with mapi id 15.20.5504.028; Tue, 16 Aug 2022 07:08:56 +0000 Message-ID: Date: Tue, 16 Aug 2022 09:08:55 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220815222150.GW2088045@pb2> From: Andreas Rheinhardt In-Reply-To: <20220815222150.GW2088045@pb2> X-TMN: [OJnBFZ0D65pzuhaczRg3gt8DbFOaAgEW] X-ClientProxiedBy: ZR0P278CA0141.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:40::20) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b4ff981a-976e-4801-62a6-08da7f562f1f X-MS-TrafficTypeDiagnostic: AS8PR01MB7941:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wySaFLmRkmP3ePky1w+ouWyX62ijhrNPpaCHngDzdLWzdahSYNNaPuqPBWoEvTeL0KVV5LIiLWIlaVnofVgHaEddTJFFiES0v81G4omHlznFRkMzqNyJRx4TQg7koMW71Te23Nxxc9ZtZ3RYBEG8XsETXWW0bGb2FMVzUIpiIo3i6hQXEgAWOW52D+suRXdyu1DWyW3RlJexdWp4kUzoDF5UmwOo3Iun5+6GiABao6N8vZumvU4HYtv9dZp8lHSBdxsagfyRyQoi2nVQiLcTMTWuR1IFvdph3A9daPCgjDse1h9eowqNHyjDOQN0njb9FtUjp95MCZbcte4fmlTgxbccDLQx4wbZmduMgdjqreEFLftRVLSjid0b2Ewk7u5dco8Dkx6C0HJzBbgTx5glIvR+tHh55rZ0uiHMsa1v8qyGKSsUrhZrJwT6w++6TUAdTujw12z/6ZkNMnS/0CCtg8mTPpNxW5P6etrOHjLvb1ee8KJEM+zuAAN9xDie4A4p366a2YE1dU3BPIMMBTJJD7admLIiJW/r23dwVVS46vpNjQfPmB8Y4ci5PjNFVa0xLvtUY631z3ALO8q3/1rdKWRviTJHf1CibMppliHssoMt92T7kcE86o+kVz1LPyXoTL1swo0/zk1nWyMV9TG27dOM+r8TIEwh9/VafXVIqziGqfERzsadV3v2nrUKY8Ns X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VllSUGdWbGdLVFp6cExHZjEvaGZqL2FRYjc4SFlwbnVYeVBLK2dsblI0RmUx?= =?utf-8?B?QzNCRjFMZW9NNmJaZjUwN1p0V3R1L011cGlWaDVTSWdKY3R6NDNNZTR2OHNR?= =?utf-8?B?bFBhNkVLS1ZXdjlZTlVZOVJ3QytKZThKSG9QRGhCaFdYZ0kwSnlJeHYzaGgv?= =?utf-8?B?Ymh5VkxEdVdoZUNZaWxLS2J3TEh6MU90djVIOXF0ZkpPMXBsOHVlZ2VsU0cx?= =?utf-8?B?U1pJT3ZMTnFzVGxnbUhxNHgxc0RlZWRQZ2FLcytPRU11eHhLVHBmVmNaTUhl?= =?utf-8?B?KzBYdkhBbjZUKzlYM0dua1hVMEhUbjlwbTMwaWdlY3dRODd6cWVERGVkVTMy?= =?utf-8?B?Y0FPYnd5WEZiS2MrcVI3ejVSbXJSYXd4dHZkWFFmSWEvd0phek9uSU1VdHN0?= =?utf-8?B?Sysvc2lXMks2MlVoTk92UWFOTzBLR0x1cEN0QWFQeVBYMVBvNEpicFVjdHQ2?= =?utf-8?B?UTduTlFlcXpXcDljKzkwc1FwVW5nV3VWdFZNdlJVb1VDM09MWGptZ2YrTmhY?= =?utf-8?B?dHZDME9xWGJyQ3ZlaTJHem1kb0xucGdrbVRmcUlBcW1sREgxTjA4dkw5d3pO?= =?utf-8?B?Rm9uY3dBS0FhOEY3WVhYVlRHRjMrZ3E1OG1kQUsvSzJqeTlxVDZpSVF6ektP?= =?utf-8?B?SWx3WUJHRng1Y1V0QnRzQys3QXFhNFVJcGZFNVZnU25UOGJlcktXY0NEZ2Jh?= =?utf-8?B?ZTNQNG5QQVY0SzNmL3NuYjVTV2lIeUFKU0pjbVBuODZxU3FNVE5Bc1FwSlI3?= =?utf-8?B?LzU5cEZ1d1N2QS9LOTl4MjNjMWNmMjdDMGZuMzlKZVdrMmxFTm1RV2FtMWpq?= =?utf-8?B?UEpvZU5FOENGVndGYWJGSUNuZnFKeWVoVzNHRHhyVjNnMnZIUncvZHhHQWN0?= =?utf-8?B?WXY5bWlVYVlYM1RoSzZFYU5xc0FiY2tlYjcwNDlPR1dpakI0SnFaazNNSGJr?= =?utf-8?B?dURqUm9GUURrZlE1ZU5kWHVNUVRUdndqbU5hd05TTDRKNDU1cHE3eHUrL2N2?= =?utf-8?B?RzkrVWxNbXhEck5zQXNKT0pNSEU2T2xsOUhjUFdsZENJWnFVMHhNRGJ1YmNi?= =?utf-8?B?Q1JtNWFQM2h4TjBpVWJ6VnYzYmxsZjZoLzZLWnZVTkNwT1YyMnEyY3JEeGlQ?= =?utf-8?B?aUx2UzZtc2JiN2Q0ZEJKaExEeDJOMWc4c2R5bTc0TkNIS3orcEJ5SXFtV3ZQ?= =?utf-8?B?RTNHeExHdTdTSEVtZkxYZnhkbGFTa2ZzVldIZm1MTGFtcmgxd0Y4S0F3WHg5?= =?utf-8?B?QzZnSDJRa1JXazdRUlduNGpFV0JudmpwZkt3UDVhWnZxYm56T21vMk1ST3J3?= =?utf-8?B?aUFFQXpvZkh6WHdSc043OVEvcDBicktVbUVTK1dqTmNVTENib2NJaStBRGtr?= =?utf-8?B?RG1GSDhPMEV5QkJNRHRnb3BiWkdOdU54K3Z1cDFETkdYZExHOGlrekM0Sitq?= =?utf-8?B?MjJCR3FhYS9JZFhuUEt5dDFFanNuWGxRR2ZnZ0RHdlE0RkIwem5rYldHdkE2?= =?utf-8?B?VU5Dajh4ZlVlVGIrTERFUUF3a3NpT0lkVmFpSjBlTk54V3drajNOUHpIVkdj?= =?utf-8?B?UmpPdFIzU2V3bmhVL1Q1Z09uMmxNR0MydmlXaG1UYk5wbytUdEoydlJoMXRa?= =?utf-8?B?djB0WjBxbXQzcjFUdGNBVWRBVlVqR0g0N2x2NXJqOTdsN2V0cWFwUEdrWWFl?= =?utf-8?B?a0dHQmZMVEVWUitQYmZ0KzVoOTJuUHZIcTlycXNJTzZXamtNTCtCYXNzRXZ2?= =?utf-8?Q?EUe+/9u7UJkcmt8/l8=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b4ff981a-976e-4801-62a6-08da7f562f1f X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2022 07:08:56.5065 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR01MB7941 Subject: Re: [FFmpeg-devel] [PATCH 1/7] avcodec/h263dec: Remove redundant code to set cur_pic_ptr X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > On Mon, Aug 15, 2022 at 01:49:24PM +0200, Andreas Rheinhardt wrote: >> It is done later in ff_mpv_frame_start() (and nobody uses >> current_picture_ptr between setting it in ff_mpv_frame_start()). >> >> (The reason the vsynth*-h263-obmc code changes is because >> the call to ff_find_unused_picture() now happens after the older >> pictures have been unreferenced in ff_mpv_frame_start(), >> so that their slots in the picture array can be immediately >> reused; the obmc code is somehow buggy and changes its output >> depending on the earlier contents of the motion_val buffer.) >> >> Signed-off-by: Andreas Rheinhardt >> --- > >> I'd like to take this opportunity to once again ask anyone familiar >> with H.263 to take a look at this OBMC issue. > > Iam too busy ATM :( i might look at some point but its not very high > on my todo as it works :) security & release is more important > Good that you became aware of this issue. (You were the "anyone familiar with H.263" person I thought of.) > but i can say this breaks fate as it is: > I am aware of this; this is due to a slight conflict with b645138a34321fb1d1b7988cd0d78b897e4d65ca. The ref file changes were appropriate for git master at the time I sent this. I already updated mine locally. > --- ./tests/ref/vsynth/vsynth1-h263-obmc 2022-08-16 00:19:00.345967181 +0200 > +++ tests/data/fate/vsynth1-h263-obmc 2022-08-16 00:19:05.262017999 +0200 > @@ -1,4 +1,4 @@ > 7dec64380f375e5118b66f3baaaa1e24 *tests/data/fate/vsynth1-h263-obmc.avi > 657320 tests/data/fate/vsynth1-h263-obmc.avi > -f5048b5f0c98833a1d11f8034fb1827f *tests/data/fate/vsynth1-h263-obmc.out.rawvideo > -stddev: 8.12 PSNR: 29.93 MAXDIFF: 113 bytes: 7603200/ 7603200 > +2a69f6b37378aa34418dfd04ec98c1c8 *tests/data/fate/vsynth1-h263-obmc.out.rawvideo > +stddev: 8.38 PSNR: 29.66 MAXDIFF: 116 bytes: 7603200/ 7603200 > Test vsynth1-h263-obmc failed. Look at tests/data/fate/vsynth1-h263-obmc.err for details. > tests/Makefile:304: recipe for target 'fate-vsynth1-h263-obmc' failed > make: *** [fate-vsynth1-h263-obmc] Error 1 > > [...] _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".