Re: [FFmpeg-devel] [PATCH v5 1/1] avutil/csp: create public API for colorspace structs

From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v5 1/1] avutil/csp: create public API for colorspace structs
Date: Sat, 28 May 2022 12:42:14 +0200
Message-ID: <DB6PR0101MB2214EF8A692D0A3E9634806F8FDB9@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com> (raw)
In-Reply-To: <c373b284-5737-8d29-7b1e-cb103265e2c8@gmail.com>

Leo Izen:
> 
> On 5/24/22 16:56, Andreas Rheinhardt wrote:
>> Leo Izen:
>>> +#define AVUTIL_CSP_DENOM 100000
>>
>> Why not 300000 given that the denominator of one of the constants has a
>> factor of three?
>> (Sorry if this has already been answered before.)
>>
> 
> I suggested this to haasn, but he pointed out that the 1/3 can be (and
> is) manually coded as {1, 3} without using the macro. The spec defines
> it as one-third exactly, not via a float value. Adding a factor of 3 to
> every denominator shouldn't be necessary as the various av_q functions
> handle that gracefully already.
> 

Then I don't even know why we prescribe the denominator the user should
use; why don't we let choosing the precision to them?

- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".