From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4CC224289A for ; Thu, 4 Aug 2022 14:51:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CA25668B9C6; Thu, 4 Aug 2022 17:51:31 +0300 (EEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-oln040092075100.outbound.protection.outlook.com [40.92.75.100]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2D23B68B99A for ; Thu, 4 Aug 2022 17:51:25 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bgWRcRx+T8B+Yzzajg+dIX42kGTXIRbbbO58ECnS8N3wxRqvpp7a+ewlvdjsoUiYBRaLm1rgwhDh0owmXJqJNpcszNMozNC3/YzNeCc2P0n7zg48iq7ZaN52wcM1hOGScBf9qj989/q7osmjQ6Ygx0Kq6/f39BsxSLLfoY/uA3p0Yu/PbnrcAc+0xy9+OI+ZuXcXrEajUkKJitRRsMEMQKqQbIPMTUm8A0DBpQr0AhdgklBvgutu31Q5t8JpH+Stf9JCSLmMcG1WTDvXoDoLbY4PyxS9dJNTTf0Pnxxgu01/PNmOWxmOg6e6L0oJDmkXQCepVA3x9yN2XANX0yvbJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mAjhniTbRS5aRsWbnCw1iAzZRobJ9SYqxvizEB2A40U=; b=cPzI1lTH1aCllbUfS0MackNkRus65GugcPAMUJL8eNj0JqslD/5SKrfdjStjdXONE7Xwn5B6H/AJNmmv3cxj7hS0WNvvWTGcX2zNjxrWGJE+/ZZpuduCiOEPJXoXdcsGcjp74C9kKneLRbsN7GCCUOFtpGclf3a3xx6+sgniF0eRrZOLNrJwev6UDnWqEf8epoyhVYFpbH72uQpbkmFxTHXHFuHeqbxohPGd0K5mufKZlgs/6ORMzUlfDwxmvkLXYzGJFVOjy4abDyzkkis7Mxp+naK43iV1mh/NXpWXpS7mEqtGC5PEcLKpHNQ7c55+WCstgO3s4HHbDF1H2i3AGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mAjhniTbRS5aRsWbnCw1iAzZRobJ9SYqxvizEB2A40U=; b=LRVWbJ/MjeMf3B6p2otbIcjlA2z4xPzDqqjhCYLktxFYip6d7uWKu6CKuSiv1J2aDIKQ2vtRSAcIoAehwVeJQAiaEHRqg/t3HDCc5N6DhxYJnYVKzUkq3bYfvfdECKEkDp5wvcxzyiAkc5uTLkC4Y1RuoDn7lUEKJ/c11LbuNSjrjKLBWRtWkayWWshVTp2Pkyt5ivagRIcsZGfhRn8pU+KZ+HN8HfStx4ppyRwEcsZAl+1mCvfx4mSx6O1Z2c6OiVdlRUYAkktSC3N6tkV/qhv8QW9UJ/qAgssoSDO6oCqrAWZJaNdoE8XADqYsBa0RRFwdaJcWv513TgYbC95Xrg== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by AM0PR01MB4465.eurprd01.prod.exchangelabs.com (2603:10a6:208:ec::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Thu, 4 Aug 2022 14:51:23 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::210e:b627:bcc9:8c46]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::210e:b627:bcc9:8c46%11]) with mapi id 15.20.5482.016; Thu, 4 Aug 2022 14:51:23 +0000 Message-ID: Date: Thu, 4 Aug 2022 16:51:22 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220803135844.16662-1-anton@khirnov.net> <20220803135844.16662-7-anton@khirnov.net> <20220804124009.GI2088045@pb2> <165962387647.15471.8117322129211321627@lain.khirnov.net> From: Andreas Rheinhardt In-Reply-To: <165962387647.15471.8117322129211321627@lain.khirnov.net> X-TMN: [nmOc2JfrLCVyOIkmrsxlCiZXSLaElX65] X-ClientProxiedBy: AS9PR06CA0173.eurprd06.prod.outlook.com (2603:10a6:20b:45c::7) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b1fac434-f2e1-4cd8-021a-08da7628cca8 X-MS-TrafficTypeDiagnostic: AM0PR01MB4465:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5NVmynRHL22OOb0e9osBtXbVMVD9CNK9Oal2ytV6FaXBcu0qUqsPXNJWHcZJ9OJfZwk1QbLQyuN3ddlpB4f0B0KWNZ7nGgyFT3cbPPC9PxCYGnTNRC2EXPAx1/LHGElylzeuzFYSuCofWZNtJF4RwqqlQoavrTnwGpQJlwa0eB0TkXclfXpDTbMaAMpn+ibPhZa2FO92jlOzudh3XW0aY/R0iVgEGexMrFhX3XfqEOheygJxUAzmjJEbLxluyzH6lZQ+3/U+PJuAHFEtxj9ibLLHhPYISNbx5oveL4h/pAa+IoP7DyHlJX7XcxHI34xwqni8ENvbrBYZVX7UQj7BlRW0f1uPhnBlt3hE6cK1hR/fiUQB/9VeSGToB9vYdrWg7c50mW0cRyEdHGv9LVRiygzJmrGAeXzF4+skTBPhdSMJjaS58l/yvZKB6zD/o/dzTGKm3r75nG5ViVy3x97pEIGKUdbWmj4qEre2ut29PdvjKKS3auyo+dZhz4m49M8JzZMI8QiwgCK8jCz6lGTeD50+c41bTGriw/iKIF9ncSFnUEvOwuuPkmeRkkqwWTHVIwqIgvP/0JO4peHZrkNSrGMd74dfJCaYEml7u8+pNVYaq9bj4bCXC40SpRQdcW12XU1BGSFO6cK2Ij+BtyvfjDOuY5Gg1RlisPSj1imsxo7dYJ6c3igPLAXpIVjf8tfL X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aUZPOU0zdTdwaDYxUGpoditjSjhreGhJeHJZc3JkVkFxb1hOa01pQit1cC9m?= =?utf-8?B?T2RuQjcyejlmTWZSM3FPL1VScElSRlFZd1JjV2NGUElYcTd2YTd0QXVlQlFT?= =?utf-8?B?Z1FocUIwOWF2NkhUNnhxSUdseG9WWGhoWS9uc01uZmNyWUFHR1hMbStMQVow?= =?utf-8?B?ZVB2VlMzLytpWVNMV0l3WExNODRSZE1oRGdmSFhFemFsclV2YkFLcU55NzN6?= =?utf-8?B?UzRuQjdoOUJuVkFYS1dCblI2Qk5CZmM4MVNydEFzM0Nidk0wN3psVjcwcyt5?= =?utf-8?B?MU5kTWVUQUFpeTgyUnYvS2pSSWoyTURuVk0rSUx5THFzS3hLN09pQWxHaHFz?= =?utf-8?B?WE5nT3c3QUpJTUI1MS9rNDdsaklITjRnWHRiVCtGQTNlTWNBOW5xYW9NV1Mv?= =?utf-8?B?OHBCYWJjVU9qbFlmd0NvN1MxTHhnUHNRK3dSalRvUVFkYTk3QXE4em82Lzcz?= =?utf-8?B?ZlNON3FZeFFzSklKVEMwRStFWXRFYm1aQyt0ZTF3a1lyaGY0SWsxcEQzcmFH?= =?utf-8?B?R2tZblBLb1NubGZNaENLODJBTEFTZmlReC9CV0hGQnFQYWV4RkU5anVneFo5?= =?utf-8?B?ZXp4U1hKM1VxVVY2UURZamlMRERLM3Y1bFRRYnJkQmJZK3NOcTNFVGxRbGJs?= =?utf-8?B?L1ZiaVZnTXhUeHFVMS9uQ29pSDQ5QlJVdHlhZzlubmMzK1M1Wm1haTArMm5z?= =?utf-8?B?YmpYbnhtdWV1Z1VkNnIrYzNYNytxeWIyS0dFUDg2TlJwdm1nb0F2Y1Y2d3lU?= =?utf-8?B?RDBGRTVsL2IwYnhZaXhzeU9iVUFFZU9RUXIyWmVTQVRhT043dXZJcnlLcDMw?= =?utf-8?B?RlI1M1IyR3BkUENkTGhEY3NQa3R6RERYYUJ5WlRjbHkybWN1dTNoWkhZaHFF?= =?utf-8?B?TE0ycTRrZmFmb2hEb25weFVuWm1Id2gxOGdFdVBQb3BjOHFiMXZSN0ZCU01S?= =?utf-8?B?clRYN1cyYUFmU04xbXdvN3FvVHQyTVBQRzZUTCtvOUdSaWpTR0paL21zRnU3?= =?utf-8?B?bHIyU2JnaWcxTnlESXE1UkdpdGxrY053YU1pSlJ5ZHVDdDR6anpiN1I2NG9W?= =?utf-8?B?MG5pb1ZTV2V3N2RUcFk5K0FnRHpINTFLZmliaHpCb2M4TFA3NjVzN3FnZmxw?= =?utf-8?B?WUs5Mm1JcGxnVTJwcUEvL3lIMFBhSEVkNCtEVFNWTUw0UlJtc3EvTzI1cUpw?= =?utf-8?B?Q210M3NXSzZPbyt3eHV2Wkt5TnYwVU9hTTNVTUEvQkpOd3dXVnZ4VUtHTXJE?= =?utf-8?B?Yks3NTZmZXlrSStOQ1h2eEZ2eHoxbHpRc3pDdEMzRlFiY0ZNMFB4bzJLWU1K?= =?utf-8?B?dE8yTzBncWxEOG9Kekx2ejFGWHJLbm80aEZ4dTZLSUIwbUt4Nkp6OTlWVGhp?= =?utf-8?B?MzRJRnlic1IxVVJDNjZSd3hTN0NUb1Ayd29hMjB5QlVGSzIzNWtiN2JINUxt?= =?utf-8?B?QTRZU0g4TFhwMjV4a0pOWFAwcFlCSVRyMitBU0xXQ2xDS3NCT3F0eTNrT0tP?= =?utf-8?B?eVNOVkx0NFMzMzJ5MUs3MDVEdWd4TW10WEVCSVl5SXU5LzNwOW1CaEhKSVAx?= =?utf-8?B?eVR0VmNzaFV4MkM1N0swckVBdzVqSmc2amtCeHc4STNIS0tNYWN1UmZ1L2RV?= =?utf-8?B?Z05aajhvWXRuaDhHZWJvUjdKeTFHd3g0TVN1U0oxdllXdlA2TEZUZkNSR043?= =?utf-8?B?Y1hlK2dmVlNaVU5peTNDazZaS3BYQUZKT3B5cGxYbmI3NFF1YVkrUytvWUhT?= =?utf-8?Q?ut+Vci1h1DU2MgmgWU=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1fac434-f2e1-4cd8-021a-08da7628cca8 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2022 14:51:23.3490 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR01MB4465 Subject: Re: [FFmpeg-devel] [PATCH 07/25] fftools/ffmpeg: remove OutputStream.stream_copy X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Anton Khirnov: > Quoting Andreas Rheinhardt (2022-08-04 14:54:41) >> Michael Niedermayer: >>> On Wed, Aug 03, 2022 at 03:58:26PM +0200, Anton Khirnov wrote: >>>> There are currently three possible modes for an output stream: >>>> 1) The stream is produced by encoding output from some filtergraph. This >>>> is true when ost->enc_ctx != NULL, or equivalently when >>>> ost->encoding_needed != 0. >>>> 2) The stream is produced by copying some input stream's packets. This >>>> is true when ost->enc_ctx == NULL && ost->source_index >= 0. >>>> 3) The stream is produced by attaching some file directly. This is true >>>> when ost->enc_ctx == NULL && ost->source_index < 0. >>>> >>>> OutputStream.stream_copy is currently used to identify case 2), and >>>> sometimes to confusingly (or even incorrectly) identify case 1). Remove >>>> it, replacing its usage with checking enc_ctx/source_index values. >>>> --- >>>> fftools/ffmpeg.c | 23 +++++++++-------------- >>>> fftools/ffmpeg.h | 1 - >>>> fftools/ffmpeg_opt.c | 33 ++++++++++++--------------------- >>>> 3 files changed, 21 insertions(+), 36 deletions(-) >>> >>> seems to break build with shared libs: >>> >>> CC fftools/ffmpeg.o >>> src/fftools/ffmpeg.c:405:32: warning: suggest braces around initialization of subobject [-Wmissing-braces] >>> struct sigaction action = {0}; >>> ^ >>> {} >>> src/fftools/ffmpeg.c:1612:37: error: address argument to atomic operation must be a pointer to non-const _Atomic type ('const atomic_uint_least64_t *' (aka 'const _Atomic(uint_least64_t) *') invalid) >>> uint64_t frame_number = atomic_load(&ost->packets_written); >>> ^ ~~~~~~~~~~~~~~~~~~~~~ >>> /usr/lib/llvm-6.0/lib/clang/6.0.0/include/stdatomic.h:134:29: note: expanded from macro 'atomic_load' >>> #define atomic_load(object) __c11_atomic_load(object, __ATOMIC_SEQ_CST) >>> ^ ~~~~~~ >>> 1 warning and 1 error generated. >>> src/ffbuild/common.mak:81: recipe for target 'fftools/ffmpeg.o' failed >>> make: *** [fftools/ffmpeg.o] Error 1 >>> >>> [...] >>> >> >> This has nothing to do with shared libs. It is just that C11 defines >> atomic_load in such a way that it does not allow a pointer to const >> atomic; presumably because atomic types might be emulated via mutexes in >> which case even a read involves a write. > > I don't even get a warning with gcc 11 or clang 13. > Yes, same for me (this is meant literally: https://ffmpeg.org/pipermail/ffmpeg-devel/2022-July/298360.html). Maybe the spec has been modified since then: https://www.open-std.org/jtc1/sc22/wg14/www/docs/n1807.htm and https://en.cppreference.com/w/c/atomic/atomic_load indicate this. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".