Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Subject: [FFmpeg-devel] [PATCH 5/5] fate/wavpack: Test APE cuesheet tags
Date: Mon, 30 May 2022 16:03:38 +0200
Message-ID: <DB6PR0101MB2214E373472AEB858C08B6138FDD9@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com> (raw)
In-Reply-To: <DB6PR0101MB2214DBC86F49EDDF15D59BC88FDD9@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com>

The cue_sheet.wv sample contains a cue sheet as APE tags,
yet this is not really covered by fate-wavpack-cuesheet
because the metadata does not affect the output of said test.
So add a proper test for this.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 tests/fate/wavpack.mak               |  7 +-
 tests/ref/fate/wavpack-cuesheet-tags | 98 ++++++++++++++++++++++++++++
 2 files changed, 104 insertions(+), 1 deletion(-)
 create mode 100644 tests/ref/fate/wavpack-cuesheet-tags

diff --git a/tests/fate/wavpack.mak b/tests/fate/wavpack.mak
index 900e509aba..c684d93f99 100644
--- a/tests/fate/wavpack.mak
+++ b/tests/fate/wavpack.mak
@@ -77,6 +77,10 @@ fate-wavpack-clipping: CMD = md5pipe -i $(TARGET_SAMPLES)/wavpack/special/clippi
 FATE_WAVPACK_S16 += fate-wavpack-cuesheet
 fate-wavpack-cuesheet: CMD = md5pipe -i $(TARGET_SAMPLES)/wavpack/special/cue_sheet.wv -f s16le -af aresample
 
+# The sample file has APE tags containing a cuesheet.
+FATE_WAVPACK_FFPROBE-$(call ALLYES, WV_DEMUXER FILE_PROTOCOL) += fate-wavpack-cuesheet-tags
+fate-wavpack-cuesheet-tags: CMD = probetags $(TARGET_SAMPLES)/wavpack/special/cue_sheet.wv
+
 FATE_WAVPACK_S16 += fate-wavpack-falsestereo
 fate-wavpack-falsestereo: CMD = md5pipe -i $(TARGET_SAMPLES)/wavpack/special/false_stereo.wv -f s16le -af aresample
 
@@ -102,5 +106,6 @@ FATE_WAVPACK-$(call FILTERDEMDECENCMUX, ARESAMPLE, WV, WAVPACK, PCM_S24LE, PCM_S
 FATE_WAVPACK-$(call FILTERDEMDECENCMUX, ARESAMPLE, WV, WAVPACK, PCM_S32LE, PCM_S32LE, MD5_PROTOCOL) += $(FATE_WAVPACK_S32)
 FATE_WAVPACK-$(call FILTERDEMDECENCMUX, ARESAMPLE, WV, WAVPACK, PCM_F32LE, PCM_F32LE, MD5_PROTOCOL) += $(FATE_WAVPACK_F32)
 
+FATE_SAMPLES_FFPROBE += $(FATE_WAVPACK_FFPROBE-yes)
 FATE_SAMPLES_FFMPEG += $(FATE_WAVPACK-yes)
-fate-wavpack: $(FATE_WAVPACK-yes)
+fate-wavpack: $(FATE_WAVPACK-yes) $(FATE_WAVPACK_FFPROBE-yes)
diff --git a/tests/ref/fate/wavpack-cuesheet-tags b/tests/ref/fate/wavpack-cuesheet-tags
new file mode 100644
index 0000000000..be6b694ae5
--- /dev/null
+++ b/tests/ref/fate/wavpack-cuesheet-tags
@@ -0,0 +1,98 @@
+[FORMAT]
+TAG:Cuesheet=REM GENRE Zydeco/Cajun
+REM DATE 1997
+PERFORMER "BeauSoliel"
+TITLE "L'Amour ou la Folie"
+REM REPLAYGAIN_ALBUM_GAIN -6.54 dB
+REM REPLAYGAIN_ALBUM_PEAK 0.972900
+FILE "CDImage.wv" WAVE
+  TRACK 01 AUDIO
+    TITLE "Newz Reel"
+    REM REPLAYGAIN_TRACK_GAIN -6.47 dB
+    REM REPLAYGAIN_TRACK_PEAK 0.972900
+    INDEX 00 00:00:00
+    INDEX 01 00:00:32
+  TRACK 02 AUDIO
+    TITLE "Les Blues de Crève de Faim"
+    REM REPLAYGAIN_TRACK_GAIN -4.56 dB
+    REM REPLAYGAIN_TRACK_PEAK 0.972900
+    INDEX 00 02:18:58
+    INDEX 01 02:21:30
+  TRACK 03 AUDIO
+    TITLE "L'Amour ou la Folie"
+    REM REPLAYGAIN_TRACK_GAIN -7.06 dB
+    REM REPLAYGAIN_TRACK_PEAK 0.972900
+    INDEX 00 06:08:40
+    INDEX 01 06:10:47
+  TRACK 04 AUDIO
+    TITLE "It's A Sin To Tell A Lie (C'est un Péché de Dire un Menterie)"
+    REM REPLAYGAIN_TRACK_GAIN -5.28 dB
+    REM REPLAYGAIN_TRACK_PEAK 0.972900
+    INDEX 00 11:29:30
+    INDEX 01 11:31:40
+  TRACK 05 AUDIO
+    TITLE "Eunice Two-Step"
+    REM REPLAYGAIN_TRACK_GAIN -7.72 dB
+    REM REPLAYGAIN_TRACK_PEAK 0.972900
+    INDEX 00 16:18:13
+    INDEX 01 16:21:10
+  TRACK 06 AUDIO
+    TITLE "Charivari"
+    REM REPLAYGAIN_TRACK_GAIN -5.47 dB
+    REM REPLAYGAIN_TRACK_PEAK 0.972900
+    INDEX 00 20:57:53
+    INDEX 01 21:00:37
+  TRACK 07 AUDIO
+    TITLE "Boudreaux"
+    REM REPLAYGAIN_TRACK_GAIN -4.71 dB
+    REM REPLAYGAIN_TRACK_PEAK 0.972900
+    INDEX 00 26:23:25
+    INDEX 01 26:25:65
+  TRACK 08 AUDIO
+    TITLE "Valse à Pop"
+    REM REPLAYGAIN_TRACK_GAIN -5.20 dB
+    REM REPLAYGAIN_TRACK_PEAK 0.972900
+    INDEX 00 29:25:33
+    INDEX 01 29:27:12
+  TRACK 09 AUDIO
+    TITLE "Can't You See (Tu Vas Voir)"
+    REM REPLAYGAIN_TRACK_GAIN -6.17 dB
+    REM REPLAYGAIN_TRACK_PEAK 0.972900
+    INDEX 00 32:50:25
+    INDEX 01 32:53:10
+  TRACK 10 AUDIO
+    TITLE "Les Blues de la Prison"
+    REM REPLAYGAIN_TRACK_GAIN -5.44 dB
+    REM REPLAYGAIN_TRACK_PEAK 0.972900
+    INDEX 00 35:59:05
+    INDEX 01 36:01:62
+  TRACK 11 AUDIO
+    TITLE "Danse Caribe"
+    REM REPLAYGAIN_TRACK_GAIN -7.46 dB
+    REM REPLAYGAIN_TRACK_PEAK 0.972900
+    INDEX 00 39:26:73
+    INDEX 01 39:29:47
+  TRACK 12 AUDIO
+    TITLE "Valse J'Aime"
+    REM REPLAYGAIN_TRACK_GAIN -7.92 dB
+    REM REPLAYGAIN_TRACK_PEAK 0.972900
+    INDEX 00 43:35:25
+    INDEX 01 43:38:15
+  TRACK 13 AUDIO
+    TITLE "Courir avec Walker"
+    REM REPLAYGAIN_TRACK_GAIN -5.19 dB
+    REM REPLAYGAIN_TRACK_PEAK 0.972900
+    INDEX 00 47:30:05
+    INDEX 01 47:32:70
+  TRACK 14 AUDIO
+    TITLE "Ma Vie S'est Arrêtée"
+    REM REPLAYGAIN_TRACK_GAIN -5.60 dB
+    REM REPLAYGAIN_TRACK_PEAK 0.972900
+    INDEX 00 51:31:08
+    INDEX 01 51:33:72
+
+TAG:Artist=BeauSoliel
+TAG:Album=L'Amour ou la Folie
+TAG:Year=1997
+TAG:Genre=Zydeco/Cajun
+[/FORMAT]
-- 
2.32.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      parent reply	other threads:[~2022-05-30 14:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-30 13:59 [FFmpeg-devel] [PATCH 1/6] fate/opus: Restore fate-opus-(celt|hybrid|silk) Andreas Rheinhardt
2022-05-30 14:03 ` [FFmpeg-devel] [PATCH 2/5] avcodec/wavpack: Remove redundant av_channel_layout_uninit() Andreas Rheinhardt
2022-05-30 14:03 ` [FFmpeg-devel] [PATCH 3/5] fate/wavpack: Fix test requirements Andreas Rheinhardt
2022-05-30 14:03 ` [FFmpeg-devel] [PATCH 4/5] fate/wavpack: Avoid temp files Andreas Rheinhardt
2022-05-30 14:03 ` Andreas Rheinhardt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB6PR0101MB2214E373472AEB858C08B6138FDD9@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com \
    --to=andreas.rheinhardt@outlook.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git