From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A53AB4261C for ; Thu, 23 Jun 2022 14:21:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DCE4368B6B8; Thu, 23 Jun 2022 17:21:28 +0300 (EEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-oln040092074095.outbound.protection.outlook.com [40.92.74.95]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0AF0068B2B5 for ; Thu, 23 Jun 2022 17:21:22 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AU5jMT9VYfB0lXtd4mnwtWwm7jxyqc122DoJ3yXWFytUaFAIo4SaRLAbSzW3n9bKoElgA6A1CiKFJAu5nF251e9YIsFC1Na+W/qBTOS+oRP+zsZS5cmZ8Zt79LvKNyFmfne+HYo1DBFc6gTL8ZkV/qXH5gl8F1wAuBKl5aDO6EU7TzV7UMQBCF+qMijRCdjMQneoxg0V/uukbxZRIpuebYSQkYahqqxq7IhNyNjZzs2N9Z2rM5N83JM+2r8EY8XHJg/Ujt6hIZE8o19k4xAUYwMxP4NPeMc+090GpiOxcJ3Tl/+/gtbZGqKR15aoiexnbYLjtxWVdCtW4+IEihExGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xkZNsjUNFOGoEinZJr7tJuZgP8AIhhEcBa4Tme4HlDc=; b=EMKL7XnfNOK2Vnlj7OF6xaZKh9ZOs01DP/gytfVKbUCcyYGPBryO5ND7UAr5dngG67BH4TMtDdhHPNhwOHfx6lx+Pa0DxlgMhq4LTUa1IVh9eSMi3/x8ogRPOV5D7AT1AsEPxh2TAg7sm85bcVo8To2r6jnCGJ1OQiZYrq+ufYkkrHwddmxrcJjEIKClcu2BsMZeku/dkZj5dfxgkkV+B3hpVzH1CsiN1JIyLaB018pM+MQbYRHp1kcOXdTT9yrOI8UICQz5UimUxLMdshge9hs62FnGWrqKmfI99jhUJtNjmhjkUsZPZkCrVH9aO8J1tlcOYz+hB/axR9xrUiHhuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xkZNsjUNFOGoEinZJr7tJuZgP8AIhhEcBa4Tme4HlDc=; b=t4QYkrTWZ5TwwWHszbNyb7LtEv2c6ooZ4NKnf2RIPnNTEzi/ayl7ZKwlihfvyfpK1gkGm1kEVugCiLQ3RobaWyoejfDlh8Uyl/Sd5hLIrHL+roDn3MA5mPvHbAb0SpFLOPARd4Li50DD71bcSoCcGZUE+lzLI62xhOXvt0bYSVqF7oK05dHCrqBf/cb4EDBGYnRqDU+lqrjr74WI1HptQTsOIuOT0YlgBF+JmJAhTwrq0bFG6s9ek7CBCVbVszlktwXpqsh1p3SA2T4OQsRki/AiZo3f9EjI8vIIuPnEb8I/yJ0tnfHvGIc7+wR6Hz8s0bMctMnS/ffVVVRQDrwsqg== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by AM6PR01MB5111.eurprd01.prod.exchangelabs.com (2603:10a6:20b:9c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.16; Thu, 23 Jun 2022 14:21:20 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c%10]) with mapi id 15.20.5353.022; Thu, 23 Jun 2022 14:21:19 +0000 Message-ID: Date: Thu, 23 Jun 2022 16:21:18 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <9642852e9da11714c8643833562b6e86133ce1a1.camel@amazon.it> <0215838ca87728a7e2742ab19af7fe1d5c3f9abc.camel@amazon.it> <165556480189.13099.7220862156046633312@lain> <80f0b155c25cfbba992dfb7ca79e1b37b8dfc12e.camel@amazon.it> <165599096835.13099.14253738660427313095@lain> From: Andreas Rheinhardt In-Reply-To: <165599096835.13099.14253738660427313095@lain> X-TMN: [gw9IzqFTKQn3DIb8FjZOn0Ak1VBeUUbo] X-ClientProxiedBy: ZRAP278CA0010.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:10::20) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: <57b9e364-23b1-7ec8-d143-c19656b67521@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bc59f58b-90cc-46bb-ca14-08da5523a443 X-MS-TrafficTypeDiagnostic: AM6PR01MB5111:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: chx4cGz1y+ELtDEiVLtASPPHH9QWsf/ZmxzOiVFxfNgDAbZp2vcqKFTDj+QKD4Us12S4sxR9WHuDjQih6YX0oLdMJTOzrcqf98512oyBZvqbxmlNpZzHUPg3MP5l+hPJOggeLSYNshZnHZUh/fSdRo7csHt8Std4CE/uDeAIUagdSLxKYYD382aSC0xEajWhDcyOHQP8AQohvrVTRxRqVT22ZuKdRaKpq6dozS6PajRsjSrypJjKcjlWrHwdo6v4eKOBgu0SXjBvExEojuFRufDvc//kY/R9X+0LdvUX2PVrbJlWrIDthv5BcK3lQj87o9AvY/eBwxqJEifr/kP7M7z2fAnA5CmnyZgd3ma8OtnFZeaMKTwQFKRFCiWsGsFfO/YCbdax3rOt/3Ioj14aFlG1kPe+7v+chaaeO2XLQfqyNr3zsgPH6CuBdeq6/L4kQwhRagkm3k1tU2gNVrHbeSwYbzIyBaqws9alTj1jDRZefmalbXduZw4kCMhfUERix23bQLy0sFSOmG955dXbx9Fg2oyILwMCx0wC8JjhAoHUemXodZnFyrFDPf5yvf+nnuH8NQWlxHC6oGhqlW6449U33w31ocB1mnVpWxySpUzQZKjPC+DeOqVGWUG296IAE/CtPIOSYPNGUPLSVV3P5w== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OUR6dDhPVmVaa2s5ZTlCWmh3ejBKd2tLZ0swWk1zaVBhNzVGUi9vaG5NTWxF?= =?utf-8?B?ZkhkR0FVZkVQY1FjTnVKVVc5ME1MM2RtZzNxT2tYRFZCT0ltcWdLV04vT2d2?= =?utf-8?B?L242L3BQRVRQRWw5b2prRWpBTnVsYUs2dG8zYWIxUWR5U081WFBNMGhYUDFH?= =?utf-8?B?SUVucGVia1d1RjBEcWdXRnJDeW5LRXQ3TVgrLzNjY2gvVGlIZmZ6bjBmL0pX?= =?utf-8?B?cGNmZVBzUFJGY1pESkZHY1hQMHZaUHZQSEp5YWsvV2ZSeDZUUVJPcStqeEtr?= =?utf-8?B?bC9saEZsVERKa0ZkVWpWeEtrcXVObHdOK3V5SFlkMUFieDNYOVVnK2t0bUZE?= =?utf-8?B?SkR6eHFVRlVyQllXQ3VHZGUyUnVLMnI1Y3BIM01iRzNVS1BPdDlRcjJpVDBn?= =?utf-8?B?VXl0eHloY2Nwcnp0ZkpTWTIxY3E4L2x1SGRKc1pHWXRyUGQxQ09sSWlhekVp?= =?utf-8?B?THdicHBwRFVBejhLM0hUMXptbllFQ2E5eTBlSkxEdEdvUDB3N1ZlNUo2R3Ba?= =?utf-8?B?NmhGNDV6SnVFV2V1dEFOa0VRRlM3WFpnOGYvU0pORlRodFMwVGdHVDVRMDhw?= =?utf-8?B?eEJjaGoydDlMQjFzYU1QWWc2OE9ZZXhUY2E5NjgzSjR5YlZ6cXFIamNOWldl?= =?utf-8?B?VWY0ZkFxNHBhckw4TDkzUms4NlUvRFBsQlVCd2ZML0V6MG5LK0lQc1BZMkZO?= =?utf-8?B?U2ZYWlRmVlp6OTgwNytlNFRzdk1LTHBnRXBmOEJrdE9URzRKaXpUYTJyb2Nu?= =?utf-8?B?clRDMHdvWGh1YnMrNWhURjZaRVBYakM1VFRoU3hyV1hCbEd1eW9BU1h1amxN?= =?utf-8?B?L2VIbHU5TXVraGgzL05vaS9XdDM4VER3cENPdzYyMVdCNzdiRDJmY3NSRStk?= =?utf-8?B?di9EMFJndW95TjdISHBpRDcreTRZejVMMHRIN2pSWjRLZzZ5RFVYdVhpeVNK?= =?utf-8?B?UVNQUmFkazJNenBja0RYOUJVc3RuVDJ5NE1KWU1RenJRQk9rdkFWQkhiMU40?= =?utf-8?B?cDB1YUJ1K0VFcEUyWU5UeVBtVkZUaVhMUVVXaDFDRThTR0RxYkhnaFJlSXNr?= =?utf-8?B?bFdjNDQ0WVo2cVMrVHJzWkRlOTFWOFRoUW1OYlRCNW4wNWM5S2NobDBnVXlh?= =?utf-8?B?REF0Qm1lNzdESThqWlpQMkw0TXp0dWZuNmp0WHNwR3l5aTNETnZMaTA3SVhE?= =?utf-8?B?VDBJMDh6bHh6NnZkUUNDSjI2OEZWV0hpTmhpQlJYK29ZZC9OaS96b1NYYTM0?= =?utf-8?B?Q2F1WEp5a1FxbnE0VWJQdFVtVmdHUzU4ckwxZ2s5aHJTL0FUZEdRZU1CUHZr?= =?utf-8?B?azd1cDl4eVF1RVcyeVZLKzJubGFmbVk5Q0M3MUhkRmpiNGFCV3ZweVB3MjdE?= =?utf-8?B?UU8ybDBnWmF2R1RudWlhNUJOY0s1RWtTejJ1aTd1SGd1N1BheHVpNys4MmZP?= =?utf-8?B?TC9EQ3pzWnMzNGlGVU1Gc1ZVeXkwWnZ5eXN6V1FUeSt0RTFQOGJCU1hacW1Q?= =?utf-8?B?MnBDRXlvQTVXRndBakUrL3ZaRzhFSGZLRzE4UjNxZk03OUFuZllXdHdUam9s?= =?utf-8?B?RDBaNnhsS1VBUDZlMTMwNnF1YmlrRHpIV01JbWdVZGltVTlUWUUydTdrdm4r?= =?utf-8?B?Sm5iZzZ5ZC96QVVJbU5udTlxMmdFM054UFJ4WG5XcFNqOVJkVG9Ga2U0eG42?= =?utf-8?B?R2hRMXlQNE9LdEVXaDhQeXg1aVp4Y3MxakdEYXFEYXFwbXRvS1lPQWh2bGVu?= =?utf-8?B?S1BVTmttRURjTUJGR1ZQcTZ0SFBVQkVUVXJnTTlNRUZ4dzB5Q2V0dEdJWHov?= =?utf-8?B?RTBtekNjOWtFR2swNGIxTW1WalNxSjRNcnl2N0J0dVd6bE4yMm1MVGV5Y1Jm?= =?utf-8?B?YTZPcjJRWGtYQi8zSXdjUTFVNW8wSHJnaXBnOXl6NHptNXFlL3BiV1k5dnMr?= =?utf-8?B?TlFYRVBuSVpNOVZBRGhiUlptQVFqVmNJbGFTME05REdnR204Q3c2NHFTN0F2?= =?utf-8?B?WkFUOWRlQ0hBPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bc59f58b-90cc-46bb-ca14-08da5523a443 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2022 14:21:19.8062 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR01MB5111 Subject: Re: [FFmpeg-devel] [PATCH] Added support for MB_INFO X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Anton Khirnov: > Quoting Carotti, Elias (2022-06-21 10:48:07) >> Hi, >> >> extending AVVideoEncParams was the first hypothesis I made but it >> didn't seem it was the proper place to add the mb_info flags. >> >> I may be wrong but my impression is that AVVideoEncParams is used to >> carry encoding parameters read from the bitstream at the decoder side >> while here were going the other direction, i.e., were passing >> information from the application to the encoder. >> >> Secondly, mb_info can't be strictly considered encoding parameters and >> it's not present in the bitstream at all. >> It's just a way to give hints to the libx264 encoder on which >> macroblock we know have not changed since the previous frame and could >> be coded as P_SKIPs. Libx264 however, may or may not oblige according >> to its logic, and this specific information is not transmitted in the >> bitstream nor can be recovered at the decoder. > > Right, seems I was too hasty in reading your patch. > > But then I have to wonder whether this really needs a new installed > header, with a struct and a destructor, given that it's specific to a > single encoder for a single codec that is about 20 years old now. > > Wouldn't AV_FRAME_DATA_X264_MBINFO that would be just a raw array of > uint8_t serve your needs just as fine? You could even get custom buffer > management by using AVFrameSideData.buf. > There is one problem though: libx264's free functions don't accept an opaque parameter, so one can't easily create a reference for libx264 to unref. I don't see a way around duplicating this buffer in the encoder. (Or is there a way to know when libx264 is done with using this buffer?) - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".