From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 48893407A2 for ; Tue, 31 May 2022 07:10:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4832568B60D; Tue, 31 May 2022 10:10:26 +0300 (EEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-oln040092064050.outbound.protection.outlook.com [40.92.64.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 91EFC68B527 for ; Tue, 31 May 2022 10:10:19 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JfNacSLxLwl2ZQ5MmFTe+JCMjInXd7ZKx3j+WIVryhfT75fROy/hVPyC3Uw6EDTa8pByqQx0c44e67+VhU8oWusmhUSikzgnmgH/qDO+YKhhyeTGuw/o3EYwjksCijzXJ8fE1KtEnFXXnPzgdT4Sz+lYZbeR1PLLmRWGkuoQjwFl4uzmhlpILomZRjZFGl63uI3EQ+x3CkGTv59apB3cjoCWMkqzxQETuovek4e3PLAFrnrEONsQT0zK9Q28DLLFNI9/k7IGwn7SpnoKWIUu8VKjDPp+TkLOwWUGTGOanLMPQCYt3S5i5kz+LD9h+6G+nKUm7uYEEYiT+mqe2ji9tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NzKK8141dsIGZtMGqmDXg2GYfPn+jK6NouuJla3Lzk0=; b=ALp1ltE2QP0ZlBEhbjxnUKg4VfX+zw7gedmK7DzVHuVk7DSMFqnvM9DSZjrIk6z8FfasK6kVtI+8WFFutdAY7jpp7A0q6gVjhEtZqwgiNYmbTtzI32CeuUcqXlwN9QEMs1dgjCMUj0qgifGiBXrTbggLAGU92Iywh8IYfURg9zXj6iuAnDvV92yWqAWpJlmmsZ5rSxizGzPLmGsjIq/AS7ZvlLjScFldnnpEXVX4fg4qzJVjuXeTyIVaGIPCvxUoGQfpLKIvnuYzLXcO3JcBKkqxO6nysioSPZ8Sf3mNpvzgTRhnQTkfGmF/4XRiOXq7mr0KCBgceVFORNZDxinpYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NzKK8141dsIGZtMGqmDXg2GYfPn+jK6NouuJla3Lzk0=; b=FwbFLdvQq5JwRoBOa8D/V6BlkB0NzUyaWHcChSd9NdX3c7XVrT8MNyCiB+fq1D6vWS6H3k6izGKwlqEaoni7rqX24bKPyXUgoCr6Mrot7S3m/CodD7IcJU0MCeAfWVFrjBoAuX7S12d5DL5CStnMx/bD5xC8xsKVa39W2PIC9IbUD9CUhNIYkR7IvpwkraAKEl/UYGH1HIINtharO0AJ/ePJl5Q6ETdDHc8T+RqmeoupGHnKQEXg44++pGUD1y39zvmvX98PuGY/W3oSYiOg4pylMNX0ZCt1hoZF5DIFnoxgZjLcxF7Ff+qINMZdNfbb211MSA3UCGia99lPtE2zTA== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by AS8PR01MB8747.eurprd01.prod.exchangelabs.com (2603:10a6:20b:40e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.19; Tue, 31 May 2022 07:10:17 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c%10]) with mapi id 15.20.5293.019; Tue, 31 May 2022 07:10:17 +0000 Message-ID: Date: Tue, 31 May 2022 09:10:14 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220531031334.19488-1-pal@sandflow.com> <20220531031334.19488-6-pal@sandflow.com> From: Andreas Rheinhardt In-Reply-To: <20220531031334.19488-6-pal@sandflow.com> X-TMN: [MgAo+rnG9wgMMu5UaLssW6DiLevtuWvx] X-ClientProxiedBy: AM5PR0701CA0012.eurprd07.prod.outlook.com (2603:10a6:203:51::22) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 46bd63d0-2c04-4d85-8a08-08da42d49d86 X-MS-TrafficTypeDiagnostic: AS8PR01MB8747:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LqfJycuuWkFgoe4foB0pk6eB1/ATGqvGMQp+CdvVmNg/YPow48ulyFUR0UA9DMPJ/uhG5YFbmUn96GwW9AfE2pGppwFTP6nbdiwSJo2eI8R5h6S3+Q3GkZsUoOBEXhrTviQB7UdYy5vjWb207KPHzSpgQTIECNSmyttL1DhOuxZXBDAv73Hgr2icxmsRusm0M1Z70fHVxUeDAPypRTCBrzeGZdXinUP6Fzj5YKHFB3bLPf7nAoFRo6E87zFj1WL0c3/k8eaTkovPEcDgLEYbUoaaK9so6MPNH6wSlf2fpLAigO1CIpoh6WmHeiUqDTrCNGAwN6vmWD3qqdZSk4o8rKEehFScVNHKkNFhn0/wBt9hnNtY7qQiJMiMDEFqdRHgambAhkHrN79RKgHtQIX1d9CGzzY/mW5iad8s9BCUALvRfCu8sjthTrz8qS6QJBErwikjrxUcmb+XIfC2vwdCeEM8Le4MRrBiUgMWT0kwYiD0+0mmrF4RMOejqRTY1ccYiCopCF9XEvJ8p90sJk8SbGX31QXcaitw9kSJGprJZcktIQ9yXIPi4RnG3IJF44gJsRcutUU0pYnpqOHD6xk+kg== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U3RCQlc2VEo3ckwzNzVvMFd0bE04UzgxOFZtS1huWnZiZ0c2aEVqZmNaZ1V6?= =?utf-8?B?cGg0cmRwbXhoUzhhSUhXTXRIOHdGbnl5eWc1NTQ0dVlWWDYyTXNWRmx2Tlgv?= =?utf-8?B?dHFrRytsUGR5UGx4QVdKbm1LKzE3Qms0VEVNSmpTaFN5SlV2YUUxZ0kvTEdS?= =?utf-8?B?dEJnZU9ybmN4c0ZDb3NoWGpQUzJPT2tZZnBRMmI5VERianpSbnRESXF3NlMx?= =?utf-8?B?MTd2TWRNdm5PMUlHQTVpVFgvWFpzSzV1dkozWVdoVkk4ZGcvMnVua1V4d3R6?= =?utf-8?B?b3VzQUVTK0J0WU1TbVVLeDlQRisvNWdaYVA4YjJ6SzlLL3FxQVF6Mm41QkZt?= =?utf-8?B?MUxGZkw3dzNFMmZuUkRuWUhibnZaZ053Rmd6REF2cmdrdjZYTkxqQkEzODN6?= =?utf-8?B?M1dzN2FWVW1JZEFxZEN3VmRMdFh6bGpPb2pjSWdYN2VkOW5VTGJhMVU3bWd4?= =?utf-8?B?Q2V1Z2NFTWJONjI1ZG1jcFB3U2dmNU1Pc3VLNlc2OFlYdXVLbEVjbENyUnNL?= =?utf-8?B?ZlhTRWhZVU02RWt2V3VrOFRLbCtNdmh6WDBLUUI0dnVsQUF2TmYrT3pldEk5?= =?utf-8?B?MUdaRTE5MGFaQ2ZYV3IxeVAwNUZxaFNITkdGc1JHc2tqcHduL1MvZlFQNFdV?= =?utf-8?B?bmEyMUVpNTNjV3dqdDhuL3F2LzhkbjFFK3hMQnBlNGR2NWRoQW91VUN3aHpm?= =?utf-8?B?M2RaRlVHSmVGSXF4M3l6T1h6R0xIOThmNHcweDNJdlNDWUtqY3dwbXlSQWlE?= =?utf-8?B?TGx1Q1ArUzNnaE1PeE1ZeFJmUFZXM1hmbmJPbWg3TEhIdGJvTkhibWtWckRJ?= =?utf-8?B?eFpIeFlsRFdSTEt4aEh5cG5iNGNBT29WeE9JZlZNL0M2SVlocGI5dnpobm1o?= =?utf-8?B?TXhBa2hwVmtmbDN0M3c5bEFGWTIwTXBiaVhXMWNxcUQ4anNiU0hOaUFFRElP?= =?utf-8?B?R2J1N3ZNQWVZYzhQVXZlb2tVOU5RMDlNVVkrOFQwaGJtU0VuRkViQkxVeW9W?= =?utf-8?B?ODFqQXVWNTNSN3FTR1RmZlFsSVZHNmRDM2JXaXJLRGdaWDJHcWxXaUVoMzVN?= =?utf-8?B?NUkzZXlONEV3Rm5jZFZWZG90RVUzTGVSQjNKOTNHQk4yVDA0NlpvNmN2SE9K?= =?utf-8?B?cFl6L0NtWkNNbVhwdDh3MjZhQmJzaWYvNjRPaTVGdWRBRHRSREpTNTV4RXpR?= =?utf-8?B?WXlrQzBPbXZNMTZsV3NVZTV6YjljS3RVMXlzSjBEVkpKU2NxbnlTTnp1aFJG?= =?utf-8?B?QWcvRXdkaW5ISTZCTExNL3c2WE5iNVdmeTZiVnJjMlh0RmJzR1huUU13by9x?= =?utf-8?B?dmk2Q05BdUdCaVpxSkZsNCsxYm1hRmd5WkxFZTZGblk2TFVUUlZEb21DdUE1?= =?utf-8?B?UndRN09oZEp2NUk2OUk1NWJRSHF3MzNSR24zRjYxV0VvRkJ3TVA1QlFET2R6?= =?utf-8?B?RjZmck1wNVlNQXlhR08xeUhJNnk5U2EyalhDQXRsZk0vZE5DZXU3T3B5Y0p5?= =?utf-8?B?eTh5Um1HdXVyZVJWMjdIRnNPZUdCUmxCUlNUZmRhcG1SYkRxNDlYcSt1RVJE?= =?utf-8?B?UGRCNEpFUy82dHovendEc04wQ0dnVWYxQ25jcER4c1NucWF2VG5mN1dzS3ND?= =?utf-8?B?dHFveFNvN010UWN4Y1BaV3M0dXZPbnY1aTlDZEpNSGdVZUlmdXpJUlNIbWF4?= =?utf-8?B?dFFjTkQzSFZULzhuRWQxVHJnVVlkU2UxMUtMNVE4NVUzQmIvL3JCUVUwenRq?= =?utf-8?B?OFlkT0ljS0NRYXZiVWp4RWFuZnM4YzduaWgyaUpWTmphREE2Q3NtcHRLK1ho?= =?utf-8?B?My9wQmhyazVhSm14R2pyTkhadUR1d2VBZnNpZG5PYU5xRXcyMTFIVG9UbE9M?= =?utf-8?B?elAxaUpCdXlQNFFBUlZjZlpNTGtaRW1MbFVRZ2s0UFlhSXlxSGRiUTA0N0V5?= =?utf-8?B?QlIwMXYvYmhCcnZTaC9CRkpVbzc3ZXBXRHBZcC9hTjhnWUsxVGN4UEV2VHFK?= =?utf-8?B?NkpjdHUyaTJnPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 46bd63d0-2c04-4d85-8a08-08da42d49d86 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 07:10:17.4997 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR01MB8747 Subject: Re: [FFmpeg-devel] [PATCH v3 6/6] avfilter/showinfo: refactor to use avutil/uuid X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: pal@sandflow.com: > From: Pierre-Anthony Lemieux > > --- > libavfilter/vf_showinfo.c | 17 +++++------------ > 1 file changed, 5 insertions(+), 12 deletions(-) > > diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c > index 12d39310ef..0d6f2805bb 100644 > --- a/libavfilter/vf_showinfo.c > +++ b/libavfilter/vf_showinfo.c > @@ -42,6 +42,7 @@ > #include "libavutil/mastering_display_metadata.h" > #include "libavutil/video_enc_params.h" > #include "libavutil/detection_bbox.h" > +#include "libavutil/uuid.h" > > #include "avfilter.h" > #include "internal.h" > @@ -421,29 +422,21 @@ static void dump_video_enc_params(AVFilterContext *ctx, const AVFrameSideData *s > > static void dump_sei_unregistered_metadata(AVFilterContext *ctx, const AVFrameSideData *sd) > { > - const int uuid_size = 16; > const uint8_t *user_data = sd->data; > int i; > > - if (sd->size < uuid_size) { > + if (sd->size < AV_UUID_LEN) { > av_log(ctx, AV_LOG_ERROR, "invalid data(%"SIZE_SPECIFIER" < " > - "UUID(%d-bytes))\n", sd->size, uuid_size); > + "UUID(%d-bytes))\n", sd->size, AV_UUID_LEN); > return; > } > > av_log(ctx, AV_LOG_INFO, "User Data Unregistered:\n"); > - av_log(ctx, AV_LOG_INFO, "UUID="); > - for (i = 0; i < uuid_size; i++) { > - av_log(ctx, AV_LOG_INFO, "%02x", user_data[i]); > - if (i == 3 || i == 5 || i == 7 || i == 9) > - av_log(ctx, AV_LOG_INFO, "-"); > - } > - av_log(ctx, AV_LOG_INFO, "\n"); > + av_log(ctx, AV_LOG_INFO, "UUID=" AV_PRI_UUID "\n", AV_UUID_ARG(user_data)); > > av_log(ctx, AV_LOG_INFO, "User Data="); > - for (; i < sd->size; i++) { > + for (i = 16; i < sd->size; i++) You can (and should) now use a for-loop with variable-declaration (and the type should be changed to size_t, as AVFrameSideData is now size_t, too). > av_log(ctx, AV_LOG_INFO, "%02x", user_data[i]); > - } > av_log(ctx, AV_LOG_INFO, "\n"); > } > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".