From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id ED26942F52 for ; Mon, 16 May 2022 11:05:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0D17A68B2DD; Mon, 16 May 2022 14:05:39 +0300 (EEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-oln040092074056.outbound.protection.outlook.com [40.92.74.56]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2F5A868B181 for ; Mon, 16 May 2022 14:05:32 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X8p1g3541zUbV/rrjiTy8P1GzlkCV+17CZ4GkxiniPSGjDw8Gln2N10a4ynn2NdSfaVrTK2A8NDM3xKJaCjkmIx7HJJ38YwZMR/5ACtf21MFD3P7g1GYWqSRG5QOkH8GA5YIkCyKNhegUhYpRHYwgbu0OGRq/pj1nnoDxFRZOA/wxBowBWlssXW20su1aSd8+yK2I1MKKSarZAg4mwGMZ4wMcvmg0kzfMCARSpCp8AixjTuuemiQQXsON27n9o0brZqGsRbeAUD6Rd8b7fe2a9qRJsgb5cyiXpgPxVA0cy78bODx8XK3HWbkh2HPrIbG5vxQCLok8xW2Prc019gl7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DSmy/0n1EwyOpyD7NrVunqGGmjF2z9aPYVdmXO5XS88=; b=EcNaBLfQ9MX8vzIQKTWfooCaVzVoQUsU3/ZV9YTz0usNeIvlM6N4oxd5dc8ZdBQrpmjN31bl8lcL899iXpEuxVLxQ108T/yOHUZotzruyUlzs2S7xV2222kI+I2CNNZvxEjuesLSOUXI31uZDLJuX8So7YD3jnmF424/vYmELIu2PFNUUFdZiX6eQgOjTCWX5pab4R6fxE2h6wvv+KvwvT7X/PWX41a8sWFvmoCx1wUolBXXKEIamTcBgfPye5M+Gt/qo4FW8Lka6M4fVtUJwllPgwuzg0CG/ry9gu2RAmjkTmGCmd4g0hDsBZUp0GTvFhbraayTWG1jGw7C+8emCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DSmy/0n1EwyOpyD7NrVunqGGmjF2z9aPYVdmXO5XS88=; b=OWmctMawd6H4ny1FzX0YDPxhNz3AYFRu2vzTBtb7Pgn0i8cAbfzFSMEn/Xj4Sxtu25z4NTfrgVECXe+0RJ0XfuwPB3ymARRnaj2yIh1Ord5ze9sSbYt7xV8asRq6sRz1m+4FSTaMDNyBShdlvQb7q1PKCa7B/9Tt7TRjJWfVL3JR17YyISPOfmMSInND1cJlvPbGRlovHd7Gju7AlN2tbQf8ewFrDGd2Lac8IKp3APqRRvYQ/bk/F1RYEjdq0/PYlf4m7DZq6c5aTgBGywBvhSpU+D+Oq06Su1uoRkJ0Rf/lQHDM5scxkTC/dTJ1EEbbza/LzaQ9UZaMkrLbkDbjJg== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by DB7PR01MB4967.eurprd01.prod.exchangelabs.com (2603:10a6:10:57::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.16; Mon, 16 May 2022 11:05:30 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c%10]) with mapi id 15.20.5250.018; Mon, 16 May 2022 11:05:30 +0000 Message-ID: Date: Mon, 16 May 2022 13:05:28 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220516011605.18792-1-michael@niedermayer.cc> <20220516011605.18792-3-michael@niedermayer.cc> From: Andreas Rheinhardt In-Reply-To: <20220516011605.18792-3-michael@niedermayer.cc> X-TMN: [jSXp6uxeNb4fQ6+LTdGs7kJf9TYkctof] X-ClientProxiedBy: ZR0P278CA0095.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:23::10) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: <6cc92f60-44a6-45d5-c423-fc69a579ec43@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c6c692e3-c58c-4063-6c1a-08da372bfd67 X-MS-TrafficTypeDiagnostic: DB7PR01MB4967:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9HhBzPz+bOtTDDmAIq1YtL6xYE4rjzMs1OzwdAyAVk9V1rr52sebF41TuSZBLOoleWrpQDj/migWpNoEiRFhHMg0QfIREP3NwYgmG/IHjTxTbLC4MdWUFth5EWyq7/ji/55q2iYXv1EulQ6vhtGkVJfcr7MyemcxDgAG57ASUPhWfRasbEodq312OHwnEgekQVAXBMxHsHN1czC6px4cXIDs63WnLYsXnFL27aj8+rPvJZWzyQi7Y1/uad+F0t5g1aOAT0rkiRKnTceghiy8b09bgGZNnlDQG3lwj3EC/Tljx1dUuQYcaiPy8HxkE+OyDdxr6Ssqwea7XaOs8PcG5BmDTpqx1kXc07tIPLtJoQdZGaeSXELnU7dyaJ5dXnOrs4UXVErlaBuJz+KvwBZsygD0ZY5GJeHpyFZpFOaI/mOUjyXheerY9oTuxZYRLHvOoDIF8sMtENmlcr0OJ/wy4IpdILwXpVMdl/AEIPKfOiHghWalo8MySIFms8Ndm2LKZeRZwf5ekzp1AC3ptoICsYetcSfWkdFHX6VZlRnpxzpJsdgsB/4LMlbI+LkAlxbHhFr18BcVD+PW4Sog8TzN53artqSUKfu0Ev5Kb/KBw1bQv7OKyVsVYhZf03oKpAkH X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MVRMTkdQam5GaGZhcFVheUdMWHJIV1lOL0c1OFh4WWhKMy9Mc2ZOS0NCajV1?= =?utf-8?B?b1VtU3BKMVlIVzZ1UTB3Z2d1a1lTQzF1YWVrU2NUM3pHYjNoY0FLK1g0UmZD?= =?utf-8?B?NHBBZ0VhL3JuTWNUbjl2NWR6ODREOXN1TUhWOUdXak9PYzFCejgzc3o3VVA4?= =?utf-8?B?eC9UV1BveFVpWHV3QzlrWHkrSVhFVktmSy9zSG9QVWxZdUNKVGl3MGdZdXNY?= =?utf-8?B?RjRUU2U5MXhIVEs5YjYyWlZSNUZwSDd4SHVramQ1bml3aFBMRTIvcHVoZUF6?= =?utf-8?B?Tm5LRVF4ZzJMMXpBQVRDTi8wdjl5QU1LMXVHKzVaVGdQdHFCT1hJN0VnVG9l?= =?utf-8?B?OFBFamF1NkgxMUtwaVA1UjlHRE9lWnpId1dPd0Q5L0thbWw4VmdiTDEzWCtB?= =?utf-8?B?QU1hdkRhWVVhbGJ2R2lvbS9wOVMrVU9HVFNWYU56L3dVeis0c1dndnUvRlpQ?= =?utf-8?B?alVXRGhsdFd2aTg4Q2txREJOZUdUT0pFTVpJajF6T1BFVXRCbmQzV29jZlp0?= =?utf-8?B?T3ZRWVYyRWVUalBwK2JhRFdoZCtMSnFrMllkMmhyZnFCZDFjMFdmNnlJSGRC?= =?utf-8?B?MS9FOEFPUVJidzlvNCt5cHQ4V3U3Q1pnUFNsbzNaaGFFaUl0eUVnSms1Y3lS?= =?utf-8?B?Sm5NdFdtNm0xTFByRWVJbzViMThVRWg4bU1kZUxoTUZyblJGd0hOWndpRUFh?= =?utf-8?B?U01hbDVoanVTREtNb2poVEVCZEF2NlFlU2pqTy9zVHkvNE5mQTd1ajRaTy9w?= =?utf-8?B?SHl1YVFqQklkNkxCRjRMZEI0Qm1oOEo5SlhBZll2WVZTVE9FMDZjV2ZWczc5?= =?utf-8?B?NDUxLzBQTkp5ai9rcTRvNXNZYy93ZTRKSmxialZKWjNSd2xDYkZMS2h6R25a?= =?utf-8?B?d1lJbjFsaExsUEdDUFIxMXNQSWZGem5Sd3pEYTYxMUJPcnVDdERsV0NGd1V3?= =?utf-8?B?OXBtRGRaZ256ZWc3OExzcERIeXZmYncxZ2dyVlhSaXdLTUhPdVBtSHBzYjNo?= =?utf-8?B?bkxBd2NsYlJIaWszSjh2RUZVU2U5eFdPczV4bDNDYVY3VTBMVzVabWYxU0pl?= =?utf-8?B?RDExYmR0NldQMWtQMk9mWHJHQUN6VjZxbWlySjVOcWpKUzUwNG9lcVp0K2Vy?= =?utf-8?B?THczblh4YnBwQjdpb0N1M1pvWVBobk9uak5FL05HcW5oeEVHVDBScnBhWjl0?= =?utf-8?B?RU5LUVpuQWFEU3prNkZvMkJpR0w5bFZPazNkZXlqVGRBRU1wSWF1UGEvbG5X?= =?utf-8?B?QmY3eE1yYlJabkkxVjVFUjBROTVza1dYMmJKZnN2aTRKK2EzdSt1UktnRmU1?= =?utf-8?B?NTJwVDk3NTZZK3lMSVJPR2ZvNFhmVVJSa3lhSXdYeDJBSWFMcldrbWhhYmxq?= =?utf-8?B?SmdIOXM2QkhpM1J3cStadG1rUExibnBSQUpVYTZmYmdaMUZNN092eWFDNG5F?= =?utf-8?B?c0I1SmRzckwvS0tBalV1bXRDVVgwbXZoQk1tQllaWGh4dkpMV3Rrb210RzNi?= =?utf-8?B?Z242S0ZIRzBxalB4YnVlc3dVWVNhR0lJMFhKbVdTZXM1ZW5qZFV2MUZmalhG?= =?utf-8?B?KzAwVmtiTDVrUTZYcnM0ZGxQRGRtb2sxNi85N0o1NVNmdGhHMng1Ym1YOWp0?= =?utf-8?B?d3BCQjd5UVp0UzF4dHBCbFNQZXRtV29GL2dSK0ZzbjMzWkRYN2tQaWlZZjZ0?= =?utf-8?B?UjFHeUtodW5TeGVGUlg1UVZpY1FVQVF1Y3NGbTFVNjE4VWpVczRtOWZ4dnFW?= =?utf-8?B?OE9saTk5UVRIdTFUczdTd0IrYm1XWUU5VmVTb3VWL1g3anppbllrTUdiMTZ3?= =?utf-8?B?cVIzMTAxNHB0OU9jL0JYdE80b0FubVRJcDduVFR1MTFDcFlCKzVsa1R4c0ZK?= =?utf-8?B?SytPWGxPQXE3SGxGVU00T0lwM3J1OGVOOWt6bGx6YjlwNjcxT1BpWm5SdlRB?= =?utf-8?B?OE1mMlp2YkYzYXhlUDZuWnkwSk8rZDlkakZpKzgxTDVMMHYzKzFzMWF4c2Ja?= =?utf-8?B?YWltczQ3RXVnPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c6c692e3-c58c-4063-6c1a-08da372bfd67 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2022 11:05:30.4787 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR01MB4967 Subject: Re: [FFmpeg-devel] [PATCH 3/3] avcodec/mpeg4videodec: Replace always true check by assert X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > Maybe helps coverity > Helps: CID1433771 > > Signed-off-by: Michael Niedermayer > --- > libavcodec/mpeg4videodec.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c > index e2bde73639..715cb606c9 100644 > --- a/libavcodec/mpeg4videodec.c > +++ b/libavcodec/mpeg4videodec.c > @@ -1981,7 +1981,8 @@ static int mpeg4_decode_studio_block(MpegEncContext *s, int32_t block[64], int n > return AVERROR_INVALIDDATA; > j = scantable[idx++]; > block[j] = get_xbits(&s->gb, additional_code_len); > - } else if (group == 21) { > + } else { > + av_assert2(group == 21); > /* Escape */ > if (idx > 63) > return AVERROR_INVALIDDATA; This also reminds me of an old attempt of mine to add an AV_UNREACHABLE macro for such scenarios: https://github.com/mkver/FFmpeg/commits/unreachable. There are two reasons why I never sent it to the ML: a) It uses ASSERT_LEVEL (i.e. with a high ASSERT_LEVEL it degenarates into an actual assert). But this is only defined internally, so useless to an API user. Therefore I wonder whether this should be in a public header (the same issue exists for av_assert1 and av_assert2). b) Both Clang and MSVC have something more, namely a __builtin_assume(cond) resp. __assume(cond). I was unsure whether this should not be added, too. It could be translated to "if (!(cond)) __builtin_unreachable()" to GCC, but would be more natural in general. (Of course, cond must not have any side effects.) - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".