From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A353E44013 for ; Wed, 24 Aug 2022 13:07:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 199F268B9F6; Wed, 24 Aug 2022 16:07:37 +0300 (EEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-oln040092074076.outbound.protection.outlook.com [40.92.74.76]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BCCC068B9CB for ; Wed, 24 Aug 2022 16:07:30 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WpP7THfAVflO+7kcMD39pbgjU2L1L9jfnKhDwRd8hLXS3irADykd2WhTAoFW7PqQ0CsUvVo0/lgNRtSijEMn0jie2/I1Me0k2OfyLyDSi92QE3H60n3JWUwuj4b4ODtX7J7TVGUnynieMrTNzu+rHCsAI9BELI5f7iz/ndqVHqCBz4Ab6Xh/FoksNIjXCr/pN5sQ4clbmDXuL5koKOmTXa0ePhtchk6JJYkTdBpDUHIW1CWWdkRq9azQNUivXCZjB1qn/kIeixTK+eDC2vehYBm90JJWy26amPXmZKCG43Z0dkgi4Jpy6LDQMQZz0pyT0lVkWuCFzWVcPqJCX+EOHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=933dOy1/15myxWMSmrGSe6SN3W2z/0KPXoRGbpwjeRY=; b=HPR0NEXrTsoin6V+0uEd3y4j+7J6C+yT41CPLKJgBmrPgFzN5xPY0gjegTM1a4MIc8bZMll3rIb+I05r8kLsBbRwAUWvJg9KX2B652GtSqkhXai2wc4XWz0DPyt37ohtdVS5Sl9GUrUAhNLZQ8WwfHGBjqDnAaXAhFvbbKsKLAsyrl+9lPa3LmvbqfHwOeypn67FtKNWYwDOqOs8BwGf6EslnBWq16e5C4pREtKYDG/o5Nt7LDKIoB6dKey2gWkncrihz2rM9hWwm97LU7xAAy0LYEawSyhZ0IfIJora+DtwV/tGvlWqN3Q4Bd8NFzPVdw282761WrZOvzbqz1BpLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=933dOy1/15myxWMSmrGSe6SN3W2z/0KPXoRGbpwjeRY=; b=u7MzSK9b7oagdR+1IMnX/kwxjeUYFGzhl4gwiWhZO6KUMq1YSUr5IczcueRByO/FkE/CkW34HXE+RTRwX7keTF19L5Gn4JNiFRM3Je4rQdpTsgY2/JLpr2Nxg8OZKD5JhgUr/g58Ll1lVKPw22wNCxw+CIXtQhkUqPOlATV2rIkePVGqRR91fHItnKWESnqtXlqCyqtK5uUBk2Lm2rgJize3u9qLSdJ2B3Z/ca3IKI+YgMZHNGA+IPigroTA+t8+VQoU97J08vk/Jw2ml4zyhgRxT8Axmvyc9IKFn+tZgWs28qXzaeVcMJtwbh2h3OctFXhlgVsosAsurL5Rv2Cfug== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by AM0PR01MB5761.eurprd01.prod.exchangelabs.com (2603:10a6:208:16c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Wed, 24 Aug 2022 13:07:28 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::210e:b627:bcc9:8c46]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::210e:b627:bcc9:8c46%11]) with mapi id 15.20.5546.022; Wed, 24 Aug 2022 13:07:28 +0000 Message-ID: Date: Wed, 24 Aug 2022 15:07:28 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220824084318.333-1-anton@khirnov.net> <20220824084318.333-13-anton@khirnov.net> From: Andreas Rheinhardt In-Reply-To: <20220824084318.333-13-anton@khirnov.net> X-TMN: [zFCCKy/zvuZCdKtxx6JihjNKU+ZpKwpX] X-ClientProxiedBy: ZR0P278CA0037.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1d::6) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: <546e74cd-4249-b328-3ebb-ac3c7e9128bc@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 75389666-478f-4743-0e08-08da85d198cb X-MS-TrafficTypeDiagnostic: AM0PR01MB5761:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wM8KvQaktvBcrjHfhJa03r3GDq7hJLUZzjE7EXE9E6VD8wYulOX85IR/05oxZn71pAcVPWAlJhuW1eEF9blRtSJ+Sf53zGA9hApnf9ZgXl+22mnuib3DzDfT9a43zzcIMqVs+1PgaZidyBHNogGkeA30eZSg2DAvOtiCyxM+UZW8sqka6kgVz0tVEieDpRMV0nsx++DE/pZ6XmkSC27cil/D6jaJeBNma7c47htK9Tn2sf9WS0vObY9JRmmU9ofaxDLDTiW95Et8bR+kizZR3zV/QzBwo+8vvUbuNgZXtkFnzRqjJ57QaJStKQ4XMwaGwsGVQhpfgyWZ5hSqiUw+u//BV4SriI9qws3BpGMJ0/kzZhCVIZLhN4ZowQn2i9RwzaQuUZ7L9O2CpYN36q0ASD5OETRGkTPCmk8qUZbG/Pq8I/wtB5VrzmFnCmm83VvZb7cGlKqArUdfO48aa6XEMw+Ua2Sqh1aWoh9O9bboK3tJsRFheM3a9mu+R5L28XPmPVIIkU9a/ih8M1PVj+203cVMUDFeM/pVW8TC+R9YY2Ys3u5N+HSJfhDD1Gy3Hn8D75wtO2xQQqOHQI8vSoexCV22yddRyoLTtYSqiWJclZJGr5IAgY3av6PCJS86Rn5nToFGWs9trxM2gGx2Q/pqjOMygBJq8KNjPe6uNNiJSwenZ6OcNiutJWylXn7EvS2X X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d0g2S1NyTW1zeURXRGlwWkdzVTJFWFMraTJZVFNVZlpBVDhTOWs0U09jSEty?= =?utf-8?B?QllzVGhMalE4WXZBbDJ1WXRvNGRIRC9MNlNBVW43WGY2ZEtmWHNNUHRsTmx3?= =?utf-8?B?WjNnd29kNm9lSGZabUlJbFMyL3FISEE4dUhuWGRIdW0vb0EwdWUvREIwNEtv?= =?utf-8?B?Tk1XdEFkdmlwVEpUdWxpOG1mUE16ZC9YeWdLSGo4TVdldkVIVHgrdzg2TDkw?= =?utf-8?B?cVNhTkxWRnB2SDhJOUp6akwyaUN5RW91Q0gxS2w0TVN1ZUI2NXh5T2pTM0Vv?= =?utf-8?B?NGdld09YYzFPM1diQzlnaDB5alFzeXVVNjdRNzdNQm9rSVV6V1FFVmVVRWc2?= =?utf-8?B?Y3FNTWlKMzFWMCtoeHg4NnorS0xmWWlSM0k4RVBPUU1mUDNiUkdCcnhUR2Zl?= =?utf-8?B?WndIc2R3a05pV3M3STJpaFRtMGlDK1E1ZUZ1cCsvY0lPTk5DWnhxVllZbGdM?= =?utf-8?B?aG1yZ2tPWkhiRC94aG1tV3BYV3BhMVQ2WGJyS2tIZ2hrY1NUZURHNDNZOGly?= =?utf-8?B?ejE3L0thU0RFcjV6VDRKNkNIUkZtRWFEeVFONHh4V0JhMjl4RUtIRGdtMG9B?= =?utf-8?B?M0pUM0JkWEpibllSZkJ6ZEk1N21NN1BMNlIyaEJ2ek5jM1RiN3ZLVWovd2pw?= =?utf-8?B?NUJDd3dMZWJZZWU1azhSVEEzZXp3V3R4dnFjZzV1eTU2WXVPL2tRVVdXbFpD?= =?utf-8?B?SEJ4NVMyc0F3UjBVNWtsQW03c2pnRnZzU2gzWE4rL2NNR3VMbEw5ekZQc0NR?= =?utf-8?B?QVpwT0hMNkh6bWZPMHQwWkVLUTBaaHRwVTJrZ1BpTVZRczJxU1NsU1R6Y1hk?= =?utf-8?B?Vm4yMmRuSnR1YWZpOXp6WkdvVDhRL2M1NXh5bngrQXUzMUhjdWU4cjM3UkFE?= =?utf-8?B?OTlGV2lpTFFyKzlvanllcGo4SytEb1M0NTJkNEczTElYUkY5VW1qWWxhZWZk?= =?utf-8?B?OUYrK3FlZGFNbTBQdXhnODdTQmlJMUJuc2d2RE4wcGE5b2pZSnA4SVJkSkhx?= =?utf-8?B?S0JYTEVBOC82NlpHSFJkd3drY2tnLzJKT3lUQnBoSWE2TXBkeFhXeUZUZ2th?= =?utf-8?B?VkUrSG43OVBsV1JVWFB2Y0tncFlDbldmVmlHNitTSFVXYmJPR0VrN0FxekVQ?= =?utf-8?B?RGsvUmJOMjBidXA0WVc1UE1IRUkxQUhFbEswSWZKTjQvMHkzVkJTSDcvSFBu?= =?utf-8?B?cVNxa004S3FtZXBvaDJTcUxUZkVtbG5CZTQzM0pzSW9LUVNLNjRLamdrbjQz?= =?utf-8?B?TzNCUnFxRVJTUnorR0o4SG8yQ2RWSTN4RVViMG1meWpoMXB6NUoreXpEVlQ0?= =?utf-8?B?MUJzRnkyU0JQOE9kVmtiT2hWSlNBRlFJbFB0N3ZqVEFJaVpUVmNPVUV3aXdI?= =?utf-8?B?Q1BhN1R6VEhnOWF5eGtDeStVYUg0T1B4NlhwVzRMKzZXNDVjSGhQWTdkTjF4?= =?utf-8?B?dUtmaU10M1h6MHU5bHQ4RlVXeWJQTThId21kbnV1RXJZNDB6ck03bW55V0ZF?= =?utf-8?B?SGxPd1F6NnFGL2R4YmZMUjMzeTliQTdiVkErbjJVK2ZDSFVVTDUxN3ZqWDYw?= =?utf-8?B?MWZPcS85TnBzKzdWSXZIWU9SVU1ZWk9JaFZDTHI4UlZmUVdEOTBQaGNSWFFv?= =?utf-8?B?bDdkNFdQMktDS3A4d21kOWRSVDFORTk4YVBVT0JmYWJwN0xiQlRYUG1IdGpU?= =?utf-8?B?S0ZIOUprUTU4ZTExTExOb3dUSXRhZnR3MDBudzFPdmZLQ3hKQ2VkMUV2Y01l?= =?utf-8?Q?5usdPOZzuQGFmlAGpU=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 75389666-478f-4743-0e08-08da85d198cb X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2022 13:07:28.7262 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR01MB5761 Subject: Re: [FFmpeg-devel] [PATCH 13/18] lavf/dv: return a meaningful error code from avpriv_dv_produce_packet() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Anton Khirnov: > --- > libavdevice/iec61883.c | 2 +- > libavformat/dv.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavdevice/iec61883.c b/libavdevice/iec61883.c > index 7223ba2e64..a4b4ce2ef8 100644 > --- a/libavdevice/iec61883.c > +++ b/libavdevice/iec61883.c > @@ -209,7 +209,7 @@ static int iec61883_parse_queue_dv(struct iec61883_data *dv, AVPacket *pkt) > dv->packets--; > > if (size < 0) > - return -1; > + return size; Did you test this? iec61883_read_packet() explicitly checks for -1 and not for < 0 for failure. It should work if you also modify iec61883_read_packet(), but I never changed this because I don't like to change code that I can't test. - Andreas > > if (av_packet_from_data(pkt, pkt->data, pkt->size) < 0) { > av_freep(&pkt->data); > diff --git a/libavformat/dv.c b/libavformat/dv.c > index f88fe62349..c888111789 100644 > --- a/libavformat/dv.c > +++ b/libavformat/dv.c > @@ -404,7 +404,7 @@ int avpriv_dv_produce_packet(DVDemuxContext *c, AVPacket *pkt, > if (buf_size < DV_PROFILE_BYTES || > !(c->sys = av_dv_frame_profile(c->sys, buf, buf_size)) || > buf_size < c->sys->frame_size) { > - return -1; /* Broken frame, or not enough data */ > + return AVERROR_INVALIDDATA; > } > > /* Queueing audio packet */ _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".