From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C541243652 for ; Wed, 20 Jul 2022 22:45:22 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5AB5268B73B; Thu, 21 Jul 2022 01:45:19 +0300 (EEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-oln040092074014.outbound.protection.outlook.com [40.92.74.14]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EF64268B46E for ; Thu, 21 Jul 2022 01:45:13 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nhnHHdd9KDpQT51AfFpmkEdbTxwXIYCsw/su0MK2juAexWOOEZI0RzQdi6dtt6r2pR+8dGC0YdlfYNkwkQA+wZEFPPgwhevwtYPR1XIZG2sqKaCOh4AePMp7wUK4RMbDlDLwPyHHWmk3iN8ATLKlnqalYuaqq2WsbcBMyD8lGmsTLmx3+Wv0EKPKdrnSUdqBuH05XhYql/4Kuj5RZ9Fd58qbV0GSSGDv+vGL3Oege13qIBUoSw9gJ+FwXtr2xpMQ6EgXNS+X4OZ0fsLaT1HcUNvMeo6kAKkg7M9HfFRUZyLXzePEwxMDcVTxATJ3qer1tOQIvKw0cTGfUKv1z0aKxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bcN2ggOWKHOp6K4M7AcgzZtBxbvbQDJCUp+RCdjx+FE=; b=gUvhupG6lj2x9renrBgjBA0krLWYI+xSNcHPg+sTLCvFt33T2WZe/U9vhEs3m0cT5SnjzKoA4ocmVIK7tYHxRw1Ud/ZdfLgfh19lXbtw1sD/eKazDtl7zqfBmNHB/TOJrZl7cLABohIh3dbsrW/Xq9aYERrO/X8clcSaIkyt/RR+0pp+E1tyeHjmeE8dw+CeDSFnqpGzz6/99wpM9qESZhAWbzfHPCvDxKvWsBRoDCLSMIN5fBXOEFzKa36+ALdwlt7oFH8K1Gw8F5+n5Eay17o/zhD+8j/sSyMeIELHXauioV+Om2zB25LeTKRg54wigAs8mMD9zkFFuumtUNIpWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bcN2ggOWKHOp6K4M7AcgzZtBxbvbQDJCUp+RCdjx+FE=; b=mpJFgWIbWhm/BjG/nYAoxE7Az77JTr9fa4JeRDd3jb1xYWD17WhT9kntoP7BIKvDYlfXPRpw0bcBq/SsTgYQhty96VsDqivvTLtROPRih+TJKQh8ePuSXSphPm8ZykivvRVgWF6CNRXS0xPwv1jA9Bqek7A5QxSZ7bOr0wkKnesgPeSVc5WezwM2k/+GJ9Su2SZ0sZhdBNMj8KYfdSYrAmS5xlof44Oldc9c/ovv4bI5I01NBiCQJzqxmdGxBVxhw0SKt5/mroRKgzSjKfeKim2aUIPV/4/qweQRrsL77WF1iH4Gj7Ofkvbb9KM4k2nJF0gOVLU16/dfm6FOpWzo2g== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by VI1PR01MB5151.eurprd01.prod.exchangelabs.com (2603:10a6:803:cb::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Wed, 20 Jul 2022 22:45:12 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::210e:b627:bcc9:8c46]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::210e:b627:bcc9:8c46%11]) with mapi id 15.20.5438.023; Wed, 20 Jul 2022 22:45:11 +0000 Message-ID: Date: Thu, 21 Jul 2022 00:45:09 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220720084006.5033-1-haihao.xiang@intel.com> <20220720084006.5033-7-haihao.xiang@intel.com> From: Andreas Rheinhardt In-Reply-To: <20220720084006.5033-7-haihao.xiang@intel.com> X-TMN: [mESbaTyDfQVZlyUPfqdXjZj+zOs8fSqP] X-ClientProxiedBy: ZR0P278CA0108.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:23::23) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bfa8d875-016e-4f86-196c-08da6aa180a4 X-MS-TrafficTypeDiagnostic: VI1PR01MB5151:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MR2P4nPVJ+KAE29cw7kMiRccCmyServcdGFoqx3dq2gvSRthrm4/i218SEOvi7QiD2k2CyIAD8hu09twxZcsSjG70vumzoMatYdJcWkoNW8064Bu0C0fynkt0zN8VLdwOltYgcK9kcAgk0EZjdNbgP2F/e/RjCAUTi58g+rIMv4drq0Wq01argkyjwyZ7wVSd9smHyX9vZ9rBA1wgdcWoW+wlTVuIIeko75LRA7KAX9hpZgzsXrR+bIih20nhSWQmbn+ici3VwLRI0fL13UqdX5Mz3NsxDRz/aAEUiTIfejOKsY/HZSBW1f8IfA4liPMed0cvv+nxwwXkJjzkHg7Gr/2sv3hGSTuFAQ1JqC9cEOi0pTUarrVBv0IIdck3/0ZAQJNblSRSI1UnWBseqCXGqKphaZqbXDVUCxlImWyElPx4pZn+A3MxB/ZH2/+smlZFn4fpUJfx3A4unaa75veRcXSEahNnNhRyJfqW5dnADkSw4UAAN8Mpzmq5ubsRFU4ms78o7Pp2A7+RDsYcC6FSMJFeVZVibBxD/nDw0wzxe9r55LIrEgPS9358dA1TZLCl6TolvjI+pmzyFyNh6fL4+/M7epaxu+9N6rzRx+tDLpE1UQuqe2DWhJwA/T/A1HYA7aS7aD2RpZVrYOnAvRSrWwu8mzMC52bVN4WHbjENvPS6HgOMquqbDbPaEb7Hx/s X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b216S2ZRRDgrUEd2MENNZEplTnE5L0JNVTlnOGtGTzVldHlNQ2ZoUDB6OE5a?= =?utf-8?B?WEJ2UTNZUk5qY2V1MXZpS3ZjVU1HOHFNdG1tY1BGbWgwcVZJejMrMVJtYUJI?= =?utf-8?B?YklGUVA4K3RuMTdxNEluYlEyaFVLYm9LYnJTM2NET2pPRW8zRnNIMDE2bmNz?= =?utf-8?B?TFY3dlRndkNud3o0c0UxQVBuenVRMy93T1lSUDdsSVRKWDBRZW9vVVcvQ1Fj?= =?utf-8?B?ZGlqZHFZbnYrSnFlT05QNCtPQ053RUZrUUtEdFJETHhwVmNaUVFKR0FQS24r?= =?utf-8?B?N3MyWWZwY05HYUN0UFhOUWt6K0RPZUdZdjI5WDY0WU1FTEZPd1JBUHl1Wjh0?= =?utf-8?B?cTE3TmpRUXFDbFB2eDI4YW5PeE1LZkFlYWNyUnBSbmdod0hOK1M0ditvOEhG?= =?utf-8?B?bE5teCtMOE9kTUdaQThWN2RnQzJxSmhGL3FsRHRJWlFocUQ1YllZWjRVZDM5?= =?utf-8?B?YjdqTGt1cGp4citZUkZCUktucFNiS1dZY2dVdnh4OGdsVGFBdlRIcE5GWENz?= =?utf-8?B?aWhveTIzQVliWWdSSmNCQ3VnWFhXUkdlS1J4NjBSaEQ5TFRLVzBrN1gyYWtV?= =?utf-8?B?NkVwTThSUkZtcTc1bVMwaEtJWjRaK2JEejNmanQ0aElXQmFqMW9kMWJiMDBw?= =?utf-8?B?SG03MG5xVTJFRTBITHVpNnZiT3lhWWVabFhLRWdYb3VvNHRVMnBPbGJWMHBy?= =?utf-8?B?RVlTVS9iaU9aVjVGd2c5TklTUUY4LytCWC9HRkZiQUNmOTJ1M29YU2d4RWJn?= =?utf-8?B?RVRvOTV6akRGL2tkVHRjcmRIZ0lvaUJnQS9PeGN0MlBYMEdoT0F4M0Viek5v?= =?utf-8?B?eHZ4TlJEQVlCeUcwSDkvaG9IQTA1bXhnYzZnSHNhWkRZYjNkTDE1YldEem0w?= =?utf-8?B?L3NkKzhxTnJncWFGTHBEZDFva0tMbmVlUjV4bU5semZoMnlJOFZXODV2dlRJ?= =?utf-8?B?b0ZFWjRVQ3VhWlkxNmZxdXNKTHhOdEcvWll5bkdtR044d3V5dE54UEdkU3Jm?= =?utf-8?B?NXJLajBtbjlXbCtRTlNibzd2VWZ0aVhTeVhtaWk1MW5zU1MwRDY2RGIzcXgv?= =?utf-8?B?THdhUHFBMmNkeTZSWDhGVUk1bkwrSFVndlJCR08rT0NnaGY5Q2pndTk0THpJ?= =?utf-8?B?Z3VwOFR4d013bmNiYjkwZnhTUmxFN0thdVJnM2puUVorb0FwQXExK3lPKy8w?= =?utf-8?B?eXE4eU1BNTZ1Q3RDcHY1Y2NYSXRocExCMEtFMTFocldqL0hwR2doRzk0T0ky?= =?utf-8?B?TE9kRGlMYzdVWmNkN1FyVXRkc0EvNUF3WGlOVU8zczcxZ3JGd1JnQy8wUlVU?= =?utf-8?B?UlIwbTc5bjRMNzdUTzZVTjJsNGZKWmJVVUEvN3pQNFZ2THhtVUR3ZUw5U2hx?= =?utf-8?B?bk5ya0cxdlRPMWk0akl6OE9YRDlFUHd5ZlZNZ0QrK0JxdTZvQk1jNDRSeFd6?= =?utf-8?B?RFRXeWhoME5sYno4ck9ISnFRZmVWOTMvWmRELzRZZStCRkZJWW5aZ3NCdEtz?= =?utf-8?B?VzhjaXd3eWFMU3BOeGNJc3RCM2VGaFArZWZxNVNjV1dMemxZVzdCcENtd3hv?= =?utf-8?B?eUNtQVFLY01TVXNrelVWdCswa2xKKzQ0Qms4SFpoQUZYdXhtUTFqOUU3RDU1?= =?utf-8?B?dWoyZGpHRFdtc3c1b200TUVHM1FtTHNPRmF6cDRGckR1UHlsa3JRUldEV2h3?= =?utf-8?B?NkNNRnBKdkZKYk5JVzZLcllwSC9PMjZEOWxJOWhqeGFrQzBRRk5yUHU3SEtv?= =?utf-8?Q?QtSWZP08U2I93yR+Mg=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bfa8d875-016e-4f86-196c-08da6aa180a4 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2022 22:45:10.9988 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR01MB5151 Subject: Re: [FFmpeg-devel] [PATCH v11 06/13] qsvenc: support multi-frame encode when MFX_VERSION < 2.0 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Xiang, Haihao: > From: Haihao Xiang > > Multi-frame encode isn't supported for MFX_VERSION >= 2.0[1][2]. This is > in preparation for oneVPL support > > [1] https://spec.oneapi.io/versions/latest/elements/oneVPL/source/VPL_intel_media_sdk.html#msdk-full-name-feature-removals > [2] https://github.com/oneapi-src/oneVPL > --- > libavcodec/qsvenc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/qsvenc.h b/libavcodec/qsvenc.h > index 4cadc38a59..40e2f65eff 100644 > --- a/libavcodec/qsvenc.h > +++ b/libavcodec/qsvenc.h > @@ -44,7 +44,7 @@ > #else > #define QSV_HAVE_AVBR 0 > #define QSV_HAVE_VCM 0 > -#define QSV_HAVE_MF 1 > +#define QSV_HAVE_MF !QSV_ONEVPL > #endif > > #define QSV_COMMON_OPTS \ "support multi-frame encode when MFX_VERSION < 2.0" sounds as if you were adding support for multi-frame encode. But the remaining commit message makes it clear that you are actually restricting multi-frame encode to MFX_VERSION < 2.0. So maybe you should reword the commit title accordingly (some other commits in this patchset suffer from the same defect). - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".