From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 04AE340EE2 for ; Fri, 10 Jun 2022 16:08:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8337B68B1E6; Fri, 10 Jun 2022 19:08:00 +0300 (EEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05olkn2038.outbound.protection.outlook.com [40.92.90.38]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EC9AB68B03D for ; Fri, 10 Jun 2022 19:07:53 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GnwmwtfUQPmhriDbE+2ys/9Lhja/VDJkMRKgIuo+DKpl7qZKVsa2gv+9xg/p8s5BuKK8wwLT849IVz+sP+29AGFbAoRj1wbJnv75WIu1K9Qend/1rZx04cjwHP+fL/bZQzK1CBUQ1BP18mPqqTSLlGcAv8NzDI70EVGScVqZc0fgnq2LmA9fBLQfjOoRBfw6z5w1rz2hbezVdGedE7gAPrWvw+o0ogiaCwl4LQJxCO2VNW8eGuLHj9ju4TVGpoWC1iI6kABIa9Upa3JigpGt4gcZX1UanCT1mwmKxIMgy99eY3ZMF0oQWuiSDDN25Aoe/JkUst0MiT1OFlwVU0/vog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=odib11/0jtsyHmfQw3Lbimr6DZBUOOK5GSAnQa2wjxI=; b=JwYo/pfyZgXOOhvjK448FqMexGNQUX4QCJbxQ9dYdRm9A7xGfRULQE+GLTfXYTIJ1B05hwULAveF47GtjErdHys7gGS73ww/8oVDg6lGXdO6JrLYKR5GDtC33OvPCR0wkXtzn/oA7HLdq6/KDsXtBI/mVB1tMkUW8Xe43keBipqQBis/b8y+qEDs04CRwjRzwkE1Oq9EajaM9MjRA3Eq5nolumlxvy16EDLBnUp5apQpPQbBb22pILdUo+QQr8npvaKycWb/Un+xp3e6TnQ3P9kG9dyqSZ/XWw7e/M4DPi/bsXyhmFaAxO+OSyLhjQvDDGdep6ufFQLnJ4+9Z4ljYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=odib11/0jtsyHmfQw3Lbimr6DZBUOOK5GSAnQa2wjxI=; b=FDERBBRDY5eZPZjVN7ETV7qTYHZhd9NXrgCx/9qRctnaStrzX96VwFmUX6Efu9HagZrgeEMiqp6pGRQHO4/B+TYrqtdNwbE/XiBJTIDyW+R599t2s3ATm8Wm3JrCe8qbx9kuk+uLyc5CnwUkY+U9TTm3tYhV+OUvCgOxTLxJ7E2bOU7A2UskXwkbMXlxFg5EHJ0Uu9PyhVgfuGK9eMpohOYcEEzA0DGQTyeICxRnLnV7ou9tfXHW6htIHYGoOysLh5kTeV/s0N9tcWHAniHua9pcFelqjjBBWUWCeuHlLWa81x09Xwiig2aXWWTvON/G4Jkko/DOguxdpfCVgVXTEg== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by AM0PR0102MB3346.eurprd01.prod.exchangelabs.com (2603:10a6:208:1e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.19; Fri, 10 Jun 2022 16:07:51 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c%10]) with mapi id 15.20.5332.013; Fri, 10 Jun 2022 16:07:45 +0000 Message-ID: Date: Fri, 10 Jun 2022 18:07:43 +0200 Content-Language: en-US To: "Ronald S. Bultje" , FFmpeg development discussions and patches References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [dJykoowSjiU0uCh+HEqU8s778dcRIneC] X-ClientProxiedBy: AM6P195CA0097.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:86::38) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: <706ff967-ef2d-0604-6534-f61c4b6092ae@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 90ff3bcc-6f1c-47ea-6b14-08da4afb5ae0 X-MS-TrafficTypeDiagnostic: AM0PR0102MB3346:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ePeV0L7cX9QfDpUgoPLZeUJyWjMkPaH91azJTjSrXl03Vyv5CTtu8X21/lu6r2FTF2YTaMmjTQ0QyfnTo7Je0UqNywXMfSSfWGJwzZetkb+ZHirC5P7DP17VhkgMcWi65Kr9IUtEB3fGNT5hvCRtZVVhSUD9Q/D9qk6dN8+q2j7cEnYqN+yLPU4kWbCUp7Z7UR7t9wIXi5F0wls6yTYdTaCGmB4pbhTVgrEPmz2s3HnY7l0lbtaRHtXclEE8dkvwtfUi64aJ+r/BRfnlpZXH/m0RnUPYNaiqcSZQ2u44wDREQRiQ05aRMK02Jn87/KRHiFuuHmYSDWL/0AJZx+WWgCqPJeOPvq0xzUgwIedC3UIUN32sKuk0zjO73l6kZ1rtgwv4hGiDhlz6Aqn6Z9Gkx8OQ56pmTrCspjb6+DvcuKVQ++PA2UgBbzl+6YjlIz4IAUyOooMjRQUI/A8XzJx0oMXGwxyclRBloxOM8lZ1/N5byTA6Mpa9dTDEw5JTzkudtfPUmi3MsFcZJ+yxxlZCXMtQcQns7ICUMLe0PAUisV/g5Tj4LCy3+MPCWGN7O9N64VCEer1NZjkEZE7404RMFQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?azdQQm51TEd3UHdOQW5ZdmQzd2dPYmFjVlVCc1oza05zczZka2F4NGV2RXlt?= =?utf-8?B?TDNWVjdzK04xMXlwbVNIZTIyQjFQRm9VMmRRc0wrbHZLK1FsUmw0dFRJSDIw?= =?utf-8?B?bFRNQ1ZTWUlEYWZ2b0UwN1ROUW5kcGM0ZWdqUlp1QU5GVWhCOE1wV2R5Q0M3?= =?utf-8?B?elRpMWJBK0kvNXlsYnVKOWJuekxGWWVYUTVwYzlEZy9MeWZzaXdFci9LRzEx?= =?utf-8?B?MHc1ZUt4ckNaNlgxYWZCSlNtUUJSKzVvTTFoSFFGM2xOcVdSQ0FWUU9xVG9G?= =?utf-8?B?NVAvUTRVODlYYUZZOHo2SnpaOFVsQlR2TTZNRTNiRXc2OGlkbU1iT2xTL1Z4?= =?utf-8?B?UTB3Q2c3QUcrbG9zZUd0anVyanN3MVllbi9IaGt6aWlWTkVoaUxETkdiNVpx?= =?utf-8?B?aDJpVlRiTGJOaXo1cnRQQVdmSitnYi9QRE9ZSG0yTEFneVkrMGQ1a1YwWEV0?= =?utf-8?B?bmdXNTNEUnJ1Nko2eTZ6ZTNVa0hhOCtZaTE5T05Wa3FISml1cldLeXJBbnQz?= =?utf-8?B?RE56M1lDbWIrWDdZakc5K2RhekhOTDlmN1pQazRIbUNPdUhkYVpWaFAzQ3RE?= =?utf-8?B?K2J2ZFc1Qk93OHBOWEVxTnN4MitWRHVPM3pFZWN5VkJlWWtvZzR2SVo5bGJI?= =?utf-8?B?R3BMR0RuMmw4SzJvbVhIeS81TzhTOW03WlJ6WlBwYjFyUlFlbFlVTGZlQ21i?= =?utf-8?B?UlVTbU83Qy9neHN1ZVF6bnpSMTg2bnlZY2x0eWNWVmZweHhGNlRXODEzZFhz?= =?utf-8?B?MVRYVjduOHpudGl2cGlqbTB1WkxRTTg1bVVYSGRGeWQ1ZStpalR1YTM5T3lL?= =?utf-8?B?TU54cHdpTENGb21YQm5wR1pERUdtc2lvM2JrOGt4Y25Td0JBa1B4a1grM25m?= =?utf-8?B?UzJ1L3FwTFhPTmc1cnB3NGtkTWJGSzRJRmJNa1crOXZaSnhUUDVGZTlwTzZs?= =?utf-8?B?VThBeTdLQVo1YTdsUnNBWndxcmJuQWQrMEY0dXVNWXpoU1RqZ2JmOE5DZStT?= =?utf-8?B?REY2RTZFeVZyQkY2Q0lBOFBwV3ZNVHR0Q2w0TVZOcFBrMEw4ZlNJcjRVQS9v?= =?utf-8?B?M1FsOW5MUDdtVmh4TFg5a0w4amM0dno3Z1EyMmdxMkpWOUZ3bUlqNGtGT0lL?= =?utf-8?B?Szgzbk5SZjJ6M0UzZC91MXg3QkpYZ28xVVpTRHhUQkIxMERicExvNkkwd0pW?= =?utf-8?B?Ry9oL051VnRoWm1hUmduaFNPSGhOV3g5aUlYY2NQOXduZWVUR1Q4aUFPY2Vq?= =?utf-8?B?TG1LM0NhNHpSdFpuck1IcE9qL0l1TWR1YWoyMkpiWUZDSENWZzZGY21UZlhz?= =?utf-8?B?b2dud0pTTUZJaXVhdnB2eitlOENubXVEK2tDelluQUo4Mm5Ob1UxOExpWVRQ?= =?utf-8?B?LzJkR0tVQi9XTTVTaE5XdHBhQ25VTzFoYXlQOVVNeTh5WTlPUGVuR3M2QllP?= =?utf-8?B?UG9sbWcySWNsNkRhdEZHUXJJMCs2dzFZTmxsM2Vpek81bU9JYVJrQ0JHbmJu?= =?utf-8?B?Q3pZY2w0ZlVRMW8zUDMwM1hjNzFtQndXTXh4Y0FNckhPS0N6RzNuOGdrY1pv?= =?utf-8?B?YitmUzg1MzZuRGh1ZEMwNFg4SnA3WHdta21qQ3Y4MGMvRzlHN0xXc0JoNnYr?= =?utf-8?B?NW9PV0ZpZXY4MDdRNVBQamRRWnh4MVN4d1ErRi9vUzEvSGxpMmMrNENTOWlO?= =?utf-8?B?Kzk2R2t1RVdJdlV2NForVHd5UEdtaU0rV3F4TEFPVmo5OW5jYUZZRVVmL3pE?= =?utf-8?B?bFJCQkhQSUV3QVpLdCtXNmw0MzNCMFo0VXpUTWxRT0pZaUxPY2tMVnZLcm94?= =?utf-8?B?Uy9JRjVDR2FVQ3pHUnlsOXFhcjRZRFNwaXY0VWdUVDdFVVdBSlFKb25hRFE5?= =?utf-8?B?bitDYlVWbDZpWG4reTBUZmZ3aFdaOXE1bGpzblJPNDZnQ1RYbldMb1Y5QlM3?= =?utf-8?B?cCs3ZmdobmhlS1FoWWQ4UkgwVzQrRHNZb3JzQ245Y3hzeVZlUWluWGZtdTdB?= =?utf-8?B?VVAwVER6cHVnPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90ff3bcc-6f1c-47ea-6b14-08da4afb5ae0 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2022 16:07:45.1687 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0102MB3346 Subject: Re: [FFmpeg-devel] [PATCH 05/41] avcodec/videodsp: Make ff_emulated_edge_mc_16 static X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Ronald S. Bultje: > Hi, > > On Thu, Jun 9, 2022 at 7:56 PM Andreas Rheinhardt < > andreas.rheinhardt@outlook.com> wrote: > >> Only ff_emulated_edge_mc_8() is used outside of lavc/videodsp.c. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/videodsp.c | 4 ++++ >> libavcodec/videodsp.h | 1 - >> libavcodec/videodsp_template.c | 1 + >> 3 files changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/libavcodec/videodsp.c b/libavcodec/videodsp.c >> index 2198d46c15..02af046b81 100644 >> --- a/libavcodec/videodsp.c >> +++ b/libavcodec/videodsp.c >> @@ -25,11 +25,15 @@ >> #include "videodsp.h" >> >> #define BIT_DEPTH 8 >> +#define STATIC >> #include "videodsp_template.c" >> +#undef STATIC >> #undef BIT_DEPTH >> >> #define BIT_DEPTH 16 >> +#define STATIC static >> #include "videodsp_template.c" >> +#undef STATIC >> #undef BIT_DEPTH >> >> static void just_return(uint8_t *buf, ptrdiff_t stride, int h) >> > [..] > >> diff --git a/libavcodec/videodsp_template.c >> b/libavcodec/videodsp_template.c >> index 55123a5844..8bc3290248 100644 >> --- a/libavcodec/videodsp_template.c >> +++ b/libavcodec/videodsp_template.c >> @@ -20,6 +20,7 @@ >> */ >> >> #include "bit_depth_template.c" >> +STATIC >> void FUNC(ff_emulated_edge_mc)(uint8_t *buf, const uint8_t *src, >> ptrdiff_t buf_linesize, >> ptrdiff_t src_linesize, >> -- >> 2.34.1 >> > > This splits the "staticness" over two places (i.e. to understand what > STATIC means and/or why it exists, you have to look at two places), and > also doesn't explain why we need "variable staticness" (i.e. one being > static, but not the other one). > > Maybe you could use the following: > > #if BIT_DEPTH != 8 // we make a call to the 8-bit version in > $fill_me_in_here$ > static > #endif > void FUNC(ff_.. > > That way the meaning of STATIC is not obfuscated (I know, STATIC should be > obvious, but it's still an indirection) and the reasoning is included also. > > Ronald > I'll change it if you prefer it that way. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".