From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Subject: [FFmpeg-devel] [PATCH 05/11] avcodec/frame_thread_encoder: Forward got_packet directly
Date: Wed, 24 Aug 2022 03:40:00 +0200
Message-ID: <DB6PR0101MB2214C6024398AF84438EA68C8F739@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com> (raw)
In-Reply-To: <DB6PR0101MB22147759BB89DB6819E1B5998F739@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com>
Instead of indicating whether we got a packet by setting
pkt->data and pkt->size to zero.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
libavcodec/frame_thread_encoder.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/libavcodec/frame_thread_encoder.c b/libavcodec/frame_thread_encoder.c
index 07d310a986..b5765b6343 100644
--- a/libavcodec/frame_thread_encoder.c
+++ b/libavcodec/frame_thread_encoder.c
@@ -45,6 +45,7 @@ typedef struct{
AVPacket *outdata;
int return_code;
int finished;
+ int got_packet;
} Task;
typedef struct{
@@ -110,10 +111,8 @@ static void * attribute_align_arg worker(void *v){
if (ret >= 0 && ret2 < 0)
ret = ret2;
pkt->pts = pkt->dts = frame->pts;
- } else {
- pkt->data = NULL;
- pkt->size = 0;
}
+ task->got_packet = got_packet;
pthread_mutex_lock(&c->buffer_mutex);
av_frame_unref(frame);
pthread_mutex_unlock(&c->buffer_mutex);
@@ -315,8 +314,7 @@ int ff_thread_video_encode_frame(AVCodecContext *avctx, AVPacket *pkt,
* because there is no outstanding task with this index. */
outtask->finished = 0;
av_packet_move_ref(pkt, outtask->outdata);
- if(pkt->data)
- *got_packet_ptr = 1;
+ *got_packet_ptr = outtask->got_packet;
c->finished_task_index = (c->finished_task_index + 1) % c->max_tasks;
return outtask->return_code;
--
2.34.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-08-24 1:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 1:28 [FFmpeg-devel] [PATCH 01/11] avcodec/tests/avcodec: Mark frame-thrd encoder incompatible with delay Andreas Rheinhardt
2022-08-24 1:39 ` [FFmpeg-devel] [PATCH 02/11] avcodec/encode: Apply intra_only_flag for receive_packet-API, too Andreas Rheinhardt
2022-08-24 1:39 ` [FFmpeg-devel] [PATCH 03/11] avcodec/aptx: Move AudioFrameQueue to aptxenc.c Andreas Rheinhardt
2022-08-24 1:39 ` [FFmpeg-devel] [PATCH 04/11] avcodec/encode: Simplify check for frame-threaded encoder Andreas Rheinhardt
2022-08-24 1:40 ` Andreas Rheinhardt [this message]
2022-08-24 1:40 ` [FFmpeg-devel] [PATCH 06/11] avcodec/encode, frame_thread_encoder: Unify calling encode callback Andreas Rheinhardt
2022-08-24 1:40 ` [FFmpeg-devel] [PATCH 07/11] avcodec/encode: Remove redundant check Andreas Rheinhardt
2022-08-24 1:40 ` [FFmpeg-devel] [PATCH 08/11] avcodec/(dca|tta|pcm-bluray|pcm-dvd|wavpack)enc: Set pts+dur generically Andreas Rheinhardt
2022-08-24 1:40 ` [FFmpeg-devel] [PATCH 09/11] avcodec: Make ff_alloc_packet() based encoders accept user buffers Andreas Rheinhardt
2022-08-24 1:40 ` [FFmpeg-devel] [PATCH 10/11] avcodec/encode: Fix outdated comment Andreas Rheinhardt
2022-08-24 1:40 ` [FFmpeg-devel] [PATCH 11/11] avcodec/internal: " Andreas Rheinhardt
2022-08-26 0:27 ` [FFmpeg-devel] [PATCH v2] " Andreas Rheinhardt
2022-08-25 2:07 ` [FFmpeg-devel] [PATCH 12/21] avcodec/roqvideoenc: Remove internal.h inclusion Andreas Rheinhardt
2022-08-27 12:13 ` Andreas Rheinhardt
2022-08-25 2:07 ` [FFmpeg-devel] [PATCH 13/21] avcodec/internal: Move ff_get_format() to decode.h Andreas Rheinhardt
2022-08-25 2:07 ` [FFmpeg-devel] [PATCH 14/21] avcodec/internal: Move ff_reget_buffer() " Andreas Rheinhardt
2022-08-25 16:33 ` [FFmpeg-devel] [PATCH 15/21] avcodec/internal: Move ff_get_buffer() " Andreas Rheinhardt
2022-08-25 16:33 ` [FFmpeg-devel] [PATCH 16/21] avcodec/internal: Move ff_set_sar() " Andreas Rheinhardt
2022-08-25 16:33 ` [FFmpeg-devel] [PATCH 17/21] avcodec/internal: Move ff_set_dimensions() " Andreas Rheinhardt
2022-08-25 16:33 ` [FFmpeg-devel] [PATCH 18/21] avcodec/internal: Move ff_samples_to_time_base() to encode.h Andreas Rheinhardt
2022-08-25 16:33 ` [FFmpeg-devel] [PATCH 19/21] avcodec/internal: Move ff_side_data_update_matrix_encoding to decode.h Andreas Rheinhardt
2022-08-25 16:33 ` [FFmpeg-devel] [PATCH 20/21] avcodec/internal: Move ff_dvdsub_parse_palette() to new header dvdsub.h Andreas Rheinhardt
2022-08-25 16:34 ` [FFmpeg-devel] [PATCH 21/21] avcodec/targa: Fix indentation Andreas Rheinhardt
2022-08-26 0:31 ` [FFmpeg-devel] [PATCH 01/11] avcodec/tests/avcodec: Mark frame-thrd encoder incompatible with delay Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB6PR0101MB2214C6024398AF84438EA68C8F739@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git