* [FFmpeg-devel] [PATCH] sws: Replace call to yuv2yuvX_mmx by yuv2yuvX_mmxext @ 2022-08-17 8:48 Alan Kelly 2022-08-17 8:56 ` Andreas Rheinhardt 0 siblings, 1 reply; 6+ messages in thread From: Alan Kelly @ 2022-08-17 8:48 UTC (permalink / raw) To: ffmpeg-devel; +Cc: Alan Kelly --- libswscale/x86/swscale.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libswscale/x86/swscale.c b/libswscale/x86/swscale.c index 32d441245d..881a4b7798 100644 --- a/libswscale/x86/swscale.c +++ b/libswscale/x86/swscale.c @@ -211,7 +211,7 @@ static void yuv2yuvX_ ##opt(const int16_t *filter, int filterSize, \ if(pixelsProcessed > 0) \ ff_yuv2yuvX_ ##opt(filter, filterSize - 1, 0, dest - offset, pixelsProcessed + offset, dither, offset); \ if(remainder > 0){ \ - ff_yuv2yuvX_mmx(filter, filterSize - 1, pixelsProcessed, dest - offset, pixelsProcessed + remainder + offset, dither, offset); \ + ff_yuv2yuvX_mmxext(filter, filterSize - 1, pixelsProcessed, dest - offset, pixelsProcessed + remainder + offset, dither, offset); \ } \ return; \ } -- 2.37.1.595.g718a3a8f04-goog _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH] sws: Replace call to yuv2yuvX_mmx by yuv2yuvX_mmxext 2022-08-17 8:48 [FFmpeg-devel] [PATCH] sws: Replace call to yuv2yuvX_mmx by yuv2yuvX_mmxext Alan Kelly @ 2022-08-17 8:56 ` Andreas Rheinhardt 2022-08-17 9:05 ` Alan Kelly 0 siblings, 1 reply; 6+ messages in thread From: Andreas Rheinhardt @ 2022-08-17 8:56 UTC (permalink / raw) To: ffmpeg-devel Alan Kelly: > --- > libswscale/x86/swscale.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libswscale/x86/swscale.c b/libswscale/x86/swscale.c > index 32d441245d..881a4b7798 100644 > --- a/libswscale/x86/swscale.c > +++ b/libswscale/x86/swscale.c > @@ -211,7 +211,7 @@ static void yuv2yuvX_ ##opt(const int16_t *filter, int filterSize, \ > if(pixelsProcessed > 0) \ > ff_yuv2yuvX_ ##opt(filter, filterSize - 1, 0, dest - offset, pixelsProcessed + offset, dither, offset); \ > if(remainder > 0){ \ > - ff_yuv2yuvX_mmx(filter, filterSize - 1, pixelsProcessed, dest - offset, pixelsProcessed + remainder + offset, dither, offset); \ > + ff_yuv2yuvX_mmxext(filter, filterSize - 1, pixelsProcessed, dest - offset, pixelsProcessed + remainder + offset, dither, offset); \ > } \ > return; \ > } What about the call to yuv2yuvX_mmx() in line 208 of this macro? Can it not also be replaced by yuv2yuvX_mmxext()? - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
* [FFmpeg-devel] [PATCH] sws: Replace call to yuv2yuvX_mmx by yuv2yuvX_mmxext 2022-08-17 8:56 ` Andreas Rheinhardt @ 2022-08-17 9:05 ` Alan Kelly 2022-08-17 9:13 ` Andreas Rheinhardt 0 siblings, 1 reply; 6+ messages in thread From: Alan Kelly @ 2022-08-17 9:05 UTC (permalink / raw) To: ffmpeg-devel; +Cc: Alan Kelly --- Call yuv2yuvX_mmxext on line 208 also. libswscale/x86/swscale.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libswscale/x86/swscale.c b/libswscale/x86/swscale.c index 32d441245d..e0f90d5c58 100644 --- a/libswscale/x86/swscale.c +++ b/libswscale/x86/swscale.c @@ -205,13 +205,13 @@ static void yuv2yuvX_ ##opt(const int16_t *filter, int filterSize, \ int remainder = (dstW % step); \ int pixelsProcessed = dstW - remainder; \ if(((uintptr_t)dest) & 15){ \ - yuv2yuvX_mmx(filter, filterSize, src, dest, dstW, dither, offset); \ + yuv2yuvX_mmxext(filter, filterSize, src, dest, dstW, dither, offset); \ return; \ } \ if(pixelsProcessed > 0) \ ff_yuv2yuvX_ ##opt(filter, filterSize - 1, 0, dest - offset, pixelsProcessed + offset, dither, offset); \ if(remainder > 0){ \ - ff_yuv2yuvX_mmx(filter, filterSize - 1, pixelsProcessed, dest - offset, pixelsProcessed + remainder + offset, dither, offset); \ + ff_yuv2yuvX_mmxext(filter, filterSize - 1, pixelsProcessed, dest - offset, pixelsProcessed + remainder + offset, dither, offset); \ } \ return; \ } -- 2.37.1.595.g718a3a8f04-goog _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH] sws: Replace call to yuv2yuvX_mmx by yuv2yuvX_mmxext 2022-08-17 9:05 ` Alan Kelly @ 2022-08-17 9:13 ` Andreas Rheinhardt 2022-08-17 9:20 ` Alan Kelly 0 siblings, 1 reply; 6+ messages in thread From: Andreas Rheinhardt @ 2022-08-17 9:13 UTC (permalink / raw) To: ffmpeg-devel Alan Kelly: > --- > Call yuv2yuvX_mmxext on line 208 also. > libswscale/x86/swscale.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libswscale/x86/swscale.c b/libswscale/x86/swscale.c > index 32d441245d..e0f90d5c58 100644 > --- a/libswscale/x86/swscale.c > +++ b/libswscale/x86/swscale.c > @@ -205,13 +205,13 @@ static void yuv2yuvX_ ##opt(const int16_t *filter, int filterSize, \ > int remainder = (dstW % step); \ > int pixelsProcessed = dstW - remainder; \ > if(((uintptr_t)dest) & 15){ \ > - yuv2yuvX_mmx(filter, filterSize, src, dest, dstW, dither, offset); \ > + yuv2yuvX_mmxext(filter, filterSize, src, dest, dstW, dither, offset); \ > return; \ > } \ > if(pixelsProcessed > 0) \ > ff_yuv2yuvX_ ##opt(filter, filterSize - 1, 0, dest - offset, pixelsProcessed + offset, dither, offset); \ > if(remainder > 0){ \ > - ff_yuv2yuvX_mmx(filter, filterSize - 1, pixelsProcessed, dest - offset, pixelsProcessed + remainder + offset, dither, offset); \ > + ff_yuv2yuvX_mmxext(filter, filterSize - 1, pixelsProcessed, dest - offset, pixelsProcessed + remainder + offset, dither, offset); \ > } \ > return; \ > } Does this not cause a warning because yuv2yuvX_mmx is now unused? - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
* [FFmpeg-devel] [PATCH] sws: Replace call to yuv2yuvX_mmx by yuv2yuvX_mmxext 2022-08-17 9:13 ` Andreas Rheinhardt @ 2022-08-17 9:20 ` Alan Kelly 2022-08-17 9:40 ` Andreas Rheinhardt 0 siblings, 1 reply; 6+ messages in thread From: Alan Kelly @ 2022-08-17 9:20 UTC (permalink / raw) To: ffmpeg-devel; +Cc: Alan Kelly --- Remove yuv2yuvX_mmx as it is no longer used. libswscale/x86/swscale.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/libswscale/x86/swscale.c b/libswscale/x86/swscale.c index 32d441245d..89ef9f5d2b 100644 --- a/libswscale/x86/swscale.c +++ b/libswscale/x86/swscale.c @@ -205,20 +205,17 @@ static void yuv2yuvX_ ##opt(const int16_t *filter, int filterSize, \ int remainder = (dstW % step); \ int pixelsProcessed = dstW - remainder; \ if(((uintptr_t)dest) & 15){ \ - yuv2yuvX_mmx(filter, filterSize, src, dest, dstW, dither, offset); \ + yuv2yuvX_mmxext(filter, filterSize, src, dest, dstW, dither, offset); \ return; \ } \ if(pixelsProcessed > 0) \ ff_yuv2yuvX_ ##opt(filter, filterSize - 1, 0, dest - offset, pixelsProcessed + offset, dither, offset); \ if(remainder > 0){ \ - ff_yuv2yuvX_mmx(filter, filterSize - 1, pixelsProcessed, dest - offset, pixelsProcessed + remainder + offset, dither, offset); \ + ff_yuv2yuvX_mmxext(filter, filterSize - 1, pixelsProcessed, dest - offset, pixelsProcessed + remainder + offset, dither, offset); \ } \ return; \ } -#if HAVE_MMX_EXTERNAL -YUV2YUVX_FUNC_MMX(mmx, 16) -#endif #if HAVE_MMXEXT_EXTERNAL YUV2YUVX_FUNC_MMX(mmxext, 16) #endif -- 2.37.1.595.g718a3a8f04-goog _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH] sws: Replace call to yuv2yuvX_mmx by yuv2yuvX_mmxext 2022-08-17 9:20 ` Alan Kelly @ 2022-08-17 9:40 ` Andreas Rheinhardt 0 siblings, 0 replies; 6+ messages in thread From: Andreas Rheinhardt @ 2022-08-17 9:40 UTC (permalink / raw) To: ffmpeg-devel Alan Kelly: > --- > Remove yuv2yuvX_mmx as it is no longer used. > libswscale/x86/swscale.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/libswscale/x86/swscale.c b/libswscale/x86/swscale.c > index 32d441245d..89ef9f5d2b 100644 > --- a/libswscale/x86/swscale.c > +++ b/libswscale/x86/swscale.c > @@ -205,20 +205,17 @@ static void yuv2yuvX_ ##opt(const int16_t *filter, int filterSize, \ > int remainder = (dstW % step); \ > int pixelsProcessed = dstW - remainder; \ > if(((uintptr_t)dest) & 15){ \ > - yuv2yuvX_mmx(filter, filterSize, src, dest, dstW, dither, offset); \ > + yuv2yuvX_mmxext(filter, filterSize, src, dest, dstW, dither, offset); \ > return; \ > } \ > if(pixelsProcessed > 0) \ > ff_yuv2yuvX_ ##opt(filter, filterSize - 1, 0, dest - offset, pixelsProcessed + offset, dither, offset); \ > if(remainder > 0){ \ > - ff_yuv2yuvX_mmx(filter, filterSize - 1, pixelsProcessed, dest - offset, pixelsProcessed + remainder + offset, dither, offset); \ > + ff_yuv2yuvX_mmxext(filter, filterSize - 1, pixelsProcessed, dest - offset, pixelsProcessed + remainder + offset, dither, offset); \ > } \ > return; \ > } > > -#if HAVE_MMX_EXTERNAL > -YUV2YUVX_FUNC_MMX(mmx, 16) > -#endif > #if HAVE_MMXEXT_EXTERNAL > YUV2YUVX_FUNC_MMX(mmxext, 16) > #endif Thanks. I'll apply this tonight unless someone else has objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-08-17 9:40 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-08-17 8:48 [FFmpeg-devel] [PATCH] sws: Replace call to yuv2yuvX_mmx by yuv2yuvX_mmxext Alan Kelly 2022-08-17 8:56 ` Andreas Rheinhardt 2022-08-17 9:05 ` Alan Kelly 2022-08-17 9:13 ` Andreas Rheinhardt 2022-08-17 9:20 ` Alan Kelly 2022-08-17 9:40 ` Andreas Rheinhardt
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git