From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 50FC943DCC for ; Thu, 11 Aug 2022 08:05:46 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 77C2868B8A2; Thu, 11 Aug 2022 11:05:44 +0300 (EEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2063.outbound.protection.outlook.com [40.92.89.63]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E699168B452 for ; Thu, 11 Aug 2022 11:05:37 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F3vo74vz5JWOgpxL16TUB2DpW4F+HUrJ20vcxzO41m4zhMqdf6GlD7Hnx7+XazZYEkbLYM9uJaUiM32K1zhTqUX+XgJZxX/88aqLR2KEYTXQHeZz8dnr3/pYS4sAEz5bwgLW2BZ9NUgYtgQURj8MCkhmfzJJWyckNcwpcx1+YAuoDC0kDwExhALYbI/pS7RR/U3Io1+sHsiMOhThDo9qIpXdKCEmhl3afF2wX7lq+7cayhxxYrpM4dasmowr2YYqAbn5m7g7JyKlgECWZ/CKnUS/xB6IoDlWefUQw2v4x45Qtbu8EYxKd7OcfwiCui8t7XU/QI3GBZHzmXTEi8494w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fwgAAeGQzCn+s6pnoj+0BFqwLdWCNg9X1HYFhKrVt2Y=; b=F4s7aAWS6+KJ7REzdlgshd0FsRdrK/fExUTzD7wMQlDK2hYm51inyLsj+9uNF2CBLGlU4ezkfodFn+DWJ/tusC4NrPUhg+WjwM2AAPJhhcFppTf3KSCncQdCVqztEqKNYsWEpPyD+fCLCl89HQ3uNdaVvOb9LM8KsURUedCYkDfSc0ENyU1B/pV/WpKiKohpEdQmHmi1+AJlUBPynPPWAlY1T2jNlezdLKSmw+9zfvKPtUDBEUEd2eqG3A+0cIUMAiucdnEX3PgV1k9pQ4esc/oONArxLGdkmUiYwWq4pKqFJPlOlUYWtyTL5iT4/jSiFrSUrg9SNQuMzpAOeRWRUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fwgAAeGQzCn+s6pnoj+0BFqwLdWCNg9X1HYFhKrVt2Y=; b=VoZEn73QHMGIBeyWbLlF1qOlAiKML3TYCWzX6jurbxE501duw0oTAiaPjov17nFCU/3xY7CFK3qwS9BN/yLonSLj/2AAV6nQuMN7d00TKJbfBe23subior6XfvXEB6OGvyGosr9bEVXvhjM0btC5LiR4mUYrJPcCnekEc2TjC1RCw0t8wqAkFqcmO/Lg0v8Sx8UjLEh0Q8fAmCzn1/ksZcp3i2MNqwUUifz8UOz4m6cY77mnakZSSYRqEkdI4v+cM65fnIxzgy6d7yz4qCfeCv3ECs4HbYQor+5Oqo0AzCmsqxUoxLc/UXOvYD6BqC1pRduL9/7pH7GWU47Ae6Xabg== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by AM9PR01MB7235.eurprd01.prod.exchangelabs.com (2603:10a6:20b:2cc::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.10; Thu, 11 Aug 2022 08:05:36 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::210e:b627:bcc9:8c46]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::210e:b627:bcc9:8c46%11]) with mapi id 15.20.5504.020; Thu, 11 Aug 2022 08:05:36 +0000 Message-ID: Date: Thu, 11 Aug 2022 10:05:33 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [6rvcASqgOsN0X2NgKUhHCecS5c5dUawe] X-ClientProxiedBy: ZRAP278CA0014.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:10::24) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 10b03380-71d0-427d-9a70-08da7b704593 X-MS-TrafficTypeDiagnostic: AM9PR01MB7235:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gtrwNSGHfL/9I1i02G97Xmr+CGe1gVRMcjuLiRlpE9/DMI87tlX65Rc/TRoiOLDml+YQfJUf1ewPi291+bbj9QxI8M8/7CwaC1AV2w0lsgU/oe581vazGsTBLzP3LbtFd3zPvjvHxbn7CPsZuOdEPL0Bonx+G4zbkHuottiNb+2gJMKDwIJmsl3Ge7vh+n+SGOjU2CAtWka6T1+JpLuBSUCWNf0fhZBjlkKwKHMaeUYW7gIP/92EF6s4QPeiKYshy9eyCo6B8+cu4Vc4/TO0ysQrVXBHyOQzDsOBUqCB7PIFl9OhzfKoaHOqOhgKqxRxjlBdz5ZKFN4MH1NsoO9zwCaH9m8R3S6tq8kCXCqC1Wj0ZooQ6CeNVggK93cK1f14T75vAAi/w6sygkLKgjGQ8sK3EQ9iJxS3/MOYOWZVfKXxqib/j9POUSrAUjNGLSNdP6GcbcEJVHvRsr1IGbIL0WrKeoZvY2Q9yS9vX+0Mr1SBPPInssmgVr85i4Yse3AQ7QPef8kowCtmYxDW4ybsWl0OyDvkZwtGnQL38ZT40KgDaNqfkLwxkN7TQIpNUHkxCM3gIsU6OJ3GxsBqq9S2JuYrvNH363mXNxJjQowylIWyjU487njHKFldM2tAqKP/4a3ziZlI/UK3TGkD04+W2fNuxMgJnuZTv2rkftEsydcXV0XARieWGFSg0LMYFUDv X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZGlMTFJQYlEySmVSdWZqSktkd0Z4QUpXUHBORlJIRXdEaStBUFFudmZJYTlJ?= =?utf-8?B?Wk9WUmFJOGt3RVJvbXM3RXFzM1VhSm9kcXdrYnovV3FlVE52dW5NMG8yNlVa?= =?utf-8?B?d29uYkVITHFFNzlRWC9zY2dTSG5uRlRHUzBnVXR3d2duMzkvUFBIZE00aUQ2?= =?utf-8?B?K2EwQ3c1b3AxREgyampCYm5CR28vanBuTzFjbHlyUUVDakZHVnBsY3pmQ2Nw?= =?utf-8?B?YkE3QU5xNGRRUEJ1YWxjNEM4VnBQNjh1bDcvZCt2NFZwQXhnczdDZ2t0Z2lX?= =?utf-8?B?enpsdllCVUJHRXV1RGxieXVjK0R4K3NuRkk0WUgySmgrQWFTYmkxc3Zwc0lv?= =?utf-8?B?bVB5cVJZVVZrRDE3N2JmZkFyTnN3SGFoTllTVmpsalJEUDFCNnIxaytDVkl6?= =?utf-8?B?ZDhEY2UwQ3lOMS9aQytjM1B3eVdNS2p4a2lFR2hpYnFLMVl2VlcxcUdzTlY5?= =?utf-8?B?ajhnR1F0REp0Z3gwTlJyV3EzVVVISHFhMis2UXEyUzFzTHBkc3hmZkpUVWlh?= =?utf-8?B?anBrTENzY2xZTDZSc3l3cS96N1RyNkUwU2VKRmVRSU8yd1JackRqYURHV1Na?= =?utf-8?B?KzROTWtHUk0xaEZGL2hyYUMxYlVQWlZsNkw3SWRuOU5OMkVvOWw3ZkZJdEpL?= =?utf-8?B?MEZ6UUErbkpTRzlzdGdQVnljcGxIcG02U1FJRWdSUUYwQVE2RzB4UXRhWWxj?= =?utf-8?B?NjNjQ0RpOWtsK0E3MDA4dU9INmdVbGlQMEFiN3dmZXRxc1g2L0lVTDk1UDZm?= =?utf-8?B?TTBiOEx3clMyUlFWaU9wektzM3Y0L3FHanVTT0VCSTMxRVZjQktwb1hOQWVw?= =?utf-8?B?aTQ1OEFreTQvTk9XeTBMZ0J5eVhNUXBWN2VqVnp6SFk1ZFZncGswTDM5aVhK?= =?utf-8?B?QnJKaGxMeWxBMkZHSUpNNDRRNjdhUVFxQnJzSU83amJPMG5ZVExJaFVZYUlV?= =?utf-8?B?bDBYaDZndXhoa0ZNNDNYVnJnT1YxZnhkcFdSMjU2cVMvMUFlK0QyclF5MENw?= =?utf-8?B?dlcxYUQvKzVwYnJGVWVLdDVkQzNQZ3VaS1N5NS9BZk5nbStGRnRoMDRMSHlt?= =?utf-8?B?ZTk3bEhUSjl1M3lpZkFmdElzVUc1WTUzaEpkZ3paY1JlRzZJL05wdlRHcEhN?= =?utf-8?B?djFqWjRyVEN6MFljcXNLQVg2aW5xWW5Ca1BrSHZTRWJodmhSSXFLUXF0Q1dh?= =?utf-8?B?Y1NlejZHN0VrWGJPZzZZTVQ0RWs0Y2l2RUFza1B2c3E2NG5HeUFhdWpyclNh?= =?utf-8?B?MWRwdjVlWlhoTEt4c1o3UVpLamZKbE40WXNaWmFRSlBaQ0k5MGluS0hBMkJq?= =?utf-8?B?Tk1oUWdITDRIai9SUFE2SDJ5YjROVDNEZVVNSFFacU41N3VBc2ZlSW8wKzZi?= =?utf-8?B?elBoU2ZJNUxLL2FlakFxZmE1OFdNSmdyMEZoT0ZSVGF4dk5TT1JwcldWTjdn?= =?utf-8?B?djI2MWR4RHpVL3htb3dnVkg0SE9YRno2bGwzZDZZOTdOQ0YwK0JrMHFSWXVj?= =?utf-8?B?RC9jdDI0Z3c3SWEzWGU1amtZa1NTeG8vd3JBUHQxa0E3SElCeW82VFNRbVJT?= =?utf-8?B?TEc4K0QraTVnaVRCdnEvVUltTUkwanZCdXRITFBYVDIzVWVEei9RSEFvVnF5?= =?utf-8?B?NCt4NHJNTUZEVWtyemovc1RXRWdZTkd6eUtESWJQZGVNSWhnN29VbmVQSnZE?= =?utf-8?B?ZXlEb0JxckIyZXJBMldiaTRwSzUyZ3Z6QWJEOGlNU3VXeVdqN3pvMlQyeDA0?= =?utf-8?Q?JEm8EICJPa2zuX1PbI=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10b03380-71d0-427d-9a70-08da7b704593 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2022 08:05:36.4732 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR01MB7235 Subject: Re: [FFmpeg-devel] [PATCH 11/11] avcodec/mpegpicture: Always reset motion val buffer X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > Codecs call ff_find_unused_picture() to get the index of > an unused picture; said picture may have buffers left > from using it previously (these buffers are intentionally > not unreferenced so that it might be possible to reuse them; > this is mpegvideo's version of a bufferpool). They should > not make any assumptions about which picture they get. > Yet somehow this is not true when decoding OBMC: Returning > random empty pictures (instead of the first one) leads > to nondeterministic results; similarly, explicitly > rezeroing the buffer before handing it over to the codec > changes the outcome of the h263-obmc tests, but it makes it > independent of the returned pictures. Therefore this commit > does so. > > (No, this commit is not intended to be applied. I just hope > to arouse the interest of people familiar with H.263 > to look at this issue.) > > Signed-off-by: Andreas Rheinhardt > --- Will apply this patchset minus this patch tomorrow unless there are objections. And I would really like anybody with knowledge about H.263 to take a look at the obmc code to see what is wrong with it. > libavcodec/mpegpicture.c | 4 ++++ > tests/ref/vsynth/vsynth1-h263-obmc | 4 ++-- > tests/ref/vsynth/vsynth2-h263-obmc | 4 ++-- > tests/ref/vsynth/vsynth_lena-h263-obmc | 4 ++-- > 4 files changed, 10 insertions(+), 6 deletions(-) > > diff --git a/libavcodec/mpegpicture.c b/libavcodec/mpegpicture.c > index c57f149752..2192f74cea 100644 > --- a/libavcodec/mpegpicture.c > +++ b/libavcodec/mpegpicture.c > @@ -280,6 +280,10 @@ int ff_alloc_picture(AVCodecContext *avctx, Picture *pic, MotionEstContext *me, > for (i = 0; i < 2; i++) { > pic->motion_val[i] = (int16_t (*)[2])pic->motion_val_buf[i]->data + 4; > pic->ref_index[i] = pic->ref_index_buf[i]->data; > + /* FIXME: The output of H.263 with OBMC depends upon > + * the earlier content of the buffer; therefore we > + * reset it here. */ > + memset(pic->motion_val_buf[i]->data, 0, pic->motion_val_buf[i]->size); > } > } > > diff --git a/tests/ref/vsynth/vsynth1-h263-obmc b/tests/ref/vsynth/vsynth1-h263-obmc > index b7a267a8cb..aed283ed53 100644 > --- a/tests/ref/vsynth/vsynth1-h263-obmc > +++ b/tests/ref/vsynth/vsynth1-h263-obmc > @@ -1,4 +1,4 @@ > 7dec64380f375e5118b66f3baaaa1e24 *tests/data/fate/vsynth1-h263-obmc.avi > 657320 tests/data/fate/vsynth1-h263-obmc.avi > -844f7ee27fa122e199fe20987b41a15c *tests/data/fate/vsynth1-h263-obmc.out.rawvideo > -stddev: 8.16 PSNR: 29.89 MAXDIFF: 113 bytes: 7603200/ 7603200 > +2a69f6b37378aa34418dfd04ec98c1c8 *tests/data/fate/vsynth1-h263-obmc.out.rawvideo > +stddev: 8.38 PSNR: 29.66 MAXDIFF: 116 bytes: 7603200/ 7603200 > diff --git a/tests/ref/vsynth/vsynth2-h263-obmc b/tests/ref/vsynth/vsynth2-h263-obmc > index 2cef7f551b..c0dcc3239e 100644 > --- a/tests/ref/vsynth/vsynth2-h263-obmc > +++ b/tests/ref/vsynth/vsynth2-h263-obmc > @@ -1,4 +1,4 @@ > 2d8a58b295e03f94e6a41468b2d3909e *tests/data/fate/vsynth2-h263-obmc.avi > 208522 tests/data/fate/vsynth2-h263-obmc.avi > -4a939ef99fc759293f2e609bfcacd2a4 *tests/data/fate/vsynth2-h263-obmc.out.rawvideo > -stddev: 6.10 PSNR: 32.41 MAXDIFF: 90 bytes: 7603200/ 7603200 > +3500b4227c1e6309ca5213414599266f *tests/data/fate/vsynth2-h263-obmc.out.rawvideo > +stddev: 6.19 PSNR: 32.29 MAXDIFF: 111 bytes: 7603200/ 7603200 > diff --git a/tests/ref/vsynth/vsynth_lena-h263-obmc b/tests/ref/vsynth/vsynth_lena-h263-obmc > index 5b963107f6..78d7cc7277 100644 > --- a/tests/ref/vsynth/vsynth_lena-h263-obmc > +++ b/tests/ref/vsynth/vsynth_lena-h263-obmc > @@ -1,4 +1,4 @@ > 3c6946f808412ac320be9e0c36051ea2 *tests/data/fate/vsynth_lena-h263-obmc.avi > 154730 tests/data/fate/vsynth_lena-h263-obmc.avi > -588d992d9d8096da8bdc5027268da914 *tests/data/fate/vsynth_lena-h263-obmc.out.rawvideo > -stddev: 5.39 PSNR: 33.49 MAXDIFF: 82 bytes: 7603200/ 7603200 > +737af7fb166e2260ba049ae6bc30673d *tests/data/fate/vsynth_lena-h263-obmc.out.rawvideo > +stddev: 5.42 PSNR: 33.44 MAXDIFF: 77 bytes: 7603200/ 7603200 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".