From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5252F43912 for ; Sun, 3 Jul 2022 07:20:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9B9D768B93E; Sun, 3 Jul 2022 10:19:57 +0300 (EEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-oln040092064105.outbound.protection.outlook.com [40.92.64.105]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2B5EE68B48C for ; Sun, 3 Jul 2022 10:19:51 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jsw26cmMiB2KfaJ60x6qNrAtutrKMk8TIshel+3MJ30qnCXHyCZiUT8MFpq7IO8fe1SePWIc5BI39X4p6B0/K5r5a2jw5N6r6TpoO69KH3cMo0SyeVUzrNnn+ypOHKmgwlkKyDTkDYScBe3GP5mLe/PPfRPMButV8NbTyALSue4jJVm1DUIxR8Guv7g4xiAgezoYTa62A5CagNk2+ZW4dZ2Zfpb8qnDYzPkr4F2EU2nhnVnEK9Tat84y1d43swDjGQQ3rtmw4/9fD4uH2sPEBydt5+VNt7bSFnc+GZ6lWZ9Wh64zZIC3g+N0tqQlt4iT4S++K0acFE2jObb4QrQDRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+8RPcZs4jq1fdwmGGj7VW0uo7znWqAfJSC9t9M8naH8=; b=NYODlqo3SRGWaf8VUEHCv/osSoRdHBvXTJiEK6feGa2VIHh8/2FVtKn3r9JdJH6K7FQ8TL8H9HVrl5wjXHEXlilpceMAjcLgW/5unDflwyzf/iZcfR/SO2naD1f7CLTLPTIqHzFJBaQpEiPjKKikwIOcfPtDTe2tMUVeDiPkMMdcKZEU6ydt9QB/AiPl8Q6rTO1LPluYJTz1DkWbl65+/2eeUy21imyCUbwUWNRq57IrOc/hWoSRI393RrO9eAdVpdfRpbZHDqjuwFa5Fxyz6LTqEcCkPAGy739g9F0xrFCFUZAE2PWPe08R0A+MvAiKjdhcIiWfNDkYWoiDjapO8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+8RPcZs4jq1fdwmGGj7VW0uo7znWqAfJSC9t9M8naH8=; b=lNQM8T0LsWJjo9vE/aqnfw4dJfc3jecdyl8+NmK6qm845O8q/dhwNG0Cas8vKtO2qKGHhie/IpRhmvSA00m755+voKBIsP2t9dZ2IIVrePLLqSgV1XzQ/hVTdDS2roE/1RN53b8fgHjUt+96u6EhJM3Y1LNTskbfWcLUsJGzXfDhKXaoKzBCupoHZtBRDL4+KYJjfdjJCGUZLSYUXs5Sj0hOMvspdbvjBPkh7ISU4BjlGm6n1aoIpIWESnSv43UY24f2O+oPhDY5NTIBJn9Ob8G/w7NSHRrRu/nxl5vWWsT1RpbcHbIznPm3n7WzJ7dxTeKENe5Rj37FpVshtfFSsQ== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by DBAPR01MB6597.eurprd01.prod.exchangelabs.com (2603:10a6:10:183::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Sun, 3 Jul 2022 07:19:49 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c%10]) with mapi id 15.20.5395.018; Sun, 3 Jul 2022 07:19:49 +0000 Message-ID: Date: Sun, 3 Jul 2022 09:19:48 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220702222532.9609-1-jamrial@gmail.com> From: Andreas Rheinhardt In-Reply-To: <20220702222532.9609-1-jamrial@gmail.com> X-TMN: [gxGFWRRyDMgAJz30QxCwIkxH/8xmsU3o] X-ClientProxiedBy: AS9PR06CA0010.eurprd06.prod.outlook.com (2603:10a6:20b:462::33) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: <760957f8-d8ca-ea87-ccb4-6f1f696e5344@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 83140312-7be8-42cb-f55d-08da5cc46a61 X-MS-TrafficTypeDiagnostic: DBAPR01MB6597:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: afQfPC5n/Ir5NKVWLbkXvQG1lL3gXQFWZOEjO9EbAUo+33uJi1Z9FTGGvJQkvVm10TOkAb07kvpz/w0OdRmgYJ/dA4zCoOazhxqXxf5lQxC2myCWwJ9Wm+v1/n8BxvNm8OMwlD1r3sANOZHnBoeGaJ4ZBv2Cv1Zo9yihzSfzC3gzMPwJRRbzJCWyA0Y3GHgSRTi/lmN7hjd3EwuihJdZC1mqlg/xcb8V/mJ7atX4EVI9R1iyC9qAQyyR2lNDCqp5/1QsxlmUW4be5WWZSo7d5gTFHbwxdxRzGgSUVv+Zd/7DPugS+j72X/Y3GJ1+xyfH5YBd5osbDdwBtZRzy5TA0+AVHVR0R9j0732HPtGx7tlprmnl3+SaxQprCKRODy3oBMgGwGc5U15GpW9k9pXHTD+22KuwOwi3LFYqTQCYXnQ67/hOJ0Uj9xgP2UaY//G6S7FltY1niS4ZWrARGmibRapnaX7NM2DaF55PGfrRS4rxQx9DlUiWGn4m827vdHkjqLsz9se9l/R0U2JSYY5F4D2DQcXNKMWVW2i/kOfg+gEa0W6yHlZpM1uja+yPTI2+QbwQa1l5I1REfJ287sdjoHAiqKf7GTV2J6t9AlheNtsEC7V058ZMGwamynFSXZbHHhYaghajb13bV6rLdCGWpQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dm9uK0RoVDJ6eGxRVnVsMWUvMEUxUHFXbWdjQWZnR3E0WW84Z2tHM0xvVU9T?= =?utf-8?B?ZmhMUkFrWjh3cllGYkx1VHl5SkV5ZHJHMXIxRWQwVGJFdTM2YmxMN2s1ZFlB?= =?utf-8?B?c2VZdmczWXJFV3IrUXJpaWVTQWF4N09BMzBscEtzWGNBWVQ5MmF2ZHNmU1JR?= =?utf-8?B?V2ZTZy9STTIvZS9WN3E4NGxXczU1aWpiZWdVYXlrVXJMWmdyanpNTXBLbkov?= =?utf-8?B?dVFRUUNMNTllcWNNb0RpNm1LRitMbGN0S2lMRW1uYnVleEdmdzY3bGJSQzFH?= =?utf-8?B?K1hjVWVvdzhNMzZZWng4Z2txbDRxV3lFdGIwZUJlTjlmZlVteW9yRVk0akFw?= =?utf-8?B?Q2xaK0ROVlgrdFZqWDhudkhWdmRCdktTWHVHL0F6ZHo5NjVYL2JUOFoyMDZC?= =?utf-8?B?R3gwMHBpT1A1bzlRNEtTNFl1N1IvakNTNkNSZG9VSHp2V25vRFgvS3M1ZXdT?= =?utf-8?B?Zk1oUytXVGpsc054OFBhV2gycjRycnBHT1pTMWVZWkgzV3ZnOVFTWVpVMVZy?= =?utf-8?B?SDNMRFkxdi9OUC9Oc3BIcWZ3anRUMnBseDI1RE81Rmg0R05BZ3RDd2ZwNlJj?= =?utf-8?B?alNOVlJHVGpNaDdyTjVLa1VGUGw5emhMZUtMT0VIbDE1a0JjZzhGeGxXT1o0?= =?utf-8?B?WTBtY3pvdXliUkxvREhrRmdxa2JQZFNFWkpFb2xuL05FRVQ3b1RvTlBGckRJ?= =?utf-8?B?NmFldjFUVEhUYWNoSk9Ncm8rQXViMW5DdFVybVZQeXlrZTJROFlUSkt3UVN5?= =?utf-8?B?aHozT1dJMkVrWktRQXpLVlI2eHo0ay9VOHNlRVAyY3RmbHdLVUhPSTh1RXdL?= =?utf-8?B?ZmlKN3JtcUE0U29MOXRYb09COWtZVS9HWmo1UmxXaHpWYmNEMmtNdXdCK1FX?= =?utf-8?B?NTVTMEo2SVcxYXhoUjZuMDJ6QW5NTFhhV1NvN0M4emhMd2tCbUwxbEF4OFpl?= =?utf-8?B?dVdqajZhY0drTUJra1A2VG5kTG51MGRRNWdORWFmS0tOaTZXTEtSamgwZEJq?= =?utf-8?B?Y0JCak9qamw3VWN6ZmdBNUF1SHNjODUwNXJmSzVCdFdtZndoWFNWajQrQi8z?= =?utf-8?B?Nm5qblpWTGpwSDBzTVA1OGQrYmRPb1ZWWVM2aU9KZXVLb3NlSUF2Y21LZ25Z?= =?utf-8?B?R2R5c3dBUHU2cDhFZ1hMcFM0OUFKZ0w3STlGZTRBWG1ZNFE1YThKdXJHa3V6?= =?utf-8?B?YUpFdURuOUE0UXRKUWJEL1EyVWc4aUFZSkYzWDRKUTQ4a2lWTE1RU3lCV1RO?= =?utf-8?B?WlhubzhqY01yWnRmRGo1WXZxdVRVVExYWEJnSTBWV2dsVm8xTDVzMWt3SUI5?= =?utf-8?B?dWpjcmFjQWFLcEdXb0ZUM2IrbXI0VG8wdTZZTFJZL3lQa0h4bGFTZTBCT3Vp?= =?utf-8?B?UG5SUDdpb1c2T1BkVk9DdnBhWGtxaStQeHJTSDlNaGs5cStFOXJMcS90NkpS?= =?utf-8?B?V3lhZFpPTnhFTlpsb0l4eGczQXZZNHpDR1kwZzN4Y1p3Ri9ZeXl6dVIzb3Z6?= =?utf-8?B?VzRteC9HcGNhaG8vNlEzSk8yb3VMTkl1bjU2REx2WWMzZ29Ka3FlaW1pcmdY?= =?utf-8?B?RDYzSzNYUVIxM0x5aEg1cGtud2Fmd3d3czlkbmVsVXdyaEJ2ckVnYmlDQXpO?= =?utf-8?B?Zk5VMmRRZXpsaVNaS2dQUDFsZG9lSi9kSU8xTmZ1WEN5cFN5UTNyaUlPUDFB?= =?utf-8?B?QjljN2NpVDM2S0ZWcjh6UFZKV0huMGxrQ2hIZUhKcHZGRXh5MDVsY2ZvUFpK?= =?utf-8?Q?z2+G6aW79TeSJuyKR8=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 83140312-7be8-42cb-f55d-08da5cc46a61 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2022 07:19:49.7340 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR01MB6597 Subject: Re: [FFmpeg-devel] [PATCH] avutil/channel_layout: don't error out on truncated strings X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: James Almer: > The doxy for av_channel_layout_describe() states that the user should look > at the return value to check if the string was truncated. Returning an error > code in this scenario goes against this and is an API break. > > This is a better fix than the one committed in 8154cb7c2f for the timeout > fuzzing issue. > > Signed-off-by: James Almer > --- > libavutil/channel_layout.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavutil/channel_layout.c b/libavutil/channel_layout.c > index 1887987789..d54a0adbe1 100644 > --- a/libavutil/channel_layout.c > +++ b/libavutil/channel_layout.c > @@ -759,7 +759,7 @@ int av_channel_layout_describe_bprint(const AVChannelLayout *channel_layout, > av_bprintf(bp, "@%s", channel_layout->u.map[i].name); > > if (!av_bprint_is_complete(bp)) > - return AVERROR(ENOMEM); > + break; > > } > if (channel_layout->nb_channels) { Isn't this actually still against the API? av_channel_layout_describe() will not return the correct number of bytes necessary to write the string for the channel layout. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".